29342 2009-09-17 12:54:01 -0700 Hardware-accelerated opacity transition on inline asserts 2009-09-17 13:13:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 147901 0 39718 simon.fraser 2009-09-17 12:54:01 -0700 Created attachment 39718 Testcase When running a hardware-accelerated opacity transition on an inline, we hit an assertion at: ASSERTION FAILED: !object || object->isBox() (/Volumes/InternalData/Development/webkit/OpenSource/WebCore/rendering/RenderBox.h:382 WebCore::RenderBox* WebCore::toRenderBox(WebCore::RenderObject*)) 147906 1 39719 simon.fraser 2009-09-17 13:07:23 -0700 Created attachment 39719 Patch 147908 2 39719 hyatt 2009-09-17 13:09:23 -0700 Comment on attachment 39719 Patch r=me, although a comment in the code about why an empty size is being passed in might be helpful. 147910 3 simon.fraser 2009-09-17 13:13:10 -0700 I added a comment. http://trac.webkit.org/changeset/48489 39718 2009-09-17 12:54:01 -0700 2009-09-17 12:54:01 -0700 Testcase opacity-on-inline.html text/html 562 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+T3BhY2l0eSBvbiBpbmxpbmU8 L3RpdGxlPgogIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CiAgICAuZmFk aW5nIHsKICAgICAgLXdlYmtpdC10cmFuc2l0aW9uOiBvcGFjaXR5IDFzOwogICAgICBib3JkZXI6 IDFweCBzb2xpZCBibGFjazsKICAgIH0KICAgIAogICAgLmZhZGluZzpob3ZlciB7CiAgICAgIG9w YWNpdHk6IDAuNTsKICAgIH0KICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgoKPHNwYW4gY2xhc3M9 ImZhZGluZyI+SG92ZXIgb3ZlciB0aGlzPC9zcGFuPgoKPGRpdiBzdHlsZT0iLXdlYmtpdC10cmFu c2Zvcm06IHRyYW5zbGF0ZVooMCkiPgogIAo8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+Cg== 39719 2009-09-17 13:07:23 -0700 2009-09-17 13:09:23 -0700 Patch 29342_patch.txt text/plain 3950 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzZTEzNjRlLi44ZmUwY2M5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDkt MTcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGFyZHdhcmUtYWNjZWxlcmF0ZWQg b3BhY2l0eSB0cmFuc2l0aW9uIG9uIGlubGluZSBhc3NlcnRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTM0MgorCisgICAgICAgIFRlc3QgdGhhdCBy dW5zIGEgaGFyZHdhcmUtYWNjZWxlcmF0ZWQgb3BhY2l0eSB0cmFuc2l0aW9uIG9uIGFuIGlubGlu ZSBlbGVtZW50LgorICAgICAgICAKKyAgICAgICAgKiBjb21wb3NpdGluZy90cmFuc2l0aW9ucy9v cGFjaXR5LW9uLWlubGluZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0 aW5nL3RyYW5zaXRpb25zL29wYWNpdHktb24taW5saW5lLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA5 LTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3Np dGluZy90cmFuc2l0aW9ucy9vcGFjaXR5LW9uLWlubGluZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9jb21wb3NpdGluZy90cmFuc2l0aW9ucy9vcGFjaXR5LW9uLWlubGluZS1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMzFiOTRiYgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3RyYW5zaXRpb25zL29wYWNpdHktb24t aW5saW5lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK1RoaXMgc2hvdWxkIG5vdCBhc3Nl cnQgaW4gZGVidWcgYnVpbGRzCisKK09wYWNpdHkgZmFkZSBvbiBpbmxpbmUKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdHJhbnNpdGlvbnMvb3BhY2l0eS1vbi1pbmxpbmUu aHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3RyYW5zaXRpb25zL29wYWNpdHktb24taW5s aW5lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMDY3M2EwMQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3RyYW5zaXRpb25zL29wYWNp dHktb24taW5saW5lLmh0bWwKQEAgLTAsMCArMSwzNiBAQAorPCFET0NUWVBFPgorCis8aHRtbD4K KzxoZWFkPgorICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQv aHRtbDsgY2hhcnNldD11dGYtOCI+CisgIDx0aXRsZT5PcGFjaXR5IG9uIGlubGluZTwvdGl0bGU+ CisgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CisgICAgI2ZhZGVyIHsK KyAgICAgIC13ZWJraXQtdHJhbnNpdGlvbjogb3BhY2l0eSAxczsKKyAgICAgIGJvcmRlcjogMXB4 IHNvbGlkIGJsYWNrOworICAgIH0KKyAgICAKKyAgICAuZmFkZWQgeworICAgICAgb3BhY2l0eTog MC41OworICAgIH0KKyAgPC9zdHlsZT4KKyAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQi IGNoYXJzZXQ9InV0Zi04Ij4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgd2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBmdW5jdGlvbigpIHsKKyAgICAgIHZhciB0ZXN0U3BhbiA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmYWRlcicpOworICAgICAgdGVzdFNwYW4uY2xhc3NO YW1lID0gJ2ZhZGVkJzsKKyAgICB9LCBmYWxzZSk7CisgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHk+CisKKzxwPlRoaXMgc2hvdWxkIG5vdCBhc3NlcnQgaW4gZGVidWcgYnVpbGRzPC9wPgorPHNw YW4gaWQ9ImZhZGVyIj5PcGFjaXR5IGZhZGUgb24gaW5saW5lPC9zcGFuPgorCis8ZGl2IHN0eWxl PSItd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWigwKSI+IDwhLS0gdGhyb3cgdGhlIHBhZ2Ug aW50byBjb21wb3NpdGluZyBtb2RlIC0tPgorPC9kaXY+CisKKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQ4 NWE5Yy4uMjBjZTBkOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wOS0xNyAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBIYXJkd2FyZS1hY2NlbGVyYXRlZCBvcGFjaXR5IHRyYW5zaXRpb24g b24gaW5saW5lIGFzc2VydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI5MzQyCisgICAgICAgIAorICAgICAgICBSZW1vdmUgYW4gZXJyb25lb3VzIHRv UmVuZGVyQm94KCkgdGhhdCBjb3VsZCBiZSBjYWxsZWQgb24gYSBSZW5kZXJJbmxpbmU7IHdlIGNh biBqdXN0CisgICAgICAgIHBhc3MgYW4gZW1wdHkgc2l6ZSwgYmVjYXVzZSB0aGUgYm94IHNpemUg aXMgb25seSByZXF1aXJlZCBmb3IgdHJhbnNmb3JtIGFuaW1hdGlvbnMuCisKKyAgICAgICAgVGVz dDogY29tcG9zaXRpbmcvdHJhbnNpdGlvbnMvb3BhY2l0eS1vbi1pbmxpbmUuaHRtbAorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllckJhY2tpbmc6OnN0YXJ0VHJhbnNpdGlvbik6CisKIDIwMDktMDktMTYgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQmFja2luZy5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw CmluZGV4IDY5YThmN2QuLjkwYTA5NTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJC YWNraW5nLmNwcApAQCAtMTA1OSw3ICsxMDU5LDcgQEAgYm9vbCBSZW5kZXJMYXllckJhY2tpbmc6 OnN0YXJ0VHJhbnNpdGlvbihkb3VibGUgYmVnaW5UaW1lLCBpbnQgcHJvcGVydHksIGNvbnN0IFIK ICAgICAgICAgICAgIEtleWZyYW1lVmFsdWVMaXN0IG9wYWNpdHlWZWN0b3IoQW5pbWF0ZWRQcm9w ZXJ0eU9wYWNpdHkpOwogICAgICAgICAgICAgb3BhY2l0eVZlY3Rvci5pbnNlcnQobmV3IEZsb2F0 QW5pbWF0aW9uVmFsdWUoMCwgY29tcG9zaXRpbmdPcGFjaXR5KGZyb21TdHlsZS0+b3BhY2l0eSgp KSkpOwogICAgICAgICAgICAgb3BhY2l0eVZlY3Rvci5pbnNlcnQobmV3IEZsb2F0QW5pbWF0aW9u VmFsdWUoMSwgY29tcG9zaXRpbmdPcGFjaXR5KHRvU3R5bGUtPm9wYWNpdHkoKSkpKTsKLSAgICAg ICAgICAgIGlmIChtX2dyYXBoaWNzTGF5ZXItPmFkZEFuaW1hdGlvbihvcGFjaXR5VmVjdG9yLCB0 b1JlbmRlckJveChyZW5kZXJlcigpKS0+Ym9yZGVyQm94UmVjdCgpLnNpemUoKSwgb3BhY2l0eUFu aW0sIFN0cmluZygpLCBiZWdpblRpbWUpKQorICAgICAgICAgICAgaWYgKG1fZ3JhcGhpY3NMYXll ci0+YWRkQW5pbWF0aW9uKG9wYWNpdHlWZWN0b3IsIEludFNpemUoKSwgb3BhY2l0eUFuaW0sIFN0 cmluZygpLCBiZWdpblRpbWUpKQogICAgICAgICAgICAgICAgIGRpZEFuaW1hdGUgPSB0cnVlOwog ICAgICAgICB9CiAgICAgfQo=