293413 2025-05-21 21:03:12 -0700 [GTK] GTK3 build broken after 295196@main removed some members from DOM Selection 2025-05-21 21:03:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 lmoura webkit-unassigned bugs-noreply oldest_to_newest 2118910 0 lmoura 2025-05-21 21:03:12 -0700 Build error: In file included from /home/lauro/dev/WebKit/WebKitBuild/GTK/Release/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-17.cpp:6: /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp: In function ‘void webkit_dom_dom_selection_set_base_and_extent(WebKitDOMDOMSelection*, WebKitDOMNode*, gulong, WebKitDOMNode*, gulong)’: /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp:400:28: error: cannot convert ‘WebCore::Node*’ to ‘WebCore::Node&’ 400 | item->setBaseAndExtent(convertedBaseNode, baseOffset, convertedExtentNode, extentOffset); | ^~~~~~~~~~~~~~~~~ | | | WebCore::Node* In file included from /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelectionPrivate.h:23, from /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp:28: /home/lauro/dev/WebKit/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/DOMSelection.h:57:46: note: initializing argument 1 of ‘WebCore::ExceptionOr<void> WebCore::DOMSelection::setBaseAndExtent(WebCore::Node&, unsigned int, WebCore::Node&, unsigned int)’ 57 | ExceptionOr<void> setBaseAndExtent(Node& anchorNode, unsigned anchorOffset, Node& focusNode, unsigned focusOffset); | ~~~~~~^~~~~~~~~~ /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp: In function ‘WebKitDOMNode* webkit_dom_dom_selection_get_base_node(WebKitDOMDOMSelection*)’: /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp:503:61: error: ‘class WebCore::DOMSelection’ has no member named ‘baseNode’ 503 | RefPtr<WebCore::Node> gobjectResult = WTF::getPtr(item->baseNode()); | ^~~~~~~~ /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp: In function ‘gulong webkit_dom_dom_selection_get_base_offset(WebKitDOMDOMSelection*)’: /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp:512:27: error: ‘class WebCore::DOMSelection’ has no member named ‘baseOffset’ 512 | gulong result = item->baseOffset(); | ^~~~~~~~~~ /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp: In function ‘WebKitDOMNode* webkit_dom_dom_selection_get_extent_node(WebKitDOMDOMSelection*)’: /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp:521:61: error: ‘class WebCore::DOMSelection’ has no member named ‘extentNode’; did you mean ‘extend’? 521 | RefPtr<WebCore::Node> gobjectResult = WTF::getPtr(item->extentNode()); | ^~~~~~~~~~ | extend /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp: In function ‘gulong webkit_dom_dom_selection_get_extent_offset(WebKitDOMDOMSelection*)’: /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp:530:27: error: ‘class WebCore::DOMSelection’ has no member named ‘extentOffset’ 530 | gulong result = item->extentOffset(); | ^~~~~~~~~~~~ In file included from /home/lauro/dev/WebKit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCharacterData.cpp:26, from /home/lauro/dev/WebKit/WebKitBuild/GTK/Release/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-17.cpp:1: /home/lauro/dev/WebKit/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/Document.h: At global scope: /home/lauro/dev/WebKit/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/Document.h:769:34: warning: inline function ‘virtual const WebCore::SettingsValues& WebCore::Document::settingsValues() const’ used but never defined 769 | inline const SettingsValues& settingsValues() const final; | ^~~~~~~~~~~~~~ ninja: build stopped: subcommand failed. Looks like these were hidden by the build failure that bug293412 fixes.