29341 2009-09-17 12:00:32 -0700 REGRESSION: fast/workers/worker-cloneport.html failing intermittently on leopard bot 2009-09-18 17:20:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric atwilson ap atwilson sam oldest_to_newest 147876 0 eric 2009-09-17 12:00:32 -0700 fast/workers/worker-cloneport.html failing intermittently on leopard bot Marking as regression since it causes the tree to be red when it didn't used to be. ;) If that's not correct, please feel free to change. http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r48479%20(5083)/results.html --- layout-test-results/fast/workers/worker-cloneport-expected.txt 2009-09-17 11:49:57.000000000 -0700 +++ layout-test-results/fast/workers/worker-cloneport-actual.txt 2009-09-17 11:49:57.000000000 -0700 @@ -1,7 +1,7 @@ Test MessagePort messaging/entangle/detangle across threads. Should print "SUCCESS" when done. PASS: Received request for 50000 messages -PASS: postBack complete, cloned > 1000 times. +FAIL: postBack complete, but only cloned 635 times. SUCCESS - received 50000 messages. DONE 147898 1 atwilson 2009-09-17 12:51:26 -0700 I'll reduce this restriction - it causes problems in Chromium as well because it makes assumptions about the speed/frequency of thread scheduling which don't really hold across all platforms. 147923 2 eric 2009-09-17 13:37:24 -0700 Looks like dedicated-worker-lifecycle.html just failed too: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r48488%20(5093)/results.html Not sure if that's related or not. 147926 3 eric 2009-09-17 13:39:50 -0700 (In reply to comment #2) > Looks like dedicated-worker-lifecycle.html just failed too: > http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r48488%20(5093)/results.html > Not sure if that's related or not. Filed bug 29344 about that one. 148287 4 39773 atwilson 2009-09-18 12:04:17 -0700 Created attachment 39773 proposed patch This test is intended to check for race conditions when cloning a port while posting messages to it from another thread. To ensure the case is adequately tested, we have some checks in place to make sure that clones are actually happening in parallel with messages being posted. The previous threshold (1000 clones) was chosen entirely arbitrarily, and turned out to be a order of magnitude too strict for some platforms (like Chromium). So I've loosened the requirement. I also relaxed a timeout that fires only in the test failure case, again because the latency involved in cross-process messaging in Chromium was causing it to be flaky. 148303 5 39773 eric 2009-09-18 12:20:40 -0700 Comment on attachment 39773 proposed patch Adding 1 second to every run of this layout test is bad news bears. No other way besides setTimeout? 148310 6 atwilson 2009-09-18 12:30:45 -0700 The timeout is only triggered when the test fails, to help in debugging why the test failed. It doesn't trigger when the test passes, so increasing the timeout does not slow down our tests. The patch includes a comment to this effect: // This only fires in the case of a test failure, so it does not slow down test running. 148324 7 39773 eric 2009-09-18 13:02:01 -0700 Comment on attachment 39773 proposed patch Sounds good. 148325 8 eric 2009-09-18 13:03:09 -0700 Thanks for taking care of this so quickly. :) 148407 9 39773 commit-queue 2009-09-18 15:02:33 -0700 Comment on attachment 39773 proposed patch Rejecting patch 39773 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11278 test cases. fast/workers/worker-cloneport.html -> failed Exiting early after 1 failures. 8198 tests run. 154.70s total testing time 8197 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 148444 10 atwilson 2009-09-18 17:20:38 -0700 Landed as r48543 39773 2009-09-18 12:04:17 -0700 2009-09-18 15:02:33 -0700 proposed patch x text/plain 2343 atwilson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MzNkNjgyLi5hZDI3ZDZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDkt MTggIERyZXcgV2lsc29uICA8YXR3aWxzb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OOiBmYXN0L3dvcmtlcnMv d29ya2VyLWNsb25lcG9ydC5odG1sIGZhaWxpbmcgaW50ZXJtdHRlbnRseSBvbiBsZW9wYXJkIGJv dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkzNDEK KworICAgICAgICAqIGZhc3Qvd29ya2Vycy93b3JrZXItY2xvbmVwb3J0Lmh0bWw6CisgICAgICAg IFVwZGF0ZWQgdGVzdCB0byBoYXZlIGEgbW9yZSBsZW5pZW50IHBlcmZvcm1hbmNlIHJlcXVpcmVt ZW50IGFuZCB0aW1lb3V0LCB0byBhZGRyZXNzIGZsYWtpbmVzcyBvbiBMZW9wYXJkIGFuZCBDaHJv bWl1bS4KKwogMjAwOS0wOS0xOCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkZWxlIFBldGVyc29uLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC93b3JrZXJzL3dvcmtlci1jbG9uZXBvcnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvd29y a2Vycy93b3JrZXItY2xvbmVwb3J0Lmh0bWwKaW5kZXggNmRjYmI4MC4uY2VhYTZjMSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1jbG9uZXBvcnQuaHRtbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb25lcG9ydC5odG1sCkBAIC01Mywx OCArNTMsMTkgQEAgZnVuY3Rpb24gcmVzZW5kUG9ydChldnQpCiAgICAgICAgIG51bUNsb25lcysr OwogICAgICAgICBldnQudGFyZ2V0LnBvc3RNZXNzYWdlKCIiLCBldnQucG9ydHMpOwogICAgIH0g ZWxzZSB7Ci0gICAgICAgIGlmIChudW1DbG9uZXMgPCAxMDAwKSB7Ci0gICAgICAgICAgICAvLyBJ ZiB3ZSBkaWRuJ3QgY2xvbmUgYXQgbGVhc3QgMTAwMCB0aW1lcywgdGhlbiB0aGVyZSdzIHNvbWV0 aGluZyBhbWlzcy4KKyAgICAgICAgaWYgKG51bUNsb25lcyA8IDUwKSB7CisgICAgICAgICAgICAv LyBJZiB3ZSBkaWRuJ3QgY2xvbmUgYXQgbGVhc3QgNTAgdGltZXMsIHRoZW4gdGhlcmUncyBzb21l dGhpbmcgYW1pc3MuCiAgICAgICAgICAgICBsb2coIkZBSUw6IHBvc3RCYWNrIGNvbXBsZXRlLCBi dXQgb25seSBjbG9uZWQgIiArIG51bUNsb25lcyArICIgdGltZXMuIik7CiAgICAgICAgIH0gZWxz ZSB7Ci0gICAgICAgICAgICBsb2coIlBBU1M6IHBvc3RCYWNrIGNvbXBsZXRlLCBjbG9uZWQgPiAx MDAwIHRpbWVzLiIpOworICAgICAgICAgICAgbG9nKCJQQVNTOiBwb3N0QmFjayBjb21wbGV0ZSwg Y2xvbmVkID4gNTAgdGltZXMuIik7CiAgICAgICAgIH0KICAgICAgICAgLy8gTWFrZSBzdXJlIHRo ZSBtZXNzYWdlcyBhcnJpdmVkIGluIG9yZGVyLgogICAgICAgICB2YXIgaXRlbU51bSA9IDA7Ci0g ICAgICAgIC8vIFF1ZXVlIHVwIGEgdGFzayB0byBleGVjdXRlIG9uY2UgdGhlIG1lc3NhZ2VzIGhh dmUgYmVlbiBwcm9jZXNzZWQuIFRoZSB0aW1lb3V0IHZhbHVlIGRvZXNuJ3QgbWF0dGVyLCBzaW5j ZSB0aW1lcnMgd29uJ3QgZmlyZSB1bnRpbCB0aGUgbWVzc2FnZSBxdWV1ZSBpcyBjbGVhcmVkLgor ICAgICAgICAvLyBRdWV1ZSB1cCBhIHRhc2sgdG8gZXhlY3V0ZSBvbmNlIHRoZSBtZXNzYWdlcyBo YXZlIGJlZW4gcHJvY2Vzc2VkLiBUaGUgdGltZW91dCB2YWx1ZSBpcyBzZXQgZmFpcmx5IGxhcmdl IHRvIGFjY291bnQgZm9yIENocm9taXVtJ3MgZGlmZmVyZW50IG1lc3NhZ2UgZGVsaXZlcnkgYXJj aGl0ZWN0dXJlLgorICAgICAgICAvLyBUaGlzIG9ubHkgZmlyZXMgaW4gdGhlIGNhc2Ugb2YgYSB0 ZXN0IGZhaWx1cmUsIHNvIGl0IGRvZXMgbm90IHNsb3cgZG93biB0ZXN0IHJ1bm5pbmcuCiAgICAg ICAgIHZhciB0aW1lciA9IHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICBsb2co IkZBSUxVUkU6IFJlY2VpdmVkOiAiICsgaXRlbU51bSArICIgZXZlbnRzIC0gZXhwZWN0ZWQ6ICIg KyBudW1NZXNzYWdlcyk7Ci0gICAgICAgIH0sIDEwKTsKKyAgICAgICAgfSwgMTAwMCk7CiAgICAg ICAgIGV2dC5wb3J0c1swXS5vbm1lc3NhZ2UgPSBmdW5jdGlvbihldmVudCkgewogICAgICAgICAg ICAgdmFyIGRvbmUgPSBmYWxzZTsKICAgICAgICAgICAgIGlmIChldmVudC5kYXRhID09IGl0ZW1O dW0pIHsK