293370 2025-05-21 09:17:12 -0700 Use SingleThreadWeakHashMap<RenderFoo> instead of UncheckedKeyHashMap<SingleThreadWeakRef<RenderFoo>> in RenderSelection 2025-05-21 14:08:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan koivisto webkit-bug-importer oldest_to_newest 2118693 0 zalan 2025-05-21 09:17:12 -0700 ssia 2118694 1 475335 zalan 2025-05-21 09:17:50 -0700 Created attachment 475335 [fast-cq]Patch 2118775 2 ews-feeder 2025-05-21 14:07:12 -0700 Committed 295229@main (2b98fc22010b): <https://commits.webkit.org/295229@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 475335. 2118776 3 webkit-bug-importer 2025-05-21 14:08:20 -0700 <rdar://problem/151802675> 475335 2025-05-21 09:17:50 -0700 2025-05-21 14:07:13 -0700 [fast-cq]Patch bug-293370-20250521091749.patch text/plain 6756 zalan RnJvbSBkZWFhZjFiYWM1MjljYjVjMmViMzhkNzhiYmNjNzVhYmM2NzVhYTZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFdlZCwgMjEgTWF5IDIwMjUgMDk6MTY6NDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBVc2UgU2lu Z2xlVGhyZWFkV2Vha0hhc2hNYXA8UmVuZGVyRm9vPiBpbnN0ZWFkIG9mCiBVbmNoZWNrZWRLZXlI YXNoTWFwPFNpbmdsZVRocmVhZFdlYWtSZWY8UmVuZGVyRm9vPj4gaW4gUmVuZGVyU2VsZWN0aW9u CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkzMzcwCgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCldpdGggZGVsYXllZCByZW5kZXJlciBkZXN0cnVjdGlvbiwg c3VjaCBXZWFrUmVmcyBhcmUgbm90IGd1YXJhbnRlZWQgYW55bW9yZS4KCiogU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclNlbGVjdGlvbi5jcHA6CihXZWJDb3JlOjpSZW5kZXJTZWxlY3Rp b246OmNvbGxlY3RCb3VuZHMgY29uc3QpOgooV2ViQ29yZTo6UmVuZGVyU2VsZWN0aW9uOjphcHBs eSk6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNlbGVjdGlvbi5jcHAgfCAz NyArKysrKysrKysrLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyks IDE4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJTZWxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNlbGVj dGlvbi5jcHAKaW5kZXggYzI4ZGE1ZWU3ZTQxLi5mZTdlMmY3ZWU4ZDQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTZWxlY3Rpb24uY3BwCkBAIC00OSw4ICs0OSw4IEBAIG5h bWVzcGFjZSB7CiAKIHN0cnVjdCBTZWxlY3Rpb25Db250ZXh0IHsKICAgICAKLSAgICB1c2luZyBS ZW5kZXJlck1hcCA9IFVuY2hlY2tlZEtleUhhc2hNYXA8U2luZ2xlVGhyZWFkV2Vha1JlZjxSZW5k ZXJPYmplY3Q+LCBzdGQ6OnVuaXF1ZV9wdHI8UmVuZGVyU2VsZWN0aW9uR2VvbWV0cnk+PjsKLSAg ICB1c2luZyBSZW5kZXJCbG9ja01hcCA9IFVuY2hlY2tlZEtleUhhc2hNYXA8U2luZ2xlVGhyZWFk V2Vha1JlZjxjb25zdCBSZW5kZXJCbG9jaz4sIHN0ZDo6dW5pcXVlX3B0cjxSZW5kZXJCbG9ja1Nl bGVjdGlvbkdlb21ldHJ5Pj47CisgICAgdXNpbmcgUmVuZGVyZXJNYXAgPSBTaW5nbGVUaHJlYWRX ZWFrSGFzaE1hcDxSZW5kZXJPYmplY3QsIHN0ZDo6dW5pcXVlX3B0cjxSZW5kZXJTZWxlY3Rpb25H ZW9tZXRyeT4+OworICAgIHVzaW5nIFJlbmRlckJsb2NrTWFwID0gU2luZ2xlVGhyZWFkV2Vha0hh c2hNYXA8Y29uc3QgUmVuZGVyQmxvY2ssIHN0ZDo6dW5pcXVlX3B0cjxSZW5kZXJCbG9ja1NlbGVj dGlvbkdlb21ldHJ5Pj47CiAKICAgICB1bnNpZ25lZCBzdGFydE9mZnNldDsKICAgICB1bnNpZ25l ZCBlbmRPZmZzZXQ7CkBAIC0xODMsNyArMTgzLDcgQEAgSW50UmVjdCBSZW5kZXJTZWxlY3Rpb246 OmNvbGxlY3RCb3VuZHMoQ2xpcFRvVmlzaWJsZUNvbnRlbnQgY2xpcFRvVmlzaWJsZUNvbnRlbnQK ICAgICAgICAgaWYgKGlzVmFsaWRSZW5kZXJlckZvclNlbGVjdGlvbigqc3RhcnQsIG1fcmVuZGVy UmFuZ2UpKSB7CiAgICAgICAgICAgICAvLyBCbG9ja3MgYXJlIHJlc3BvbnNpYmxlIGZvciBwYWlu dGluZyBsaW5lIGdhcHMgYW5kIG1hcmdpbiBnYXBzLiBUaGV5IG11c3QgYmUgZXhhbWluZWQgYXMg d2VsbC4KICAgICAgICAgICAgIHJlbmRlcmVycy5zZXQoKnN0YXJ0LCBtYWtlVW5pcXVlPFJlbmRl clNlbGVjdGlvbkdlb21ldHJ5Pigqc3RhcnQsIGNsaXBUb1Zpc2libGVDb250ZW50ID09IENsaXBU b1Zpc2libGVDb250ZW50OjpZZXMpKTsKLSAgICAgICAgICAgIExPR19XSVRIX1NUUkVBTShTZWxl Y3Rpb24sIHN0cmVhbSA8PCAiIGFkZGVkIHN0YXJ0ICIgPDwgKnN0YXJ0IDw8ICIgd2l0aCByZWN0 ICIgPDwgcmVuZGVyZXJzLmdldChzdGFydCktPnJlY3QoKSk7CisgICAgICAgICAgICBMT0dfV0lU SF9TVFJFQU0oU2VsZWN0aW9uLCBzdHJlYW0gPDwgIiBhZGRlZCBzdGFydCAiIDw8ICpzdGFydCA8 PCAiIHdpdGggcmVjdCAiIDw8IHJlbmRlcmVycy5nZXQoKnN0YXJ0KS0+cmVjdCgpKTsKICAgICAg ICAgICAgIAogICAgICAgICAgICAgYXV0byogYmxvY2sgPSBzdGFydC0+Y29udGFpbmluZ0Jsb2Nr KCk7CiAgICAgICAgICAgICB3aGlsZSAoYmxvY2sgJiYgIWlzPFJlbmRlclZpZXc+KCpibG9jaykp IHsKQEAgLTIwMSwxMyArMjAxLDE0IEBAIEludFJlY3QgUmVuZGVyU2VsZWN0aW9uOjpjb2xsZWN0 Qm91bmRzKENsaXBUb1Zpc2libGVDb250ZW50IGNsaXBUb1Zpc2libGVDb250ZW50CiAgICAgCiAg ICAgLy8gTm93IGNyZWF0ZSBhIHNpbmdsZSBib3VuZGluZyBib3ggcmVjdCB0aGF0IGVuY2xvc2Vz IHRoZSB3aG9sZSBzZWxlY3Rpb24uCiAgICAgTGF5b3V0UmVjdCBzZWxlY3Rpb25SZWN0OwotICAg IGZvciAoYXV0byYgaW5mbyA6IHJlbmRlcmVycy52YWx1ZXMoKSkgeworICAgIGZvciAoYXV0byBz bGVjdGlvbkVudHJ5IDogcmVuZGVyZXJzKSB7CisgICAgICAgIGF1dG8qIHNlbGVjdGlvbkdlb21l dHJ5ID0gc2xlY3Rpb25FbnRyeS52YWx1ZS5nZXQoKTsKICAgICAgICAgLy8gUmVuZGVyU2VsZWN0 aW9uR2VvbWV0cnk6OnJlY3QoKSBpcyBpbiB0aGUgY29vcmRpbmF0ZXMgb2YgdGhlIHJlcGFpbnRD b250YWluZXIsIHNvIG1hcCB0byBwYWdlIGNvb3JkaW5hdGVzLgotICAgICAgICBMYXlvdXRSZWN0 IGN1cnJlbnRSZWN0ID0gaW5mby0+cmVjdCgpOworICAgICAgICBMYXlvdXRSZWN0IGN1cnJlbnRS ZWN0ID0gc2VsZWN0aW9uR2VvbWV0cnktPnJlY3QoKTsKICAgICAgICAgaWYgKGN1cnJlbnRSZWN0 LmlzRW1wdHkoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAKLSAgICAgICAgaWYg KGF1dG8qIHJlcGFpbnRDb250YWluZXIgPSBpbmZvLT5yZXBhaW50Q29udGFpbmVyKCkpIHsKKyAg ICAgICAgaWYgKGF1dG8qIHJlcGFpbnRDb250YWluZXIgPSBzZWxlY3Rpb25HZW9tZXRyeS0+cmVw YWludENvbnRhaW5lcigpKSB7CiAgICAgICAgICAgICBGbG9hdFJlY3QgbG9jYWxSZWN0ID0gY3Vy cmVudFJlY3Q7CiAgICAgICAgICAgICBGbG9hdFF1YWQgYWJzUXVhZCA9IHJlcGFpbnRDb250YWlu ZXItPmxvY2FsVG9BYnNvbHV0ZVF1YWQobG9jYWxSZWN0KTsKICAgICAgICAgICAgIGN1cnJlbnRS ZWN0ID0gYWJzUXVhZC5lbmNsb3NpbmdCb3VuZGluZ0JveCgpOwpAQCAtMjI0LDggKzIyNSw4IEBA IHZvaWQgUmVuZGVyU2VsZWN0aW9uOjphcHBseShjb25zdCBSZW5kZXJSYW5nZSYgbmV3U2VsZWN0 aW9uLCBSZXBhaW50TW9kZSBibG9ja1JlCiB7CiAgICAgYXV0byBvbGRTZWxlY3Rpb25EYXRhID0g Y29sbGVjdFNlbGVjdGlvbkRhdGEobV9yZW5kZXJSYW5nZSwgYmxvY2tSZXBhaW50TW9kZSA9PSBS ZXBhaW50TW9kZTo6TmV3WE9ST2xkKTsKICAgICAvLyBSZW1vdmUgY3VycmVudCBzZWxlY3Rpb24u Ci0gICAgZm9yIChhdXRvJiByZW5kZXJlciA6IG9sZFNlbGVjdGlvbkRhdGEucmVuZGVyZXJzLmtl eXMoKSkKLSAgICAgICAgcmVuZGVyZXItPnNldFNlbGVjdGlvblN0YXRlSWZOZWVkZWQoUmVuZGVy T2JqZWN0OjpIaWdobGlnaHRTdGF0ZTo6Tm9uZSk7CisgICAgZm9yIChhdXRvIHNlbGVjdGlvbkVu dHJ5IDogb2xkU2VsZWN0aW9uRGF0YS5yZW5kZXJlcnMpCisgICAgICAgIHNlbGVjdGlvbkVudHJ5 LmtleS5zZXRTZWxlY3Rpb25TdGF0ZUlmTmVlZGVkKFJlbmRlck9iamVjdDo6SGlnaGxpZ2h0U3Rh dGU6Ok5vbmUpOwogICAgIG1fcmVuZGVyUmFuZ2UgPSBuZXdTZWxlY3Rpb247CiAgICAgYXV0byog c2VsZWN0aW9uU3RhcnQgPSBtX3JlbmRlclJhbmdlLnN0YXJ0KCk7CiAgICAgLy8gVXBkYXRlIHRo ZSBzZWxlY3Rpb24gc3RhdHVzIG9mIGFsbCBvYmplY3RzIGJldHdlZW4gc2VsZWN0aW9uU3RhcnQg YW5kIHNlbGVjdGlvbkVuZApAQCAtMjg3LDQxICsyODgsNDEgQEAgdm9pZCBSZW5kZXJTZWxlY3Rp b246OmFwcGx5KGNvbnN0IFJlbmRlclJhbmdlJiBuZXdTZWxlY3Rpb24sIFJlcGFpbnRNb2RlIGJs b2NrUmUKICAgICAgICAgcmV0dXJuOwogICAgIAogICAgIC8vIEhhdmUgYW55IG9mIHRoZSBvbGQg c2VsZWN0ZWQgb2JqZWN0cyBjaGFuZ2VkIGNvbXBhcmVkIHRvIHRoZSBuZXcgc2VsZWN0aW9uPwot ICAgIGZvciAoYXV0byYgc2VsZWN0ZWRSZW5kZXJlckluZm8gOiBvbGRTZWxlY3Rpb25EYXRhLnJl bmRlcmVycykgeworICAgIGZvciAoYXV0byBzZWxlY3RlZFJlbmRlcmVySW5mbyA6IG9sZFNlbGVj dGlvbkRhdGEucmVuZGVyZXJzKSB7CiAgICAgICAgIGF1dG8mIHJlbmRlcmVyID0gc2VsZWN0ZWRS ZW5kZXJlckluZm8ua2V5OwotICAgICAgICBhdXRvKiBuZXdJbmZvID0gbmV3U2VsZWN0ZWRSZW5k ZXJlcnMuZ2V0KHJlbmRlcmVyLmdldCgpKTsKKyAgICAgICAgYXV0byogbmV3SW5mbyA9IG5ld1Nl bGVjdGVkUmVuZGVyZXJzLmdldChyZW5kZXJlcik7CiAgICAgICAgIGF1dG8qIG9sZEluZm8gPSBz ZWxlY3RlZFJlbmRlcmVySW5mby52YWx1ZS5nZXQoKTsKICAgICAgICAgaWYgKCFuZXdJbmZvIHx8 IG9sZEluZm8tPnJlY3QoKSAhPSBuZXdJbmZvLT5yZWN0KCkgfHwgb2xkSW5mby0+c3RhdGUoKSAh PSBuZXdJbmZvLT5zdGF0ZSgpCi0gICAgICAgICAgICB8fCAobV9yZW5kZXJSYW5nZS5zdGFydCgp ID09IHJlbmRlcmVyLnB0cigpICYmIG9sZFNlbGVjdGlvbkRhdGEuc3RhcnRPZmZzZXQgIT0gbV9y ZW5kZXJSYW5nZS5zdGFydE9mZnNldCgpKQotICAgICAgICAgICAgfHwgKG1fcmVuZGVyUmFuZ2Uu ZW5kKCkgPT0gcmVuZGVyZXIucHRyKCkgJiYgb2xkU2VsZWN0aW9uRGF0YS5lbmRPZmZzZXQgIT0g bV9yZW5kZXJSYW5nZS5lbmRPZmZzZXQoKSkpIHsKKyAgICAgICAgICAgIHx8IChtX3JlbmRlclJh bmdlLnN0YXJ0KCkgPT0gJnJlbmRlcmVyICYmIG9sZFNlbGVjdGlvbkRhdGEuc3RhcnRPZmZzZXQg IT0gbV9yZW5kZXJSYW5nZS5zdGFydE9mZnNldCgpKQorICAgICAgICAgICAgfHwgKG1fcmVuZGVy UmFuZ2UuZW5kKCkgPT0gJnJlbmRlcmVyICYmIG9sZFNlbGVjdGlvbkRhdGEuZW5kT2Zmc2V0ICE9 IG1fcmVuZGVyUmFuZ2UuZW5kT2Zmc2V0KCkpKSB7CiAgICAgICAgICAgICBvbGRJbmZvLT5yZXBh aW50KCk7CiAgICAgICAgICAgICBpZiAobmV3SW5mbykgewogICAgICAgICAgICAgICAgIG5ld0lu Zm8tPnJlcGFpbnQoKTsKLSAgICAgICAgICAgICAgICBuZXdTZWxlY3RlZFJlbmRlcmVycy5yZW1v dmUocmVuZGVyZXIuZ2V0KCkpOworICAgICAgICAgICAgICAgIG5ld1NlbGVjdGVkUmVuZGVyZXJz LnJlbW92ZShyZW5kZXJlcik7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAgICAg CiAgICAgLy8gQW55IG5ldyBvYmplY3RzIHRoYXQgcmVtYWluIHdlcmUgbm90IGZvdW5kIGluIHRo ZSBvbGQgb2JqZWN0cyBkaWN0LCBhbmQgc28gdGhleSBuZWVkIHRvIGJlIHVwZGF0ZWQuCi0gICAg Zm9yIChhdXRvJiBzZWxlY3RlZFJlbmRlcmVySW5mbyA6IG5ld1NlbGVjdGVkUmVuZGVyZXJzKQor ICAgIGZvciAoYXV0byBzZWxlY3RlZFJlbmRlcmVySW5mbyA6IG5ld1NlbGVjdGVkUmVuZGVyZXJz KQogICAgICAgICBzZWxlY3RlZFJlbmRlcmVySW5mby52YWx1ZS0+cmVwYWludCgpOwogICAgIAog ICAgIC8vIEhhdmUgYW55IG9mIHRoZSBvbGQgYmxvY2tzIGNoYW5nZWQ/Ci0gICAgZm9yIChhdXRv JiBzZWxlY3RlZEJsb2NrSW5mbyA6IG9sZFNlbGVjdGlvbkRhdGEuYmxvY2tzKSB7CisgICAgZm9y IChhdXRvIHNlbGVjdGVkQmxvY2tJbmZvIDogb2xkU2VsZWN0aW9uRGF0YS5ibG9ja3MpIHsKICAg ICAgICAgYXV0byYgYmxvY2sgPSBzZWxlY3RlZEJsb2NrSW5mby5rZXk7Ci0gICAgICAgIGF1dG8q IG5ld0luZm8gPSBuZXdTZWxlY3RlZEJsb2Nrcy5nZXQoYmxvY2suZ2V0KCkpOworICAgICAgICBh dXRvKiBuZXdJbmZvID0gbmV3U2VsZWN0ZWRCbG9ja3MuZ2V0KGJsb2NrKTsKICAgICAgICAgYXV0 byogb2xkSW5mbyA9IHNlbGVjdGVkQmxvY2tJbmZvLnZhbHVlLmdldCgpOwogICAgICAgICBpZiAo IW5ld0luZm8gfHwgb2xkSW5mby0+cmVjdHMoKSAhPSBuZXdJbmZvLT5yZWN0cygpIHx8IG9sZElu Zm8tPnN0YXRlKCkgIT0gbmV3SW5mby0+c3RhdGUoKSkgewogICAgICAgICAgICAgb2xkSW5mby0+ cmVwYWludCgpOwogICAgICAgICAgICAgaWYgKG5ld0luZm8pIHsKICAgICAgICAgICAgICAgICBu ZXdJbmZvLT5yZXBhaW50KCk7Ci0gICAgICAgICAgICAgICAgbmV3U2VsZWN0ZWRCbG9ja3MucmVt b3ZlKGJsb2NrLmdldCgpKTsKKyAgICAgICAgICAgICAgICBuZXdTZWxlY3RlZEJsb2Nrcy5yZW1v dmUoYmxvY2spOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQogICAgIAogICAgIC8v IEFueSBuZXcgYmxvY2tzIHRoYXQgcmVtYWluIHdlcmUgbm90IGZvdW5kIGluIHRoZSBvbGQgYmxv Y2tzIGRpY3QsIGFuZCBzbyB0aGV5IG5lZWQgdG8gYmUgdXBkYXRlZC4KLSAgICBmb3IgKGF1dG8m IHNlbGVjdGVkQmxvY2tJbmZvIDogbmV3U2VsZWN0ZWRCbG9ja3MpCisgICAgZm9yIChhdXRvIHNl bGVjdGVkQmxvY2tJbmZvIDogbmV3U2VsZWN0ZWRCbG9ja3MpCiAgICAgICAgIHNlbGVjdGVkQmxv Y2tJbmZvLnZhbHVlLT5yZXBhaW50KCk7CiB9CiAK