29330 2009-09-17 01:57:13 -0700 [v8] Don't keep clean wrappers artificially alive 2013-09-12 22:21:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 christian.plesner.hansen christian.plesner.hansen abarth andersca commit-queue dglazkov eric levin oldest_to_newest 147766 0 christian.plesner.hansen 2009-09-17 01:57:13 -0700 We currently keep all DOM node wrappers alive, even when there are no more references to them from JS, in case they have properties that we need to keep around if new JS references are created. This changes the policy to only keep wrappers artificially alive if they have changed since they were created. Empty wrappers are discarded and recreated as needed. 147767 1 39686 christian.plesner.hansen 2009-09-17 02:01:26 -0700 Created attachment 39686 initial 147768 2 christian.plesner.hansen 2009-09-17 02:04:23 -0700 Important note: this change can not be committed until v8 has been updated in chromium. Should I wait until then to get this reviewed? 147769 3 39686 abarth 2009-09-17 02:42:10 -0700 Comment on attachment 39686 initial Super cool change. Feel free to ping this bug when you want it landed. You can also set the commit-queue flag to ? if you'd like the commit bot to land the patch. 147773 4 christian.plesner.hansen 2009-09-17 02:55:36 -0700 Thanks, that was quick! So if I set the commit flag to ? someone with the right permissions will notice and set it to +? 147814 5 abarth 2009-09-17 09:24:12 -0700 (In reply to comment #4) > Thanks, that was quick! Well, the patch is obviously correct by magic (because all the hard work is going on in V8). :) > So if I set the commit flag to ? someone with the right permissions will notice > and set it to +? Yes. I've CC'ed Eric explicitly because he's good at setting the commit-queue flag. 147816 6 eric 2009-09-17 09:34:02 -0700 (In reply to comment #5) > Yes. I've CC'ed Eric explicitly because he's good at setting the commit-queue > flag. Huh? 147825 7 abarth 2009-09-17 09:57:00 -0700 > Huh? Meaning if you see an email with commit-queue?, you're likely to go to the bug and set commit-queue+. :) 148356 8 eric 2009-09-18 13:28:25 -0700 (In reply to comment #7) > > Huh? > > Meaning if you see an email with commit-queue?, you're likely to go to the bug > and set commit-queue+. :) Except here it's set to cq-... 148462 9 abarth 2009-09-18 22:45:37 -0700 (In reply to comment #8) > Except here it's set to cq-... See comment #2. :) 149049 10 39686 commit-queue 2009-09-22 07:54:41 -0700 Comment on attachment 39686 initial Rejecting patch 39686 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... Merge conflict during commit: Your file or directory 'WebCore/ChangeLog' is probably out-of-date: resource out of date; try updating at /usr/local/libexec/git-core//git-svn line 469 149051 11 39686 abarth 2009-09-22 07:59:35 -0700 Comment on attachment 39686 initial I don't think the commit queue should reject patches when it gets that error. 149075 12 eric 2009-09-22 09:55:30 -0700 (In reply to comment #11) > (From update of attachment 39686 [details]) > I don't think the commit queue should reject patches when it gets that error. I totally agree! bug 28316. I'll see if I can post a patch to fix it today. :( 149076 13 eric 2009-09-22 09:56:14 -0700 Builders have been red for the last while: http://webkit-commit-queue.appspot.com/ But once they go green again this will land. 149093 14 39686 commit-queue 2009-09-22 10:26:40 -0700 Comment on attachment 39686 initial Clearing flags on attachment: 39686 Committed r48639: <http://trac.webkit.org/changeset/48639> 149094 15 commit-queue 2009-09-22 10:26:48 -0700 All reviewed patches have been landed. Closing bug. 149264 16 dglazkov 2009-09-22 16:38:29 -0700 This patch seems to have introduced all kinds of weird, seemingly random layout test failures. I am rolling this out until we hash this out. 149268 17 dglazkov 2009-09-22 16:49:21 -0700 Rolled out in http://trac.webkit.org/changeset/48657. Awesome scripting, Eric! 928633 18 andersca 2013-09-12 22:21:28 -0700 V8 is gone. 39686 2009-09-17 02:01:26 -0700 2010-06-10 19:07:30 -0700 initial bug-29330-20090917110119.patch text/plain 1698 christian.plesner.hansen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODQ1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDktMTcgIENocmlzdGlhbiBQbGVzbmVyIEhhbnNlbiAgPGNo cmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBEb24ndCBrZWVwIGNsZWFuIHdyYXBwZXJz IGFydGlmaWNpYWxseSBhbGl2ZSAgICAgICAgCisgICAgICAgIFdlIGN1cnJlbnRseSBrZWVwIGFs bCBET00gbm9kZSB3cmFwcGVycyBhbGl2ZSwgZXZlbiB3aGVuIHRoZXJlIGFyZQorICAgICAgICBu byBtb3JlIHJlZmVyZW5jZXMgdG8gdGhlbSBmcm9tIEpTLCBpbiBjYXNlIHRoZXkgaGF2ZSBwcm9w ZXJ0aWVzCisgICAgICAgIHRoYXQgd2UgbmVlZCB0byBrZWVwIGFyb3VuZCBpZiBuZXcgSlMgcmVm ZXJlbmNlcyBhcmUgY3JlYXRlZC4KKyAgICAgICAgVGhpcyBjaGFuZ2VzIHRoZSBwb2xpY3kgdG8g b25seSBrZWVwIHdyYXBwZXJzIGFydGlmaWNpYWxseSBhbGl2ZQorICAgICAgICBpZiB0aGV5IGhh dmUgY2hhbmdlZCBzaW5jZSB0aGV5IHdlcmUgY3JlYXRlZC4gRW1wdHkgd3JhcHBlcnMgYXJlCisg ICAgICAgIGRpc2NhcmRlZCBhbmQgcmVjcmVhdGVkIGFzIG5lZWRlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5MzMwCisKKyAgICAgICAgKiBiaW5k aW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpPYmplY3RHcm91 cGVyVmlzaXRvcjo6dmlzaXRET01XcmFwcGVyKToKKwogMjAwOS0wOS0xNiAgRGFuaWVsIEJhdGVz ICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNDg0 MjMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjcyLDYgKzI3MiwxMSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHZpc2l0RE9NV3Jh cHBlcihOb2RlKiBub2RlLCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQogICAg IHsKKyAgICAgICAgLy8gSWYgdGhlIHdyYXBwZXIgaXMgY2xlYW4gaXQgd2lsbCBub3QgYmUgZGV0 ZWN0YWJsZSBpZiBpdAorICAgICAgICAvLyBnb2VzIGF3YXkgYW5kIGlzIHJlY3JlYXRlZCBsYXRl ciBzbyB3ZSBkb24ndCBtYWtlIGFuIGVmZm9ydAorICAgICAgICAvLyB0byBrZWVwIGl0IGFsaXZl IGhlcmUuCisgICAgICAgIGlmICghd3JhcHBlci0+SXNEaXJ0eSgpKQorICAgICAgICAgICAgcmV0 dXJuOwogCiAgICAgICAgIC8vIElmIHRoZSBub2RlIGlzIGluIGRvY3VtZW50LCBwdXQgaXQgaW4g dGhlIG93bmVyRG9jdW1lbnQncyBvYmplY3QgZ3JvdXAuCiAgICAgICAgIC8v