<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>293240</bug_id>
          
          <creation_ts>2025-05-19 11:27:03 -0700</creation_ts>
          <short_desc>Remove all calls to deprecated NSImage setScalesWhenResized</short_desc>
          <delta_ts>2025-05-21 14:46:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2118161</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2025-05-19 11:27:03 -0700</bug_when>
    <thetext>I removed on use of the deprecated `setScalesWhenResized:` call in Bug 293071. I failed to search the codebase for other instances, and missed several others.

We should remove them, too.

The NSImage method `setScalesWhenResized:` has been deprecated since macOS 10.6.
&quot;You should be able to remove use of this method without any replacement.  See 10.6
AppKit release notes for details.&quot;
&lt;https://developer.apple.com/documentation/appkit/nsimage/setscaleswhenresized:&gt;

The AppKit (for 10.6) notes indicate:
&quot;Sets whether different-sized image representations are scaled to fit the receiver&apos;s
size. (Deprecated in Mac OS X v10.6. This method was related to caching behavior. In
Mac OS X v10.6 and later image caching is no long necessary and as a result there is
no replacement necessary.)&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2118162</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2025-05-19 11:28:37 -0700</bug_when>
    <thetext>&lt;rdar://problem/151628981&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2118163</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2025-05-19 11:31:50 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/45601</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2118797</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-05-21 14:46:28 -0700</bug_when>
    <thetext>Committed 295233@main (04842bc8c686): &lt;https://commits.webkit.org/295233@main&gt;

Reviewed commits have been landed. Closing PR #45601 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>