29318 2009-09-16 15:47:00 -0700 Update contributing.html to mention recently added tools. 2009-09-17 13:07:25 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue darin oldest_to_newest 147652 0 eric 2009-09-16 15:47:00 -0700 Update contributing.html to mention recently added tools. CC'ing darin as he's often edited this file in the past. 147653 1 39664 eric 2009-09-16 15:48:29 -0700 Created attachment 39664 Patch v1 147738 2 39664 darin 2009-09-16 22:33:47 -0700 Comment on attachment 39664 Patch v1 > - <li>Upload the patch for review. In Bugzilla, be sure to set the <tt>review:?</tt> flag.</li> > + <li>Upload the patch for review. In Bugzilla, be sure to mark your file as a patch and set the <tt>review:?</tt> flag.</li> I think this could be slightly more explicit; it may not be obvious there is a check box labeled "patch" they have to check. But I don't have better wording to suggest. 147748 3 39664 eric 2009-09-16 23:53:53 -0700 Comment on attachment 39664 Patch v1 Agreed. We could further improve the patch checkbox wording. Ideally we could just get rid of that checkbox all together. :) I think for now I'll commit this as is and we can iterate from here. Thanks for the review! I'll mark this cq+. The queue is off for the moment as Mark has been performing builder maintenance this evening. This will land tomorrow morning when I turn the queue back on. 147905 4 39664 commit-queue 2009-09-17 13:07:20 -0700 Comment on attachment 39664 Patch v1 Clearing flags on attachment: 39664 Committed r48488: <http://trac.webkit.org/changeset/48488> 147907 5 commit-queue 2009-09-17 13:07:25 -0700 All reviewed patches have been landed. Closing bug. 39664 2009-09-16 15:48:29 -0700 2009-09-17 13:07:20 -0700 Patch v1 bug-29318-20090916154828.patch text/plain 6476 eric ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggM2U2OTExYi4uZjZlMzYxMSAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOS0wOS0xNiAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGNvbnRyaWJ1dGluZy5odG1sIHRvIG1lbnRp b24gcmVjZW50bHkgYWRkZWQgdG9vbHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yOTMxOAorCisgICAgICAgIFVwZGF0ZSBvdXIgY29udHJpYnV0aW5n IGluc3RydWN0aW9ucyB0byBtZW50aW9uCisgICAgICAgIHRoZSBuZXcgdG9vbHMgKGNoZWNrLXdl YmtpdC1zdHlsZSBhbmQgY29tbWl0LXF1ZXVlKQorICAgICAgICByZWNlbnRseSBhZGRlZCB0byBt YWtlIGNvbnRyaWJ1dGlvbnMgZWFzaWVyLgorCisgICAgICAgICogY29kaW5nL2NvbnRyaWJ1dGlu Zy5odG1sOgorICAgICAgICAgLSBNZW50aW9uIGNoZWNrLXdlYmtpdC1zdHlsZSBhcyBhbiBvcHRp b25hbCBoZWxwZXIgdG9vbC4KKyAgICAgICAgIC0gTWVudGlvbiBjaGVja2luZyB0aGUgJ3BhdGNo JyBjaGVja2JveC4KKyAgICAgICAgIC0gTWVudGlvbiB0aGUgY29tbWl0LXF1ZXVlIGFzIGFuIG9w dGlvbmFsIGhlbHBlciB0b29sLgorICAgICAgICAgLSBSZW1vdmUgIm9yIGluIGVtYWlsIiBzaW5j ZSBwYXRjaCByZXZpZXdzIGFyZSBhbGwgZG9uZSB2aWEgYnVnemlsbGEuCisgICAgICAgICAtIEVu Y291cmFnZSBjb250cmlidXRlcnMgdG8gYmUgcmVzcG9uc2libGUgZm9yIGdldHRpbmcgdGhlaXIg cGF0Y2ggbGFuZGVkLiAgUHJvdmlkZSBhIGxpc3Qgb2YgY29tbWl0dGVycy4KKyAgICAgICAgIC0g TWVudGlvbiBjb21taXQtcXVldWUgYXMgYW4gb3B0aW9uYWwgaGVscCBpbiBnZXR0aW5nIHlvdXIg cGF0Y2ggbGFuZGVkLgorICAgICAgICAgLSBHaXZlIGFuIG92ZXJ2aWV3IG9mIHRoZSBjb21taXQt cXVldWUgcHJvY2VzcyBhbmQgbGluayB0byB0aGUgQ29tbWl0IFF1ZXVlIGRvY3MuCisKIDIwMDkt MDktMDkgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvY29k aW5nL2NvbnRyaWJ1dGluZy5odG1sIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29udHJpYnV0aW5nLmh0 bWwKaW5kZXggNGYxOWE2YS4uNzBlZjQxOCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9jb2Rpbmcv Y29udHJpYnV0aW5nLmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29udHJpYnV0aW5nLmh0 bWwKQEAgLTYsMTUgKzYsMTYgQEAKIDxwPkNvbnRyaWJ1dGluZyBjb2RlIHRvIHRoZSBXZWJLaXQg cHJvamVjdCBpcyBhIHN0cmFpZ2h0Zm9yd2FyZCBwcm9jZXNzLgogT25jZSB5b3UgaGF2ZSB0aGUg Y29kZSA8YSBocmVmPSIvYnVpbGRpbmcvY2hlY2tvdXQuaHRtbCI+Y2hlY2tlZCBvdXQ8L2E+LCA8 YSBocmVmPSIvYnVpbGRpbmcvYnVpbGQuaHRtbCI+YnVpbHQ8L2E+LCBhbmQgbWFkZSB5b3VyIGNo YW5nZXMsIHlvdSdsbCBuZWVkIHRvIGRvIGEgZmV3IHRoaW5ncyBpbiBvcmRlciB0byBnZXQgaXQg bGFuZGVkIGluIHRoZSB0cmVlOjwvcD4KIDxvbD4KLSAgICA8bGk+TWFrZSBzdXJlIHlvdXIgY2hh bmdlcyBtZWV0IHRoZSA8YSBocmVmPSIvY29kaW5nL2NvZGluZy1zdHlsZS5odG1sIj5jb2RlIHN0 eWxlIGd1aWRlbGluZXM8L2E+LjwvbGk+CisgICAgPGxpPk1ha2Ugc3VyZSB5b3VyIGNoYW5nZXMg bWVldCB0aGUgPGEgaHJlZj0iL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbCI+Y29kZSBzdHlsZSBn dWlkZWxpbmVzPC9hPi4gPHR0PmNoZWNrLXdlYmtpdC1zdHlsZTwvdHQ+IG1heSBiZSBvZiBoZWxw LjwvbGk+CiAgICAgPGxpPlJ1biB0aGUgbGF5b3V0IHRlc3RzIHVzaW5nIHRoZSA8dHQ+cnVuLXdl YmtpdC10ZXN0czwvdHQ+IHNjcmlwdCBhbmQgbWFrZSBzdXJlIHRoZXkgYWxsIHBhc3MuCiAgICAg ICAgIFNlZSB0aGUgPGEgaHJlZj0iL3F1YWxpdHkvdGVzdHdyaXRpbmcuaHRtbCI+dGVzdGluZyBw YWdlPC9hPiBmb3IgbW9yZSBpbmZvcm1hdGlvbiwgYXMgd2VsbCBhcyB3aGF0IHlvdSBuZWVkIHRv IGRvIGlmIHlvdSd2ZSBtb2RpZmllZCBKYXZhU2NyaXB0Q29yZS48L2xpPgogICAgIDxsaT5BZGQg YW55IG5ldyBmaWxlcyBhbmQgbGF5b3V0IHRlc3RzIHRvIFN1YnZlcnNpb24gdXNpbmcgdGhlIDx0 dD5zdm4gYWRkPC90dD4gY29tbWFuZC48L2xpPgogICAgIDxsaT5QcmVwYXJlIGEgY2hhbmdlIGxv ZyBlbnRyeS4gWW91IG1heSBoYXZlIHRvIGFkZCBlbnRyaWVzIHRvIG11bHRpcGxlIENoYW5nZUxv Z3MuIFRoZSA8dHQ+cHJlcGFyZS1DaGFuZ2VMb2c8L3R0PiBzY3JpcHQgd2lsbCBjcmVhdGUgc3R1 YiBlbnRyaWVzIGZvciB5b3UuICBTZWUgdGhlIDxhIGhyZWY9IiNjaGFuZ2Vsb2dzIj5wYXJhZ3Jh cGggYWJvdXQgQ2hhbmdlTG9nczwvYT4gYmVsb3cuPC9saT4KICAgICA8bGk+Q3JlYXRlIHRoZSBw YXRjaCB1c2luZyB0aGUgPHR0PnN2bi1jcmVhdGUtcGF0Y2g8L3R0PiBzY3JpcHQuPC9saT4KLSAg ICA8bGk+VXBsb2FkIHRoZSBwYXRjaCBmb3IgcmV2aWV3LiBJbiBCdWd6aWxsYSwgYmUgc3VyZSB0 byBzZXQgdGhlIDx0dD5yZXZpZXc6PzwvdHQ+IGZsYWcuPC9saT4KKyAgICA8bGk+VXBsb2FkIHRo ZSBwYXRjaCBmb3IgcmV2aWV3LiBJbiBCdWd6aWxsYSwgYmUgc3VyZSB0byBtYXJrIHlvdXIgZmls ZSBhcyBhIHBhdGNoIGFuZCBzZXQgdGhlIDx0dD5yZXZpZXc6PzwvdHQ+IGZsYWcuPC9saT4KICAg ICA8bGk+TWFrZSBhbnkgY2hhbmdlcyByZWNvbW1lbmRlZCBieSB0aGUgcmV2aWV3ZXIuPC9saT4K LSAgICA8bGk+T25jZSByZXZpZXdlZCwgZ2V0IHlvdXIgcGF0Y2ggbGFuZGVkIGluIHRoZSB0cmVl IGFuZCB3YXRjaCBmb3IgYW55IHJlZ3Jlc3Npb25zIGl0IG1heSBoYXZlIGNhdXNlZCAoaG9wZWZ1 bGx5IG5vbmUpITwvbGk+CisgICAgPGxpPk9uY2UgcmV2aWV3ZWQsIGFzayBzb21lb25lIHRvIGxh bmQgeW91ciBwYXRjaCBvciBtYXJrIGl0IGZvciA8YSBocmVmPSIjY29tbWl0cXVldWUiPmF1dG9t YXRlZCBjb21taXQ8L2E+LgorICAgIDxsaT5QbGVhc2Ugd2F0Y2ggZm9yIGFueSByZWdyZXNzaW9u cyBpdCBtYXkgaGF2ZSBjYXVzZWQgKGhvcGVmdWxseSBub25lKSE8L2xpPgogPC9vbD4KIAogCkBA IC01NiwxNiArNTcsMTggQEAgc3VyZSBubyBjaGFuZ2VzIGFyZSBsZWZ0IG91dCBvZiB5b3VyIHBh dGNoLiBJdCBpcyBub3QgbmVjZXNzYXJ5IHRvIGJyZWFrIGEgcGF0Y2gKIDxoMz5QYXRjaCByZXZp ZXc8L2gzPgogPHA+T25jZSB5b3UgaGF2ZSBhIHBhdGNoIGZpbGUsIGl0IG11c3QgYmUgcmV2aWV3 ZWQgYnkgb25lIG9mIHRoZSBhcHByb3ZlZCBXZWJLaXQgcmV2aWV3ZXJzLiBUbyByZXF1ZXN0IGEg cmV2aWV3LCBhdHRhY2ggdGhlIHBhdGNoCiB0byB0aGUgYnVnIHJlcG9ydCwgYW5kIG1hcmsgdGhl IHBhdGNoIHdpdGggdGhlIGZsYWcgPHR0PnJldmlldzo/PC90dD4uIFRoZSByZXZpZXdlciB3aWxs IHR5cGljYWxseSBlaXRoZXIgYXBwcm92ZSB0aGUgcGF0Y2gKLShieSByZXNwb25kaW5nIHdpdGgg YW4gPHR0PnI9bWU8L3R0PiBpbiB0aGUgYnVnIHJlcG9ydCBvciBpbiBlLW1haWwgYW5kIG1hcmtp bmcgdGhlIHBhdGNoIDx0dD5yZXZpZXc6KzwvdHQ+KSBvciByZXF1ZXN0IHJldmlzaW9ucworKGJ5 IHJlc3BvbmRpbmcgd2l0aCBhbiA8dHQ+cj1tZTwvdHQ+IGluIHRoZSBidWcgcmVwb3J0IGFuZCBt YXJraW5nIHRoZSBwYXRjaCA8dHQ+cmV2aWV3Ois8L3R0Pikgb3IgcmVxdWVzdCByZXZpc2lvbnMK IHRvIHRoZSBwYXRjaCAoYW5kIG1hcmsgdGhlIHBhdGNoIDx0dD5yZXZpZXc6LTwvdHQ+KS4gSW4g cmFyZSBjYXNlcyBhIHBhdGNoIG1heSBiZSBwZXJtYW5lbnRseSByZWplY3RlZCwgbWVhbmluZyB0 aGF0IHRoZSByZXZpZXdlcgogYmVsaWV2ZXMgdGhlIGZlYXR1cmUgc2hvdWxkIG5ldmVyIGJlIGNv bW1pdHRlZCB0byB0aGUgdHJlZS4gVGhlIHJldmlldyBwcm9jZXNzIGNhbiBjb25zaXN0IG9mIG11 bHRpcGxlIGl0ZXJhdGlvbnMgYmV0d2VlbiB5b3UgYW5kCiB0aGUgcmV2aWV3ZXIgYXMgcmV2aXNp b25zIGFyZSBtYWRlIHRvIHlvdXIgcGF0Y2guPC9wPgogCi08aDM+TGFuZGluZyBpbiB0aGUgdHJl ZTwvaDM+Ci08cD5PbmNlIGEgcGF0Y2ggaXMgYXBwcm92ZWQsIHNvbWVvbmUgd2l0aCBjb21taXQg YWNjZXNzIHdpbGwgbGFuZCB5b3VyIHBhdGNoLiBZb3VyIHJlc3BvbnNpYmlsaXR5IGZvciB0aGUg cGF0Y2ggZG9lcyBub3QgZW5kIHdpdGgKLXRoZSBwYXRjaCBsYW5kaW5nIGluIHRoZSB0cmVlLiBU aGVyZSBtYXkgYmUgcmVncmVzc2lvbnMgZnJvbSB5b3VyIGNoYW5nZSBvciBhZGRpdGlvbmFsIGZl ZWRiYWNrIGZyb20gcmV2aWV3ZXJzIGFmdGVyIHRoZSBwYXRjaCBoYXMgbGFuZGVkLiAgWW91IGNh biB3YXRjaCB0aGUgdHJlZSBhdCA8YSBocmVmPSJodHRwOi8vYnVpbGQud2Via2l0Lm9yZyI+YnVp bGQud2Via2l0Lm9yZzwvYT4gdG8gbWFrZSBzdXJlIHlvdXIgcGF0Y2ggYnVpbGRzIGFuZCBwYXNz ZXMgdGVzdHMgb24gYWxsIHBsYXRmb3Jtcy4KKzxoMz48YSBuYW1lPSJsYW5kaW5nIj5MYW5kaW5n IGluIHRoZSB0cmVlPC9hPjwvaDM+Cis8cD5PbmNlIGEgcGF0Y2ggaXMgYXBwcm92ZWQsIHlvdSBz aG91bGQgYXNrIDxhIGhyZWY9Imh0dHBzOi8vbGlzdHMud2Via2l0Lm9yZy9tYWlsbWFuL3Jvc3Rl ci5jZ2kvd2Via2l0LWNvbW1pdHRlcnMiPnNvbWVvbmUgd2l0aCBjb21taXQgYWNjZXNzPC9hPiB0 byBsYW5kIHlvdXIgcGF0Y2guIEFsdGVybmF0aXZlbHkgeW91IGNhbiByZXF1ZXN0IHRoYXQgeW91 ciBwYXRjaCBiZSBjb21taXR0ZWQgYnkgb3VyIDxhIGhyZWY9IiNjb21taXRxdWV1ZSI+Y29tbWl0 IGJvdDwvYT4uIEluIGVpdGhlciBjYXNlLCB5b3VyIHJlc3BvbnNpYmlsaXR5IGZvciB0aGUgcGF0 Y2ggZG9lcyBub3QgZW5kIHdpdGggdGhlIHBhdGNoIGxhbmRpbmcgaW4gdGhlIHRyZWUuIFRoZXJl IG1heSBiZSByZWdyZXNzaW9ucyBmcm9tIHlvdXIgY2hhbmdlIG9yIGFkZGl0aW9uYWwgZmVlZGJh Y2sgZnJvbSByZXZpZXdlcnMgYWZ0ZXIgdGhlIHBhdGNoIGhhcyBsYW5kZWQuIFlvdSBjYW4gd2F0 Y2ggdGhlIHRyZWUgYXQgPGEgaHJlZj0iaHR0cDovL2J1aWxkLndlYmtpdC5vcmciPmJ1aWxkLndl YmtpdC5vcmc8L2E+IHRvIG1ha2Ugc3VyZSB5b3VyIHBhdGNoIGJ1aWxkcyBhbmQgcGFzc2VzIHRl c3RzIG9uIGFsbCBwbGF0Zm9ybXMuCiBJdCBpcyB5b3VyIHJlc3BvbnNpYmlsaXR5IHRvIGJlIGF2 YWlsYWJsZSBzaG91bGQgcmVncmVzc2lvbnMgYXJpc2UgYW5kIHRvIHJlc3BvbmQgdG8gYWRkaXRp b25hbCBmZWVkYmFjayB0aGF0IGhhcHBlbnMgYWZ0ZXIgYSBjaGVjay1pbi48L3A+CiAKKzxoMz48 YSBuYW1lPSJjb21taXRxdWV1ZSI+T3B0aW9uYWw6IFVzZSBvZiB0aGUgV2ViS2l0IENvbW1pdCBC b3Q8L2E+PC9oMz4KKzxwPldlYktpdCBwcm92aWRlcyBhbiBhdXRvbWF0ZWQgc3lzdGVtIChjb21t aXQtcXVldWUpIGZvciBsYW5kaW5nIHBhdGNoZXMgZm9yIGFueSB3aG8gd291bGQgbGlrZSB0byB1 c2UgaXQuICBUbyB1c2UgdGhlIGNvbW1pdC1xdWV1ZSwgc2V0IHRoZSA8dHQ+Y29tbWl0LXF1ZXVl Oj88L3R0PiBmbGFnIG9uIHlvdXIgcGF0Y2guICBBIGNvbW1pdHRlciB3aWxsIHNldCA8dHQ+Y29t bWl0LXF1ZXVlOis8L3R0PiBhbmQgYW4gYXV0b21hdGVkIHByb2Nlc3Mgd2lsbCBkb3dubG9hZCwg YnVpbGQsIHJ1biB0aGUgbGF5b3V0IHRlc3RzLCBhbmQgc3VibWl0IHlvdXIgcGF0Y2ggb24geW91 ciBiZWhhbGYuICBJZiB0aGUgPGEgaHJlZj0iaHR0cDovL2J1aWxkLndlYmtpdC5vcmcvIj5XZWJL aXQgYnVpbGRib3RzPC9hPiBhcmUgcGFzc2luZywgeW91ciBwYXRjaCBzaG91bGQgYmUgbGFuZGVk IHdpdGhpbiAxNSBtaW51dGVzIGFmdGVyIDx0dD5jb21taXQtcXVldWU6KzwvdHQ+IGlzIHNldC4g U2VlIHRoZSA8YSBocmVmPSJodHRwczovL3RyYWMud2Via2l0Lm9yZy93aWtpL0NvbW1pdFF1ZXVl Ij5jb21taXQtcXVldWUgZG9jdW1lbnRhdGlvbjwvYT4gZm9yIG1vcmUgaW5mb3JtYXRpb24uPC9w PgorCiA8aDI+V2ViS2l0IFNjcmlwdHM8L2gyPgogPHA+PHR0PldlYktpdFRvb2xzL1NjcmlwdHM8 L3R0PiBjb250YWlucyBhIG51bWJlciBvZiBzY3JpcHRzIHRvIGhlbHAgbWFrZSBsaWZlIGVhc2ll ciB3aGVuIHN1Ym1pdHRpbmcgYSBwYXRjaC4gQWxsIHNjcmlwdHMgbWVudGlvbmVkCiBvbiB0aGlz IHBhZ2UgKGFuZCBvbiB0aGUgcmVzdCBvZiB0aGUgc2l0ZSBhcyB3ZWxsKSBhcmUgbG9jYXRlZCBo ZXJlIHVubGVzcyBvdGhlcndpc2UgbWVudGlvbmVkLjwvcD4=