29295 2009-09-16 04:21:08 -0700 Free ThreadGlobalData in Qt (heavily leaks when JS workers are used) 2009-09-16 06:21:26 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 0 zherczeg webkit-unassigned zoltan oldest_to_newest 147500 0 zherczeg 2009-09-16 04:21:08 -0700 This patch proposes a fix for the Qt port of wtf/ThreadSpecific.h to free thread local objects when a thread is destroyed. 147501 1 39639 zherczeg 2009-09-16 04:28:12 -0700 Created attachment 39639 proposed patch 147506 2 39642 zherczeg 2009-09-16 05:48:03 -0700 Created attachment 39642 More changelog text 147508 3 39642 hausmann 2009-09-16 06:03:11 -0700 Comment on attachment 39642 More changelog text r=me, thanks for the more detailed explanation in the ChangeLog 147514 4 zoltan 2009-09-16 06:21:26 -0700 Landed in @48412. http://trac.webkit.org/changeset/48412/ 39639 2009-09-16 04:28:12 -0700 2009-09-16 05:48:03 -0700 proposed patch 0001-Free-thread-local-objects.patch text/plain 3254 zherczeg RnJvbSAzYzQ5OTg1ZGMwNTc5MjBiY2YxMDYzYTBmZDQ5Yzc5ODJlNmYyMjUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBXZWQsIDE2IFNlcCAyMDA5IDEzOjI2OjE1ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gRnJlZSB0aHJlYWQgbG9jYWwgb2JqZWN0cwoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhlcmN6 ZWcgPHpoZXJjemVnQGluZi51LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIEphdmFTY3JpcHRDb3JlL3d0 Zi9UaHJlYWRTcGVjaWZpYy5oIHwgICAyMCArKysrKysrKysrKysrLS0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZGE3NDQwLi45Mzg0MjQwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysr IGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDktMTYg IFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IHd0Zi9UaHJlYWRT cGVjaWZpYy5oIHVuZGVyIFF0IHRvIGZyZWUgdGhyZWFkIGxvY2FsIG9iamVjdHMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTI5NQorCisgICAgICAg IFRoaXMgaXMgYW4gaW1wb3J0YW50IGZpeCB3aGVuIEphdmFTY3JpcHQgd29ya2VycyBhcmUKKyAg ICAgICAgaW4gdXNlLCBzaW5jZSB1bmZyZWVkIFRocmVhZEdsb2JhbERhdGFzIGxlYWsgYSBiaWcg YW1vdW50CisgICAgICAgIG9mIG1lbW9yeSAoNTAtMTAwayBlYWNoKS4KKworICAgICAgICAqIHd0 Zi9UaHJlYWRTcGVjaWZpYy5oOgorICAgICAgICAoV1RGOjpUaHJlYWRTcGVjaWZpYzo6RGF0YTo6 fkRhdGEpOgorICAgICAgICAoV1RGOjo6On5UaHJlYWRTcGVjaWZpYyk6CisgICAgICAgIChXVEY6 Ojo6c2V0KToKKyAgICAgICAgKFdURjo6OjpkZXN0cm95KToKKwogMjAwOS0wOS0wOCAgSm9obiBB YmQtRWwtTWFsZWsgIDxqYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERp bWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRTcGVj aWZpYy5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZFNwZWNpZmljLmgKaW5kZXggNGQ1ZDJm Ny4uYjZmNWZkMyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZFNwZWNpZmlj LmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZFNwZWNpZmljLmgKQEAgLTc5LDEwICs3 OSwxMyBAQCBwcml2YXRlOgogI2lmIFVTRShQVEhSRUFEUykgfHwgUExBVEZPUk0oUVQpIHx8IFBM QVRGT1JNKFdJTl9PUykKICAgICBzdHJ1Y3QgRGF0YSA6IE5vbmNvcHlhYmxlIHsKICAgICAgICAg RGF0YShUKiB2YWx1ZSwgVGhyZWFkU3BlY2lmaWM8VD4qIG93bmVyKSA6IHZhbHVlKHZhbHVlKSwg b3duZXIob3duZXIpIHt9CisjaWYgUExBVEZPUk0oUVQpCisgICAgICAgIH5EYXRhKCkgeyBvd25l ci0+ZGVzdHJveSh0aGlzKTsgfQorI2VuZGlmCiAKICAgICAgICAgVCogdmFsdWU7CiAgICAgICAg IFRocmVhZFNwZWNpZmljPFQ+KiBvd25lcjsKLSNpZiAhVVNFKFBUSFJFQURTKQorI2lmICFVU0Uo UFRIUkVBRFMpICYmICFQTEFURk9STShRVCkKICAgICAgICAgdm9pZCAoKmRlc3RydWN0b3IpKHZv aWQqKTsKICNlbmRpZgogICAgIH07CkBAIC0xMzYsOSArMTM5LDcgQEAgaW5saW5lIFRocmVhZFNw ZWNpZmljPFQ+OjpUaHJlYWRTcGVjaWZpYygpCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogaW5saW5l IFRocmVhZFNwZWNpZmljPFQ+Ojp+VGhyZWFkU3BlY2lmaWMoKQogewotICAgIERhdGEqIGRhdGEg PSBzdGF0aWNfY2FzdDxEYXRhKj4obV9rZXkubG9jYWxEYXRhKCkpOwotICAgIGlmIChkYXRhKQot ICAgICAgICBkYXRhLT5kZXN0cnVjdG9yKGRhdGEpOworICAgIC8vIERvZXMgbm90IGludm9rZSBk ZXN0cnVjdG9yIGZ1bmN0aW9ucy4gUVRocmVhZFN0b3JhZ2Ugd2lsbCBkbyBpdAogfQogCiB0ZW1w bGF0ZTx0eXBlbmFtZSBUPgpAQCAtMTUzLDcgKzE1NCw2IEBAIGlubGluZSB2b2lkIFRocmVhZFNw ZWNpZmljPFQ+OjpzZXQoVCogcHRyKQogewogICAgIEFTU0VSVCghZ2V0KCkpOwogICAgIERhdGEq IGRhdGEgPSBuZXcgRGF0YShwdHIsIHRoaXMpOwotICAgIGRhdGEtPmRlc3RydWN0b3IgPSAmVGhy ZWFkU3BlY2lmaWM8VD46OmRlc3Ryb3k7CiAgICAgbV9rZXkuc2V0TG9jYWxEYXRhKGRhdGEpOwog fQogCkBAIC0yMTgsMjEgKzIxOCwyNyBAQCBpbmxpbmUgdm9pZCBUaHJlYWRTcGVjaWZpYzxUPjo6 ZGVzdHJveSh2b2lkKiBwdHIpCiAgICAgLy8gU29tZSBwdGhyZWFkcyBpbXBsZW1lbnRhdGlvbnMg emVybyBvdXQgdGhlIHBvaW50ZXIgYmVmb3JlIGNhbGxpbmcgZGVzdHJveSgpLCBzbyB3ZSB0ZW1w b3JhcmlseSByZXNldCBpdC4KICAgICBwdGhyZWFkX3NldHNwZWNpZmljKGRhdGEtPm93bmVyLT5t X2tleSwgcHRyKTsKICNlbmRpZgotICAgIAorI2lmIFBMQVRGT1JNKFFUKQorICAgIC8vIFNlZSBj b21tZW50IGFzIGFib3ZlCisgICAgZGF0YS0+b3duZXItPm1fa2V5LnNldExvY2FsRGF0YShkYXRh KTsKKyNlbmRpZgorCiAgICAgZGF0YS0+dmFsdWUtPn5UKCk7CiAgICAgZmFzdEZyZWUoZGF0YS0+ dmFsdWUpOwogCiAjaWYgVVNFKFBUSFJFQURTKQogICAgIHB0aHJlYWRfc2V0c3BlY2lmaWMoZGF0 YS0+b3duZXItPm1fa2V5LCAwKTsKICNlbGlmIFBMQVRGT1JNKFFUKQotICAgIGRhdGEtPm93bmVy LT5tX2tleS5zZXRMb2NhbERhdGEoMCk7CisgICAgLy8gRG8gbm90aGluZyBoZXJlCiAjZWxpZiBQ TEFURk9STShXSU5fT1MpCiAgICAgVGxzU2V0VmFsdWUodGxzS2V5cygpW2RhdGEtPm93bmVyLT5t X2luZGV4XSwgMCk7CiAjZWxzZQogI2Vycm9yIFRocmVhZFNwZWNpZmljIGlzIG5vdCBpbXBsZW1l bnRlZCBmb3IgdGhpcyBwbGF0Zm9ybS4KICNlbmRpZgogCisjaWYgIVBMQVRGT1JNKFFUKQogICAg IGRlbGV0ZSBkYXRhOworI2VuZGlmCiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+Ci0tIAoxLjYu MC40Cgo= 39642 2009-09-16 05:48:03 -0700 2009-09-16 06:03:11 -0700 More changelog text 0001-Free-thread-local-objects.patch text/plain 3952 zherczeg RnJvbSA0MmZhMzc4NTcyMWNhOGU0ZDE5M2EyZjAwZDdjZWZlYjM4NzUzZTkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBXZWQsIDE2IFNlcCAyMDA5IDE0OjQ1OjQwICswMjAwClN1YmplY3Q6IFtQQVRD SF0gRnJlZSB0aHJlYWQgbG9jYWwgb2JqZWN0cwoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhlcmN6 ZWcgPHpoZXJjemVnQGluZi51LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cgICAgICAgICAgICB8ICAgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwogSmF2YVNjcmlw dENvcmUvd3RmL1RocmVhZFNwZWNpZmljLmggfCAgIDIwICsrKysrKysrKysrKystLS0tLS0tCiAy IGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CmluZGV4IDVkYTc0NDAuLmQzNTI2ZjUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAw OS0wOS0xNiAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0BpbmYudS1zemVnZWQuaHU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggd3Rm L1RocmVhZFNwZWNpZmljLmggdW5kZXIgUXQgdG8gZnJlZSB0aHJlYWQgbG9jYWwgb2JqZWN0cy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5Mjk1CisK KyAgICAgICAgVGhpcyBpcyBhbiBpbXBvcnRhbnQgZml4IHdoZW4gSmF2YVNjcmlwdCB3b3JrZXJz IGFyZSBpbiB1c2UsIHNpbmNlCisgICAgICAgIHVuZnJlZWQgVGhyZWFkR2xvYmFsRGF0YXMgbGVh ayBhIGJpZyBhbW91bnQgb2YgbWVtb3J5ICg1MC0xMDBrIGVhY2gpLgorICAgICAgICBRVGhyZWFk U3RvcmFnZSBjYWxscyB0aGUgZGVzdHJ1Y3RvciBvZiBhIGdpdmVuIG9iamVjdCwgd2hpY2ggaXMg dGhlCisgICAgICAgIFRocmVhZFNwZWNpZmljOjpEYXRhLiBVbmxpa2UgcHRocmVhZCwgUXQgaXMg b2JqZWN0IG9yaWVudGVkLCBhbmQgZG9lcworICAgICAgICBub3Qgc3VwcG9ydCB0aGUgY2FsbGlu ZyBvZiBhIHN0YXRpYyB1dGlsaXR5IGZ1bmN0aW9uIHdoZW4gdGhlIHRocmVhZAorICAgICAgICBp cyBhYm91dCB0byBjbG9zZS4gSW4gdGhpcyBwYXRjaCB3ZSBjYWxsIHRoZSBUaHJlYWRTcGVjaWZp Yzo6ZGVzdHJveSgpCisgICAgICAgIHV0aWxpdHkgZnVuY3Rpb24gZnJvbSB0aGUgZGVzdHJ1Y3Rv ciBvZiBUaHJlYWRTcGVjaWZpYzo6RGF0YS4gTW9yZW92ZXIsCisgICAgICAgIHNpbmNlIFF0IHJl c2V0cyBhbGwgdGhyZWFkIGxvY2FsIHZhbHVlcyB0byAwIGJlZm9yZSB0aGUgY2FsbGluZyBvZiB0 aGUKKyAgICAgICAgYXBwcm9wcmlhdGUgZGVzdHJ1Y3RvcnMsIHdlIHNldCBiYWNrIHRoZSBwb2lu dGVyIHRvIGl0cyBvcmlnaW5hbCB2YWx1ZS4KKyAgICAgICAgVGhpcyBpcyBuZWNlc3NhcnkgYmVj YXVzZSB0aGUgZ2V0KCkgbWV0aG9kIG9mIHRoZSBUaHJlYWRTcGVjaWZpYworICAgICAgICBvYmpl Y3QgbWF5IGJlIGNhbGxlZCBkdXJpbmcgdGhlIGV4dWN0aW9uIG9mIHRoZSBkZXN0cnVjdG9yLgor CisgICAgICAgICogd3RmL1RocmVhZFNwZWNpZmljLmg6CisgICAgICAgIChXVEY6OlRocmVhZFNw ZWNpZmljOjpEYXRhOjp+RGF0YSk6CisgICAgICAgIChXVEY6Ojo6flRocmVhZFNwZWNpZmljKToK KyAgICAgICAgKFdURjo6OjpzZXQpOgorICAgICAgICAoV1RGOjo6OmRlc3Ryb3kpOgorCiAyMDA5 LTA5LTA4ICBKb2huIEFiZC1FbC1NYWxlayAgPGphbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUv d3RmL1RocmVhZFNwZWNpZmljLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkU3BlY2lmaWMu aAppbmRleCA0ZDVkMmY3Li5iNmY1ZmQzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYv VGhyZWFkU3BlY2lmaWMuaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkU3BlY2lmaWMu aApAQCAtNzksMTAgKzc5LDEzIEBAIHByaXZhdGU6CiAjaWYgVVNFKFBUSFJFQURTKSB8fCBQTEFU Rk9STShRVCkgfHwgUExBVEZPUk0oV0lOX09TKQogICAgIHN0cnVjdCBEYXRhIDogTm9uY29weWFi bGUgewogICAgICAgICBEYXRhKFQqIHZhbHVlLCBUaHJlYWRTcGVjaWZpYzxUPiogb3duZXIpIDog dmFsdWUodmFsdWUpLCBvd25lcihvd25lcikge30KKyNpZiBQTEFURk9STShRVCkKKyAgICAgICAg fkRhdGEoKSB7IG93bmVyLT5kZXN0cm95KHRoaXMpOyB9CisjZW5kaWYKIAogICAgICAgICBUKiB2 YWx1ZTsKICAgICAgICAgVGhyZWFkU3BlY2lmaWM8VD4qIG93bmVyOwotI2lmICFVU0UoUFRIUkVB RFMpCisjaWYgIVVTRShQVEhSRUFEUykgJiYgIVBMQVRGT1JNKFFUKQogICAgICAgICB2b2lkICgq ZGVzdHJ1Y3Rvcikodm9pZCopOwogI2VuZGlmCiAgICAgfTsKQEAgLTEzNiw5ICsxMzksNyBAQCBp bmxpbmUgVGhyZWFkU3BlY2lmaWM8VD46OlRocmVhZFNwZWNpZmljKCkKIHRlbXBsYXRlPHR5cGVu YW1lIFQ+CiBpbmxpbmUgVGhyZWFkU3BlY2lmaWM8VD46On5UaHJlYWRTcGVjaWZpYygpCiB7Ci0g ICAgRGF0YSogZGF0YSA9IHN0YXRpY19jYXN0PERhdGEqPihtX2tleS5sb2NhbERhdGEoKSk7Ci0g ICAgaWYgKGRhdGEpCi0gICAgICAgIGRhdGEtPmRlc3RydWN0b3IoZGF0YSk7CisgICAgLy8gRG9l cyBub3QgaW52b2tlIGRlc3RydWN0b3IgZnVuY3Rpb25zLiBRVGhyZWFkU3RvcmFnZSB3aWxsIGRv IGl0CiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+CkBAIC0xNTMsNyArMTU0LDYgQEAgaW5saW5l IHZvaWQgVGhyZWFkU3BlY2lmaWM8VD46OnNldChUKiBwdHIpCiB7CiAgICAgQVNTRVJUKCFnZXQo KSk7CiAgICAgRGF0YSogZGF0YSA9IG5ldyBEYXRhKHB0ciwgdGhpcyk7Ci0gICAgZGF0YS0+ZGVz dHJ1Y3RvciA9ICZUaHJlYWRTcGVjaWZpYzxUPjo6ZGVzdHJveTsKICAgICBtX2tleS5zZXRMb2Nh bERhdGEoZGF0YSk7CiB9CiAKQEAgLTIxOCwyMSArMjE4LDI3IEBAIGlubGluZSB2b2lkIFRocmVh ZFNwZWNpZmljPFQ+OjpkZXN0cm95KHZvaWQqIHB0cikKICAgICAvLyBTb21lIHB0aHJlYWRzIGlt cGxlbWVudGF0aW9ucyB6ZXJvIG91dCB0aGUgcG9pbnRlciBiZWZvcmUgY2FsbGluZyBkZXN0cm95 KCksIHNvIHdlIHRlbXBvcmFyaWx5IHJlc2V0IGl0LgogICAgIHB0aHJlYWRfc2V0c3BlY2lmaWMo ZGF0YS0+b3duZXItPm1fa2V5LCBwdHIpOwogI2VuZGlmCi0gICAgCisjaWYgUExBVEZPUk0oUVQp CisgICAgLy8gU2VlIGNvbW1lbnQgYXMgYWJvdmUKKyAgICBkYXRhLT5vd25lci0+bV9rZXkuc2V0 TG9jYWxEYXRhKGRhdGEpOworI2VuZGlmCisKICAgICBkYXRhLT52YWx1ZS0+flQoKTsKICAgICBm YXN0RnJlZShkYXRhLT52YWx1ZSk7CiAKICNpZiBVU0UoUFRIUkVBRFMpCiAgICAgcHRocmVhZF9z ZXRzcGVjaWZpYyhkYXRhLT5vd25lci0+bV9rZXksIDApOwogI2VsaWYgUExBVEZPUk0oUVQpCi0g ICAgZGF0YS0+b3duZXItPm1fa2V5LnNldExvY2FsRGF0YSgwKTsKKyAgICAvLyBEbyBub3RoaW5n IGhlcmUKICNlbGlmIFBMQVRGT1JNKFdJTl9PUykKICAgICBUbHNTZXRWYWx1ZSh0bHNLZXlzKClb ZGF0YS0+b3duZXItPm1faW5kZXhdLCAwKTsKICNlbHNlCiAjZXJyb3IgVGhyZWFkU3BlY2lmaWMg aXMgbm90IGltcGxlbWVudGVkIGZvciB0aGlzIHBsYXRmb3JtLgogI2VuZGlmCiAKKyNpZiAhUExB VEZPUk0oUVQpCiAgICAgZGVsZXRlIGRhdGE7CisjZW5kaWYKIH0KIAogdGVtcGxhdGU8dHlwZW5h bWUgVD4KLS0gCjEuNi4wLjQKCg==