29280 2009-09-15 14:41:17 -0700 On Windows7 add missing Windows 6.1 to the user agent 2009-09-16 16:14:15 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows 7 RESOLVED FIXED Qt P2 Normal --- 0 ben webkit-unassigned commit-queue oldest_to_newest 147383 0 39615 ben 2009-09-15 14:41:17 -0700 Created attachment 39615 fix currently the windows version is "" on Windows7 because that case is not handled. This should probably go in 4.5.3 also. 147438 1 39615 eric 2009-09-15 18:05:15 -0700 Comment on attachment 39615 fix LGTM. What's with the strange ChangeLog diff? 147441 2 ben 2009-09-15 18:16:42 -0700 The changelog is the same one I always submit (using the prepare-changelog script), should it look different? 147648 3 39615 eric 2009-09-16 15:38:34 -0700 Comment on attachment 39615 fix Filed bug 29317. Did you edit your patch file by hand? If so then please close bug 29317 as invalid. I guess we'll add this to the commit-queue and see if it rejects your diff. 147654 4 39615 commit-queue 2009-09-16 15:53:50 -0700 Comment on attachment 39615 fix Rejecting patch 39615 from commit-queue. ('WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1') Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11265 test cases. media/video-source-error.html -> timed out Sampling process 50978 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 50978 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 9110 tests run. 526.85s total testing time 9109 test cases (99%) succeeded 1 test case (<1%) timed out 5 test cases (<1%) had stderr output 147655 5 39615 eric 2009-09-16 15:59:02 -0700 Comment on attachment 39615 fix You were bit by bug 28845. Adding back to the queue. 147662 6 39615 commit-queue 2009-09-16 16:14:12 -0700 Comment on attachment 39615 fix Clearing flags on attachment: 39615 Committed r48444: <http://trac.webkit.org/changeset/48444> 147663 7 commit-queue 2009-09-16 16:14:15 -0700 All reviewed patches have been landed. Closing bug. 39615 2009-09-15 14:41:17 -0700 2009-09-16 16:14:12 -0700 fix windows7.patch text/plain 1554 ben RnJvbSBlYjZhMWM5ZGI2MjUyZDMyNWM1ZDczZDJkYTFhMjQ3Mzk2MWViMmRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxiZW5qYW1pbi5tZXllckB0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMTUgU2VwIDIwMDkgMTc6MzY6NTMgLTA0MDAKU3ViamVj dDogW1BBVENIXSAyMDA5LTA5LTE1ICBCZW5qYW1pbiBDIE1leWVyICA8YmVuamFtaW4ubWV5ZXJA dG9yY2htb2JpbGUuY29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAg ICAgICAgRGV0ZWN0IGFuZCBhZGQgV2luZG93czcgcHJvcGVybHkgdG8gdGhlIHVzZXIgYWdlbnQu CgogICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKICAgICAgICAoUVdlYlBhZ2U6OnVzZXJBZ2Vu dEZvclVybCk6Ci0tLQogV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAgfCAgICAzICsrKwogV2Vi S2l0L3F0L0NoYW5nZUxvZyAgICAgICAgfCAgICA5ICsrKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk LCAxMiBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9x dC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKaW5kZXggMjIy ODc4YS4uYzcwZDk0MSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysr IGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTI5MDksNiArMjkwOSw5IEBAIFFTdHJp bmcgUVdlYlBhZ2U6OnVzZXJBZ2VudEZvclVybChjb25zdCBRVXJsJiB1cmwpIGNvbnN0CiAgICAg ICAgIGNhc2UgUVN5c0luZm86OldWX1ZJU1RBOgogICAgICAgICAgICAgdmVyID0gIldpbmRvd3Mg TlQgNi4wIjsKICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFFTeXNJbmZvOjpXVl9X SU5ET1dTNzoKKyAgICAgICAgICAgIHZlciA9ICJXaW5kb3dzIE5UIDYuMSI7CisgICAgICAgICAg ICBicmVhazsKICAgICAgICAgY2FzZSBRU3lzSW5mbzo6V1ZfQ0U6CiAgICAgICAgICAgICB2ZXIg PSAiV2luZG93cyBDRSI7CiAgICAgICAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL1dlYktpdC9x dC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDk0YTVhYTIuLmViYjVhNDYg MTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTA5LTE1ICBCZW5qYW1pbiBDIE1leWVyICA8YmVuamFt aW4ubWV5ZXJAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERldGVjdCBhbmQgYWRkIFdpbmRvd3M3IHByb3Blcmx5IHRvIHRo ZSB1c2VyIGFnZW50LgorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFX ZWJQYWdlOjp1c2VyQWdlbnRGb3JVcmwpOgorCiAyMDA5LTA5LTE0ICBKYWt1YiBXaWVjem9yZWsg IDxmYXcyMTdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5u LgotLSAKMS42LjAuNAoK