29259 2009-09-14 15:20:46 -0700 Local variables 'k' and 'y' in s2b() in dtoa.cpp are computed but not used 2010-08-26 01:55:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P3 Trivial --- 0 wtc webkit-unassigned mjs xan.lopez oldest_to_newest 147210 0 wtc 2009-09-14 15:20:46 -0700 In WebKit/JavaScriptCore/wtf/dtoa.cpp (r48248) on the trunk, we have: static void s2b(BigInt& b, const char* s, int nd0, int nd, uint32_t y9) { int k; int32_t y; int32_t x = (nd + 8) / 9; for (k = 0, y = 1; x > y; y <<= 1, k++) { } ... The local variables 'k' and 'y' are not used after the for loop, so the variables 'k' and 'y' and the for loop can be deleted. This is a cleanup of r43457. Also, the macro Kmax is defined but not used: #define Kmax 15 That definition can be deleted. 147212 1 wtc 2009-09-14 15:28:52 -0700 Re: Kmax When dtoa.cpp was moved to WebKit/JavaScriptCore/wtf in r38117, Kmax was already defined but not used. I didn't look further back in the history of dtoa.cpp. 267690 2 65060 xan.lopez 2010-08-22 07:53:16 -0700 Created attachment 65060 dtoa.diff Wan-Teh is right... the 'x' variable can also be removed, since it's only used in the loop. 269757 3 65060 tkent 2010-08-26 00:32:51 -0700 Comment on attachment 65060 dtoa.diff Looks good. 269774 4 65060 xan.lopez 2010-08-26 01:55:14 -0700 Comment on attachment 65060 dtoa.diff Landed as r66089. 269776 5 xan.lopez 2010-08-26 01:55:25 -0700 Closing. 65060 2010-08-22 07:53:16 -0700 2010-08-26 01:55:14 -0700 dtoa.diff dtoa.diff text/plain 1969 xan.lopez RnJvbSBmYWExZGNjYjMxOGVmODQ1MDFhNmU4YTlkOTE2YjY5NjExZDBjMGQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBT dW4sIDIyIEF1ZyAyMDEwIDIzOjUxOjU3ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0wOC0y MiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBMb2NhbCB2YXJpYWJsZXMgJ2snIGFuZCAneScgaW4gczJi KCkgaW4gZHRvYS5jcHAgYXJlIGNvbXB1dGVkIGJ1dCBub3QgdXNlZAogICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTI1OQoKICAgICAgICBSZW1vdmUgdW51 c2VkIGNvZGUgaW4gZHRvYS5jcHAsIHNwb3R0ZWQgYnkgV2FuLVRlaCBDaGFuZy4KCiAgICAgICAg KiB3dGYvZHRvYS5jcHA6CiAgICAgICAgKFdURjo6czJiKToKLS0tCiBKYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cgICAgfCAgIDEyICsrKysrKysrKysrKwogSmF2YVNjcmlwdENvcmUvd3RmL2R0b2Eu Y3BwIHwgICAgNyAtLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM3OGY0NTAuLjlkMDk1ZmUgMTAwNjQ0Ci0tLSBh L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOC0yMiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG9j YWwgdmFyaWFibGVzICdrJyBhbmQgJ3knIGluIHMyYigpIGluIGR0b2EuY3BwIGFyZSBjb21wdXRl ZCBidXQgbm90IHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI5MjU5CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBjb2RlIGluIGR0b2EuY3BwLCBz cG90dGVkIGJ5IFdhbi1UZWggQ2hhbmcuCisKKyAgICAgICAgKiB3dGYvZHRvYS5jcHA6CisgICAg ICAgIChXVEY6OnMyYik6CisKIDIwMTAtMDgtMTkgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmts aW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9kdG9hLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0 Zi9kdG9hLmNwcAppbmRleCBmN2UxOWJmLi4zOGQxODJkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0 Q29yZS93dGYvZHRvYS5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL2R0b2EuY3BwCkBAIC0y NzEsOCArMjcxLDYgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgdWludDMyX3QqIHN0b3JlSW5jKHVp bnQzMl90KiBwLCB1aW50MTZfdCBoaWdoLCB1aW50MTZfdCBsb3cKICNlbmRpZgogI2VuZGlmCiAK LSNkZWZpbmUgS21heCAxNQotCiBzdHJ1Y3QgQmlnSW50IHsKICAgICBCaWdJbnQoKSA6IHNpZ24o MCkgeyB9CiAgICAgaW50IHNpZ247CkBAIC0zNDksMTEgKzM0Nyw2IEBAIHN0YXRpYyB2b2lkIG11 bHRhZGQoQmlnSW50JiBiLCBpbnQgbSwgaW50IGEpICAgIC8qIG11bHRpcGx5IGJ5IG0gYW5kIGFk ZCBhICovCiAKIHN0YXRpYyB2b2lkIHMyYihCaWdJbnQmIGIsIGNvbnN0IGNoYXIqIHMsIGludCBu ZDAsIGludCBuZCwgdWludDMyX3QgeTkpCiB7Ci0gICAgaW50IGs7Ci0gICAgaW50MzJfdCB5Owot ICAgIGludDMyX3QgeCA9IChuZCArIDgpIC8gOTsKLQotICAgIGZvciAoayA9IDAsIHkgPSAxOyB4 ID4geTsgeSA8PD0gMSwgaysrKSB7IH0KICNpZmRlZiBQYWNrXzMyCiAgICAgYi5zaWduID0gMDsK ICAgICBiLnJlc2l6ZSgxKTsKLS0gCjEuNy4yLjEKCg==