<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>29251</bug_id>
          
          <creation_ts>2009-09-14 12:07:26 -0700</creation_ts>
          <short_desc>Implement distinguishing of un/conditional breakpoints in the Breakpoints sidebar pane</short_desc>
          <delta_ts>2026-01-12 09:08:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexander Pavlov (apavlov)">apavlov</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bburg</cc>
    
    <cc>chrisjshull</cc>
    
    <cc>graouts</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>mattbaker</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>147131</commentid>
    <comment_count>0</comment_count>
    <who name="Alexander Pavlov (apavlov)">apavlov</who>
    <bug_when>2009-09-14 12:07:26 -0700</bug_when>
    <thetext>Currently there is no way to tell if a breakpoint in the sidebar has a condition associated with it.

The original conditional breakpoints UI issue is https://bugs.webkit.org/show_bug.cgi?id=28908</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967079</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-01-12 16:13:54 -0800</bug_when>
    <thetext>&lt;rdar://problem/15801499&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1051289</commentid>
    <comment_count>2</comment_count>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-11-28 19:48:30 -0800</bug_when>
    <thetext>There is *sort of* a visual difference now when a breakpoint has any actions, but not for a conditional breakpoint. This would be an easy fix-Tim, any ideas for the icon?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1276289</commentid>
    <comment_count>3</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2017-02-13 12:14:04 -0800</bug_when>
    <thetext>Maybe we can add a ? on top of the wedge.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1276334</commentid>
    <comment_count>4</comment_count>
    <who name="Matt Baker">mattbaker</who>
    <bug_when>2017-02-13 13:15:58 -0800</bug_when>
    <thetext>We don&apos;t style breakpoints with actions differently from default breakpoints, unless they are set to auto-continue (which breakpoints having actions typically are).

What Other Do:
- Chrome: conditional breakpoints are orange/yellow
- Edge: overlays a &quot;+&quot; icon in the breakpoint
- FireFox: look identical to regular breakpoints

Fun Fact:
Edge breakpoints are styled after Visual Studio, which also styles auto-continue breakpoints as a diamond rather than a circle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1276337</commentid>
    <comment_count>5</comment_count>
    <who name="Matt Baker">mattbaker</who>
    <bug_when>2017-02-13 13:30:51 -0800</bug_when>
    <thetext>Three methods of distinguishing breakpoints come to mind:

1. Shape
2. Color
3. Decorations

We only use method 2: unresolved breakpoints are gray, and disabled breakpoints are slightly transparent. There are accessibility concerns with method 2, but for non-critical UI hints color is a simple solution.

Method 3 is interesting, and doesn&apos;t suffer from the same issues as method 2. However, since our breakpoints overlap the line number some accommodations would need to be made for large files.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>