29247 2009-09-14 11:08:08 -0700 document.caretRangeFromPoint() should check whether the point is within frameview's boundary before taking scroll offset into consideration 2009-09-14 14:53:54 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED DUPLICATE 29245 P2 Normal --- 0 xji webkit-unassigned jshin mjs sam xji oldest_to_newest 147114 0 39555 xji 2009-09-14 11:08:08 -0700 Created attachment 39555 caretRangeFromPointWithScroll.html document.caretRangeFromPoint() might return a null range which should not. Please see attached file caretRangeFromPointWithScroll.html for detailed explanation. The problem probably is at: IntPoint point = roundedIntPoint(FloatPoint(x * zoomFactor, y * zoomFactor)) + view()->scrollOffset(); if (!frameView->boundsRect().contains(point)) return 0; Which should be: IntPoint point = roundedIntPoint(FloatPoint(x * zoomFactor, y * zoomFactor)); if (!frameView->boundsRect().contains(point)) return 0; point += view()->scrollOffset(); // Then, hit test. 147188 1 sam 2009-09-14 14:28:06 -0700 Is this a dup of bug 29245? 147196 2 xji 2009-09-14 14:53:54 -0700 *** This bug has been marked as a duplicate of bug 29245 *** 39555 2009-09-14 11:08:08 -0700 2009-09-14 11:08:08 -0700 caretRangeFromPointWithScroll.html caretRangeFromPointWithScroll.html text/html 1537 xji PEhUTUw+CjxIRUFEPgo8VElUTEU+ZG9jdW1lbnQuY2FyZXRSYW5nZUZyb21Qb2ludCgpIE1ldGhv ZDwvVElUTEU+CjxTQ1JJUFQgTEFOR1VBR0U9IkphdmFTY3JpcHQiPgpmdW5jdGlvbiBzaG93RWxl bVVuZGVybmVhdGhXaXRob3V0U2Nyb2xsKCkgewogICAgZG9jdW1lbnQuYWxsLm15U3Bhbi5pbm5l clRleHQgPSAiIjsKICAgIHZhciByYW5nZSA9IGRvY3VtZW50LmNhcmV0UmFuZ2VGcm9tUG9pbnQo ZXZlbnQuY2xpZW50WCwgZXZlbnQuY2xpZW50WSk7CiAgICB2YXIgb2Zmc2V0ID0gMDsKICAgIGlm IChyYW5nZSkKICAgICAgb2Zmc2V0ID0gcmFuZ2Uuc3RhcnRPZmZzZXQ7CiAgICBlbHNlIHsKICAg ICAgYWxlcnQoInJhbmdlIGlzIG51bGwiKTsKICAgICAgcmV0dXJuOwogICAgfQoKICAgIHZhciBj aGlsZCA9IGV2ZW50LnRhcmdldC5maXJzdENoaWxkOwogICAgcmFuZ2UgPSBjaGlsZC5vd25lckRv Y3VtZW50LmNyZWF0ZVJhbmdlKCk7CiAgICByYW5nZS5zZWxlY3ROb2RlKGNoaWxkKTsKICAgIHZh ciBzdHIgPSByYW5nZS50b1N0cmluZygpOwoKICAgIGRvY3VtZW50LmFsbC5teVNwYW4uaW5uZXJU ZXh0ID0gIng6ICIgKyBldmVudC5jbGllbnRYICsgIjt5OiAiICsgZXZlbnQuY2xpZW50WSArICI7 IHN0aXJuZzogIiArIHJhbmdlLnRvU3RyaW5nKCkgKyAiOyAgIG9mZnNldCA9ICIgKyBvZmZzZXQ7 Cn0KZG9jdW1lbnQub25jbGljayA9IHNob3dFbGVtVW5kZXJuZWF0aFdpdGhvdXRTY3JvbGw7Cjwv U0NSSVBUPgo8L0hFQUQ+CjxCT0RZPgo8SDEgSUQ9ImhlYWRlciI+ZG9jdW1lbnQuY2FyZXRSYW5n ZUZyb21Qb2ludCgpIE1ldGhvZDwvSDE+CjxIUj4KPFAgc3R5bGU9IndoaXRlLXNwYWNlOm5vd3Jh cCI+VGhpcyBpcyB0byB0ZXN0IGRvY3VtZW50LmNhcmV0UmFuZ2VGcm9tUG9pbnQoKSBpbiBhIHNj cm9sbGVkIHBhZ2UuIEkgdGhpbmsgdGhlIG9mZnNldCBpbiB0aGUgcmV0dXJuZWQgcmFuZ2Ugc2hv dWxkIGJlIHRoZSBjaGFyYWN0ZXIvY2FyZXQgb2Zmc2V0IGluIHRoZSBlbGVtZW50LCBub3QgcmVs YXRpdmUgdG8gdGhlIHZpZXdwb2ludC4gCjxQPlBsZWFzZSByZXNpemUgdGhlIHdpbmRvdyB0byBi ZSA8c3BhbiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjpyZWQiPnZlcnkgbmFycm93PC9zcGFuPiBo b3Jpem9udGFsbHkuIFRoZW4sIHNjcm9sbCB0aGUgcGFnZSB0byB0aGUgdmVyeSByaWdodC4gQ2xp Y2sgYW55d2hlcmUgaW4gdGhlIGxhc3Qgd29yZCAidmlld3BvaW50IiBpbiBhYm92ZSBzZW50ZW5j ZS4gWW91IHdpbGwgc2VlICJyYW5nZSBpcyBudWxsIiBhbGVydC4gIFdoaWNoIGlzIGNhdXNlZCBi eSB0aGUgZm9sbG93aW5nIGNoZWNrIGluIERvY3VtZW50LmNhcmV0UmFuZ2VGcm9tUG9pbnQoKQo8 cHJlPgogICAgaWYgKCFmcmFtZVZpZXctPmJvdW5kc1JlY3QoKS5jb250YWlucyhwb2ludCkpCiAg ICAgICAgcmV0dXJuIDA7CjwvcHJlPgo8QlI+PEJSPlJlc3VsdDogPFNQQU4gSUQ9Im15U3BhbiIg U1RZTEU9ImZvbnQtd2VpZ2h0OmJvbGQiPjwvU1BBTj4iLjwvUD4KPC9CT0RZPgo8L0hUTUw+Cg==