<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>29230</bug_id>
          
          <creation_ts>2009-09-12 20:49:29 -0700</creation_ts>
          <short_desc>Need to ensure that incorrect parameters and types are never sent to OpenGL from WebGL</short_desc>
          <delta_ts>2020-07-31 15:11:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>38145</dependson>
    
    <dependson>40175</dependson>
    
    <dependson>41095</dependson>
    
    <dependson>41574</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Marrin">cmarrin</reporter>
          <assigned_to name="Chris Marrin">cmarrin</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>dino</cc>
    
    <cc>ilmari.heikkinen</cc>
    
    <cc>jdarpinian</cc>
    
    <cc>kbr</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>zmo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>146975</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Marrin">cmarrin</who>
    <bug_when>2009-09-12 20:49:29 -0700</bug_when>
    <thetext>Passing badly typed uniform or vertex data to OpenGL can cause some drivers to crash. We need to do sufficient checks to prevent that from happening. For instance, passing a vertexAttribPointer as UNSIGNED_BYTE with 3 values when the value is actually FLOAT with 2 values will crash some hardware and not others. likewise, passing UNSIGNED_BYTE with 3 values to a vertexAttrib of type vec4 will crash some hardware.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>147036</commentid>
    <comment_count>1</comment_count>
    <who name="Ilmari Heikkinen">ilmari.heikkinen</who>
    <bug_when>2009-09-14 03:39:21 -0700</bug_when>
    <thetext>These tests written against the Firefox GL canvas might be helpful: http://github.com/kig/canvas3d-tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>246378</commentid>
    <comment_count>2</comment_count>
    <who name="Zhenyao Mo">zmo</who>
    <bug_when>2010-07-03 18:46:24 -0700</bug_when>
    <thetext>I think after all the dependency patches land, the only thing left unchecked is vertexArreibPointer()&apos;s &quot;type&quot;.  GL_FIXED is a valid enum for type in GLES2, but it&apos;s not supported in GL.  I think we should add in the spec that FIXED is not allowed in WebGL.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>247920</commentid>
    <comment_count>3</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2010-07-07 18:21:00 -0700</bug_when>
    <thetext>The WebGL spec has been updated to explicitly state that the GL_FIXED data type is not supported.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966191</commentid>
    <comment_count>4</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-01-09 20:39:09 -0800</bug_when>
    <thetext>Dean - I think we can close this based on the specification change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676990</commentid>
    <comment_count>5</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-31 15:11:26 -0700</bug_when>
    <thetext>Closing this old bug. WebKit&apos;s ANGLE backend, which is a conformant ES 2.0 / 3.0 implementation, has conclusively fixed this.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>