29212 2009-09-11 16:38:54 -0700 bugzilla-tool rollout --complete-rollout should make a nicer bug comment 2010-01-06 14:25:42 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth bweinstein webkit.review.bot oldest_to_newest 146793 0 eric 2009-09-11 16:38:54 -0700 bugzilla-tool rollout --complete-rollout should make a nicer bug comment See: https://bugs.webkit.org/show_bug.cgi?id=26700#c22 Committed r48321: <http://trac.webkit.org/changeset/48321> It should probably mention that this is a rollout commit, and what revision it rolled out. 173650 1 eric 2009-12-19 23:52:03 -0800 Actually it's gotten worse. It's regressed to being the old-style comment: https://bugs.webkit.org/show_bug.cgi?id=32738#c13 I blame adam! 177746 2 eric 2010-01-06 13:54:25 -0800 *** Bug 30086 has been marked as a duplicate of this bug. *** 177747 3 eric 2010-01-06 13:55:21 -0800 I've improved the comment and also made reopen_bug much more robust (per bug 30086). 177748 4 45991 eric 2010-01-06 13:57:48 -0800 Created attachment 45991 Patch 177750 5 webkit.review.bot 2010-01-06 13:58:35 -0800 style-queue ran check-webkit-style on attachment 45991 without any errors. 177754 6 45991 abarth 2010-01-06 14:04:21 -0800 Comment on attachment 45991 Patch Death to FIXMES! 177768 7 45991 eric 2010-01-06 14:14:18 -0800 Comment on attachment 45991 Patch Clearing flags on attachment: 45991 Committed r52870: <http://trac.webkit.org/changeset/52870> 177769 8 eric 2010-01-06 14:14:25 -0800 All reviewed patches have been landed. Closing bug. 177775 9 eric 2010-01-06 14:25:42 -0800 Committed r52873: <http://trac.webkit.org/changeset/52873> 45991 2010-01-06 13:57:48 -0800 2010-01-06 14:14:18 -0800 Patch bug-29212-20100106135747.patch text/plain 3699 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5NjcxMTFjLi40MWJlMDQwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEt MDYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wgcm9sbG91dCAtLWNvbXBs ZXRlLXJvbGxvdXQgc2hvdWxkIG1ha2UgYSBuaWNlciBidWcgY29tbWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkyMTIKKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvYnVnemlsbGEucHk6CisgICAgICAgICAtIE1ha2UgcmVvcGVuX2J1ZyBy b2J1c3QgYWdhaW5zdCB0aGUgYnVnIGFscmVhZHkgYmVpbmcgb3Blbi4KKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2NvbW1hbmRzL2Rvd25sb2FkLnB5OgorICAgICAgICAgLSBSZW1vdmUgZGVh ZCBjb2RlIGZyb20gUm9sbG91dC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL2Nv bXBsZXRlcm9sbG91dC5weToKKyAgICAgICAgIC0gSW1wcm92ZSB0aGUgcm9sbG91dCBjb21tZW50 LgorCiAyMDEwLTAxLTA2ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAaW5mLnUtc3plZ2VkLmh1Pgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvYnVnemlsbGEucHkKaW5kZXggMmQ0M2ZmYS4uNzdlYjVlNSAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2J1Z3ppbGxhLnB5CkBAIC01NTksNiArNTU5LDEzIEBAIGNsYXNzIEJ1 Z3ppbGxhKG9iamVjdCk6CiAKICAgICAgICAgc2VsZi5icm93c2VyLm9wZW4oc2VsZi5idWdfdXJs X2Zvcl9idWdfaWQoYnVnX2lkKSkKICAgICAgICAgc2VsZi5icm93c2VyLnNlbGVjdF9mb3JtKG5h bWU9ImNoYW5nZWZvcm0iKQotICAgICAgICBzZWxmLmJyb3dzZXJbJ2J1Z19zdGF0dXMnXSA9IFsn UkVPUEVORUQnXQorICAgICAgICBidWdfc3RhdHVzID0gc2VsZi5icm93c2VyLmZpbmRfY29udHJv bCgiYnVnX3N0YXR1cyIsIHR5cGU9InNlbGVjdCIpCisgICAgICAgICMgVGhpcyBpcyBhIGhhY2sg YXJvdW5kIHRoZSBmYWN0IHRoYXQgQ2xpZW50Rm9ybS5MaXN0Q29udHJvbCBzZWVtcyB0byBoYXZl IG5vIHNpbXBsZXIgd2F5IHRvIGFzaworICAgICAgICAjIGlmIGEgY29udHJvbCBoYXMgYW4gaXRl bSBuYW1lZCAiUkVPUEVORUQiIHdpdGhvdXQgdXNpbmcgZXhjZXB0aW9ucyBmb3IgY29udHJvbCBm bG93LgorICAgICAgICBwb3NzaWJsZV9idWdfc3RhdHVzZXMgPSBtYXAobGFtYmRhIGl0ZW06IGl0 ZW0ubmFtZSwgYnVnX3N0YXR1cy5pdGVtcykKKyAgICAgICAgaWYgIlJFT1BFTkVEIiBpbiBwb3Nz aWJsZV9idWdfc3RhdHVzZXM6CisgICAgICAgICAgICBidWdfc3RhdHVzLnZhbHVlID0gWyJSRU9Q RU5FRCJdCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBsb2coIkRpZCBub3QgcmVvcGVuIGJ1 ZyAlcy4gIEl0IGFwcGVhcnMgdG8gYWxyZWFkeSBiZSBvcGVuIHdpdGggc3RhdHVzICVzLiIgJSAo YnVnX2lkLCBidWdfc3RhdHVzLnZhbHVlKSkKICAgICAgICAgc2VsZi5icm93c2VyWydjb21tZW50 J10gPSBjb21tZW50X3RleHQKICAgICAgICAgc2VsZi5icm93c2VyLnN1Ym1pdCgpCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL2Rvd25sb2FkLnB5IGIv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9kb3dubG9hZC5weQppbmRleCBk NzMyZjQ0Li44NmE2NDIwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1hbmRzL2Rvd25sb2FkLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbWFuZHMvZG93bmxvYWQucHkKQEAgLTI1NCwxNCArMjU0LDYgQEAgY2xhc3MgUm9sbG91dChB YnN0cmFjdFNlcXVlbmNlZENvbW1tYW5kKToKICAgICAgICAgb3JpZ2luYWxfZGlmZiA9IHRvb2wu c2NtKCkuZGlmZl9mb3JfcmV2aXNpb24ocmV2aXNpb24pCiAgICAgICAgIHJldHVybiBwYXJzZV9i dWdfaWQob3JpZ2luYWxfZGlmZikKIAotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgX3Jlb3Bl bl9idWdfYWZ0ZXJfcm9sbG91dCh0b29sLCBidWdfaWQsIGNvbW1lbnRfdGV4dCk6Ci0gICAgICAg IGlmIGJ1Z19pZDoKLSAgICAgICAgICAgIHRvb2wuYnVncy5yZW9wZW5fYnVnKGJ1Z19pZCwgY29t bWVudF90ZXh0KQotICAgICAgICBlbHNlOgotICAgICAgICAgICAgbG9nKGNvbW1lbnRfdGV4dCkK LSAgICAgICAgICAgIGxvZygiTm8gYnVncyB3ZXJlIHVwZGF0ZWQgb3IgcmUtb3BlbmVkIHRvIHJl ZmxlY3QgdGhpcyByb2xsb3V0LiIpCi0KICAgICBkZWYgZXhlY3V0ZShzZWxmLCBvcHRpb25zLCBh cmdzLCB0b29sKToKICAgICAgICAgcmV2aXNpb24gPSBhcmdzWzBdCiAgICAgICAgIHJlYXNvbiA9 IGFyZ3NbMV0KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3RlcHMv Y29tcGxldGVyb2xsb3V0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdGVwcy9j b21wbGV0ZXJvbGxvdXQucHkKaW5kZXggNWI4M2QxMy4uMzExYjlhOCAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdGVwcy9jb21wbGV0ZXJvbGxvdXQucHkKKysrIGIv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdGVwcy9jb21wbGV0ZXJvbGxvdXQucHkKQEAg LTU1LDkgKzU1LDExIEBAIGNsYXNzIENvbXBsZXRlUm9sbG91dChNZXRhU3RlcCk6CiAKICAgICAg ICAgTWV0YVN0ZXAucnVuKHNlbGYsIHN0YXRlKQogCisgICAgICAgIGNvbW1pdF9jb21tZW50ID0g YnVnX2NvbW1lbnRfZnJvbV9jb21taXRfdGV4dChzZWxmLl90b29sLnNjbSgpLCBzdGF0ZVsiY29t bWl0X3RleHQiXSkKKyAgICAgICAgY29tbWVudF90ZXh0ID0gIlJldmVydGVkIHIlcyBmb3IgcmVh c29uOlxuXG4lc1xuXG4lcyIgJSAoc3RhdGVbInJldmlzaW9uIl0sIHN0YXRlWyJyZWFzb24iXSwg Y29tbWl0X2NvbW1lbnQpCisKICAgICAgICAgaWYgbm90IGJ1Z19pZDoKLSAgICAgICAgICAgIGxv ZyhzdGF0ZVsiY29tbWl0X3RleHQiXSkKLSAgICAgICAgICAgIGxvZygiTm8gYnVncyB3ZXJlIHVw ZGF0ZWQgb3IgcmUtb3BlbmVkIHRvIHJlZmxlY3QgdGhpcyByb2xsb3V0LiIpCisgICAgICAgICAg ICBsb2coY29tbWVudF90ZXh0KQorICAgICAgICAgICAgbG9nKCJObyBidWdzIHdlcmUgdXBkYXRl ZC4iKQogICAgICAgICAgICAgcmV0dXJuCi0gICAgICAgICMgRklYTUU6IEknbSBub3Qgc3VyZSBz dGF0ZVsiY29tbWl0X3RleHQiXSBpcyBxdWl0ZSByaWdodCBoZXJlLgotICAgICAgICBzZWxmLl90 b29sLmJ1Z3MucmVvcGVuX2J1ZyhidWdfaWQsIHN0YXRlWyJjb21taXRfdGV4dCJdKQorICAgICAg ICBzZWxmLl90b29sLmJ1Z3MucmVvcGVuX2J1ZyhidWdfaWQsIGNvbW1lbnRfdGV4dCkK