29210 2009-09-11 14:48:11 -0700 Assertion failed in Node::isFocusable 2009-09-11 19:18:08 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=12875 P1 Major --- 1 arv arv commit-queue oldest_to_newest 146749 0 39478 arv 2009-09-11 14:48:11 -0700 Created attachment 39478 Test case If a link is inside a display:none div and it will not have a renderer and it has styleNeedsRecalc() returning true. This causes the assert to fail. In the URL above, and in the test case, focus the address field and press tab. This triggered the assert. 146771 1 39482 arv 2009-09-11 15:36:36 -0700 Created attachment 39482 Fixes an assert in Node::isFocusable which was causing crashes in certain cases. https://bugs.webkit.org/show_bug.cgi?id=29210 --- 6 files changed, 64 insertions(+), 1 deletions(-) 146799 2 39482 eric 2009-09-11 16:43:22 -0700 Comment on attachment 39482 Fixes an assert in Node::isFocusable which was causing crashes in certain cases. Looks sane to me. 146825 3 39482 commit-queue 2009-09-11 17:17:32 -0700 Comment on attachment 39482 Fixes an assert in Node::isFocusable which was causing crashes in certain cases. Rejecting patch 39482 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 146826 4 39482 eric 2009-09-11 17:18:39 -0700 Comment on attachment 39482 Fixes an assert in Node::isFocusable which was causing crashes in certain cases. bug 28316. I'm working on fixing this right now. 146870 5 39482 commit-queue 2009-09-11 19:18:04 -0700 Comment on attachment 39482 Fixes an assert in Node::isFocusable which was causing crashes in certain cases. Clearing flags on attachment: 39482 Committed r48327: <http://trac.webkit.org/changeset/48327> 146871 6 commit-queue 2009-09-11 19:18:08 -0700 All reviewed patches have been landed. Closing bug. 39478 2009-09-11 14:48:11 -0700 2009-09-11 14:48:11 -0700 Test case tmp.html text/html 352 arv PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHRpdGxlPjwvdGl0bGU+CjxzdHlsZT4KCjwv c3R5bGU+CjxzY3JpcHQ+Cgp3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKSB7CiAgdmFyIGRpdiA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwogIGRpdi5zdHlsZS5kaXNwbGF5ID0gJ25v bmUnOwoKICB2YXIgYSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2EnKTsKICBhLmhyZWYgPSAn aHR0cDovL3dlYmtpdC5vcmcnOwogIGRpdi5hcHBlbmRDaGlsZChhKTsKCiAgZG9jdW1lbnQuYm9k eS5hcHBlbmRDaGlsZChkaXYpOwp9OwoKCjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5PgoKPC9ib2R5 Pgo8L2h0bWw+Cg== 39482 2009-09-11 15:36:36 -0700 2009-09-11 19:18:04 -0700 Fixes an assert in Node::isFocusable which was causing crashes in certain cases. bug-29210-20090911153635.patch text/plain 3771 arv ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiYWZkYmEyLi45ZmI1MmEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDkt MTEgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBhbiBhc3NlcnQgaW4gTm9kZTo6 aXNGb2N1c2FibGUgd2hpY2ggd2FzIGNhdXNpbmcgY3Jhc2hlcyBpbiBjZXJ0YWluIGNhc2VzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkyMTAKKwor ICAgICAgICAqIGZhc3QvZXZlbnRzL3Jlc291cmNlcy90YWItaXMtZm9jdXNhYmxlLWFzc2VydC5q czoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy90YWItaXMtZm9jdXNhYmxlLWFzc2VydC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorCiAyMDA5LTA5LTExICBDYW1lcm9uIE1jQ29ybWFjayAgPGNhbUBtY2Mu aWQuYXU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZXNvdXJjZXMvdGFiLWlzLWZvY3VzYWJsZS1hc3NlcnQu anMgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZXNvdXJjZXMvdGFiLWlzLWZvY3VzYWJsZS1h c3NlcnQuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uM2ZhMzk0MwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Jlc291cmNlcy90YWItaXMt Zm9jdXNhYmxlLWFzc2VydC5qcwpAQCAtMCwwICsxLDE4IEBACitkZXNjcmlwdGlvbignTWFraW5n IHN1cmUgdGhhdCB0aGUgYXNzZXJ0IGluIE5vZGU6OmlzRm9jdXNhYmxlIGRvZXMgbm90IGZhaWwu ICcgKworICAgICAgICAgICAgJ2h0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yOTIxMCcpOworCit2YXIgZGl2ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7Citk aXYuc3R5bGUuZGlzcGxheSA9ICdub25lJzsKKwordmFyIGEgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCdhJyk7CithLmhyZWYgPSAnaHR0cDovL3dlYmtpdC5vcmcnOworZGl2LmFwcGVuZENoaWxk KGEpOworCitkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRpdik7CisKK2lmICh3aW5kb3cuZXZl bnRTZW5kZXIpCisgICAgZXZlbnRTZW5kZXIua2V5RG93bignXHQnKTsKKwordGVzdFBhc3NlZCgn Tm8gY3Jhc2gnKTsKKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90YWItaXMtZm9jdXNhYmxlLWFzc2VydC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90YWItaXMtZm9jdXNhYmxlLWFzc2VydC1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNGJjOTc0MAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RhYi1pcy1mb2N1c2Fi bGUtYXNzZXJ0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitNYWtpbmcgc3VyZSB0aGF0 IHRoZSBhc3NlcnQgaW4gTm9kZTo6aXNGb2N1c2FibGUgZG9lcyBub3QgZmFpbC4gaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5MjEwCisKK09uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFIi4KKworCitQQVNTIE5vIGNyYXNoCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0 cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvdGFiLWlzLWZvY3VzYWJsZS1hc3NlcnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L3RhYi1pcy1mb2N1c2FibGUtYXNzZXJ0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uZjZiZmM3YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZl bnRzL3RhYi1pcy1mb2N1c2FibGUtYXNzZXJ0Lmh0bWwKQEAgLTAsMCArMSwxMyBAQAorPCFET0NU WVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4K KzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5 bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYg aWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy90YWItaXMtZm9jdXNh YmxlLWFzc2VydC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ5NTcxMmIuLjM1MzUx NTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMTEgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlcyBhbiBhc3NlcnQgaW4gTm9kZTo6aXNGb2N1c2FibGUgd2hpY2ggd2FzIGNhdXNpbmcg Y3Jhc2hlcyBpbiBjZXJ0YWluIGNhc2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjkyMTAKKworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok5vZGU6OmlzRm9jdXNhYmxlKToKKwogMjAwOS0wOS0xMSAgQnJpYW4gV2Vp bnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGlt b3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9XZWJDb3Jl L2RvbS9Ob2RlLmNwcAppbmRleCA1YWY4OGFkLi44MWMxODY3IDEwMDY0NAotLS0gYS9XZWJDb3Jl L2RvbS9Ob2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtODQ0LDcgKzg0NCw5 IEBAIGJvb2wgTm9kZTo6aXNGb2N1c2FibGUoKSBjb25zdAogICAgIGlmIChyZW5kZXJlcigpKQog ICAgICAgICBBU1NFUlQoIXJlbmRlcmVyKCktPm5lZWRzTGF5b3V0KCkpOwogICAgIGVsc2UKLSAg ICAgICAgQVNTRVJUKCFuZWVkc1N0eWxlUmVjYWxjKCkpOworICAgICAgICAvLyBJZiB0aGUgbm9k ZSBpcyBpbiBhIGRpc3BsYXk6bm9uZSB0cmVlIGl0IG1pZ2h0IHNheSBpdCBuZWVkcyBzdHlsZSBy ZWNhbGMgYnV0CisgICAgICAgIC8vIHRoZSB3aG9sZSBkb2N1bWVudCBpcyBhdHVhbGx5IHVwIHRv IGRhdGUuCisgICAgICAgIEFTU0VSVCghZG9jdW1lbnQoKS0+Y2hpbGROZWVkc1N0eWxlUmVjYWxj KCkpOwogICAgIAogICAgIC8vIEZJWE1FOiBFdmVuIGlmIHdlIGFyZSBub3QgdmlzaWJsZSwgd2Ug bWlnaHQgaGF2ZSBhIGNoaWxkIHRoYXQgaXMgdmlzaWJsZS4KICAgICAvLyBIeWF0dCB3YW50cyB0 byBmaXggdGhhdCBzb21lIGRheSB3aXRoIGEgImhhcyB2aXNpYmxlIGNvbnRlbnQiIGZsYWcgb3Ig dGhlIGxpa2Uu