29199 2009-09-11 11:41:41 -0700 wx port: no way to query Frame::shouldClose 2009-09-13 18:21:30 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned kevino oldest_to_newest 146677 0 kevinwatters 2009-09-11 11:41:41 -0700 The wx port should expose Frame::shouldClose through its API to allow complex closing behavior in users of wxWebKit. 146681 1 39459 kevinwatters 2009-09-11 11:42:42 -0700 Created attachment 39459 exposes Frame::shouldClose in a wxWebView method 147011 2 kevino 2009-09-13 18:21:30 -0700 Landed in r48347, thanks! 39459 2009-09-11 11:42:42 -0700 2009-09-12 23:39:59 -0700 exposes Frame::shouldClose in a wxWebView method should_close.patch text/plain 2120 kevinwatters ZGlmZiAtLWdpdCBhL1dlYktpdC93eC9DaGFuZ2VMb2cgYi9XZWJLaXQvd3gvQ2hhbmdlTG9nCmlu ZGV4IDFiYWIwZmIuLjI4YjdhYzQgMTAwNjQ0Ci0tLSBhL1dlYktpdC93eC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3d4L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA5LTA5LTA5ICBLZXZp biBXYXR0ZXJzICA8a2V2aW53YXR0ZXJzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxvdyB0aGUgdXNlciB0byBxdWVyeSBGcmFt ZTo6c2hvdWxkQ2xvc2UgdmlhIHd4IEFQSS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE5OQorCisgICAgICAgICogV2ViRnJhbWUu Y3BwOgorICAgICAgICAod3hXZWJGcmFtZTo6U2hvdWxkQ2xvc2UpOgorICAgICAgICAqIFdlYkZy YW1lLmg6CisgICAgICAgICogV2ViVmlldy5jcHA6CisgICAgICAgICh3eFdlYlZpZXc6OlNob3Vs ZENsb3NlKToKKyAgICAgICAgKiBXZWJWaWV3Lmg6CisKIDIwMDktMDktMDMgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBlcmljQHdlYmtpdC5v cmcuCmRpZmYgLS1naXQgYS9XZWJLaXQvd3gvV2ViRnJhbWUuY3BwIGIvV2ViS2l0L3d4L1dlYkZy YW1lLmNwcAppbmRleCA4NzhhOWY0Li5mMjA1MTUyIDEwMDY0NAotLS0gYS9XZWJLaXQvd3gvV2Vi RnJhbWUuY3BwCisrKyBiL1dlYktpdC93eC9XZWJGcmFtZS5jcHAKQEAgLTM5MywzICszOTMsMTAg QEAgd3hXZWJWaWV3RE9NRWxlbWVudEluZm8gd3hXZWJGcmFtZTo6SGl0VGVzdChjb25zdCB3eFBv aW50JiBwb3MpIGNvbnN0CiAgICAgcmV0dXJuIGRvbUluZm87CiB9CiAKK2Jvb2wgd3hXZWJGcmFt ZTo6U2hvdWxkQ2xvc2UoKSBjb25zdAoreworICAgIGlmIChtX2ltcGwtPmZyYW1lKQorICAgICAg ICByZXR1cm4gbV9pbXBsLT5mcmFtZS0+c2hvdWxkQ2xvc2UoKTsKKworICAgIHJldHVybiB0cnVl OworfQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3d4L1dlYkZyYW1lLmggYi9XZWJLaXQvd3gvV2ViRnJh bWUuaAppbmRleCBkM2I3YzZlLi5iZDRiZGIwIDEwMDY0NAotLS0gYS9XZWJLaXQvd3gvV2ViRnJh bWUuaAorKysgYi9XZWJLaXQvd3gvV2ViRnJhbWUuaApAQCAtMTUxLDYgKzE1MSw4IEBAIHB1Ymxp YzoKIAogICAgIHd4V2ViVmlld0RPTUVsZW1lbnRJbmZvIEhpdFRlc3QoY29uc3Qgd3hQb2ludCYg cG9zdCkgY29uc3Q7CiAgICAgCisgICAgYm9vbCBTaG91bGRDbG9zZSgpIGNvbnN0OworICAgIAog cHJpdmF0ZToKICAgICBmbG9hdCBtX3RleHRNYWduaWZpZXI7CiAgICAgYm9vbCBtX2lzRWRpdGFi bGU7CmRpZmYgLS1naXQgYS9XZWJLaXQvd3gvV2ViVmlldy5jcHAgYi9XZWJLaXQvd3gvV2ViVmll dy5jcHAKaW5kZXggZWRmODY4Ny4uYWU2ODI5YiAxMDA2NDQKLS0tIGEvV2ViS2l0L3d4L1dlYlZp ZXcuY3BwCisrKyBiL1dlYktpdC93eC9XZWJWaWV3LmNwcApAQCAtODU1LDMgKzg1NSwxMCBAQCB3 eFdlYlZpZXdET01FbGVtZW50SW5mbyB3eFdlYlZpZXc6OkhpdFRlc3QoY29uc3Qgd3hQb2ludCYg cG9zKSBjb25zdAogICAgIHJldHVybiB3eFdlYlZpZXdET01FbGVtZW50SW5mbygpOwogfQogCiti b29sIHd4V2ViVmlldzo6U2hvdWxkQ2xvc2UoKSBjb25zdAoreworICAgIGlmIChtX21haW5GcmFt ZSkKKyAgICAgICAgcmV0dXJuIG1fbWFpbkZyYW1lLT5TaG91bGRDbG9zZSgpOworCisgICAgcmV0 dXJuIHRydWU7Cit9CmRpZmYgLS1naXQgYS9XZWJLaXQvd3gvV2ViVmlldy5oIGIvV2ViS2l0L3d4 L1dlYlZpZXcuaAppbmRleCBkMmUyNTMyLi40ZGQ1ZWQ5IDEwMDY0NAotLS0gYS9XZWJLaXQvd3gv V2ViVmlldy5oCisrKyBiL1dlYktpdC93eC9XZWJWaWV3LmgKQEAgLTE1OSw2ICsxNTksOCBAQCBw dWJsaWM6CiAgICAgd3hXZWJGcmFtZSogR2V0TWFpbkZyYW1lKCkgeyByZXR1cm4gbV9tYWluRnJh bWU7IH0KIAogICAgIHd4V2ViVmlld0RPTUVsZW1lbnRJbmZvIEhpdFRlc3QoY29uc3Qgd3hQb2lu dCYgcG9zKSBjb25zdDsKKyAgICAKKyAgICBib29sIFNob3VsZENsb3NlKCkgY29uc3Q7CiAKIHBy b3RlY3RlZDoKIAo=