29196 2009-09-11 11:32:52 -0700 wx port is missing several filesystem functions in FileSystemWx.cpp 2015-05-07 16:34:58 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 kevinwatters kevino kevino mrobinson oldest_to_newest 146665 0 kevinwatters 2009-09-11 11:32:52 -0700 The wx port is missing a few FileSystemWx.cpp functions, which are prohibiting HTML5 local databases from being created and managed correctly. 146666 1 39454 kevinwatters 2009-09-11 11:33:54 -0700 Created attachment 39454 implements a few FileSystemWx.cpp functions 146804 2 39454 eric 2009-09-11 16:48:18 -0700 Comment on attachment 39454 implements a few FileSystemWx.cpp functions This looks fine. Except do you really want to use 0777? 76 return wxFileName::Mkdir(path, 0777, wxPATH_MKDIR_FULL); Wouldn't you want to respect the user's umask? Or at least restrict these to rwx for the user? 147002 3 kevino 2009-09-13 17:56:05 -0700 Landed in r48344, thanks!(In reply to comment #2) > (From update of attachment 39454 [details]) > This looks fine. Except do you really want to use 0777? > 76 return wxFileName::Mkdir(path, 0777, wxPATH_MKDIR_FULL); > > Wouldn't you want to respect the user's umask? Or at least restrict these to > rwx for the user? Sorry, didn't notice this comment somehow before landing the change. (r48344, BTW) After checking into it, I do see that the POSIX and GTK implementations do set umask to rwx for the user. Whether this is the right behavior for this API or not (vs. respecting the user's umask), I don't know, but it would seem that we run less risk of having unpredictable behavior by doing the same thing as other platforms. I'll leave this ticket open and work up a patch to change it if Kevin W. doesn't beat me to it. ;) Thanks for catching this! 148352 4 39454 eric 2009-09-18 13:25:35 -0700 Comment on attachment 39454 implements a few FileSystemWx.cpp functions Clearing r+ on this landed change. It would be better to file a new bug to track the new change. 39454 2009-09-11 11:33:54 -0700 2010-06-10 19:05:56 -0700 implements a few FileSystemWx.cpp functions filesystem.patch text/plain 2804 kevinwatters ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzE3NDgwZS4uMmU0MjgzYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wOS0wOSAgS2V2aW4gV2F0dGVy cyAgPGtldmlud2F0dGVyc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW3d4XSBJbXBsZW1lbnQgZmlsZXN5c3RlbSBmdW5jdGlvbnMu CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5MTk2 CisKKyAgICAgICAgKiBwbGF0Zm9ybS93eC9GaWxlU3lzdGVtV3guY3BwOgorICAgICAgICAoV2Vi Q29yZTo6ZmlsZUV4aXN0cyk6CisgICAgICAgIChXZWJDb3JlOjpkZWxldGVGaWxlKToKKyAgICAg ICAgKFdlYkNvcmU6OmRlbGV0ZUVtcHR5RGlyZWN0b3J5KToKKyAgICAgICAgKFdlYkNvcmU6Omdl dEZpbGVTaXplKToKKyAgICAgICAgKFdlYkNvcmU6OmdldEZpbGVNb2RpZmljYXRpb25UaW1lKToK KyAgICAgICAgKFdlYkNvcmU6Om1ha2VBbGxEaXJlY3Rvcmllcyk6CisgICAgICAgIChXZWJDb3Jl OjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQpOgorICAgICAgICAoV2ViQ29yZTo6aG9tZURpcmVj dG9yeVBhdGgpOgorICAgICAgICAoV2ViQ29yZTo6ZGlyZWN0b3J5TmFtZSk6CisKIDIwMDktMDkt MDggIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAg d3ggYnVpbGQgZml4IGZvciAyLjguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3d4L0Zp bGVTeXN0ZW1XeC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3d4L0ZpbGVTeXN0ZW1XeC5jcHAKaW5k ZXggN2RlNDI1ZS4uMTA5Mjc4ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS93eC9GaWxl U3lzdGVtV3guY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vd3gvRmlsZVN5c3RlbVd4LmNwcApA QCAtNDAsNTAgKzQwLDUwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogYm9vbCBmaWxlRXhpc3Rz KGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVy biB0cnVlOworICAgIHJldHVybiB3eEZpbGVOYW1lOjpGaWxlRXhpc3RzKHBhdGgpOwogfQogCiBi b29sIGRlbGV0ZUZpbGUoY29uc3QgU3RyaW5nJiBwYXRoKQogewotICAgIG5vdEltcGxlbWVudGVk KCk7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiB3eFJlbW92ZUZpbGUocGF0aCk7CiB9 CiAKIGJvb2wgZGVsZXRlRW1wdHlEaXJlY3RvcnkoY29uc3QgU3RyaW5nJiBwYXRoKQogewotICAg IG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiB3eEZpbGVO YW1lOjpSbWRpcihwYXRoKTsKIH0KIAogYm9vbCBnZXRGaWxlU2l6ZShjb25zdCBTdHJpbmcmIHBh dGgsIGxvbmcgbG9uZyYgcmVzdWx0U2l6ZSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IHd4VUxvbmdMb25nIHNpemUgPSB3eEZpbGVOYW1lOjpHZXRTaXplKHBhdGgpOworICAgIGlmICh3 eEludmFsaWRTaXplICE9IHNpemUpIHsKKyAgICAgICAgLy8gVE9ETzogd2h5IGlzIEZpbGVTeXN0 ZW06OmdldEZpbGVTaXplIHNpZ25lZD8KKyAgICAgICAgcmVzdWx0U2l6ZSA9IChsb25nIGxvbmcp c2l6ZS5HZXRWYWx1ZSgpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKICAgICByZXR1 cm4gZmFsc2U7CiB9CiAKLWJvb2wgZ2V0RmlsZU1vZGlmaWNhdGlvblRpbWUoY29uc3QgU3RyaW5n JiwgdGltZV90JikKK2Jvb2wgZ2V0RmlsZU1vZGlmaWNhdGlvblRpbWUoY29uc3QgU3RyaW5nJiBw YXRoLCB0aW1lX3QmIHQpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gZmFs c2U7CisgICAgdCA9IHd4RmlsZU5hbWUocGF0aCkuR2V0TW9kaWZpY2F0aW9uVGltZSgpLkdldFRp Y2tzKCk7CisgICAgcmV0dXJuIHRydWU7CiB9CiAKIGJvb2wgbWFrZUFsbERpcmVjdG9yaWVzKGNv bnN0IFN0cmluZyYgcGF0aCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBm YWxzZTsKKyAgICByZXR1cm4gd3hGaWxlTmFtZTo6TWtkaXIocGF0aCwgMDc3Nywgd3hQQVRIX01L RElSX0ZVTEwpOwogfQogCiBTdHJpbmcgcGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGNvbnN0IFN0 cmluZyYgcGF0aCwgY29uc3QgU3RyaW5nJiBjb21wb25lbnQpCiB7Ci0gICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgICByZXR1cm4gU3RyaW5nKCk7CisgICAgcmV0dXJuIHd4RmlsZU5hbWUocGF0aCwg Y29tcG9uZW50KS5HZXRGdWxsUGF0aCgpOwogfQogCiBTdHJpbmcgaG9tZURpcmVjdG9yeVBhdGgo KQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIFN0cmluZygpOworICAgIHJl dHVybiB3eEZpbGVOYW1lOjpHZXRIb21lRGlyKCk7CiB9CiAKIFN0cmluZyBwYXRoR2V0RmlsZU5h bWUoY29uc3QgU3RyaW5nJiBwYXRoKQpAQCAtOTMsOCArOTMsNyBAQCBTdHJpbmcgcGF0aEdldEZp bGVOYW1lKGNvbnN0IFN0cmluZyYgcGF0aCkKIAogU3RyaW5nIGRpcmVjdG9yeU5hbWUoY29uc3Qg U3RyaW5nJiBwYXRoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIFN0cmlu ZygpOworICAgIHJldHVybiB3eEZpbGVOYW1lKHBhdGgpLkdldFBhdGgoKTsKIH0KIAogQ1N0cmlu ZyBvcGVuVGVtcG9yYXJ5RmlsZShjb25zdCBjaGFyKiBwcmVmaXgsIFBsYXRmb3JtRmlsZUhhbmRs ZSYgaGFuZGxlKQo=