291925 2025-04-22 18:50:44 -0700 [WebDriver][BiDi] Assertion in RefCountedAndCanMakeWeakPtr<WebSocketServer> destructor 2025-04-25 16:34:48 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=286274 InRadar P2 Normal --- 1 lmoura lmoura bburg webkit-bug-importer oldest_to_newest 2112529 0 lmoura 2025-04-22 18:50:44 -0700 During a full test run, sometimes we hit the following assertion: #0 0x00005f3871508dc5 in WTFCrash () #1 0x00005f387148fc3a in WTFCrashWithInfo(int, char const*, char const*, int) () #2 0x00005f38714f32d8 in WTF::RefCountedAndCanMakeWeakPtr<WebDriver::WebSocketServer>::~RefCountedAndCanMakeWeakPtr() () #3 0x00005f38714dc6b0 in WebDriver::WebDriverService::~WebDriverService() () #4 0x00005f38714dc52b in main () This happens because while WebSocketServer is RefCountedAndCanMakeWeakPtr, it's held by value by WebDriverService. Originally, bug286274 and https://github.com/WebKit/WebKit/pull/39310 addressed it, but also modified other classes in relation to smart pointer usage, despite not hitting assertions. During the review process, we agreed to submit first a more focused fix (this issue), leaving the original bug for when we address other safer cpp-related issues. 2112530 1 lmoura 2025-04-22 18:57:59 -0700 Pull request: https://github.com/WebKit/WebKit/pull/44398 2113219 2 ews-feeder 2025-04-25 16:31:36 -0700 Committed 294135@main (71b34966f4fb): <https://commits.webkit.org/294135@main> Reviewed commits have been landed. Closing PR #44398 and removing active labels. 2113220 3 webkit-bug-importer 2025-04-25 16:34:48 -0700 <rdar://problem/150069220>