29190 2009-09-11 09:58:28 -0700 commit-log-editor should move common prefixes to the top of the commit log 2009-09-21 18:31:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 aroben webkit-unassigned ddkilzer eric oldest_to_newest 146617 0 39445 aroben 2009-09-11 09:58:28 -0700 Created attachment 39445 Patch v1 It's silly to have common prefixes in ChangeLogs (e.g., bug title/URL + reviewer) repeated in the commit log. Let's move common prefixes to the top of the log instead. 146921 1 39445 ddkilzer 2009-09-12 05:04:04 -0700 Comment on attachment 39445 Patch v1 > + foreach my $key (keys %{$hashOfStrings}) { > + $hashOfStrings->{$key} = substr($hashOfStrings->{$key}, $lastDoubleNewline); Don't you want to use ($lastDoubleNewline + 2) here as well? > + } > + return substr($prefix, 0, $lastDoubleNewline + 2); > +} Otherwise this looks great! 147064 2 aroben 2009-09-14 09:01:35 -0700 (In reply to comment #1) > (From update of attachment 39445 [details]) > > + foreach my $key (keys %{$hashOfStrings}) { > > + $hashOfStrings->{$key} = substr($hashOfStrings->{$key}, $lastDoubleNewline); > > Don't you want to use ($lastDoubleNewline + 2) here as well? The current behavior is what we want. The leading double newline that's left on each ChangeLog entry ends up right after the label for that ChangeLog, like "WebCore:\n\nUnique part of the entry". But even though this is the behavior we want, it does seem a bit subtle. It would probably be better to strip the leading double newline from each entry, then explicitly add the double newline after each label. 148349 3 eric 2009-09-18 13:24:26 -0700 This was landed on Sept 11th as r48307. /me points aroben at 'bugzilla-tool land-diff' as an svn ci replacement. :) It will auto-close the bug for you. :) You can even pass --no-build or --no-test if you don't want it to bother automatically doing one-last build and test cycle for you before landing. :) 39445 2009-09-11 09:58:28 -0700 2009-09-12 05:04:04 -0700 Patch v1 20090911125828.patch text/plain 2911 aroben ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjOWZiZmJlLi44MDhiODI1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMDktMDkt MTEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAgIE1ha2UgY29tbWl0 LWxvZy1lZGl0b3IgbW92ZSBjb21tb24gcHJlZml4ZXMgdG8gdGhlIHRvcCBvZiB0aGUgbG9nCisK KyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMv Y29tbWl0LWxvZy1lZGl0b3I6IEZpbmQgYW5kIHJlbW92ZSB0aGUgbG9uZ2VzdCBjb21tb24gcHJl Zml4CisgICAgICAgIGVuZGluZyBpbiBhIGRvdWJsZSBuZXdsaW5lIGZyb20gZWFjaCBDaGFuZ2VM b2cgZW50cnksIHRoZW4gcHV0IHRoYXQKKyAgICAgICAgY29tbW9uIHByZWZpeCBhdCB0aGUgdG9w IG9mIHRoZSBjb21taXQgbG9nLgorICAgICAgICAocmVtb3ZlTG9uZ2VzdENvbW1vblByZWZpeEVu ZGluZ0luRG91YmxlTmV3bGluZSk6IEFkZGVkLiBGaW5kcywKKyAgICAgICAgcmVtb3ZlcywgYW5k IHJldHVybnMgdGhlIGxvbmdlc3QgY29tbW9uIHByZWZpeCBlbmRpbmcgaW4gYSBkb3VibGUKKyAg ICAgICAgbmV3bGluZSBmcm9tIGEgaGFzaCBvZiBzdHJpbmdzCisKKzIwMDktMDktMTEgIEFkYW0g Um9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCiAgICAgICAgIEdldCB1c2VyIHNjcmlwdC9zdHls ZXNoZWV0IHRlc3RzIHJ1bm5pbmcgb24gV2luZG93cwogCiAgICAgICAgIEZpeGVzIDxodHRwOi8v d2Via2l0Lm9yZy9iLzI5MTgxPiBVc2VyIHNjcmlwdC9zdHlsZXNoZWV0IHRlc3RzIGFyZQpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9jb21taXQtbG9nLWVkaXRvciBiL1dlYktpdFRv b2xzL1NjcmlwdHMvY29tbWl0LWxvZy1lZGl0b3IKaW5kZXggZTJmYzkyZC4uYTQ3MDkxZSAxMDA3 NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9jb21taXQtbG9nLWVkaXRvcgorKysgYi9XZWJL aXRUb29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yCkBAIC0zOSw2ICszOSw3IEBAIHVzZSBW Q1NVdGlsczsKIHVzZSB3ZWJraXRkaXJzOwogCiBzdWIgbm9ybWFsaXplTGluZUVuZGluZ3MoJCQp Oworc3ViIHJlbW92ZUxvbmdlc3RDb21tb25QcmVmaXhFbmRpbmdJbkRvdWJsZU5ld2xpbmUoXCUp OwogCiBzdWIgdXNhZ2UKIHsKQEAgLTIxNiw2ICsyMTcsOCBAQCBmb3IgbXkgJGNoYW5nZUxvZyAo QGNoYW5nZUxvZ3MpIHsKICAgICAkY2hhbmdlTG9nQ29udGVudHN7JGxhYmVsfSA9ICRjb250ZW50 czsKIH0KIAorbXkgJGNvbW1vblByZWZpeCA9IHJlbW92ZUxvbmdlc3RDb21tb25QcmVmaXhFbmRp bmdJbkRvdWJsZU5ld2xpbmUoJWNoYW5nZUxvZ0NvbnRlbnRzKTsKKwogbXkgJGZpcnN0ID0gMTsK IG9wZW4gTkVXTE9HLCAiPiRsb2cuZWRpdCIgb3IgZGllOwogaWYgKGlzR2l0KCkgJiYgc2NhbGFy IGtleXMgJWNoYW5nZUxvZ1NvcnQgPT0gMCkgewpAQCAtMjMzLDYgKzIzNiw3IEBAIGlmIChpc0dp dCgpICYmIHNjYWxhciBrZXlzICVjaGFuZ2VMb2dTb3J0ID09IDApIHsKICAgICAgICAgY2xvc2Ug Q0hBTkdFTE9HX0VOVFJJRVM7CiAgICAgfQogfSBlbHNlIHsKKyAgICBwcmludCBORVdMT0cgbm9y bWFsaXplTGluZUVuZGluZ3MoJGNvbW1vblByZWZpeCwgJGVuZGwpOwogICAgIGZvciBteSAkc29y dEtleSAoc29ydCBrZXlzICVjaGFuZ2VMb2dTb3J0KSB7CiAgICAgICAgIG15ICRsYWJlbCA9ICRj aGFuZ2VMb2dTb3J0eyRzb3J0S2V5fTsKICAgICAgICAgaWYgKGtleXMgJWNoYW5nZUxvZ1NvcnQg PiAxKSB7CkBAIC0yNzMsMyArMjc3LDMxIEBAIHN1YiBub3JtYWxpemVMaW5lRW5kaW5ncygkJCkK ICAgICAkc3RyaW5nID1+IHMvXHI/XG4vJGVuZGwvZzsKICAgICByZXR1cm4gJHN0cmluZzsKIH0K Kworc3ViIHJlbW92ZUxvbmdlc3RDb21tb25QcmVmaXhFbmRpbmdJbkRvdWJsZU5ld2xpbmUoXCUp Cit7CisgICAgbXkgKCRoYXNoT2ZTdHJpbmdzKSA9IEBfOworCisgICAgbXkgQHN0cmluZ3MgPSB2 YWx1ZXMgJXskaGFzaE9mU3RyaW5nc307CisgICAgcmV0dXJuICIiIHVubGVzcyBAc3RyaW5ncyA+ IDE7CisgICAgbXkgJHByZWZpeCA9IHNoaWZ0IEBzdHJpbmdzOworICAgIG15ICRwcmVmaXhMZW5n dGggPSBsZW5ndGggJHByZWZpeDsKKyAgICBmb3JlYWNoIG15ICRzdHJpbmcgKEBzdHJpbmdzKSB7 CisgICAgICAgIHdoaWxlICgkcHJlZml4TGVuZ3RoKSB7CisgICAgICAgICAgICBsYXN0IGlmIHN1 YnN0cigkc3RyaW5nLCAwLCAkcHJlZml4TGVuZ3RoKSBlcSAkcHJlZml4OworICAgICAgICAgICAg LS0kcHJlZml4TGVuZ3RoOworICAgICAgICAgICAgJHByZWZpeCA9IHN1YnN0cigkcHJlZml4LCAw LCAtMSk7CisgICAgICAgIH0KKyAgICAgICAgbGFzdCB1bmxlc3MgJHByZWZpeExlbmd0aDsKKyAg ICB9CisKKyAgICByZXR1cm4gIiIgdW5sZXNzICRwcmVmaXhMZW5ndGg7CisKKyAgICBteSAkbGFz dERvdWJsZU5ld2xpbmUgPSByaW5kZXgoJHByZWZpeCwgIlxuXG4iKTsKKyAgICByZXR1cm4gIiIg dW5sZXNzICRsYXN0RG91YmxlTmV3bGluZSA+IDA7CisKKyAgICBmb3JlYWNoIG15ICRrZXkgKGtl eXMgJXskaGFzaE9mU3RyaW5nc30pIHsKKyAgICAgICAgJGhhc2hPZlN0cmluZ3MtPnska2V5fSA9 IHN1YnN0cigkaGFzaE9mU3RyaW5ncy0+eyRrZXl9LCAkbGFzdERvdWJsZU5ld2xpbmUpOworICAg IH0KKyAgICByZXR1cm4gc3Vic3RyKCRwcmVmaXgsIDAsICRsYXN0RG91YmxlTmV3bGluZSArIDIp OworfQ==