29175 2009-09-11 03:09:01 -0700 JavaScriptCore: corrects build break on sparc 64 with gcc 2009-09-11 06:29:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 0 jturcotte webkit-unassigned commit-queue oldest_to_newest 146511 0 39420 jturcotte 2009-09-11 03:09:01 -0700 Created attachment 39420 Patch Compiling JavaScriptCore on sparc 64 with gcc fails. ThreadSafeShared uses the atomic __gnu_cxx::__exchange_and_add with an int, however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes). The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use a mutex instead when compiling for sparc 64 with gcc. 146525 1 39423 jturcotte 2009-09-11 05:39:10 -0700 Created attachment 39423 Patch v0.2 Copy but patch description into changelog 146527 2 39423 hausmann 2009-09-11 05:40:53 -0700 Comment on attachment 39423 Patch v0.2 r=me 146533 3 39423 commit-queue 2009-09-11 06:29:37 -0700 Comment on attachment 39423 Patch v0.2 Clearing flags on attachment: 39423 Committed r48300: <http://trac.webkit.org/changeset/48300> 146534 4 commit-queue 2009-09-11 06:29:49 -0700 All reviewed patches have been landed. Closing bug. 39420 2009-09-11 03:09:01 -0700 2009-09-11 05:39:10 -0700 Patch jsc_sparc64.patch text/plain 1842 jturcotte ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1ZGE3NDQwLi4xMWYzNjdmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMDktMDktMTAgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE aXNhYmxlcyBXVEZfVVNFX0xPQ0tGUkVFX1RIUkVBRFNBRkVTSEFSRUQgb24gU3BhcmM2NCBnY2Mg dG8gY29ycmVjdAorICAgICAgICBidWlsZCBicmVhayBvbiB0aGlzIGNwdS9jb21waWxlci4KKwor ICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorICAgICAgICBfX3NwYXJjNjRfXyBpcyBub3QgZGVm aW5lZCBvbiBhbGwgT1MuCisgICAgICAgIFVzZXMgaW5zdGVhZDogX19zcGFyY19fICYmIF9fYXJj aDY0X18gfHwgX19zcGFyY3Y5CisgICAgICAgICogd3RmL1RocmVhZGluZy5oOgorCiAyMDA5LTA5 LTA4ICBKb2huIEFiZC1FbC1NYWxlayAgPGphbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3Rm L1BsYXRmb3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCAyNGQxZWJl Li44NDJmZmJkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysg Yi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtMjc5LDcgKzI3OSw3IEBACiAjZW5k aWYKIAogLyogUExBVEZPUk0oU1BBUkM2NCkgKi8KLSNpZiBkZWZpbmVkKF9fc3BhcmM2NF9fKQor I2lmIGRlZmluZWQoX19zcGFyY19fKSAmJiBkZWZpbmVkKF9fYXJjaDY0X18pIHx8IGRlZmluZWQg KF9fc3BhcmN2OSkKICNkZWZpbmUgV1RGX1BMQVRGT1JNX1NQQVJDNjQgMQogI2RlZmluZSBXVEZf UExBVEZPUk1fQklHX0VORElBTiAxCiAjZW5kaWYKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3Jl L3d0Zi9UaHJlYWRpbmcuaCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAppbmRleCA0 ZTNlOTgwLi41MTU0NTQ1IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5n LmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZy5oCkBAIC0yMjgsNyArMjI4LDcg QEAgaW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0 dXJuIEludGVybG9ja2VkRGVjcmVtZW50KHIKIGlubGluZSBpbnQgYXRvbWljSW5jcmVtZW50KGlu dCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBPU0F0b21pY0luY3JlbWVudDMyQmFycmllcihj b25zdF9jYXN0PGludCo+KGFkZGVuZCkpOyB9CiBpbmxpbmUgaW50IGF0b21pY0RlY3JlbWVudChp bnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gT1NBdG9taWNEZWNyZW1lbnQzMkJhcnJpZXIo Y29uc3RfY2FzdDxpbnQqPihhZGRlbmQpKTsgfQogCi0jZWxpZiBDT01QSUxFUihHQ0MpCisjZWxp ZiBDT01QSUxFUihHQ0MpICYmICFQTEFURk9STShTUEFSQzY0KSAvLyBzaXplb2YoX0F0b21pY193 b3JkKSAhPSBzaXplb2YoaW50KSBvbiBzcGFyYzY0IGdjYwogI2RlZmluZSBXVEZfVVNFX0xPQ0tG UkVFX1RIUkVBRFNBRkVTSEFSRUQgMQogCiBpbmxpbmUgaW50IGF0b21pY0luY3JlbWVudChpbnQg dm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gX19nbnVfY3h4OjpfX2V4Y2hhbmdlX2FuZF9hZGQo YWRkZW5kLCAxKSArIDE7IH0K 39423 2009-09-11 05:39:10 -0700 2009-09-11 06:29:37 -0700 Patch v0.2 jsc_sparc64.patch text/plain 2168 jturcotte ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1ZGE3NDQwLi5jOWRhOWNkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMDktMDktMTAgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b21waWxpbmcgSmF2YVNjcmlwdENvcmUgb24gc3BhcmMgNjQgd2l0aCBnY2MgZmFpbHMuCisKKyAg ICAgICAgVGhyZWFkU2FmZVNoYXJlZCB1c2VzIHRoZSBhdG9taWMgX19nbnVfY3h4OjpfX2V4Y2hh bmdlX2FuZF9hZGQgd2l0aCBhbiBpbnQsCisgICAgICAgIGhvd2V2ZXIgb24gc3BhcmMgNjQgdGhl IF9BdG9taWNfd29yZCBhcmd1bWVudCBpcyB0eXBlZGVmZWQgdG8gbG9uZyAoOCBieXRlcykuCisK KyAgICAgICAgVGhlIHBhdGNoIGRpc2FibGVzIFdURl9VU0VfTE9DS0ZSRUVfVEhSRUFEU0FGRVNI QVJFRCBpbiBUaHJlYWRTYWZlU2hhcmVkIHRvIHVzZQorICAgICAgICBhIG11dGV4IGluc3RlYWQg d2hlbiBjb21waWxpbmcgZm9yIHNwYXJjIDY0IHdpdGggZ2NjLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE3NQorCisgICAgICAgICogd3RmL1Bs YXRmb3JtLmg6CisgICAgICAgIF9fc3BhcmM2NF9fIGlzIG5vdCBkZWZpbmVkIG9uIGFsbCBPUy4K KyAgICAgICAgVXNlcyBpbnN0ZWFkOiBfX3NwYXJjX18gJiYgX19hcmNoNjRfXyB8fCBfX3NwYXJj djkKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nLmg6CisKIDIwMDktMDktMDggIEpvaG4gQWJkLUVs LU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJp IEdsYXprb3YuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaCBiL0ph dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDI0ZDFlYmUuLjg0MmZmYmQgMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL0phdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybS5oCkBAIC0yNzksNyArMjc5LDcgQEAKICNlbmRpZgogCiAvKiBQTEFURk9S TShTUEFSQzY0KSAqLwotI2lmIGRlZmluZWQoX19zcGFyYzY0X18pCisjaWYgZGVmaW5lZChfX3Nw YXJjX18pICYmIGRlZmluZWQoX19hcmNoNjRfXykgfHwgZGVmaW5lZCAoX19zcGFyY3Y5KQogI2Rl ZmluZSBXVEZfUExBVEZPUk1fU1BBUkM2NCAxCiAjZGVmaW5lIFdURl9QTEFURk9STV9CSUdfRU5E SUFOIDEKICNlbmRpZgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZy5o IGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZy5oCmluZGV4IDRlM2U5ODAuLjUxNTQ1NDUg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAorKysgYi9KYXZhU2Ny aXB0Q29yZS93dGYvVGhyZWFkaW5nLmgKQEAgLTIyOCw3ICsyMjgsNyBAQCBpbmxpbmUgaW50IGF0 b21pY0RlY3JlbWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gSW50ZXJsb2NrZWRE ZWNyZW1lbnQocgogaW5saW5lIGludCBhdG9taWNJbmNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRl bmQpIHsgcmV0dXJuIE9TQXRvbWljSW5jcmVtZW50MzJCYXJyaWVyKGNvbnN0X2Nhc3Q8aW50Kj4o YWRkZW5kKSk7IH0KIGlubGluZSBpbnQgYXRvbWljRGVjcmVtZW50KGludCB2b2xhdGlsZSogYWRk ZW5kKSB7IHJldHVybiBPU0F0b21pY0RlY3JlbWVudDMyQmFycmllcihjb25zdF9jYXN0PGludCo+ KGFkZGVuZCkpOyB9CiAKLSNlbGlmIENPTVBJTEVSKEdDQykKKyNlbGlmIENPTVBJTEVSKEdDQykg JiYgIVBMQVRGT1JNKFNQQVJDNjQpIC8vIHNpemVvZihfQXRvbWljX3dvcmQpICE9IHNpemVvZihp bnQpIG9uIHNwYXJjNjQgZ2NjCiAjZGVmaW5lIFdURl9VU0VfTE9DS0ZSRUVfVEhSRUFEU0FGRVNI QVJFRCAxCiAKIGlubGluZSBpbnQgYXRvbWljSW5jcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5k KSB7IHJldHVybiBfX2dudV9jeHg6Ol9fZXhjaGFuZ2VfYW5kX2FkZChhZGRlbmQsIDEpICsgMTsg fQo=