29173 2009-09-11 02:07:21 -0700 [GTK] Use gtk_style_set_background instead of gdk_window_set_background 2009-09-11 23:55:30 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned oldest_to_newest 146500 0 xan.lopez 2009-09-11 02:07:21 -0700 Explanation in the patch. 146502 1 39417 xan.lopez 2009-09-11 02:09:52 -0700 Created attachment 39417 setbackground.diff 146516 2 39417 jmalonzo 2009-09-11 03:58:52 -0700 Comment on attachment 39417 setbackground.diff Are there any visible changes to this? If so can we have a test (manual or otherwise)? 146517 3 xan.lopez 2009-09-11 04:03:09 -0700 (In reply to comment #2) > (From update of attachment 39417 [details]) > Are there any visible changes to this? If so can we have a test (manual or > otherwise)? Not really, gtk_style_set_background will just call the same function we were using. The difference is that it also takes into account pixmap backgrounds, so it's safer to use it. 146767 4 39417 jmalonzo 2009-09-11 15:27:23 -0700 Comment on attachment 39417 setbackground.diff r=me. 146902 5 xan.lopez 2009-09-11 23:55:30 -0700 Landed in r48332. 39417 2009-09-11 02:09:52 -0700 2009-09-11 15:27:23 -0700 setbackground.diff setbackground.diff text/plain 2282 xan.lopez RnJvbSA3NDI0YzAwYmNlZjQ3NWU3MzBjNmYwNjViZjQ0MGViZDBiNGM1ZWJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBG cmksIDExIFNlcCAyMDA5IDEyOjA4OjIzICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wOS0x MSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBVc2UgZ3RrX3N0eWxlX3NldF9iYWNrZ3JvdW5k IGluc3RlYWQgb2YgZ2RrX3dpbmRvd19zZXRfYmFja2dyb3VuZAogICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE3MwoKICAgICAgICBVc2UgZ3RrX3N0eWxl X3NldF9iYWNrZ3JvdW5kIGluc3RlYWQgb2YgZ2RrX3dpbmRvd19zZXRfYmFja2dyb3VuZCwKICAg ICAgICBhcyBzdWdnZXN0ZWQgYnkgdGhlIGRvY3VtZW50YXRpb24uIEFsc28sIHVzZSBHVEtfU1RB VEVfTk9STUFMCiAgICAgICAgZGlyZWN0bHksIHNpbmNlIHRoYXQncyB0aGUgZGVmYXVsdCBzdGF0 ZSBvZiBhIEd0a1dpZGdldC4KCiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CiAg ICAgICAgKHdlYmtpdF93ZWJfdmlld19yZWFsaXplKToKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYnZpZXcuY3BwIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9n IGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggZTdjZDhkNy4uYjY0ZjRlOCAxMDA2NDQKLS0t IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAwOS0wOS0xMSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVXNl IGd0a19zdHlsZV9zZXRfYmFja2dyb3VuZCBpbnN0ZWFkIG9mIGdka193aW5kb3dfc2V0X2JhY2tn cm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5 MTczCisKKyAgICAgICAgVXNlIGd0a19zdHlsZV9zZXRfYmFja2dyb3VuZCBpbnN0ZWFkIG9mIGdk a193aW5kb3dfc2V0X2JhY2tncm91bmQsCisgICAgICAgIGFzIHN1Z2dlc3RlZCBieSB0aGUgZG9j dW1lbnRhdGlvbi4gQWxzbywgdXNlIEdUS19TVEFURV9OT1JNQUwKKyAgICAgICAgZGlyZWN0bHks IHNpbmNlIHRoYXQncyB0aGUgZGVmYXVsdCBzdGF0ZSBvZiBhIEd0a1dpZGdldC4KKworICAgICAg ICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19y ZWFsaXplKToKKwogMjAwOS0wOS0wOSAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KZGlmZiAtLWdpdCBh L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2Vidmlldy5jcHAKaW5kZXggNjE3Y2UwYi4uMDU1NGVhMSAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2Vidmlldy5jcHAKQEAgLTY1NSw3ICs2NTUsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRf d2ViX3ZpZXdfcmVhbGl6ZShHdGtXaWRnZXQqIHdpZGdldCkKICAgICBnZGtfd2luZG93X3NldF91 c2VyX2RhdGEod2lkZ2V0LT53aW5kb3csIHdpZGdldCk7CiAKICAgICB3aWRnZXQtPnN0eWxlID0g Z3RrX3N0eWxlX2F0dGFjaCh3aWRnZXQtPnN0eWxlLCB3aWRnZXQtPndpbmRvdyk7Ci0gICAgZ2Rr X3dpbmRvd19zZXRfYmFja2dyb3VuZCh3aWRnZXQtPndpbmRvdywgJndpZGdldC0+c3R5bGUtPmJh c2VbR1RLX1dJREdFVF9TVEFURSh3aWRnZXQpXSk7CisgICAgZ3RrX3N0eWxlX3NldF9iYWNrZ3Jv dW5kKHdpZGdldC0+c3R5bGUsIHdpZGdldC0+d2luZG93LCBHVEtfU1RBVEVfTk9STUFMKTsKIAog ICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KTsKICAg ICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IHdlYlZpZXctPnByaXY7Ci0tIAoxLjYuNC4x Cgo=