29172 2009-09-11 01:33:57 -0700 [V8] OwnHandle might get a weak callback after destruction 2009-09-17 13:00:05 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue dglazkov levin oldest_to_newest 146490 0 abarth 2009-09-11 01:33:57 -0700 Be sure to clear our weak reference when we clear the OwnHandle to make sure we don't get a callback after we've destructed ourselves. 146493 1 39416 abarth 2009-09-11 01:37:07 -0700 Created attachment 39416 Patch v1 146807 2 39416 eric 2009-09-11 16:50:50 -0700 Comment on attachment 39416 Patch v1 Was this causing crashes? Is this a testable change? 146816 3 abarth 2009-09-11 17:02:31 -0700 I don't know of any crashes that this causes. This class currently has only one client. I don't think it's testable currently. 147483 4 39416 eric 2009-09-15 23:03:14 -0700 Comment on attachment 39416 Patch v1 You ChangeLog should mention that it's not testable. 147902 5 39416 commit-queue 2009-09-17 12:59:58 -0700 Comment on attachment 39416 Patch v1 Clearing flags on attachment: 39416 Committed r48486: <http://trac.webkit.org/changeset/48486> 147903 6 commit-queue 2009-09-17 13:00:05 -0700 All reviewed patches have been landed. Closing bug. 39416 2009-09-11 01:37:07 -0700 2009-09-17 12:59:57 -0700 Patch v1 bug-29172-20090911013706.patch text/plain 1771 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODI4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMTEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhd IE93bkhhbmRsZSBtaWdodCBnZXQgYSB3ZWFrIGNhbGxiYWNrIGFmdGVyIGRlc3RydWN0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE3MgorCisg ICAgICAgIEJlIHN1cmUgdG8gY2xlYXIgb3V0IHdlYWsgcmVmZXJlbmNlIHNvIHdlIGRvbid0IGdl dCBhIHdlYWsgY2FsbGJhY2sKKyAgICAgICAgYWZ0ZXIgd2UndmUgZGVzdHJ1Y3RlZCBvdXJzZWx2 ZXMuICBBbHNvLCByZW1vdmVkIHNvbWUgdHJpY2t5IG1ldGhvZHMKKyAgICAgICAgdGhhdCBoYWQg bm8gY2xpZW50cy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L093bkhhbmRsZS5oOgorICAgICAg ICAoV2ViQ29yZTo6T3duSGFuZGxlOjpjbGVhcik6CisKIDIwMDktMDktMTEgIEpvY2VseW4gVHVy Y290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvT3duSGFuZGxlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9Pd25IYW5kbGUuaAkocmV2aXNpb24g NDgyODMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L093bkhhbmRsZS5oCSh3b3JraW5nIGNvcHkp CkBAIC00NSwxNSArNDUsMTMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2ODo6SGFu ZGxlPFQ+IGdldCgpIGNvbnN0IHsgcmV0dXJuIG1faGFuZGxlOyB9CiAgICAgICAgIHZvaWQgc2V0 KHY4OjpIYW5kbGU8VD4gaGFuZGxlKSB7IGNsZWFyKCk7IG1faGFuZGxlID0gdjg6OlBlcnNpc3Rl bnQ8VD46Ok5ldyhoYW5kbGUpOyB9CiAKLSAgICAgICAgLy8gRklYTUU6IFdoYXQgaWYgd2UgcmVs ZWFzZSBhIHdlYWsgaGFuZGxlPyAgV29uJ3QgdGhlIGNhbGxiYWNrIGRvIHRoZSB3cm9uZyB0aGlu Zz8KLSAgICAgICAgdjg6OlBlcnNpc3RlbnQ8VD4gcmVsZWFzZSgpIHsgdjg6OlBlcnNpc3RlbnQ8 VD4gcmVzdWx0ID0gbV9oYW5kbGU7IG1faGFuZGxlLkNsZWFyKCk7IHJldHVybiByZXN1bHQ7IH0K LSAgICAgICAgdm9pZCBhZG9wdCh2ODo6UGVyc2lzdGVudDxUPiBoYW5kbGUpIHsgY2xlYXIoKTsg bV9oYW5kbGUgPSBoYW5kbGU7IH0KLQogICAgICAgICAvLyBOb3RlOiBUaGlzIGlzIGNsZWFyIGlu IHRoZSBPd25QdHIgc2Vuc2UsIG5vdCB0aGUgdjg6OkhhbmRsZSBzZW5zZS4KICAgICAgICAgdm9p ZCBjbGVhcigpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmIChtX2hhbmRsZS5Jc0VtcHR5KCkp CiAgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgaWYgKG1faGFuZGxlLklzV2Vh aygpKQorICAgICAgICAgICAgICAgIG1faGFuZGxlLkNsZWFyV2VhaygpOwogICAgICAgICAgICAg bV9oYW5kbGUuRGlzcG9zZSgpOwogICAgICAgICAgICAgbV9oYW5kbGUuQ2xlYXIoKTsKICAgICAg ICAgfQ==