29165 2009-09-10 17:23:54 -0700 Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm 2009-09-11 02:03:10 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Enhancement --- 1 heycam webkit-unassigned commit-queue dglazkov eric oldest_to_newest 146413 0 heycam 2009-09-10 17:23:54 -0700 CodeGeneratorV8.pm has its own copies of WK_ucfirst and WK_lcfirst. It should just call the ones in CodeGenerator.pm instead. 146416 1 39399 heycam 2009-09-10 17:31:16 -0700 Created attachment 39399 Patch v1 I note that the WK_lcfirst in CodeGenerator.pm is different from the one in CodeGeneratorV8.pm. The only case that CodeGeneratorV8 calls WK_lcfirst for is the "URL" attribute on Document (and a couple of other interfaces), so there should be no change in output. I inspected the output of running generate-bindings.pl on Document visually, but didn't build anything to test (I guess I'd need to check out Chromium to do that). 146425 2 39399 eric 2009-09-10 17:55:44 -0700 Comment on attachment 39399 Patch v1 You're a brave man. :) I guess we'll just roll this out if you break the Chromium canary. 146444 3 dglazkov 2009-09-10 20:28:13 -0700 This is a good clean-up. cam++. 146498 4 39399 commit-queue 2009-09-11 02:03:06 -0700 Comment on attachment 39399 Patch v1 Clearing flags on attachment: 39399 Committed r48292: <http://trac.webkit.org/changeset/48292> 146499 5 commit-queue 2009-09-11 02:03:10 -0700 All reviewed patches have been landed. Closing bug. 39399 2009-09-10 17:31:16 -0700 2009-09-11 02:03:05 -0700 Patch v1 29165-v1.patch text/plain 4159 heycam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODI3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMTAgIENhbWVyb24gTWNDb3JtYWNrICA8Y2FtQG1jYy5p ZC5hdT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW1vdmUgZHVwbGljYXRlZCBXS197dSxsfWNmaXJzdCBzdWJzIGZyb20gQ29kZUdlbmVyYXRvclY4 LnBtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE2 NQorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IFJlbW92 ZSBXS191Y2ZpcnN0IGFuZAorICAgICAgICBXS19sY2ZpcnN0LCBhbmQgY2FsbCB0aGUgb25lcyBp biBDb2RlR2VuZXJhdG9yLnBtIGluc3RlYWQuCisKIDIwMDktMDktMDggIEpvaG4gQWJkLUVsLU1h bGVrICA8amFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEds YXprb3YuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0JKHJldmlzaW9uIDQ4MjcxKQorKysgV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JWOC5wbQkod29ya2luZyBjb3B5KQpAQCAtNSw2ICs1LDcgQEAKICMgQ29weXJpZ2h0IChD KSAyMDA2IEFsZXhleSBQcm9za3VyeWFrb3YgPGFwQHdlYmtpdC5vcmc+CiAjIENvcHlyaWdodCAo QykgMjAwNiBBcHBsZSBDb21wdXRlciwgSW5jLgogIyBDb3B5cmlnaHQgKEMpIDIwMDcsIDIwMDgs IDIwMDkgR29vZ2xlIEluYy4KKyMgQ29weXJpZ2h0IChDKSAyMDA5IENhbWVyb24gTWNDb3JtYWNr IDxjYW1AbWNjLmlkLmF1PgogIwogIyBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUgS0RFIHByb2pl Y3QKICMKQEAgLTkwLDI2ICs5MSw2IEBAIHN1YiBsZWZ0U2hpZnQoJCQpIHsKICAgICByZXR1cm4g KCgkdmFsdWUgPDwgJGRpc3RhbmNlKSAmIDB4RkZGRkZGRkYpOwogfQogCi0jIFVwcGVyY2FzZSB0 aGUgZmlyc3QgbGV0dGVyLCB3aGlsZSByZXNwZWN0aW5nIFdlYktpdCBzdHlsZSBndWlkZWxpbmVz LgotIyBFLmcuLCB4bWxFbmNvZGluZyBiZWNvbWVzIFhNTEVuY29kaW5nLCBidXQgeG1sbGxhbmcg YmVjb21lcyBYbWxsYW5nLgotc3ViIFdLX3VjZmlyc3QKLXsKLSAgICBteSAkcGFyYW0gPSBzaGlm dDsKLSAgICBteSAkcmV0ID0gdWNmaXJzdCgkcGFyYW0pOwotICAgICRyZXQgPX4gcy9YbWwvWE1M LyBpZiAkcmV0ID1+IC9eWG1sW15hLXpdLzsKLSAgICByZXR1cm4gJHJldDsKLX0KLQotIyBMb3dl cmNhc2UgdGhlIGZpcnN0IGxldHRlciB3aGlsZSByZXNwZWN0aW5nIFdlYktpdCBzdHlsZSBndWlk ZWxpbmVzLgotIyBVUkwgYmVjb21lcyB1cmwsIGJ1dCBTZXRVUkwgYmVjb21lcyBzZXRVUkwuCi1z dWIgV0tfbGNmaXJzdAotewotICAgIG15ICRwYXJhbSA9IHNoaWZ0OwotICAgIG15ICRyZXQgPSBs Y2ZpcnN0KCRwYXJhbSk7Ci0gICAgJHJldCA9fiBzL3VSTC91cmwvOwotICAgIHJldHVybiAkcmV0 OwotfQotCiAjIFdvcmthcm91bmQgZm9yIFY4IGJpbmRpbmdzIGRpZmZlcmVuY2Ugd2hlcmUgUkdC Q29sb3IgaXMgbm90IGEgUE9EIHR5cGUuCiBzdWIgSXNQb2RUeXBlCiB7CkBAIC01NDksNyArNTMw LDcgQEAgRU5ECiAgICAgICAgICRhdHRyTmFtZSA9ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57InY4cmVmZXJlbmNlYXR0ciJ9OwogICAgIH0KIAotICAgIG15ICRn ZXR0ZXJGdW5jID0gV0tfbGNmaXJzdCgkYXR0ck5hbWUpOworICAgIG15ICRnZXR0ZXJGdW5jID0g JGNvZGVHZW5lcmF0b3ItPldLX2xjZmlyc3QoJGF0dHJOYW1lKTsKICAgICAkZ2V0dGVyRnVuYyAu PSAiQW5pbWF0ZWQiIGlmICRjb2RlR2VuZXJhdG9yLT5Jc1NWR0FuaW1hdGVkVHlwZSgkYXR0cmli dXRlLT5zaWduYXR1cmUtPnR5cGUpOwogCiAgICAgbXkgJHJldHVyblR5cGUgPSBHZXRUeXBlRnJv bVNpZ25hdHVyZSgkYXR0cmlidXRlLT5zaWduYXR1cmUpOwpAQCAtNTg4LDcgKzU2OSw3IEBAIEVO RAogICAgICAgICBteSAkZ2V0dGVyID0gJGdldHRlclN0cmluZzsKICAgICAgICAgJGdldHRlciA9 fiBzL2ltcC0+Ly87CiAgICAgICAgICRnZXR0ZXIgPX4gcy9cKFwpLy87Ci0gICAgICAgIG15ICRz ZXR0ZXIgPSAic2V0IiAuIFdLX3VjZmlyc3QoJGdldHRlcik7CisgICAgICAgIG15ICRzZXR0ZXIg PSAic2V0IiAuICRjb2RlR2VuZXJhdG9yLT5XS191Y2ZpcnN0KCRnZXR0ZXIpOwogCiAgICAgICAg IG15ICRpbXBsQ2xhc3NJc0FuaW1hdGVkVHlwZSA9ICRjb2RlR2VuZXJhdG9yLT5Jc1NWR0FuaW1h dGVkVHlwZSgkaW1wbENsYXNzTmFtZSk7CiAgICAgICAgIGlmIChub3QgJGltcGxDbGFzc0lzQW5p bWF0ZWRUeXBlIGFuZCAkY29kZUdlbmVyYXRvci0+SXNQb2RUeXBlV2l0aFdyaXRlYWJsZVByb3Bl cnRpZXMoJGF0dHJUeXBlKSBhbmQgbm90IGRlZmluZWQgJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW1tdXRhYmxlIn0pIHsKQEAgLTczNCw3ICs3MTUsNyBAQCBF TkQKICAgICBpZiAoJGltcGxDbGFzc05hbWUgZXEgImRvdWJsZSIpIHsKICAgICAgICAgcHVzaChA aW1wbENvbnRlbnREZWNscywgIiAgICAqaW1wID0gJHJlc3VsdDtcbiIpOwogICAgIH0gZWxzZSB7 Ci0gICAgICAgIG15ICRpbXBsU2V0dGVyRnVuY3Rpb25OYW1lID0gV0tfdWNmaXJzdCgkYXR0ck5h bWUpOworICAgICAgICBteSAkaW1wbFNldHRlckZ1bmN0aW9uTmFtZSA9ICRjb2RlR2VuZXJhdG9y LT5XS191Y2ZpcnN0KCRhdHRyTmFtZSk7CiAgICAgICAgIG15ICRyZWZsZWN0ID0gJGF0dHJpYnV0 ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiUmVmbGVjdCJ9OwogICAgICAgICBt eSAkcmVmbGVjdFVSTCA9ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IlJlZmxlY3RVUkwifTsKICAgICAgICAgaWYgKCRyZWZsZWN0IHx8ICRyZWZsZWN0VVJMKSB7 CkBAIC04MDAsNyArNzgxLDcgQEAgc3ViIEdlbmVyYXRlTmV3RnVuY3Rpb25UZW1wbGF0ZQogICAg ICAgICBteSAkY3VzdG9tRnVuYyA9ICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJp YnV0ZXMtPnsiQ3VzdG9tIn0gfHwKICAgICAgICAgICAgICAgICAgICAgICAgICAkZnVuY3Rpb24t PnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4Q3VzdG9tIn07CiAgICAgICAgIGlm ICgkY3VzdG9tRnVuYyBlcSAxKSB7Ci0gICAgICAgICAgICAkY3VzdG9tRnVuYyA9ICRpbnRlcmZh Y2VOYW1lIC4gV0tfdWNmaXJzdCgkbmFtZSk7CisgICAgICAgICAgICAkY3VzdG9tRnVuYyA9ICRp bnRlcmZhY2VOYW1lIC4gJGNvZGVHZW5lcmF0b3ItPldLX3VjZmlyc3QoJG5hbWUpOwogICAgICAg ICB9CiAgICAgICAgIHJldHVybiAidjg6OkZ1bmN0aW9uVGVtcGxhdGU6Ok5ldyhWOEN1c3RvbTo6 djgke2N1c3RvbUZ1bmN9Q2FsbGJhY2ssIHY4OjpIYW5kbGU8djg6OlZhbHVlPigpLCAkc2lnbmF0 dXJlKSI7CiAgICAgfSBlbHNlIHsKQEAgLTk1Myw3ICs5MzQsNyBAQCBzdWIgR2VuZXJhdGVCYXRj aGVkQXR0cmlidXRlRGF0YQogICAgICAgICAgICAgIiI7CiAgICAgICAgIGlmICgkY3VzdG9tQWNj ZXNzb3IgZXEgMSkgewogICAgICAgICAgICAgIyB1c2UgdGhlIG5hbWluZyBjb252ZW5zaW9uLCBp bnRlcmZhY2UgKyAoY2FwaXRhbGl6ZSkgYXR0ciBuYW1lCi0gICAgICAgICAgICAkY3VzdG9tQWNj ZXNzb3IgPSAkaW50ZXJmYWNlTmFtZSAuIFdLX3VjZmlyc3QoJGF0dHJOYW1lKTsKKyAgICAgICAg ICAgICRjdXN0b21BY2Nlc3NvciA9ICRpbnRlcmZhY2VOYW1lIC4gJGNvZGVHZW5lcmF0b3ItPldL X3VjZmlyc3QoJGF0dHJOYW1lKTsKICAgICAgICAgfQogCiAgICAgICAgIG15ICRnZXR0ZXI7Cg==