29164 2009-09-10 17:17:26 -0700 execCommand('removeFormat') adds extra styles inside tables 2010-10-25 17:07:15 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 43017 1 jparent webkit-unassigned hdn michael.vm rniwa oldest_to_newest 146410 0 jparent 2009-09-10 17:17:26 -0700 1. Create a simple table, with a style inside a cell, for example: "<table><tr><td><b>foo</b></td></tr><tr><td>bar</td></tr></table>" 2. Select some styled text, for example: select "foo" 3. document.execCommand('removeFormat', false, null) Result: Extra apple-style-span added with border-spacing styles, for example: <table><tbody><tr><td><span class="Apple-style-span" style="-webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px;">foo</span></td></tr><tr><td>bar</td></tr></tbody></table> Expected Result: Just the b tag is removed, for example: <table><tbody><tr><td>foo</td></tr><tr><td>bar</td></tr></tbody></table> Demo: http://www.plexode.com/cgi-bin/eval3.py#ht=%3Cdiv%20contentEditable%20id%3D'editable'%3E%3Ctable%3E%3Ctr%3E%3Ctd%3E%3Cb%20id%3D'foo'%3Efoo%3C%2Fb%3E%3C%2Ftd%3E%3C%2Ftr%3E%3Ctr%3E%3Ctd%3Ebar%3C%2Ftd%3E%3C%2Ftr%3E%3C%2Ftable%3E%3C%2Fdiv%3E&ohh=1&ohj=1&jt=%2F%2F%20Select%20%22foo%22%0Avar%20rng%20%3D%20document.createRange()%3B%0Arng.setStart(foo.firstChild%2C%200)%3B%0Arng.setEnd(foo.firstChild%2C%20foo.firstChild.length)%3B%0Adocument.getSelection().addRange(rng)%3B%0A%0Adocument.execCommand('removeFormat'%2C%20false%2C%20null)%3B%0Aalert(editable.innerHTML)%3B%0A&ojh=0&ojj=0&ms=100&oth=0&otj=0&cex=1 299107 1 71795 rniwa 2010-10-25 14:29:19 -0700 Created attachment 71795 Patch 299124 2 71795 tony 2010-10-25 15:14:05 -0700 Comment on attachment 71795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71795&action=review > LayoutTests/editing/execCommand/remove-format-in-table-cell.html:8 > +Markup.description('This tests RemoveFormant command "hello". "hello" should be the immediate child of td below and there should be no style attribute.'); Nit: I'm not sure what 'This tests RemoveFormant command "hello".' means. Can you rewrite it? Something like: This tests that RemoveFormat doesn't add extra span tags when inside a table cell. 299193 3 rniwa 2010-10-25 17:03:29 -0700 Thanks for the review! (In reply to comment #2) > (From update of attachment 71795 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71795&action=review > > > LayoutTests/editing/execCommand/remove-format-in-table-cell.html:8 > > +Markup.description('This tests RemoveFormant command "hello". "hello" should be the immediate child of td below and there should be no style attribute.'); > > Nit: I'm not sure what 'This tests RemoveFormant command "hello".' means. Can you rewrite it? Something like: > This tests that RemoveFormat doesn't add extra span tags when inside a table cell. This wasn't intended. Thanks for catching that. Will fix and land. 299198 4 rniwa 2010-10-25 17:07:15 -0700 Committed r70507: <http://trac.webkit.org/changeset/70507> 71795 2010-10-25 14:29:19 -0700 2010-10-25 15:14:05 -0700 Patch bug-29164-20101025142918.patch text/plain 2312 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDkwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMjUgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgZXhlY0NvbW1hbmQoJ3JlbW92ZUZvcm1hdCcpIGFkZHMgZXh0cmEgc3R5bGVzIGlu c2lkZSB0YWJsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI5MTY0CisKKyAgICAgICAgQWRkZWQgYSB0ZXN0IHRvIGVuc3VyZSBSZW1vdmVGb3JtYXQg Y29tbWFuZCBkb2VzIG5vdCBhZGQgZXJyb25lb3VzIHN0eWxlIGF0dHJpYnV0ZQorICAgICAgICB3 aGVuIHJlbW92aW5nIHN0eWxlcyBpbnNpZGUgYSB0YWJsZSBjZWxsLgorCisgICAgICAgICogZWRp dGluZy9leGVjQ29tbWFuZC9yZW1vdmUtZm9ybWF0LWluLXRhYmxlLWNlbGwtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1mb3JtYXQtaW4t dGFibGUtY2VsbC5odG1sOiBBZGRlZC4KKwogMjAxMC0xMC0yNSAgRGltaXRyaSBHbGF6a292ICA8 ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZGVkIG1vcmUgZmxha2luZXNzIGV4 cGVjdGF0aW9ucy4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3Zl LWZvcm1hdC1pbi10YWJsZS1jZWxsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1mb3JtYXQtaW4tdGFibGUtY2VsbC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5k L3JlbW92ZS1mb3JtYXQtaW4tdGFibGUtY2VsbC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsOSBAQAorVGhpcyB0ZXN0cyBSZW1vdmVGb3JtYW50IGNvbW1hbmQgImhlbGxvIi4g ImhlbGxvIiBzaG91bGQgYmUgdGhlIGltbWVkaWF0ZSBjaGlsZCBvZiB0ZCBiZWxvdyBhbmQgdGhl cmUgc2hvdWxkIGJlIG5vIHN0eWxlIGF0dHJpYnV0ZS4KK3wgPHRhYmxlPgorfCAgIDx0Ym9keT4K K3wgICAgIDx0cj4KK3wgICAgICAgPHRkPgorfCAgICAgICAgICI8I3NlbGVjdGlvbi1hbmNob3I+ aGVsbG88I3NlbGVjdGlvbi1mb2N1cz4iCit8ICAgICA8dHI+Cit8ICAgICAgIDx0ZD4KK3wgICAg ICAgICAid29ybGQiCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92 ZS1mb3JtYXQtaW4tdGFibGUtY2VsbC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Vk aXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLWZvcm1hdC1pbi10YWJsZS1jZWxsLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1mb3JtYXQt aW4tdGFibGUtY2VsbC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1IEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2R1 bXAtYXMtbWFya3VwLmpzIj48L3NjcmlwdD4KKzxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0YWJs ZT48dGFibGU+PHRyPjx0ZD48Yj5oZWxsbzwvYj48L3RkPjwvdHI+PHRyPjx0ZD53b3JsZDwvdGQ+ PC90cj48L3RhYmxlPjwvZGl2PgorPHNjcmlwdD4KKworTWFya3VwLmRlc2NyaXB0aW9uKCdUaGlz IHRlc3RzIFJlbW92ZUZvcm1hbnQgY29tbWFuZCAiaGVsbG8iLiAiaGVsbG8iIHNob3VsZCBiZSB0 aGUgaW1tZWRpYXRlIGNoaWxkIG9mIHRkIGJlbG93IGFuZCB0aGVyZSBzaG91bGQgYmUgbm8gc3R5 bGUgYXR0cmlidXRlLicpOword2luZG93LmdldFNlbGVjdGlvbigpLnNlbGVjdEFsbENoaWxkcmVu KGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCdiJylbMF0pOworZG9jdW1lbnQuZXhlY0Nv bW1hbmQoJ1JlbW92ZUZvcm1hdCcsIGZhbHNlLCBudWxsKTsKK01hcmt1cC5kdW1wKCd0ZXN0Jyk7 CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=