29163 2009-09-10 17:17:19 -0700 [REGRESSION] Style deletions are not commited 2009-09-16 14:39:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P2 Normal --- 1 rik yurys commit-queue pfeldman timothy yurys oldest_to_newest 146409 0 rik 2009-09-10 17:17:19 -0700 In r48199, style deletions in the inspector are not commited. Step to reproduce: 1) Select a node 2) Delete a style by emptying it Expected result: Style deleted. Actual result: The change seems done in the inspector but no change on the page. Plus, if you select another node and come back to the first node, you'll see the style you removed. 147268 1 39593 yurys 2009-09-15 03:00:19 -0700 Created attachment 39593 patch 147627 2 39593 commit-queue 2009-09-16 14:39:04 -0700 Comment on attachment 39593 patch Clearing flags on attachment: 39593 Committed r48437: <http://trac.webkit.org/changeset/48437> 147628 3 commit-queue 2009-09-16 14:39:08 -0700 All reviewed patches have been landed. Closing bug. 39593 2009-09-15 03:00:19 -0700 2009-09-16 14:39:04 -0700 patch empty-style.patch text/plain 4620 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWIyYWQ2Mi4uYjAxNzYzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wOS0xNSAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgc3R5bGUgcHJvcGVydHkgaWYgZW1wdHkgc3RyaW5n IGlzIGVudGVyZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI5MTYzCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJl ZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5w cm90b3R5cGUuX29ubW91c2VvdXQpOiBmaXhlZCBudWxsIHBvaW50ZXIgZXhjZXB0aW9uCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qczoKKyAgICAgICAgKElu amVjdGVkU2NyaXB0LmFwcGx5U3R5bGVUZXh0KTogaWYgc3R5bGV0ZXh0IHRvIGFwcGx5IGlzIGVt cHR5IGl0IHdpbGwgcmV0dXJuIGFuIGFycmF5IHRvIGNvbmZpcm0gdGhlIHByb3BlcnR5IHJlbW92 YWwKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUu KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90 eXBlKToKKwogMjAwOS0wOS0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBGaXggdGhlIGNoYW5nZSBpbiByNDgzNzYgdG8gZG8gYSBudWxsLWNoZWNr IHRvIGZpeCBhIGNyYXNoaW5nIHRlc3QuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IGE1NTU0N2YuLjA4YmExYzIgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz CisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz CkBAIC0yMjUsNyArMjI1LDcgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUucHJv dG90eXBlID0gewogICAgIF9vbm1vdXNlb3V0OiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAg ICAgIHZhciBub2RlVW5kZXJNb3VzZSA9IGRvY3VtZW50LmVsZW1lbnRGcm9tUG9pbnQoZXZlbnQu cGFnZVgsIGV2ZW50LnBhZ2VZKTsKLSAgICAgICAgaWYgKG5vZGVVbmRlck1vdXNlLmlzRGVzY2Vu ZGFudCh0aGlzLmVsZW1lbnQpKQorICAgICAgICBpZiAobm9kZVVuZGVyTW91c2UgJiYgbm9kZVVu ZGVyTW91c2UuaXNEZXNjZW5kYW50KHRoaXMuZWxlbWVudCkpCiAgICAgICAgICAgICByZXR1cm47 CiAKICAgICAgICAgaWYgKHRoaXMuX3ByZXZpb3VzSG92ZXJlZEVsZW1lbnQpIHsKZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwppbmRleCAyYWE4ODAwLi4w MDNlNjk0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRT Y3JpcHQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0 LmpzCkBAIC0xMTIsNiArMTEyLDEwIEBAIEluamVjdGVkU2NyaXB0LmFwcGx5U3R5bGVUZXh0ID0g ZnVuY3Rpb24oc3R5bGVJZCwgc3R5bGVUZXh0LCBwcm9wZXJ0eU5hbWUpCiAgICAgICAgICAgICBz dHlsZS5yZW1vdmVQcm9wZXJ0eShwcm9wZXJ0eU5hbWUpOwogICAgIH0KIAorICAgIC8vIE5vdGlm eSBjYWxsZXIgdGhhdCB0aGUgcHJvcGVydHkgd2FzIHN1Y2Nlc3NmdWxseSBkZWxldGVkLgorICAg IGlmICghc3R5bGVUZXh0TGVuZ3RoKQorICAgICAgICByZXR1cm4gW251bGwsIFtwcm9wZXJ0eU5h bWVdXTsKKwogICAgIGlmICghdGVtcFN0eWxlLmxlbmd0aCkKICAgICAgICAgcmV0dXJuIGZhbHNl OwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJh clBhbmUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUu anMKaW5kZXggNDU1MWFkNi4uNjE4NWFmZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwpAQCAtMTMxNiwxNyArMTMxNiwxNCBAQCBXZWJJ bnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAg dmFyIHNlY3Rpb24gPSB0aGlzLnRyZWVPdXRsaW5lLnNlY3Rpb247CiAgICAgICAgIHZhciBlbGVt ZW50c1BhbmVsID0gV2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50czsKICAgICAgICAgdmFyIHN0 eWxlVGV4dExlbmd0aCA9IHN0eWxlVGV4dC50cmltV2hpdGVzcGFjZSgpLmxlbmd0aDsKLSAgICAg ICAgaWYgKCFzdHlsZVRleHRMZW5ndGgpIHsKLSAgICAgICAgICAgIGlmICh1cGRhdGVJbnRlcmZh Y2UpIHsKKyAgICAgICAgaWYgKCFzdHlsZVRleHRMZW5ndGggJiYgdXBkYXRlSW50ZXJmYWNlKSB7 CisgICAgICAgICAgICBpZiAodGhpcy5fbmV3UHJvcGVydHkpIHsKICAgICAgICAgICAgICAgICAv LyBUaGUgdXNlciBkZWxldGVkIGV2ZXJ5dGhpbmcsIHNvIHJlbW92ZSB0aGUgdHJlZSBlbGVtZW50 IGFuZCB1cGRhdGUuCi0gICAgICAgICAgICAgICAgaWYgKCF0aGlzLl9uZXdQcm9wZXJ0eSkKLSAg ICAgICAgICAgICAgICAgICAgZGVsZXRlIHNlY3Rpb24uX2FmdGVyVXBkYXRlOwotICAgICAgICAg ICAgICAgIGlmIChzZWN0aW9uICYmIHNlY3Rpb24ucGFuZSkKLSAgICAgICAgICAgICAgICAgICAg c2VjdGlvbi5wYW5lLnVwZGF0ZSgpOwogICAgICAgICAgICAgICAgIHRoaXMucGFyZW50LnJlbW92 ZUNoaWxkKHRoaXMpOwotICAgICAgICAgICAgICAgIGVsZW1lbnRzUGFuZWwucmVtb3ZlU3R5bGVD aGFuZ2Uoc2VjdGlvbi5pZGVudGlmaWVyLCB0aGlzLnN0eWxlLCB0aGlzLm5hbWUpOworICAgICAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAg ZGVsZXRlIHNlY3Rpb24uX2FmdGVyVXBkYXRlOwogICAgICAgICAgICAgfQotICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICB9CiAKICAgICAgICAgdmFyIHNlbGYgPSB0aGlzOwpAQCAtMTM0OSwx MCArMTM0NiwxNiBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3Rv dHlwZSA9IHsKICAgICAgICAgICAgIHZhciBjaGFuZ2VkUHJvcGVydGllcyA9IHJlc3VsdFsxXTsK ICAgICAgICAgICAgIGVsZW1lbnRzUGFuZWwucmVtb3ZlU3R5bGVDaGFuZ2Uoc2VjdGlvbi5pZGVu dGlmaWVyLCBzZWxmLnN0eWxlLCBzZWxmLm5hbWUpOwogCi0gICAgICAgICAgICBzZWxmLnN0eWxl ID0gV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb24ucGFyc2VTdHlsZShuZXdQYXlsb2Fk KTsKLSAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgY2hhbmdlZFByb3BlcnRpZXMubGVu Z3RoOyArK2kpCi0gICAgICAgICAgICAgICAgZWxlbWVudHNQYW5lbC5hZGRTdHlsZUNoYW5nZShz ZWN0aW9uLmlkZW50aWZpZXIsIHNlbGYuc3R5bGUsIGNoYW5nZWRQcm9wZXJ0aWVzW2ldKTsKLSAg ICAgICAgICAgIHNlbGYuX3N0eWxlUnVsZS5zdHlsZSA9IHNlbGYuc3R5bGU7CisgICAgICAgICAg ICBpZiAoIXN0eWxlVGV4dExlbmd0aCkgeworICAgICAgICAgICAgICAgIC8vIERvIHJlbW92ZSBv dXJzZWx2ZXMgZnJvbSBVSSB3aGVuIHRoZSBwcm9wZXJ0eSByZW1vdmFsIGlzIGNvbmZpcm1lZC4K KyAgICAgICAgICAgICAgICBzZWxmLnBhcmVudC5yZW1vdmVDaGlsZChzZWxmKTsKKyAgICAgICAg ICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgc2VsZi5zdHlsZSA9IFdlYkluc3BlY3Rvci5D U1NTdHlsZURlY2xhcmF0aW9uLnBhcnNlU3R5bGUobmV3UGF5bG9hZCk7CisgICAgICAgICAgICAg ICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjaGFuZ2VkUHJvcGVydGllcy5sZW5ndGg7ICsraSkKKyAg ICAgICAgICAgICAgICAgICAgZWxlbWVudHNQYW5lbC5hZGRTdHlsZUNoYW5nZShzZWN0aW9uLmlk ZW50aWZpZXIsIHNlbGYuc3R5bGUsIGNoYW5nZWRQcm9wZXJ0aWVzW2ldKTsKKyAgICAgICAgICAg ICAgICBzZWxmLl9zdHlsZVJ1bGUuc3R5bGUgPSBzZWxmLnN0eWxlOworICAgICAgICAgICAgfQor CiAgICAgICAgICAgICBpZiAoc2VjdGlvbiAmJiBzZWN0aW9uLnBhbmUpCiAgICAgICAgICAgICAg ICAgc2VjdGlvbi5wYW5lLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycygic3R5bGUgZWRpdGVkIik7 CiAK