29152 2009-09-10 14:35:18 -0700 [v8] inline WebCore::v8String 2009-09-11 07:47:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 antonm webkit-unassigned commit-queue eric oldest_to_newest 146342 0 antonm 2009-09-10 14:35:18 -0700 Inline WebCore::v8String---it's short enough. 146349 1 39383 antonm 2009-09-10 14:48:55 -0700 Created attachment 39383 First pass 146377 2 39383 commit-queue 2009-09-10 15:49:36 -0700 Comment on attachment 39383 First pass Rejecting patch 39383 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39383 from bug 29152 failed to download and apply. 146385 3 eric 2009-09-10 16:15:16 -0700 Looks like this patch does not have full paths in it. Make sure you use svn-create-patch to create your patches. Although it's possible you're hitting bug 29112. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: bindings/v8/V8Binding.cpp |=================================================================== |--- bindings/v8/V8Binding.cpp (revision 48239) |+++ bindings/v8/V8Binding.cpp (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: bindings/v8/V8Binding.h |=================================================================== |--- bindings/v8/V8Binding.h (revision 48239) |+++ bindings/v8/V8Binding.h (working copy) -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored 146528 4 39424 antonm 2009-09-11 05:46:02 -0700 Created attachment 39424 Hopefully right paths 146529 5 antonm 2009-09-11 05:49:21 -0700 (In reply to comment #3) > Looks like this patch does not have full paths in it. Make sure you use > svn-create-patch to create your patches. Although it's possible you're hitting > bug 29112. > > can't find file to patch at input line 5 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > |Index: bindings/v8/V8Binding.cpp > |=================================================================== > |--- bindings/v8/V8Binding.cpp (revision 48239) > |+++ bindings/v8/V8Binding.cpp (working copy) > -------------------------- > No file to patch. Skipping patch. > 1 out of 1 hunk ignored > can't find file to patch at input line 5 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > |Index: bindings/v8/V8Binding.h > |=================================================================== > |--- bindings/v8/V8Binding.h (revision 48239) > |+++ bindings/v8/V8Binding.h (working copy) > -------------------------- > No file to patch. Skipping patch. > 2 out of 2 hunks ignored Eric, I do use svn-create-patch (in Chromium tree, on MacOS, with WebKitTools, separate WebKit checkout) and that's exactly the way it creates patches. I raised this issue one, but currently don't have time to fix it myself. This patch was produced with plain svn diff and, hopefully, has correct paths. 146557 6 39424 commit-queue 2009-09-11 07:47:39 -0700 Comment on attachment 39424 Hopefully right paths Clearing flags on attachment: 39424 Committed r48301: <http://trac.webkit.org/changeset/48301> 146558 7 commit-queue 2009-09-11 07:47:46 -0700 All reviewed patches have been landed. Closing bug. 39383 2009-09-10 14:48:55 -0700 2009-09-11 05:46:02 -0700 First pass WebCore.patch text/plain 2138 antonm SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ4MjY2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDkt MTAgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmxpbmUgV2ViQ29yZTo6djhTdHJpbmcg YXMgaXQgb25seSBpbnZva2VzIFdlYkNvcmU6OnY4RXh0ZXJuYWxTdHJpbmcuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE1MgorCisgICAgICAgICog YmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRp bmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OnY4U3RyaW5nKToKKwogMjAwOS0wOS0xMCAgQ2FtZXJv biBNY0Nvcm1hY2sgIDxjYW1AbWNjLmlkLmF1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpJbmRleDogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBi aW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCShyZXZpc2lvbiA0ODIzOSkKKysrIGJpbmRpbmdzL3Y4 L1Y4QmluZGluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNiwxMSArMjE2LDYgQEAgQXRvbWlj U3RyaW5nIHY4Tm9uU3RyaW5nVmFsdWVUb0F0b21pY1dlYgogICAgIHJldHVybiBBdG9taWNTdHJp bmcodjhOb25TdHJpbmdWYWx1ZVRvV2ViQ29yZVN0cmluZyhvYmplY3QpKTsKIH0KIAotdjg6Okhh bmRsZTx2ODo6U3RyaW5nPiB2OFN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZykKLXsKLSAgICBy ZXR1cm4gdjhFeHRlcm5hbFN0cmluZyhzdHJpbmcpOwotfQotCiBzdGF0aWMgYm9vbCBzdHJpbmdJ bXBsQ2FjaGVFbmFibGVkID0gZmFsc2U7CiAKIHZvaWQgZW5hYmxlU3RyaW5nSW1wbENhY2hlKCkK SW5kZXg6IGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGJpbmRpbmdzL3Y4 L1Y4QmluZGluZy5oCShyZXZpc2lvbiA0ODIzOSkKKysrIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5o CSh3b3JraW5nIGNvcHkpCkBAIC02MSw5ICs2MSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAg ICAgICAgcmV0dXJuIHY4Tm9uU3RyaW5nVmFsdWVUb0F0b21pY1dlYkNvcmVTdHJpbmcodmFsdWUp OwogICAgIH0KIAotICAgIC8vIENvbnZlcnQgYSBzdHJpbmcgdG8gYSBWOCBzdHJpbmcuCi0gICAg djg6OkhhbmRsZTx2ODo6U3RyaW5nPiB2OFN0cmluZyhjb25zdCBTdHJpbmcmKTsKLQogICAgIGlu bGluZSBTdHJpbmcgdG9TdHJpbmcoY29uc3QgU3RyaW5nJiBzdHJpbmcpCiAgICAgewogICAgICAg ICByZXR1cm4gc3RyaW5nOwpAQCAtNzQsNiArNzEsMTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgIC8vIHVuZGVybHlpbmcgYnVmZmVyIGFsaXZlIHdoaWxlIHRoZSBzdHJpbmcgaXMgc3RpbGwg bGl2ZSBpbiB0aGUgVjggZW5naW5lLgogICAgIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiB2OEV4dGVy bmFsU3RyaW5nKGNvbnN0IFN0cmluZyYpOwogCisgICAgLy8gQ29udmVydCBhIHN0cmluZyB0byBh IFY4IHN0cmluZy4KKyAgICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiB2OFN0cmluZyhj b25zdCBTdHJpbmcmIHN0cmluZykKKyAgICB7CisgICAgICAgIHJldHVybiB2OEV4dGVybmFsU3Ry aW5nKHN0cmluZyk7CisgICAgfQorCiAgICAgLy8gRW5hYmxlcyBjYWNoaW5nIHY4IHdyYXBwZXJz IGNyZWF0ZWQgZm9yIFdlYkNvcmU6OlN0cmluZ0ltcGwuICBDdXJyZW50bHkgdGhpcyBjYWNoZSBy ZXF1aXJlcwogICAgIC8vIGFsbCB0aGUgY2FsbHMgKGJvdGggdG8gY29udmVydCBXZWJDb3JlOjpT dHJpbmcgdG8gdjg6OlN0cmluZyBhbmQgdG8gR0MgdGhlIGhhbmRsZSkKICAgICAvLyB0byBiZSBw ZXJmb3JtZWQgb24gdGhlIG1haW4gdGhyZWFkLgo= 39424 2009-09-11 05:46:02 -0700 2009-09-11 07:47:38 -0700 Hopefully right paths WebCore.patch text/plain 2129 antonm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODI2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDktMTAgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bmxpbmUgV2ViQ29yZTo6djhTdHJpbmcgYXMgaXQgb25seSBpbnZva2VzIFdlYkNvcmU6OnY4RXh0 ZXJuYWxTdHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yOTE1MgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcDoKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OnY4U3RyaW5n KToKKwogMjAwOS0wOS0xMCAgQ2FtZXJvbiBNY0Nvcm1hY2sgIDxjYW1AbWNjLmlkLmF1PgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k aW5nLmNwcAkocmV2aXNpb24gNDgyMzkpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGlu Zy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNiwxMSArMjE2LDYgQEAKICAgICByZXR1cm4gQXRv bWljU3RyaW5nKHY4Tm9uU3RyaW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcob2JqZWN0KSk7CiB9CiAK LXY4OjpIYW5kbGU8djg6OlN0cmluZz4gdjhTdHJpbmcoY29uc3QgU3RyaW5nJiBzdHJpbmcpCi17 Ci0gICAgcmV0dXJuIHY4RXh0ZXJuYWxTdHJpbmcoc3RyaW5nKTsKLX0KLQogc3RhdGljIGJvb2wg c3RyaW5nSW1wbENhY2hlRW5hYmxlZCA9IGZhbHNlOwogCiB2b2lkIGVuYWJsZVN0cmluZ0ltcGxD YWNoZSgpCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgJKHJldmlzaW9uIDQ4MjM5KQorKysg V2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsOSAr NjEsNiBAQAogICAgICAgICByZXR1cm4gdjhOb25TdHJpbmdWYWx1ZVRvQXRvbWljV2ViQ29yZVN0 cmluZyh2YWx1ZSk7CiAgICAgfQogCi0gICAgLy8gQ29udmVydCBhIHN0cmluZyB0byBhIFY4IHN0 cmluZy4KLSAgICB2ODo6SGFuZGxlPHY4OjpTdHJpbmc+IHY4U3RyaW5nKGNvbnN0IFN0cmluZyYp OwotCiAgICAgaW5saW5lIFN0cmluZyB0b1N0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZykKICAg ICB7CiAgICAgICAgIHJldHVybiBzdHJpbmc7CkBAIC03NCw2ICs3MSwxMiBAQAogICAgIC8vIHVu ZGVybHlpbmcgYnVmZmVyIGFsaXZlIHdoaWxlIHRoZSBzdHJpbmcgaXMgc3RpbGwgbGl2ZSBpbiB0 aGUgVjggZW5naW5lLgogICAgIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiB2OEV4dGVybmFsU3RyaW5n KGNvbnN0IFN0cmluZyYpOwogCisgICAgLy8gQ29udmVydCBhIHN0cmluZyB0byBhIFY4IHN0cmlu Zy4KKyAgICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiB2OFN0cmluZyhjb25zdCBTdHJp bmcmIHN0cmluZykKKyAgICB7CisgICAgICAgIHJldHVybiB2OEV4dGVybmFsU3RyaW5nKHN0cmlu Zyk7CisgICAgfQorCiAgICAgLy8gRW5hYmxlcyBjYWNoaW5nIHY4IHdyYXBwZXJzIGNyZWF0ZWQg Zm9yIFdlYkNvcmU6OlN0cmluZ0ltcGwuICBDdXJyZW50bHkgdGhpcyBjYWNoZSByZXF1aXJlcwog ICAgIC8vIGFsbCB0aGUgY2FsbHMgKGJvdGggdG8gY29udmVydCBXZWJDb3JlOjpTdHJpbmcgdG8g djg6OlN0cmluZyBhbmQgdG8gR0MgdGhlIGhhbmRsZSkKICAgICAvLyB0byBiZSBwZXJmb3JtZWQg b24gdGhlIG1haW4gdGhyZWFkLgo=