29150 2009-09-10 14:06:06 -0700 [v8] create a real handler to JS objects when returning strings from StringImplCache 2009-09-11 10:21:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 antonm webkit-unassigned ager commit-queue eric oldest_to_newest 146329 0 antonm 2009-09-10 14:06:06 -0700 Currently, just a wrapper is created (v8::Local<v8::String>(pointer)) which won't save the object being handled if GC would happen (to be more precise, one mark flavours). Let's use a proper local handle instead. 146330 1 39376 antonm 2009-09-10 14:11:26 -0700 Created attachment 39376 First pass 146351 2 39376 abarth 2009-09-10 14:50:43 -0700 Comment on attachment 39376 First pass I don't fully understand the V8 garbage collector, but this seems reasonable and I believe that you know what you're doing. :) 146355 3 39376 abarth 2009-09-10 14:55:21 -0700 Comment on attachment 39376 First pass I forgot that you aren't a committer yet. 146376 4 39376 commit-queue 2009-09-10 15:49:20 -0700 Comment on attachment 39376 First pass Rejecting patch 39376 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39376 from bug 29150 failed to download and apply. 146384 5 eric 2009-09-10 16:13:17 -0700 Looks like somehow this patch is not from the root: can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: bindings/v8/V8Binding.cpp |=================================================================== |--- bindings/v8/V8Binding.cpp (revision 48239) |+++ bindings/v8/V8Binding.cpp (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored 146464 6 ager 2009-09-10 23:24:48 -0700 Looks good to me as well. Good catch Anton. 146530 7 39425 antonm 2009-09-11 05:52:57 -0700 Created attachment 39425 Hopefully right paths Same story as with inlining patch. Sorry all for inconvenience. 146559 8 39425 commit-queue 2009-09-11 07:52:22 -0700 Comment on attachment 39425 Hopefully right paths Rejecting patch 39425 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 146565 9 antonm 2009-09-11 08:11:54 -0700 (In reply to comment #8) > (From update of attachment 39425 [details]) > Rejecting patch 39425 from commit-queue. > > This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', > '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit > code 1 what should I do? svn update and merge? tia, anton. 146571 10 39425 abarth 2009-09-11 08:28:37 -0700 Comment on attachment 39425 Hopefully right paths This is likely a flaky test. Let's try again. 146596 11 eric 2009-09-11 09:21:08 -0700 Bitten by bug 28845. :( compositing/color-matching/image-color-matching.html -> timed out 146614 12 39425 commit-queue 2009-09-11 09:47:14 -0700 Comment on attachment 39425 Hopefully right paths Rejecting patch 39425 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 146618 13 39425 eric 2009-09-11 10:01:36 -0700 Comment on attachment 39425 Hopefully right paths Just your lucky day. :( Bug 28845 again! compositing/self-painting-layers.html -> crashed 146623 14 39425 commit-queue 2009-09-11 10:20:48 -0700 Comment on attachment 39425 Hopefully right paths Clearing flags on attachment: 39425 Committed r48305: <http://trac.webkit.org/changeset/48305> 146624 15 commit-queue 2009-09-11 10:21:01 -0700 All reviewed patches have been landed. Closing bug. 39376 2009-09-10 14:11:26 -0700 2009-09-11 05:52:57 -0700 First pass webcore.patch text/plain 1208 antonm SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ4MjY1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDkt MTAgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmVhdGUgYSByZWFsIGhhbmRsZSAob25l IHdoaWNoIHdvdWxkIHNhdmUgYW4gb2JqZWN0IGZyb20gR0MpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkxNTAKKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2OEV4dGVybmFsU3RyaW5nKToK KwogMjAwOS0wOS0xMCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNv bGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXogYW5kIERhbiBX aW5zaGlwLgpJbmRleDogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBi aW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCShyZXZpc2lvbiA0ODIzOSkKKysrIGJpbmRpbmdzL3Y4 L1Y4QmluZGluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2OSw3ICsyNjksNyBAQCB2ODo6TG9j YWw8djg6OlN0cmluZz4gdjhFeHRlcm5hbFN0cmluZyhjCiAgICAgU3RyaW5nQ2FjaGUmIHN0cmlu Z0NhY2hlID0gZ2V0U3RyaW5nQ2FjaGUoKTsKICAgICB2ODo6U3RyaW5nKiBjYWNoZWRWOFN0cmlu ZyA9IHN0cmluZ0NhY2hlLmdldChzdHJpbmdJbXBsKTsKICAgICBpZiAoY2FjaGVkVjhTdHJpbmcp Ci0gICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6OlN0cmluZz4oY2FjaGVkVjhTdHJpbmcpOwor ICAgICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpTdHJpbmc+OjpOZXcodjg6OkhhbmRsZTx2ODo6 U3RyaW5nPihjYWNoZWRWOFN0cmluZykpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5l d1N0cmluZyA9IG1ha2VFeHRlcm5hbFN0cmluZyhzdHJpbmcpOwogICAgIGlmIChuZXdTdHJpbmcu SXNFbXB0eSgpKQo= 39425 2009-09-11 05:52:57 -0700 2009-09-11 10:20:48 -0700 Hopefully right paths WebCore.patch text/plain 1215 antonm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMTAgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD cmVhdGUgYSByZWFsIGhhbmRsZSAob25lIHdoaWNoIHdvdWxkIHNhdmUgYW4gb2JqZWN0IGZyb20g R0MpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjkx NTAKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJD b3JlOjp2OEV4dGVybmFsU3RyaW5nKToKKwogMjAwOS0wOS0xMCAgR3VzdGF2byBOb3JvbmhhIFNp bHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdl ZCBieSBYYW4gTG9wZXogYW5kIERhbiBXaW5zaGlwLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k aW5nLmNwcAkocmV2aXNpb24gNDgyMzkpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGlu Zy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2OSw3ICsyNjksNyBAQAogICAgIFN0cmluZ0NhY2hl JiBzdHJpbmdDYWNoZSA9IGdldFN0cmluZ0NhY2hlKCk7CiAgICAgdjg6OlN0cmluZyogY2FjaGVk VjhTdHJpbmcgPSBzdHJpbmdDYWNoZS5nZXQoc3RyaW5nSW1wbCk7CiAgICAgaWYgKGNhY2hlZFY4 U3RyaW5nKQotICAgICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpTdHJpbmc+KGNhY2hlZFY4U3Ry aW5nKTsKKyAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6U3RyaW5nPjo6TmV3KHY4OjpIYW5k bGU8djg6OlN0cmluZz4oY2FjaGVkVjhTdHJpbmcpKTsKIAogICAgIHY4OjpMb2NhbDx2ODo6U3Ry aW5nPiBuZXdTdHJpbmcgPSBtYWtlRXh0ZXJuYWxTdHJpbmcoc3RyaW5nKTsKICAgICBpZiAobmV3 U3RyaW5nLklzRW1wdHkoKSkK