29148 2009-09-10 13:54:02 -0700 replace platform time code with WTF::currentTime() 2009-09-24 15:01:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yong.li.webkit webkit-unassigned commit-queue darin eric joenotcharles laszlo.gombos manyoso mjs staikos oldest_to_newest 146323 0 yong.li.webkit 2009-09-10 13:54:02 -0700 We have WTF::currentTime() now. We should use it to replace those duplicate platform-dependent code. 1. In TimeoutChecker.cpp: getCPUTime currently returns system time except for PLATFORM(DARWIN) and PLATFORM(WIN_OS) (they can get actual thread time) 2. jsc.cpp: a lot of time related code can be simplified with currentTime() Patch is coming 146363 1 39385 yong.li.webkit 2009-09-10 15:13:05 -0700 Created attachment 39385 the patch the patch 146531 2 39385 ariya.hidayat 2009-09-11 06:21:08 -0700 Comment on attachment 39385 the patch CurrentTime.h is missing in the patch. 146544 3 yong.li.webkit 2009-09-11 07:04:26 -0700 (In reply to comment #2) > (From update of attachment 39385 [details]) > CurrentTime.h is missing in the patch. What do you mean? CurrentTime.h already exists in JavaScriptCore/wtf. 146678 4 joenotcharles 2009-09-11 11:41:50 -0700 I believe that in the current codebase, currentTime() is only ever used to check relative times, even though the descriptions specifies that it should return seconds since the Unix epoch. That could let ports take shortcuts by implementing it to return seconds since some other epoch, or since the system boot, or whatever's easiest for them. I don't know if any ports actually DO take such shortcuts, but this should be double-checked if this patch is landed. I was about to suggest renaming currentTime and changing the description to make it clear the way it was actually used, but I like this approach better. No need to duplicate code. 149657 5 39385 abarth 2009-09-23 22:24:30 -0700 Comment on attachment 39385 the patch I'm not an expert here, but this seems reasonable and this patch has been setting in the review queue for a while with little discussion. 149817 6 eric 2009-09-24 13:44:46 -0700 Looks reasonable to me too. CCing Darin and Maciej who I believe worked on this code long ago, so that they at least see this go by. 149846 7 39385 commit-queue 2009-09-24 14:31:40 -0700 Comment on attachment 39385 the patch Rejecting patch 39385 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 149847 8 39385 eric 2009-09-24 14:33:34 -0700 Comment on attachment 39385 the patch Sigh. Bug 28316, sorry. 149856 9 39385 commit-queue 2009-09-24 15:00:54 -0700 Comment on attachment 39385 the patch Clearing flags on attachment: 39385 Committed r48736: <http://trac.webkit.org/changeset/48736> 149857 10 commit-queue 2009-09-24 15:01:00 -0700 All reviewed patches have been landed. Closing bug. 39385 2009-09-10 15:13:05 -0700 2009-09-24 15:00:54 -0700 the patch 29148.patch text/plain 3840 yong.li.webkit ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1NTEzYjQxLi5lM2EwNmNjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMDktMDktMTAgIFlvbmcgTGkgIDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlIHBsYXRm b3JtLWRlcGVuZGVudCBjb2RlIHdpdGggV1RGOjpjdXJyZW50VGltZSgpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE0OAorCisgICAgICAgICoganNj LmNwcDoKKyAgICAgICAgKFN0b3BXYXRjaDo6c3RhcnQpOgorICAgICAgICAoU3RvcFdhdGNoOjpz dG9wKToKKyAgICAgICAgKFN0b3BXYXRjaDo6Z2V0RWxhcHNlZE1TKToKKyAgICAgICAgKiBydW50 aW1lL1RpbWVvdXRDaGVja2VyLmNwcDoKKyAgICAgICAgKEpTQzo6Z2V0Q1BVVGltZSk6CisKIDIw MDktMDktMTAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKEJ1aWxkIGZpeCkuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9q c2MuY3BwIGIvSmF2YVNjcmlwdENvcmUvanNjLmNwcAppbmRleCA5MmIxZTU4Li5lZTRlMzkzIDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL2pz Yy5jcHAKQEAgLTI0LDYgKzI0LDcgQEAKIAogI2luY2x1ZGUgIkJ5dGVjb2RlR2VuZXJhdG9yLmgi CiAjaW5jbHVkZSAiQ29tcGxldGlvbi5oIgorI2luY2x1ZGUgIkN1cnJlbnRUaW1lLmgiCiAjaW5j bHVkZSAiSW5pdGlhbGl6ZVRocmVhZGluZy5oIgogI2luY2x1ZGUgIkpTQXJyYXkuaCIKICNpbmNs dWRlICJKU0Z1bmN0aW9uLmgiCkBAIC0xMTgsNTMgKzExOSwyMyBAQCBwdWJsaWM6CiAgICAgbG9u ZyBnZXRFbGFwc2VkTVMoKTsgLy8gY2FsbCBzdG9wKCkgZmlyc3QKIAogcHJpdmF0ZToKLSNpZiBQ TEFURk9STShRVCkKLSAgICB1aW50IG1fc3RhcnRUaW1lOwotICAgIHVpbnQgbV9zdG9wVGltZTsK LSNlbGlmIFBMQVRGT1JNKFdJTl9PUykKLSAgICBEV09SRCBtX3N0YXJ0VGltZTsKLSAgICBEV09S RCBtX3N0b3BUaW1lOwotI2Vsc2UKLSAgICAvLyBXaW5kb3dzIGRvZXMgbm90IGhhdmUgdGltZXZh bCwgZGlzYWJsaW5nIHRoaXMgY2xhc3MgZm9yIG5vdyAoYnVnIDczOTkpCi0gICAgdGltZXZhbCBt X3N0YXJ0VGltZTsKLSAgICB0aW1ldmFsIG1fc3RvcFRpbWU7Ci0jZW5kaWYKKyAgICBkb3VibGUg bV9zdGFydFRpbWU7CisgICAgZG91YmxlIG1fc3RvcFRpbWU7CiB9OwogCiB2b2lkIFN0b3BXYXRj aDo6c3RhcnQoKQogewotI2lmIFBMQVRGT1JNKFFUKQotICAgIFFEYXRlVGltZSB0ID0gUURhdGVU aW1lOjpjdXJyZW50RGF0ZVRpbWUoKTsKLSAgICBtX3N0YXJ0VGltZSA9IHQudG9UaW1lX3QoKSAq IDEwMDAgKyB0LnRpbWUoKS5tc2VjKCk7Ci0jZWxpZiBQTEFURk9STShXSU5fT1MpCi0gICAgbV9z dGFydFRpbWUgPSB0aW1lR2V0VGltZSgpOwotI2Vsc2UKLSAgICBnZXR0aW1lb2ZkYXkoJm1fc3Rh cnRUaW1lLCAwKTsKLSNlbmRpZgorICAgIG1fc3RhcnRUaW1lID0gY3VycmVudFRpbWUoKTsKIH0K IAogdm9pZCBTdG9wV2F0Y2g6OnN0b3AoKQogewotI2lmIFBMQVRGT1JNKFFUKQotICAgIFFEYXRl VGltZSB0ID0gUURhdGVUaW1lOjpjdXJyZW50RGF0ZVRpbWUoKTsKLSAgICBtX3N0b3BUaW1lID0g dC50b1RpbWVfdCgpICogMTAwMCArIHQudGltZSgpLm1zZWMoKTsKLSNlbGlmIFBMQVRGT1JNKFdJ Tl9PUykKLSAgICBtX3N0b3BUaW1lID0gdGltZUdldFRpbWUoKTsKLSNlbHNlCi0gICAgZ2V0dGlt ZW9mZGF5KCZtX3N0b3BUaW1lLCAwKTsKLSNlbmRpZgorICAgIG1fc3RvcFRpbWUgPSBjdXJyZW50 VGltZSgpOwogfQogCiBsb25nIFN0b3BXYXRjaDo6Z2V0RWxhcHNlZE1TKCkKIHsKLSNpZiBQTEFU Rk9STShXSU5fT1MpIHx8IFBMQVRGT1JNKFFUKQotICAgIHJldHVybiBtX3N0b3BUaW1lIC0gbV9z dGFydFRpbWU7Ci0jZWxzZQotICAgIHRpbWV2YWwgZWxhcHNlZFRpbWU7Ci0gICAgdGltZXJzdWIo Jm1fc3RvcFRpbWUsICZtX3N0YXJ0VGltZSwgJmVsYXBzZWRUaW1lKTsKLQotICAgIHJldHVybiBl bGFwc2VkVGltZS50dl9zZWMgKiAxMDAwICsgbHJvdW5kZihlbGFwc2VkVGltZS50dl91c2VjIC8g MTAwMC4wZik7Ci0jZW5kaWYKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8bG9uZz4oKG1fc3RvcFRp bWUgLSBtX3N0YXJ0VGltZSkgKiAxMDAwKTsKIH0KIAogY2xhc3MgR2xvYmFsT2JqZWN0IDogcHVi bGljIEpTR2xvYmFsT2JqZWN0IHsKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv VGltZW91dENoZWNrZXIuY3BwIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UaW1lb3V0Q2hlY2tl ci5jcHAKaW5kZXggMzBiYTZlOS4uMmEwNTZjOSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUv cnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9U aW1lb3V0Q2hlY2tlci5jcHAKQEAgLTM1LDE4ICszNSwxMCBAQAogCiAjaWYgUExBVEZPUk0oREFS V0lOKQogI2luY2x1ZGUgPG1hY2gvbWFjaC5oPgotI2VuZGlmCi0KLSNpZiBIQVZFKFNZU19USU1F X0gpCi0jaW5jbHVkZSA8c3lzL3RpbWUuaD4KLSNlbmRpZgotCi0jaWYgUExBVEZPUk0oV0lOX09T KQorI2VsaWYgUExBVEZPUk0oV0lOX09TKQogI2luY2x1ZGUgPHdpbmRvd3MuaD4KLSNlbmRpZgot Ci0jaWYgUExBVEZPUk0oUVQpCi0jaW5jbHVkZSA8UURhdGVUaW1lPgorI2Vsc2UKKyNpbmNsdWRl ICJDdXJyZW50VGltZS5oIgogI2VuZGlmCiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CkBAIC03NSwx NCArNjcsNiBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGdldENQVVRpbWUoKQogICAgIHRpbWUg Kz0gaW5mby5zeXN0ZW1fdGltZS5zZWNvbmRzICogMTAwMCArIGluZm8uc3lzdGVtX3RpbWUubWlj cm9zZWNvbmRzIC8gMTAwMDsKICAgICAKICAgICByZXR1cm4gdGltZTsKLSNlbGlmIEhBVkUoU1lT X1RJTUVfSCkKLSAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcHJvYmFibHkgdXNlIGdldHJ1c2Fn ZSB3aXRoIHRoZSBSVVNBR0VfVEhSRUFEIGZsYWcuCi0gICAgc3RydWN0IHRpbWV2YWwgdHY7Ci0g ICAgZ2V0dGltZW9mZGF5KCZ0diwgMCk7Ci0gICAgcmV0dXJuIHR2LnR2X3NlYyAqIDEwMDAgKyB0 di50dl91c2VjIC8gMTAwMDsKLSNlbGlmIFBMQVRGT1JNKFFUKQotICAgIFFEYXRlVGltZSB0ID0g UURhdGVUaW1lOjpjdXJyZW50RGF0ZVRpbWUoKTsKLSAgICByZXR1cm4gdC50b1RpbWVfdCgpICog MTAwMCArIHQudGltZSgpLm1zZWMoKTsKICNlbGlmIFBMQVRGT1JNKFdJTl9PUykKICAgICB1bmlv biB7CiAgICAgICAgIEZJTEVUSU1FIGZpbGVUaW1lOwpAQCAtOTcsNyArODEsOCBAQCBzdGF0aWMg aW5saW5lIHVuc2lnbmVkIGdldENQVVRpbWUoKQogICAgIAogICAgIHJldHVybiB1c2VyVGltZS5m aWxlVGltZUFzTG9uZyAvIDEwMDAwICsga2VybmVsVGltZS5maWxlVGltZUFzTG9uZyAvIDEwMDAw OwogI2Vsc2UKLSNlcnJvciBQbGF0Zm9ybSBkb2VzIG5vdCBoYXZlIGdldEN1cnJlbnRUaW1lIGZ1 bmN0aW9uCisgICAgLy8gRklYTUU6IFdlIHNob3VsZCByZXR1cm4gdGhlIHRpbWUgdGhlIGN1cnJl bnQgdGhyZWFkIGhhcyBzcGVudCBleGVjdXRpbmcuCisgICAgcmV0dXJuIGN1cnJlbnRUaW1lKCkg KiAxMDAwOwogI2VuZGlmCiB9CiAK