29136 2009-09-10 11:59:56 -0700 [Qt] emit microFocusChanged() signal when no QWidget-based view is present. 2009-09-11 01:56:03 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 yongjun.zhang webkit-unassigned commit-queue oldest_to_newest 146275 0 yongjun.zhang 2009-09-10 11:59:56 -0700 Currently, EditorClientQt::setInputMethodState emits microFocusChanged only when view is present. For viewless client like wrt canvas, it also need to get this signal that some special actions can be triggered (like VKB in s60 5.0). 146278 1 39363 yongjun.zhang 2009-09-10 12:04:43 -0700 Created attachment 39363 emit microFocusChanged() regardless of view. 146470 2 39363 hausmann 2009-09-11 00:09:49 -0700 Comment on attachment 39363 emit microFocusChanged() regardless of view. r=me, thanks This is a correct change, but I think it will need more work to fully function. This ties into the discussion about making QWebPage work better in environments without a view but a graphics item instead. Just emitting the signal helps, but it's not sufficient to determine then if the input method should be enabled or not. Please see also the discussion in #28862 and the follow-up in #29085. We could benefit from your experience in using it without a view :) 146496 3 39363 commit-queue 2009-09-11 01:55:57 -0700 Comment on attachment 39363 emit microFocusChanged() regardless of view. Clearing flags on attachment: 39363 Committed r48291: <http://trac.webkit.org/changeset/48291> 146497 4 commit-queue 2009-09-11 01:56:03 -0700 All reviewed patches have been landed. Closing bug. 39363 2009-09-10 12:04:43 -0700 2009-09-11 01:55:56 -0700 emit microFocusChanged() regardless of view. microFocusChange.patch text/plain 1281 yongjun.zhang SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDgyNjEpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMTAgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVu LnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yOTEzNgorICAgICAgICBbUXRdIGVtaXQgbWljcm9Gb2N1c0NoYW5nZWQoKSBzaWduYWwgd2hl biBubyBRV2lkZ2V0LWJhc2VkIHZpZXcgaXMgcHJlc2VudC4KKworICAgICAgICBlbWl0IG1pY3Jv Rm9jdXNDaGFuZ2UoKSBzaWduYWwgcmVnYXJkbGVzcyBvZiB2aWV3LgorCisgICAgICAgICogV2Vi Q29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9y Q2xpZW50UXQ6OnNldElucHV0TWV0aG9kU3RhdGUpOgorCiAyMDA5LTA5LTEwICBMYXN6bG8gR29t Ym9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLgpJ bmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwCShyZXZp c2lvbiA0ODI1MikKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTU5NSwxMCArNTk1LDEwIEBAIGJvb2wgRWRpdG9yQ2xpZW50 UXQ6OmlzRWRpdGluZygpIGNvbnN0CiB2b2lkIEVkaXRvckNsaWVudFF0OjpzZXRJbnB1dE1ldGhv ZFN0YXRlKGJvb2wgYWN0aXZlKQogewogICAgIFFXaWRnZXQgKnZpZXcgPSBtX3BhZ2UtPnZpZXco KTsKLSAgICBpZiAodmlldykgeworICAgIGlmICh2aWV3KQogICAgICAgICB2aWV3LT5zZXRBdHRy aWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5hYmxlZCwgYWN0aXZlKTsKLSAgICAgICAgZW1pdCBt X3BhZ2UtPm1pY3JvRm9jdXNDaGFuZ2VkKCk7Ci0gICAgfQorCisgICAgZW1pdCBtX3BhZ2UtPm1p Y3JvRm9jdXNDaGFuZ2VkKCk7CiB9CiAKIH0K