29123 2009-09-10 06:49:35 -0700 Fails to parse the "d" attribute of a path if a command starts with a '.' 2009-10-15 02:08:30 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC Windows XP VERIFIED FIXED P2 Normal --- 1 rrutkowski webkit-unassigned commit-queue darin oldest_to_newest 146180 0 rrutkowski 2009-09-10 06:49:35 -0700 The following path will not be parsed <path d="M.1 0.1l0 .3 .2 0" /> The cause is the last command: ".2 0", which starts with a '.'. The following examples work fine: M.1 0.1l0 .3 +.2 0 M.1 0.1l0 .3 0.2 0 M.1 0.1l0 .3 l.2 0 M.1 0.1l0 .3 Test case: http://strony.aster.pl/rrutkows/test_cases/webkit/svg_path_parse_error/L.svg Result: Nothing is displayed. An error appears in the Chrome console: Error: Problem parsing d="M.1 0.1l0 .3 .2 0" Expected result: A black shape resembling a capital letter 'L' should be displayed. Works on Opera, Firefox and IE+Adobe SVG Viewer. Tested on Safari 4.0 (530.17) and Chrome 4.0.206.1 (532.0) 147054 1 39544 charles.wei 2009-09-14 07:49:34 -0700 Created attachment 39544 patch that fixes SVG path tat starts with dot '.' This patch fixes the SVT Path problem that starts with a dot '.' 147057 2 39544 darin 2009-09-14 07:52:51 -0700 Comment on attachment 39544 patch that fixes SVG path tat starts with dot '.' In the WebKit project we require regression tests checked in along with bug fixes. There's already a test of the path parser in LayoutTests/svg/dom/path-parser.html so for this bug you could probably add some tests cases to that. review- because of lack of a test 147261 3 39589 charles.wei 2009-09-15 00:15:07 -0700 Created attachment 39589 re-submit the patch with test case added resubmitting the patch with test cases added. 147330 4 39589 commit-queue 2009-09-15 10:52:16 -0700 Comment on attachment 39589 re-submit the patch with test case added Clearing flags on attachment: 39589 Committed r48393: <http://trac.webkit.org/changeset/48393> 147331 5 commit-queue 2009-09-15 10:52:22 -0700 All reviewed patches have been landed. Closing bug. 39544 2009-09-14 07:49:34 -0700 2009-09-15 00:15:07 -0700 patch that fixes SVG path tat starts with dot '.' 29123.patch text/plain 1399 charles.wei SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODM1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMTQgIGNoYXJsZXMgd2VpICA8Y2hhcmxlcy53ZWlAdG9y Y2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGZpeCBTVkcgcGF0aCBwcm9ibGVtIHRoYXQgc3RhcnRzIHdpdGggYSBkb3QgJy4n CisKKyAgICAgICAgdGVzdCBjYXNlIGluIHRoZSBidWcgbGluayBhdCA6CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTEyMworCisgICAgICAgICogc3Zn L1NWR1BhcnNlclV0aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdQYXRoUGFyc2Vy OjpwYXJzZVNWRyk6CisKIDIwMDktMDktMTMgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CiAKICAgICAgICAgd3ggYnVpbGQgZml4LCBmaWxlIHdhcyBtaXNzZWQgZHVy aW5nIFRMUy5jcHAgcmVtb3ZhbC4KSW5kZXg6IFdlYkNvcmUvc3ZnL1NWR1BhcnNlclV0aWxpdGll cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9zdmcvU1ZHUGFyc2VyVXRpbGl0aWVzLmNwcAko cmV2aXNpb24gNDgzNTMpCisrKyBXZWJDb3JlL3N2Zy9TVkdQYXJzZXJVdGlsaXRpZXMuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01MDksOCArNTA5LDggQEAgYm9vbCBTVkdQYXRoUGFyc2VyOjpwYXJz ZVNWRyhjb25zdCBTdHJpbgogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICAgICAgLy8g Q2hlY2sgZm9yIHJlbWFpbmluZyBjb29yZGluYXRlcyBpbiB0aGUgY3VycmVudCBjb21tYW5kLgot ICAgICAgICBpZiAoKCpwdHIgPT0gJysnIHx8ICpwdHIgPT0gJy0nIHx8ICgqcHRyID49ICcwJyAm JiAqcHRyIDw9ICc5JykpICYmCi0gICAgICAgICAgICAoY29tbWFuZCAhPSAneicgJiYgY29tbWFu ZCAhPSAnWicpKSB7CisgICAgICAgIGlmICgoKnB0ciA9PSAnKycgfHwgKnB0ciA9PSAnLScgfHwg KnB0ciA9PSAnLicgfHwgKCpwdHIgPj0gJzAnICYmICpwdHIgPD0gJzknKSkKKyAgICAgICAgICAg ICYmIChjb21tYW5kICE9ICd6JyAmJiBjb21tYW5kICE9ICdaJykpIHsKICAgICAgICAgICAgIGlm IChjb21tYW5kID09ICdNJykKICAgICAgICAgICAgICAgICBjb21tYW5kID0gJ0wnOwogICAgICAg ICAgICAgZWxzZSBpZiAoY29tbWFuZCA9PSAnbScpCg== 39589 2009-09-15 00:15:07 -0700 2009-09-15 10:52:16 -0700 re-submit the patch with test case added 29123.patch text/plain 2985 charles.wei SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODM4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMTUgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9y Y2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBTVkcgcGF0aCBwYXJzaW5nIGVycm9yIGlmIGEgY29tbWFuZCBzdGFydHMg d2l0aCBkb3QgJy4nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yOTEyMworCisgICAgICAgICogc3ZnL1NWR1BhcnNlclV0aWxpdGllcy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTVkdQYXRoUGFyc2VyOjpwYXJzZVNWRyk6CisKIDIwMDktMDktMTQgIEJy YWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9zdmcvU1ZHUGFyc2VyVXRpbGl0aWVzLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3N2Zy9TVkdQYXJzZXJVdGlsaXRpZXMuY3BwCShyZXZpc2lvbiA0 ODM4OCkKKysrIFdlYkNvcmUvc3ZnL1NWR1BhcnNlclV0aWxpdGllcy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTUwOSw4ICs1MDksOCBAQCBib29sIFNWR1BhdGhQYXJzZXI6OnBhcnNlU1ZHKGNvbnN0 IFN0cmluCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgICAgICAvLyBDaGVjayBmb3Ig cmVtYWluaW5nIGNvb3JkaW5hdGVzIGluIHRoZSBjdXJyZW50IGNvbW1hbmQuCi0gICAgICAgIGlm ICgoKnB0ciA9PSAnKycgfHwgKnB0ciA9PSAnLScgfHwgKCpwdHIgPj0gJzAnICYmICpwdHIgPD0g JzknKSkgJiYKLSAgICAgICAgICAgIChjb21tYW5kICE9ICd6JyAmJiBjb21tYW5kICE9ICdaJykp IHsKKyAgICAgICAgaWYgKCgqcHRyID09ICcrJyB8fCAqcHRyID09ICctJyB8fCAqcHRyID09ICcu JyB8fCAoKnB0ciA+PSAnMCcgJiYgKnB0ciA8PSAnOScpKQorICAgICAgICAgICAgJiYgKGNvbW1h bmQgIT0gJ3onICYmIGNvbW1hbmQgIT0gJ1onKSkgewogICAgICAgICAgICAgaWYgKGNvbW1hbmQg PT0gJ00nKQogICAgICAgICAgICAgICAgIGNvbW1hbmQgPSAnTCc7CiAgICAgICAgICAgICBlbHNl IGlmIChjb21tYW5kID09ICdtJykKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ4Mzg4KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDkt MTUgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5ldyB0ZXN0 IGNhc2UgZm9yIFNWRyBQYXRoIHBhcnNpbmcgd2l0aCBhIGRlZmF1bHQgY29tbWFuZCBhbmQgc3Rh cnRzIHdpdGggZG90ICcuJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjkxMjMKKworICAgICAgICAqIHN2Zy9kb20vcGF0aC1wYXJzZXItZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIHN2Zy9kb20vcmVzb3VyY2VzL3BhdGgtcGFyc2VyLmpzOgorCiAyMDA5 LTA5LTE0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9kb20vcGF0aC1wYXJz ZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9kb20vcGF0aC1w YXJzZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA0ODM4OCkKKysrIExheW91dFRlc3RzL3N2Zy9k b20vcGF0aC1wYXJzZXItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC01Nyw2ICs1Nyw3 IEBAIFBBU1MgcGFyc2VQYXRoKCdNMSwyeCcpIGlzICcnCiBQQVNTIHBhcnNlUGF0aCgnJykgaXMg JycKIFBBU1MgcGFyc2VQYXRoKCd4JykgaXMgJycKIFBBU1MgcGFyc2VQYXRoKCdMMSwyJykgaXMg JycKK1BBU1MgcGFyc2VQYXRoKCdNLjEgLjIgTC4zIC40IC41IC42JykgaXMgJ00wLjEsMC4yIEww LjMsMC40IEwwLjUsMC42JwogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNU IENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvZG9tL3Jlc291cmNlcy9wYXRoLXBhcnNl ci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvZG9tL3Jlc291cmNlcy9wYXRoLXBh cnNlci5qcwkocmV2aXNpb24gNDgzODgpCisrKyBMYXlvdXRUZXN0cy9zdmcvZG9tL3Jlc291cmNl cy9wYXRoLXBhcnNlci5qcwkod29ya2luZyBjb3B5KQpAQCAtMTA3LDUgKzEwNyw2IEBAIHNob3Vs ZEJlKCJwYXJzZVBhdGgoJ00xLDJ4JykiLCAiJyciKTsKIHNob3VsZEJlKCJwYXJzZVBhdGgoJycp IiwgIicnIik7CiBzaG91bGRCZSgicGFyc2VQYXRoKCd4JykiLCAiJyciKTsKIHNob3VsZEJlKCJw YXJzZVBhdGgoJ0wxLDInKSIsICInJyIpOworc2hvdWxkQmUoInBhcnNlUGF0aCgnTS4xIC4yIEwu MyAuNCAuNSAuNicpIiwgIidNMC4xLDAuMiBMMC4zLDAuNCBMMC41LDAuNiciKTsKIAogc3VjY2Vz c2Z1bGx5UGFyc2VkID0gdHJ1ZTsK