29119 2009-09-09 23:29:02 -0700 [GTK] EventSender does not properly convert some keyDown strings 2009-09-10 07:04:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mrobinson webkit-unassigned commit-queue oldest_to_newest 146089 0 mrobinson 2009-09-09 23:29:02 -0700 I'm working on getting some more of the key event unit tests passing in GTK+. I noticed that some keyDown strings used in the LayoutTests are not properly converted to GDK key codes in the GTK+ EventSender. 146092 1 39325 mrobinson 2009-09-09 23:36:53 -0700 Created attachment 39325 Patch for this issue I've attached a small patch which adds more key code conversions for event sender. Key codes like '\x8' (and in general all those less than '\x20') are not converted properly by gdk_unicode_to_keyval. 146181 2 39325 xan.lopez 2009-09-10 06:51:37 -0700 Comment on attachment 39325 Patch for this issue r=me 146186 3 39325 commit-queue 2009-09-10 07:04:40 -0700 Comment on attachment 39325 Patch for this issue Clearing flags on attachment: 39325 Committed r48253: <http://trac.webkit.org/changeset/48253> 146187 4 commit-queue 2009-09-10 07:04:44 -0700 All reviewed patches have been landed. Closing bug. 39325 2009-09-09 23:36:53 -0700 2009-09-10 07:04:40 -0700 Patch for this issue 0001-Fix-keyDown-string-to-character-code-conversion-for.patch text/plain 3093 mrobinson RnJvbSBiNWViYzExN2ZkNjVhMzUzZDQ3ZTY2OWIzMzIxMjVjYjE5ZDQzM2QxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1hcnRpbi5qYW1lcy5yb2JpbnNv bkBnbWFpbC5jb20+CkRhdGU6IFdlZCwgOSBTZXAgMjAwOSAyMzoyOToyOCAtMDcwMApTdWJqZWN0 OiBbUEFUQ0hdIEZpeCBrZXlEb3duIHN0cmluZyB0byBjaGFyYWN0ZXIgY29kZSBjb252ZXJzaW9u IGZvciBHVEsrIEV2ZW50U2VuZGVyLgoKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKysrKwogV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcCB8ICAgMzAgKysrKysrKysrKysrKysrKysrKysrKyst CiAyIGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGIyYjZhZWEuLmE2YmVlZjEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZwor KysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOS0wOSAg TWFydGluIFJvYmluc29uICA8bWFydGluLmphbWVzLnJvYmluc29uQGdtYWlsLmNvbT4KKworICAg ICAgICBbR1RLXSBFdmVudFNlbmRlciBkb2VzIG5vdCBwcm9wZXJseSBjb252ZXJ0IHNvbWUga2V5 RG93biBzdHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yOTExOQorCisgICAgICAgIEFkZCBtb3JlIGtleURvd24gc3RyaW5nIHRvIGNoYXJhY3Rl ciBjb2RlIGNvbnZlcnNpb25zIGZvciBHVEsrIEV2ZW50U2VuZGVyLgorCisgICAgICAgICogRHVt cFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcDoKKyAgICAgICAgKGtleURvd25DYWxsYmFj ayk6CisKIDIwMDktMDktMDkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCmluZGV4IGFkYjNhZjcuLjM1NDM2ZWMgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKKysrIGIv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcApAQCAtMzMxLDEw ICszMzEsMzggQEAgc3RhdGljIEpTVmFsdWVSZWYga2V5RG93bkNhbGxiYWNrKEpTQ29udGV4dFJl ZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlMKICAgICAgICAgZ2RrS2V5U3ltID0g R0RLX0VuZDsKICAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKGNoYXJh Y3RlciwgImRlbGV0ZSIpKQogICAgICAgICBnZGtLZXlTeW0gPSBHREtfRGVsZXRlOworICAgIGVs c2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hhcmFjdGVyLCAiRjEiKSkKKyAg ICAgICAgZ2RrS2V5U3ltID0gR0RLX0YxOworICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRv VVRGOENTdHJpbmcoY2hhcmFjdGVyLCAiRjIiKSkKKyAgICAgICAgZ2RrS2V5U3ltID0gR0RLX0Yy OworICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hhcmFjdGVyLCAi RjMiKSkKKyAgICAgICAgZ2RrS2V5U3ltID0gR0RLX0YzOworICAgIGVsc2UgaWYgKEpTU3RyaW5n SXNFcXVhbFRvVVRGOENTdHJpbmcoY2hhcmFjdGVyLCAiRjQiKSkKKyAgICAgICAgZ2RrS2V5U3lt ID0gR0RLX0Y0OworICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hh cmFjdGVyLCAiRjUiKSkKKyAgICAgICAgZ2RrS2V5U3ltID0gR0RLX0Y1OworICAgIGVsc2UgaWYg KEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hhcmFjdGVyLCAiRjYiKSkKKyAgICAgICAg Z2RrS2V5U3ltID0gR0RLX0Y2OworICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENT dHJpbmcoY2hhcmFjdGVyLCAiRjciKSkKKyAgICAgICAgZ2RrS2V5U3ltID0gR0RLX0Y3OworICAg IGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hhcmFjdGVyLCAiRjgiKSkK KyAgICAgICAgZ2RrS2V5U3ltID0gR0RLX0Y4OworICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVh bFRvVVRGOENTdHJpbmcoY2hhcmFjdGVyLCAiRjkiKSkKKyAgICAgICAgZ2RrS2V5U3ltID0gR0RL X0Y5OworICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hhcmFjdGVy LCAiRjEwIikpCisgICAgICAgIGdka0tleVN5bSA9IEdES19GMTA7CisgICAgZWxzZSBpZiAoSlNT dHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhjaGFyYWN0ZXIsICJGMTEiKSkKKyAgICAgICAgZ2Rr S2V5U3ltID0gR0RLX0YxMTsKKyAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3Ry aW5nKGNoYXJhY3RlciwgIkYxMiIpKQorICAgICAgICBnZGtLZXlTeW0gPSBHREtfRjEyOwogICAg IGVsc2UgewogICAgICAgICBpbnQgY2hhckNvZGUgPSBKU1N0cmluZ0dldENoYXJhY3RlcnNQdHIo Y2hhcmFjdGVyKVswXTsKLSAgICAgICAgaWYgKGNoYXJDb2RlID09ICdcbicpCisgICAgICAgIGlm IChjaGFyQ29kZSA9PSAnXG4nIHx8IGNoYXJDb2RlID09ICdccicpCiAgICAgICAgICAgICBnZGtL ZXlTeW0gPSBHREtfUmV0dXJuOworICAgICAgICBlbHNlIGlmIChjaGFyQ29kZSA9PSAnXHQnKQor ICAgICAgICAgICAgZ2RrS2V5U3ltID0gR0RLX1RhYjsKKyAgICAgICAgZWxzZSBpZiAoY2hhckNv ZGUgPT0gJ1x4OCcpCisgICAgICAgICAgICBnZGtLZXlTeW0gPSBHREtfQmFja1NwYWNlOwogICAg ICAgICBlbHNlIHsKICAgICAgICAgICAgIGdka0tleVN5bSA9IGdka191bmljb2RlX3RvX2tleXZh bChjaGFyQ29kZSk7CiAgICAgICAgICAgICBpZiAoV1RGOjppc0FTQ0lJVXBwZXIoY2hhckNvZGUp KQotLSAKMS42LjAuNAoK