29091 2009-09-09 10:19:45 -0700 commit-queue hangs if a builder has never built 2009-09-09 15:21:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth levin oldest_to_newest 145817 0 eric 2009-09-09 10:19:45 -0700 commit-queue hangs if a builder has never built buildbot.py was throwing exceptions when trying to parse the buildbot page if one of the builders had never built. Fixed. 145818 1 39276 eric 2009-09-09 10:20:34 -0700 Created attachment 39276 Patch v1 145869 2 39276 levin 2009-09-09 11:36:37 -0700 Comment on attachment 39276 Patch v1 r=me if there is a good answer to my question below. > diff --git a/WebKitTools/Scripts/modules/buildbot.py b/WebKitTools/Scripts/modules/buildbot.py > + if not status_link: > + # We failed to find a link in the first cell, just give up. > + # This can happen if a builder is just-added, the first cell will just be "no build" > + return builder Are other parts of the code robust to 'built_revision', 'is_green', 'build_url' not being in builder? > diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py b/WebKitTools/Scripts/modules/buildbot_unittest.py > + <td align="center" class="Activity building">building<br />< 1 min</td> &lt; 1 min ? 145872 3 eric 2009-09-09 11:40:46 -0700 (In reply to comment #2) > (From update of attachment 39276 [details]) > r=me if there is a good answer to my question below. > > > diff --git a/WebKitTools/Scripts/modules/buildbot.py b/WebKitTools/Scripts/modules/buildbot.py > > + if not status_link: > > + # We failed to find a link in the first cell, just give up. > > + # This can happen if a builder is just-added, the first cell will just be "no build" > > + return builder > > Are other parts of the code robust to 'built_revision', 'is_green', 'build_url' > not being in builder? Possibly not. I'll check before landing and fix it to add is_green, etc if necessary. > > diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py b/WebKitTools/Scripts/modules/buildbot_unittest.py > > + <td align="center" class="Activity building">building<br />< 1 min</td> > > &lt; 1 min ? I literally copy/pasted from the buildbot html source. :) So I think I'll leave it as this "invalid" html for now. :) 145979 4 eric 2009-09-09 15:21:14 -0700 Committed r48230: <http://trac.webkit.org/changeset/48230> 39276 2009-09-09 10:20:34 -0700 2009-09-09 11:36:37 -0700 Patch v1 bug-29091-20090909102033.patch text/plain 3132 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyMTZiZGJiLi42NGNkOThlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDkt MDkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBoYW5ncyBpZiBhIGJ1aWxk ZXIgaGFzIG5ldmVyIGJ1aWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yOTA5MQorCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2J1aWxkYm90LnB5 OgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9idWlsZGJvdF91bml0dGVzdC5weToKKwogMjAw OS0wOS0wOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDxo dHRwOi8vd2Via2l0Lm9yZy9iLzI5MDYxPiBGaXggb2J2aW91cyBjb3B5LXBhc3RlIGVycm9yIGlu IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNsaWNrUG9pbnRZKCkKZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWlsZGJvdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv bW9kdWxlcy9idWlsZGJvdC5weQppbmRleCBkNDBhYzg4Li4xY2U2Mzg1IDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVpbGRib3QucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2J1aWxkYm90LnB5CkBAIC01OSw2ICs1OSwxMCBAQCBjbGFzcyBCdWls ZEJvdDoKICAgICAgICAgYnVpbGRlclsnYnVpbGRlcl91cmwnXSA9IHNlbGYuYnVpbGRib3Rfc2Vy dmVyX3VybCArIG5hbWVfbGlua1snaHJlZiddCiAKICAgICAgICAgc3RhdHVzX2xpbmsgPSBzdGF0 dXNfY2VsbHNbMV0uZmluZCgnYScpCisgICAgICAgIGlmIG5vdCBzdGF0dXNfbGluazoKKyAgICAg ICAgICAgICMgV2UgZmFpbGVkIHRvIGZpbmQgYSBsaW5rIGluIHRoZSBmaXJzdCBjZWxsLCBqdXN0 IGdpdmUgdXAuCisgICAgICAgICAgICAjIFRoaXMgY2FuIGhhcHBlbiBpZiBhIGJ1aWxkZXIgaXMg anVzdC1hZGRlZCwgdGhlIGZpcnN0IGNlbGwgd2lsbCBqdXN0IGJlICJubyBidWlsZCIKKyAgICAg ICAgICAgIHJldHVybiBidWlsZGVyCiAgICAgICAgIHJldmlzaW9uX3N0cmluZyA9IHN0YXR1c19s aW5rLnN0cmluZyAjIFdpbGwgYmUgZWl0aGVyIGEgcmV2aXNpb24gbnVtYmVyIG9yIGEgYnVpbGQg bnVtYmVyCiAgICAgICAgICMgSWYgcmV2aXNpb25fc3RyaW5nIGhhcyBub24tZGlnaXRzIGFzc3Vt ZSBpdCdzIG5vdCBhIHJldmlzaW9uIG51bWJlci4KICAgICAgICAgYnVpbGRlclsnYnVpbHRfcmV2 aXNpb24nXSA9IGludChyZXZpc2lvbl9zdHJpbmcpIGlmIG5vdCByZS5tYXRjaCgnXEQnLCByZXZp c2lvbl9zdHJpbmcpIGVsc2UgTm9uZQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9t b2R1bGVzL2J1aWxkYm90X3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVz L2J1aWxkYm90X3VuaXR0ZXN0LnB5CmluZGV4IDcwNTRiZWUuLjY4ZDJlNmIgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWlsZGJvdF91bml0dGVzdC5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVpbGRib3RfdW5pdHRlc3QucHkKQEAgLTQxLDYg KzQxLDEwIEBAIGNsYXNzIEJ1aWxkQm90VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICA8 dGQgYWxpZ249ImNlbnRlciIgY2xhc3M9Ikxhc3RCdWlsZCBib3ggc3VjY2VzcyI+PGEgaHJlZj0i YnVpbGRlcnMvV2luZG93cyUyMERlYnVnJTIwJTI4VGVzdHMlMjkvYnVpbGRzLzM2OTMiPjQ3Mzgw PC9hPjxiciAvPmJ1aWxkPGJyIC8+c3VjY2Vzc2Z1bDwvdGQ+CiAgICAgICA8dGQgYWxpZ249ImNl bnRlciIgY2xhc3M9IkFjdGl2aXR5IGJ1aWxkaW5nIj5idWlsZGluZzxiciAvPkVUQSBpbjxiciAv Pn4gMTQgbWluczxiciAvPmF0IDEzOjQwPC90ZD4KICAgICA8dHI+CisgICAgPHRkIGNsYXNzPSJi b3giPjxhIGhyZWY9ImJ1aWxkZXJzL1Nub3dMZW9wYXJkJTIwSW50ZWwlMjBSZWxlYXNlIj5Tbm93 TGVvcGFyZCBJbnRlbCBSZWxlYXNlPC9hPjwvdGQ+CisgICAgICA8dGQgY2xhc3M9Ikxhc3RCdWls ZCBib3giID5ubyBidWlsZDwvdGQ+CisgICAgICA8dGQgYWxpZ249ImNlbnRlciIgY2xhc3M9IkFj dGl2aXR5IGJ1aWxkaW5nIj5idWlsZGluZzxiciAvPjwgMSBtaW48L3RkPgorICAgIDx0cj4KICAg ICA8dGQgY2xhc3M9ImJveCI+PGEgaHJlZj0iYnVpbGRlcnMvUXQlMjBMaW51eCUyMFJlbGVhc2Ui PlF0IExpbnV4IFJlbGVhc2U8L2E+PC90ZD4KICAgICAgIDx0ZCBhbGlnbj0iY2VudGVyIiBjbGFz cz0iTGFzdEJ1aWxkIGJveCBmYWlsdXJlIj48YSBocmVmPSJidWlsZGVycy9RdCUyMExpbnV4JTIw UmVsZWFzZS9idWlsZHMvNjU0Ij40NzM4MzwvYT48YnIgLz5mYWlsZWQ8YnIgLz5jb21waWxlLXdl YmtpdDwvdGQ+CiAgICAgICA8dGQgYWxpZ249ImNlbnRlciIgY2xhc3M9IkFjdGl2aXR5IGlkbGUi PmlkbGU8L3RkPgpAQCAtNTUsNiArNTksMTAgQEAgY2xhc3MgQnVpbGRCb3RUZXN0KHVuaXR0ZXN0 LlRlc3RDYXNlKToKICAgICAgICAgICAgICdidWlsdF9yZXZpc2lvbic6IDQ3MzgwCiAgICAgICAg IH0sCiAgICAgICAgIHsKKyAgICAgICAgICAgICdidWlsZGVyX3VybCc6IHUnaHR0cDovL2J1aWxk LndlYmtpdC5vcmcvYnVpbGRlcnMvU25vd0xlb3BhcmQlMjBJbnRlbCUyMFJlbGVhc2UnLAorICAg ICAgICAgICAgJ25hbWUnOiB1J1Nub3dMZW9wYXJkIEludGVsIFJlbGVhc2UnLAorICAgICAgICB9 LAorICAgICAgICB7CiAgICAgICAgICAgICAnYnVpbGRlcl91cmwnOiB1J2h0dHA6Ly9idWlsZC53 ZWJraXQub3JnL2J1aWxkZXJzL1F0JTIwTGludXglMjBSZWxlYXNlJywKICAgICAgICAgICAgICdi dWlsZF91cmwnOiB1J2h0dHA6Ly9idWlsZC53ZWJraXQub3JnL2J1aWxkZXJzL1F0JTIwTGludXgl MjBSZWxlYXNlL2J1aWxkcy82NTQnLAogICAgICAgICAgICAgJ2lzX2dyZWVuJzogRmFsc2Us