29089 2009-09-09 09:56:57 -0700 Inspector should remember preferences for docked/undocked etc 2009-10-03 20:21:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 wells joepeck joepeck timothy oldest_to_newest 145810 0 wells 2009-09-09 09:56:57 -0700 Inspector should remember a user's settings for preferences such as whether the window is docked, whether small icons are shown, whether the console is open, and so on. 146844 1 timothy 2009-09-11 17:57:06 -0700 We do remember if it is docked already. The others will be good to remember. 152077 2 40575 joepeck 2009-10-03 08:31:24 -0700 Created attachment 40575 [PATCH] Remember Resources Large / Small Rows Preference I'm open to changing the name "resourcesLargeRows". The naming convention I was going for was "<panel><SettingName>". But there are so few preferences right now that this might not be needed. 152078 3 joepeck 2009-10-03 08:35:22 -0700 (In reply to comment #0) > whether small icons are shown Current patch attempts this. Is there anywhere else other then Resources rows? Is there one in the Profiler or something? I seem to remember but I couldn't find anything else. > whether the console is open I'm against this. I prefer using ⌥⌘C to open with Console and ⌥⌘I to open without the Console and some extra real estate. In fact, I'm hoping there can be a Console Only Inspector sometime! 152105 4 40575 timothy 2009-10-03 16:06:44 -0700 Comment on attachment 40575 [PATCH] Remember Resources Large / Small Rows Preference > + if (resourcesLargeRows !== undefined) Should be: typeof resourcesLargeRows !== "undefined" 152116 5 joepeck 2009-10-03 17:24:27 -0700 (In reply to comment #4) > (From update of attachment 40575 [details]) > > > + if (resourcesLargeRows !== undefined) > > Should be: > > typeof resourcesLargeRows !== "undefined" I thought about this (cause we had mentioned it before). I took a look to check if there were others and felt fine when I saw there were a bunch. Should I bother changing any of the others? InjectedScript.js 1058: return (obj.nodeType === undefined ? type : "node"); inspector.js 698: if (complete === undefined) Resource.js 406: if (this._requestHeaders === undefined) 424: if (this._sortedRequestHeaders !== undefined) 437: if (this._responseHeaders === undefined) 455: if (this._sortedResponseHeaders !== undefined) 576: && this.contentLength !== undefined treeoutline.js 74: if (child.hasChildren && child.treeOutline._treeElementsExpandedState[child.identifier] !== undefined) 122: if (child.hasChildren && child.treeOutline._treeElementsExpandedState[child.identifier] !== undefined) 152117 6 timothy 2009-10-03 17:25:47 -0700 Either works. I just prefer the typeof version now. 152122 7 joepeck 2009-10-03 20:16:49 -0700 Landed in r49072 => http://trac.webkit.org/changeset/49072 r49072 = 45c28c0b6c817190798c81538d182c8a8312cc35 (trunk) 152123 8 joepeck 2009-10-03 20:21:17 -0700 Wells Oliver - we're going to mark this as resolved. If you still feel another preference should be added for the Console let us know. We are comfortable with the current behavior and the keyboard shortcut solution. 40575 2009-10-03 08:31:24 -0700 2009-10-03 16:06:43 -0700 [PATCH] Remember Resources Large / Small Rows Preference resources_large_rows.patch text/plain 4274 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjFjNGVlNC4uMTlmMTM1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0wMyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluc3BlY3RvciBTaG91bGQgUmVtZW1iZXIgUHJlZmVyZW5jZXMg Rm9yIFJlc291cmNlIFJvdyBTaXplcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjkwODkKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVz b3VyY2VzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJv dG90eXBlLl90b2dnbGVMYXJnZXJSZXNvdXJjZXMpOiB0b2dnbGUgdGhlIHByZWZlcmVuY2UKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5fbG9hZFByZWZlcmVuY2VzKTogZmFjdG9yZWQgb3V0IGxvYWRpbmcgcHJlZmVyZW5j ZXMKKyAgICAgICAgKFdlYkluc3BlY3Rvci5sb2FkZWQpOgorCiAyMDA5LTEwLTAyICBCcmlhbiBX ZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBU aW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2VzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2Vz UGFuZWwuanMKaW5kZXggMDllNzliYy4uYjU3NWZjMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtMTMzLDggKzEzMywxMiBAQCBXZWJJbnNw ZWN0b3IuUmVzb3VyY2VzUGFuZWwgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5lbmFibGVUb2dnbGVC dXR0b24uYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl90b2dnbGVSZXNvdXJjZVRyYWNr aW5nLmJpbmQodGhpcyksIGZhbHNlKTsKIAogICAgIHRoaXMubGFyZ2VyUmVzb3VyY2VzQnV0dG9u ID0gbmV3IFdlYkluc3BlY3Rvci5TdGF0dXNCYXJCdXR0b24oV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCJVc2Ugc21hbGwgcmVzb3VyY2Ugcm93cy4iKSwgInJlc291cmNlcy1sYXJnZXItcmVzb3VyY2Vz LXN0YXR1cy1iYXItaXRlbSIpOwotICAgIHRoaXMubGFyZ2VyUmVzb3VyY2VzQnV0dG9uLnRvZ2ds ZWQgPSB0cnVlOworICAgIHRoaXMubGFyZ2VyUmVzb3VyY2VzQnV0dG9uLnRvZ2dsZWQgPSBQcmVm ZXJlbmNlcy5yZXNvdXJjZXNMYXJnZVJvd3M7CiAgICAgdGhpcy5sYXJnZXJSZXNvdXJjZXNCdXR0 b24uYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl90b2dnbGVMYXJnZXJSZXNvdXJjZXMu YmluZCh0aGlzKSwgZmFsc2UpOworICAgIGlmICghUHJlZmVyZW5jZXMucmVzb3VyY2VzTGFyZ2VS b3dzKSB7CisgICAgICAgIFByZWZlcmVuY2VzLnJlc291cmNlc0xhcmdlUm93cyA9ICFQcmVmZXJl bmNlcy5yZXNvdXJjZXNMYXJnZVJvd3M7CisgICAgICAgIHRoaXMuX3RvZ2dsZUxhcmdlclJlc291 cmNlcygpOyAvLyB0aGlzIHdpbGwgdG9nZ2xlIHRoZSBwcmVmZXJlbmNlIGJhY2sgdG8gdGhlIG9y aWdpbmFsCisgICAgfQogCiAgICAgdGhpcy5zb3J0aW5nU2VsZWN0RWxlbWVudCA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoInNlbGVjdCIpOwogICAgIHRoaXMuc29ydGluZ1NlbGVjdEVsZW1lbnQu Y2xhc3NOYW1lID0gInN0YXR1cy1iYXItaXRlbSI7CkBAIC04MjUsNiArODI5LDggQEAgV2ViSW5z cGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybjsK IAogICAgICAgICB0aGlzLnJlc291cmNlc1RyZWVFbGVtZW50LnNtYWxsQ2hpbGRyZW4gPSAhdGhp cy5yZXNvdXJjZXNUcmVlRWxlbWVudC5zbWFsbENoaWxkcmVuOworICAgICAgICBQcmVmZXJlbmNl cy5yZXNvdXJjZXNMYXJnZVJvd3MgPSAhUHJlZmVyZW5jZXMucmVzb3VyY2VzTGFyZ2VSb3dzOwor ICAgICAgICBJbnNwZWN0b3JDb250cm9sbGVyLnNldFNldHRpbmcoInJlc291cmNlcy1sYXJnZS1y b3dzIiwgUHJlZmVyZW5jZXMucmVzb3VyY2VzTGFyZ2VSb3dzKTsKIAogICAgICAgICBpZiAodGhp cy5yZXNvdXJjZXNUcmVlRWxlbWVudC5zbWFsbENoaWxkcmVuKSB7CiAgICAgICAgICAgICB0aGlz LnJlc291cmNlc0dyYXBoc0VsZW1lbnQuYWRkU3R5bGVDbGFzcygic21hbGwiKTsKZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCmluZGV4IGU5ZTRkZDMuLjk5YjA3OTQgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtNDMsNyArNDMsOCBA QCB2YXIgUHJlZmVyZW5jZXMgPSB7CiAgICAgc2FtcGxpbmdDUFVQcm9maWxlcjogZmFsc2UsCiAg ICAgc2hvd0NvbG9yTmlja25hbWVzOiB0cnVlLAogICAgIGNvbG9yRm9ybWF0OiAiaGV4IiwKLSAg ICBldmVudExpc3RlbmVyc0ZpbHRlcjogImFsbCIKKyAgICBldmVudExpc3RlbmVyc0ZpbHRlcjog ImFsbCIsCisgICAgcmVzb3VyY2VzTGFyZ2VSb3dzOiB0cnVlCiB9CiAKIHZhciBXZWJJbnNwZWN0 b3IgPSB7CkBAIC0xNDUsNiArMTQ2LDIxIEBAIHZhciBXZWJJbnNwZWN0b3IgPSB7CiAgICAgICAg ICAgICB0aGlzLnBhbmVscy5zdG9yYWdlID0gbmV3IFdlYkluc3BlY3Rvci5TdG9yYWdlUGFuZWwo KTsgICAgICAKICAgICB9LAogCisgICAgX2xvYWRQcmVmZXJlbmNlczogZnVuY3Rpb24oKQorICAg IHsKKyAgICAgICAgdmFyIGNvbG9yRm9ybWF0ID0gSW5zcGVjdG9yQ29udHJvbGxlci5zZXR0aW5n KCJjb2xvci1mb3JtYXQiKTsKKyAgICAgICAgaWYgKGNvbG9yRm9ybWF0KQorICAgICAgICAgICAg UHJlZmVyZW5jZXMuY29sb3JGb3JtYXQgPSBjb2xvckZvcm1hdDsKKworICAgICAgICB2YXIgZXZl bnRMaXN0ZW5lcnNGaWx0ZXIgPSBJbnNwZWN0b3JDb250cm9sbGVyLnNldHRpbmcoImV2ZW50LWxp c3RlbmVycy1maWx0ZXIiKTsKKyAgICAgICAgaWYgKGV2ZW50TGlzdGVuZXJzRmlsdGVyKQorICAg ICAgICAgICAgUHJlZmVyZW5jZXMuZXZlbnRMaXN0ZW5lcnNGaWx0ZXIgPSBldmVudExpc3RlbmVy c0ZpbHRlcjsKKworICAgICAgICB2YXIgcmVzb3VyY2VzTGFyZ2VSb3dzID0gSW5zcGVjdG9yQ29u dHJvbGxlci5zZXR0aW5nKCJyZXNvdXJjZXMtbGFyZ2Utcm93cyIpOworICAgICAgICBpZiAocmVz b3VyY2VzTGFyZ2VSb3dzICE9PSB1bmRlZmluZWQpCisgICAgICAgICAgICBQcmVmZXJlbmNlcy5y ZXNvdXJjZXNMYXJnZVJvd3MgPSByZXNvdXJjZXNMYXJnZVJvd3M7CisgICAgfSwKKwogICAgIGdl dCBhdHRhY2hlZCgpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fYXR0YWNoZWQ7CkBAIC0z NTEsMTMgKzM2Nyw3IEBAIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgdmFy IHBsYXRmb3JtID0gSW5zcGVjdG9yQ29udHJvbGxlci5wbGF0Zm9ybSgpOwogICAgIGRvY3VtZW50 LmJvZHkuYWRkU3R5bGVDbGFzcygicGxhdGZvcm0tIiArIHBsYXRmb3JtKTsKIAotICAgIHZhciBj b2xvckZvcm1hdCA9IEluc3BlY3RvckNvbnRyb2xsZXIuc2V0dGluZygiY29sb3ItZm9ybWF0Iik7 Ci0gICAgaWYgKGNvbG9yRm9ybWF0KQotICAgICAgICBQcmVmZXJlbmNlcy5jb2xvckZvcm1hdCA9 IGNvbG9yRm9ybWF0OwotCi0gICAgdmFyIGV2ZW50TGlzdGVuZXJzRmlsdGVyID0gSW5zcGVjdG9y Q29udHJvbGxlci5zZXR0aW5nKCJldmVudC1saXN0ZW5lcnMtZmlsdGVyIik7Ci0gICAgaWYgKGV2 ZW50TGlzdGVuZXJzRmlsdGVyKQotICAgICAgICBQcmVmZXJlbmNlcy5ldmVudExpc3RlbmVyc0Zp bHRlciA9IGV2ZW50TGlzdGVuZXJzRmlsdGVyOworICAgIHRoaXMuX2xvYWRQcmVmZXJlbmNlcygp OwogCiAgICAgdGhpcy5kcmF3ZXIgPSBuZXcgV2ViSW5zcGVjdG9yLkRyYXdlcigpOwogICAgIHRo aXMuY29uc29sZSA9IG5ldyBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcodGhpcy5kcmF3ZXIpOwo=