29083 2009-09-09 06:54:29 -0700 Disable some ARM compiler warnings 2009-09-10 05:01:54 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED Qt P2 Normal --- 0 laszlo.gombos webkit-unassigned eric oldest_to_newest 145722 0 laszlo.gombos 2009-09-09 06:54:29 -0700 By default the ARM compiler is very chatty and it is hard to see "the wood for the trees". I would propose to disable the following ARM warnings (as far as I can tell none of these warnings are enabled on most ports): #68-D: integer conversion resulted in a change of sign #111-D: statement is unreachable #177-D: variable XXX was declared but never referenced #368-D: class XXX defines no constructor to initialize the following: YYY #830-D: function XXX "XXX::operator new" has no corresponding operator delete (to be called if an exception is thrown during initialization of an allocated object) #1293-D: assignment in condition 145726 1 39268 laszlo.gombos 2009-09-09 07:06:52 -0700 Created attachment 39268 proposed path Also did a bit of refactoring so that the rules don't repeat for all ARM compiler targets. 145748 2 eric 2009-09-09 07:53:19 -0700 Maybe we should add a comment in the build file about the warnings you are disabling? Or at least in the ChangeLog? 145754 3 laszlo.gombos 2009-09-09 08:01:34 -0700 (In reply to comment #2) > Maybe we should add a comment in the build file about the warnings you are > disabling? Or at least in the ChangeLog? Eric, I will add the list of warnings to the ChangeLog when I commit. Thanks ! 145787 4 39272 laszlo.gombos 2009-09-09 09:29:14 -0700 Created attachment 39272 Updated ChangeLog Incorporating Eric's comment. 146010 5 eric 2009-09-09 16:52:31 -0700 Do you really want to disable all these? #68-D: integer conversion resulted in a change of sign #111-D: statement is unreachable #177-D: variable XXX was declared but never referenced #368-D: class XXX defines no constructor to initialize the following: YYY #830-D: function XXX "XXX::operator new" has no corresponding operator delete (to be called if an exception is thrown during initialization of an allocated object) #1293-D: assignment in condition All of those sound useful (and likely real bugs), no? 146165 6 laszlo.gombos 2009-09-10 04:48:52 -0700 (In reply to comment #5) > Do you really want to disable all these? > > #68-D: integer conversion resulted in a change of sign > #111-D: statement is unreachable > #177-D: variable XXX was declared but never referenced > #368-D: class XXX defines no constructor to initialize the following: YYY > #830-D: function XXX "XXX::operator new" has no corresponding operator delete > (to be called if an exception is thrown during initialization of an allocated > object) > #1293-D: assignment in condition > > All of those sound useful (and likely real bugs), no? Eric, I scanned trough the warnings and the corresponding code and I could not spot a real bug. The direction is definitively to get rid of all the warnings gradually (and take them out from this list), but restricting the list help to focus on the remaining warnings first. 146167 7 laszlo.gombos 2009-09-10 05:01:34 -0700 Committed as http://trac.webkit.org/changeset/48250 39268 2009-09-09 07:06:52 -0700 2009-09-09 09:29:14 -0700 proposed path patch_29083.txt text/plain 1400 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ4MjA1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDkt MDkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgc29tZSBBUk0g Y29tcGlsZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI5MDgzCisKKyAgICAgICAgKiBXZWJLaXQucHJpOgorCiAyMDA5LTA5LTA3ICBY YW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBi eSBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJLaXQucHJpCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC5wcmkJKHJldmlzaW9uIDQ4MTY1KQorKysgV2ViS2l0LnByaQkod29ya2luZyBjb3B5KQpAQCAt NDQsMTQgKzQ0LDE5IEBAIENPTkZJRyAtPSB3YXJuX29uCiAjUU1BS0VfQ1hYRkxBR1MgKz0gLVdh bGwgLVduby11bmRlZiAtV25vLXVudXNlZC1wYXJhbWV0ZXIKIAogIyBFbmFibGUgR05VIGNvbXBp bGVyIGV4dGVuc2lvbnMgdG8gdGhlIEFSTSBjb21waWxlciBmb3IgYWxsIFF0IHBvcnRzIHVzaW5n IFJWQ1QKLSotYXJtY2MgewotICAgIFFNQUtFX0NGTEFHUyArPSAtLWdudQotICAgIFFNQUtFX0NY WEZMQUdTICs9IC0tZ251IC0tbm9fcGFyc2VfdGVtcGxhdGVzCitzeW1iaWFufCotYXJtY2Mgewor ICAgIFJWQ1RfQ09NTU9OX0NGTEFHUyA9IC0tZ251IC0tZGlhZ19zdXBwcmVzcyA2OCwxMTEsMTc3 LDM2OCw4MzAsMTI5MworICAgIFJWQ1RfQ09NTU9OX0NYWEZMQUdTID0gJCRSVkNUX0NPTU1PTl9D RkxBR1MgLS1ub19wYXJzZV90ZW1wbGF0ZXMKKyAgICBERUZJTkVTICo9IFFUX05PX1VJVE9PTFMK IH0gCiAKKyotYXJtY2MgeworICAgIFFNQUtFX0NGTEFHUyArPSAkJFJWQ1RfQ09NTU9OX0NGTEFH UworICAgIFFNQUtFX0NYWEZMQUdTICs9ICQkUlZDVF9DT01NT05fQ1hYRkxBR1MKK30KKwogc3lt YmlhbiB7Ci0gICAgUU1BS0VfQ1hYRkxBR1MuQVJNQ0MgKz0gLS1nbnUgLS1ub19wYXJzZV90ZW1w bGF0ZXMKLSAgICBERUZJTkVTICo9IFFUX05PX1VJVE9PTFMKKyAgICBRTUFLRV9DWFhGTEFHUy5B Uk1DQyArPSAkJFJWQ1RfQ09NTU9OX0NYWEZMQUdTCiB9CiAKIGNvbnRhaW5zKERFRklORVMsIFFU X05PX1VJVE9PTFMpOiBDT05GSUcgLT0gdWl0b29scwo= 39272 2009-09-09 09:29:14 -0700 2009-09-10 05:01:54 -0700 Updated ChangeLog patch_29083.txt text/plain 1856 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ4MjA5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMDkt MDkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgc29tZSBBUk0g Y29tcGlsZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI5MDgzCisKKyAgICAgICAgVGhlIGZvbGxvd2luZyBBUk0gY29tcGlsZXIgd2Fy bmluZ3MgYXJlIGRpc2FibGVkCisKKyAgICAgICAgLSAjNjgtRDogaW50ZWdlciBjb252ZXJzaW9u IHJlc3VsdGVkIGluIGEgY2hhbmdlIG9mIHNpZ24KKyAgICAgICAgLSAjMTExLUQ6IHN0YXRlbWVu dCBpcyB1bnJlYWNoYWJsZQorICAgICAgICAtICMxNzctRDogdmFyaWFibGUgWFhYIHdhcyBkZWNs YXJlZCBidXQgbmV2ZXIgcmVmZXJlbmNlZAorICAgICAgICAtICMzNjgtRDogY2xhc3MgWFhYIGRl ZmluZXMgbm8gY29uc3RydWN0b3IgdG8gaW5pdGlhbGl6ZSB0aGUgZm9sbG93aW5nOiBZWVkKKyAg ICAgICAgLSAjODMwLUQ6IGZ1bmN0aW9uIFhYWCAiWFhYOjpvcGVyYXRvciBuZXciIGhhcyBubyBj b3JyZXNwb25kaW5nIG9wZXJhdG9yIGRlbGV0ZQorICAgICAgICAtICMxMjkzLUQ6IGFzc2lnbm1l bnQgaW4gY29uZGl0aW9uCisKKyAgICAgICAgKiBXZWJLaXQucHJpOgorCiAyMDA5LTA5LTA3ICBY YW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBi eSBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJLaXQucHJpCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC5wcmkJKHJldmlzaW9uIDQ4MjA5KQorKysgV2ViS2l0LnByaQkod29ya2luZyBjb3B5KQpAQCAt NDQsMTQgKzQ0LDE5IEBAIENPTkZJRyAtPSB3YXJuX29uCiAjUU1BS0VfQ1hYRkxBR1MgKz0gLVdh bGwgLVduby11bmRlZiAtV25vLXVudXNlZC1wYXJhbWV0ZXIKIAogIyBFbmFibGUgR05VIGNvbXBp bGVyIGV4dGVuc2lvbnMgdG8gdGhlIEFSTSBjb21waWxlciBmb3IgYWxsIFF0IHBvcnRzIHVzaW5n IFJWQ1QKLSotYXJtY2MgewotICAgIFFNQUtFX0NGTEFHUyArPSAtLWdudQotICAgIFFNQUtFX0NY WEZMQUdTICs9IC0tZ251IC0tbm9fcGFyc2VfdGVtcGxhdGVzCitzeW1iaWFufCotYXJtY2Mgewor ICAgIFJWQ1RfQ09NTU9OX0NGTEFHUyA9IC0tZ251IC0tZGlhZ19zdXBwcmVzcyA2OCwxMTEsMTc3 LDM2OCw4MzAsMTI5MworICAgIFJWQ1RfQ09NTU9OX0NYWEZMQUdTID0gJCRSVkNUX0NPTU1PTl9D RkxBR1MgLS1ub19wYXJzZV90ZW1wbGF0ZXMKKyAgICBERUZJTkVTICo9IFFUX05PX1VJVE9PTFMK IH0gCiAKKyotYXJtY2MgeworICAgIFFNQUtFX0NGTEFHUyArPSAkJFJWQ1RfQ09NTU9OX0NGTEFH UworICAgIFFNQUtFX0NYWEZMQUdTICs9ICQkUlZDVF9DT01NT05fQ1hYRkxBR1MKK30KKwogc3lt YmlhbiB7Ci0gICAgUU1BS0VfQ1hYRkxBR1MuQVJNQ0MgKz0gLS1nbnUgLS1ub19wYXJzZV90ZW1w bGF0ZXMKLSAgICBERUZJTkVTICo9IFFUX05PX1VJVE9PTFMKKyAgICBRTUFLRV9DWFhGTEFHUy5B Uk1DQyArPSAkJFJWQ1RfQ09NTU9OX0NYWEZMQUdTCiB9CiAKIGNvbnRhaW5zKERFRklORVMsIFFU X05PX1VJVE9PTFMpOiBDT05GSUcgLT0gdWl0b29scwo=