29066 2009-09-08 19:14:08 -0700 Remove WTF_PLATFORM_FORCE_PACK as it is no longer used 2009-09-09 10:58:03 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned eric oldest_to_newest 145630 0 laszlo.gombos 2009-09-08 19:14:08 -0700 svn blame pointed me to to this 2 years old commit. http://trac.webkit.org/changeset/25321 I did a full search for FORCE_PACK in the source tree and all the references are removed from WebKit. ARM detection rules are already compex enough, we do not need a configuration option that is no longer used. 145633 1 39243 laszlo.gombos 2009-09-08 19:45:30 -0700 Created attachment 39243 proposed patch. 145788 2 39243 eric 2009-09-09 09:32:50 -0700 Comment on attachment 39243 proposed patch. Rejecting patch 39243 from commit-queue. laszlo.1.gombos@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 145798 3 39243 eric 2009-09-09 09:38:50 -0700 Comment on attachment 39243 proposed patch. Seems laszlo needs to add himself to committers.py. But I'm happy to set cq+ on this patch. 145812 4 laszlo.gombos 2009-09-09 10:01:23 -0700 (In reply to comment #3) > (From update of attachment 39243 [details]) > Seems laszlo needs to add himself to committers.py. But I'm happy to set cq+ > on this patch. Eric, I think I added myself to the list yesterday - see http://trac.webkit.org/changeset/48159 I'm happy to commit as well, if needed. 145839 5 eric 2009-09-09 10:58:03 -0700 http://trac.webkit.org/changeset/48216 The commit-queue is undergoing some minor surgery at the moment. :) Bear with me... 39243 2009-09-08 19:45:30 -0700 2009-09-09 09:38:50 -0700 proposed patch. patch_29066.txt text/plain 1139 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ4MTk4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDktMDggIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBXVEZfUExBVEZPUk1fRk9SQ0VfUEFD SyBhcyBpdCBpcyBubyBsb25nZXIgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjkwNjYKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAy MDA5LTA5LTA4ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAg ICAgICAgIHd4IGJ1aWxkIGZpeCwgZ2VuZXJhdGUgZGVyaXZlZCBzb3VyY2VzIGVhcmxpZXIgaW4g b3JkZXIgdG8gbWFrZSBzdXJlCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNDgx NjUpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAt MjM0LDkgKzIzNCw2IEBACiAjZWxpZiAhZGVmaW5lZChfX0FSTV9FQUJJX18pICYmICFkZWZpbmVk KF9fRUFCSV9fKSAmJiAhZGVmaW5lZChfX1ZGUF9GUF9fKQogI2RlZmluZSBXVEZfUExBVEZPUk1f TUlERExFX0VORElBTiAxCiAjZW5kaWYKLSNpZiAhZGVmaW5lZChfX0FSTV9FQUJJX18pICYmICFk ZWZpbmVkKF9fRUFCSV9fKQotI2RlZmluZSBXVEZfUExBVEZPUk1fRk9SQ0VfUEFDSyAxCi0jZW5k aWYKICNkZWZpbmUgQVJNX0FSQ0hfVkVSU0lPTiAzCiAjaWYgZGVmaW5lZChfX0FSTV9BUkNIXzRf XykgfHwgZGVmaW5lZChfX0FSTV9BUkNIXzRUX18pCiAjdW5kZWYgQVJNX0FSQ0hfVkVSU0lPTgo=