29051 2009-09-08 14:05:51 -0700 [V8] Chromium mac build break due to spurious <iterator> include in V8Proxy 2009-09-08 14:14:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet japhet eric mark oldest_to_newest 145526 0 japhet 2009-09-08 14:05:51 -0700 V8Proxy.h unnecessarily includes <iterator>, which just recently started being included in an ObjC include chain. This library appears to make use of some exception code, and the proper redefines are not present to make try/catch blocks play nice in a compile that doesn't allow exceptions. Fixing should be as simple as removing the <iterator> include. 145528 1 39210 japhet 2009-09-08 14:08:36 -0700 Created attachment 39210 patch 145529 2 39210 dglazkov 2009-09-08 14:09:59 -0700 Comment on attachment 39210 patch Victory! r=me. 145534 3 japhet 2009-09-08 14:14:09 -0700 Landed as r48185. 39210 2009-09-08 14:08:36 -0700 2009-09-08 14:09:59 -0700 patch patch.txt text/plain 981 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODE4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMDggIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8 aXRlcmF0b3I+IGluY2x1ZGUgaW4gVjhQcm94eS5oIGlzIHNwdXJpb3VzIGFuZCBjYXVzaW5nIE9i akMgY29tcGlsZSBpc3N1ZXMgZm9yIENocm9taXVtLgorCisgICAgICAgIFRlc3Q6IENocm9taXVt IG1hYyBjYW5hcnkgYnVpbGQgaXMgZml4ZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFBy b3h5Lmg6IFJlbW92ZSA8aXRlcmF0b3I+IGluY2x1ZGUuCisKIDIwMDktMDktMDggIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYXR0ZW1wdCB0byBm aXggdGhlIEdUSysgYnVpbGQuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAkocmV2aXNpb24gNDgx ODIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAt NDksNyArNDksNiBAQAogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+IC8vIHNvIGdlbmVyYXRl ZCBiaW5kaW5ncyBkb24ndCBoYXZlIHRvCiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCi0jaW5j bHVkZSA8aXRlcmF0b3I+CiAjaW5jbHVkZSA8bGlzdD4KIAogI2lmZGVmIEVOQUJMRV9ET01fU1RB VFNfQ09VTlRFUlMK