29048 2009-09-08 13:43:27 -0700 [Qt] make RenderStyle.h compile in winscw compiler. 2010-12-16 09:28:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 27065 1 yongjun.zhang yongjun.zhang commit-queue hausmann koshuin laszlo.gombos webkit.review.bot oldest_to_newest 145519 0 yongjun.zhang 2009-09-08 13:43:27 -0700 In RenderStyle.h, Winscw compiler is not able to resolve compareEuqal used in SET_VAR macro; the compiler reports error "illegal operand". 145551 1 39217 yongjun.zhang 2009-09-08 14:50:49 -0700 Created attachment 39217 Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template. 145552 2 39217 eric 2009-09-08 14:53:39 -0700 Comment on attachment 39217 Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template. There needs to be a comment next to the macro definition as to why it exists. Also, could you paste the error in the bug? Are we sure this is the best solution? Do we have a bug filed with the winscw compiler? If so, can we link to it? 145693 3 vestbo 2009-09-09 02:55:53 -0700 Please use the keyword 'Qt' for bugs related to QtWebKit. The component 'WebKit Qt' is for QtWebKit API issues only. 175491 4 hausmann 2009-12-29 03:45:58 -0800 This appears to be one of the few remaining WINSCW issues. Any update on this about the error message, etc.? (See Eric's comment) 176049 5 yongjun.zhang 2009-12-30 14:25:56 -0800 There was a bug reported against this in Winscw compiler bugzilla: https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447 176050 6 45686 yongjun.zhang 2009-12-30 14:27:21 -0800 Created attachment 45686 add link to winscw compiler bug as suggested by Erik. 176054 7 webkit.review.bot 2009-12-30 14:33:53 -0800 style-queue ran check-webkit-style on attachment 45686 without any errors. 176185 8 45686 laszlo.gombos 2009-12-31 07:03:38 -0800 Comment on attachment 45686 add link to winscw compiler bug as suggested by Erik. Looks good to me, r+; At commit, it would be useful to add a comment right by the macro in RenderStyle.h as well, as Eric suggested. 176686 9 45686 commit-queue 2010-01-04 07:33:50 -0800 Comment on attachment 45686 add link to winscw compiler bug as suggested by Erik. Clearing flags on attachment: 45686 Committed r52733: <http://trac.webkit.org/changeset/52733> 176687 10 commit-queue 2010-01-04 07:33:55 -0800 All reviewed patches have been landed. Closing bug. 39217 2009-09-08 14:50:49 -0700 2009-09-08 14:53:38 -0700 Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template. RenderStyle_h.patch text/plain 1279 yongjun.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODE4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDktMDggIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuLnpoYW5n QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkwNDgKKworICAg ICAgICBbUXRdIG1ha2UgUmVuZGVyU3R5bGUuaCBjb21waWxlIGluIHdpbnNjdyBjb21waWxlci4K KworICAgICAgICBDaGFuZ2UgY29tcGFyZUVxdWFsIHRvIGEgbWFjcm8gaW4gV2luc2N3IGNvbXBp bGVyIHRvIGdldCBhcm91bmQgImlsbGVnYWwgb3BlcmFuZCIgZXJyb3IKKyAgICAgICAgd2hlbiBj b21wYXJlRXF1YWwgaXMgZGVmaW5lZCBhcyB0ZW1wbGF0ZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9zdHlsZS9SZW5kZXJTdHlsZS5oOgorCiAyMDA5LTA5LTA4ICBYYW4gTG9wZXogIDx4bG9wZXpA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGF0dGVtcHQgdG8gZml4IHRoZSBHVEsr IGJ1aWxkLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCShyZXZpc2lv biA0ODE2MCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgJKHdvcmtp bmcgY29weSkKQEAgLTg3LDcgKzg3LDExIEBACiAjaW5jbHVkZSAiQmluZGluZ1VSSS5oIgogI2Vu ZGlmCiAKKyNpZiBQTEFURk9STShXSU5TQ1cpCisjZGVmaW5lIGNvbXBhcmVFcXVhbCh0LCB1KSAg ICAgICAgICAgICAgKCh0KSA9PSAodSkpCisjZWxzZQogdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlw ZW5hbWUgVT4gaW5saW5lIGJvb2wgY29tcGFyZUVxdWFsKGNvbnN0IFQmIHQsIGNvbnN0IFUmIHUp IHsgcmV0dXJuIHQgPT0gc3RhdGljX2Nhc3Q8VD4odSk7IH0KKyNlbmRpZgogCiAjZGVmaW5lIFNF VF9WQVIoZ3JvdXAsIHZhcmlhYmxlLCB2YWx1ZSkgXAogICAgIGlmICghY29tcGFyZUVxdWFsKGdy b3VwLT52YXJpYWJsZSwgdmFsdWUpKSBcCg== 45686 2009-12-30 14:27:21 -0800 2010-01-04 07:33:49 -0800 add link to winscw compiler bug as suggested by Erik. RenderStyle.patch text/plain 1377 yongjun.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjY3MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTItMzAgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuLnpoYW5n QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkwNDgKKyAgICAg ICAgW1F0XSBtYWtlIFJlbmRlclN0eWxlLmggY29tcGlsZSBpbiB3aW5zY3cgY29tcGlsZXIuCisK KyAgICAgICAgQ2hhbmdlIGNvbXBhcmVFcXVhbCB0byBhIG1hY3JvIGluIFdpbnNjdyBjb21waWxl ciB0byBnZXQgYXJvdW5kICJpbGxlZ2FsIG9wZXJhbmQiIAorICAgICAgICBlcnJvciB3aGVuIGNv bXBhcmVFcXVhbCBpcyBkZWZpbmVkIGFzIHRlbXBsYXRlLgorCisgICAgICAgIFRoZSBjb21waWxl ciBidWcgaXMgcmVwb3J0ZWQgYXQ6CisgICAgICAgIGh0dHBzOi8veGRhYnVnMDAxLmV4dC5ub2tp YS5jb20vYnVnemlsbGEvc2hvd19idWcuY2dpP2lkPTEwNDQ3CisKKyAgICAgICAgKiByZW5kZXJp bmcvc3R5bGUvUmVuZGVyU3R5bGUuaDoKKwogMjAwOS0xMi0zMCAgTmF0ZSBDaGFwaW4gIDxqYXBo ZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4K SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAkocmV2aXNpb24gNTI2NjAp CisrKyBXZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCSh3b3JraW5nIGNvcHkp CkBAIC04OSw3ICs4OSwxMSBAQAogI2luY2x1ZGUgIkJpbmRpbmdVUkkuaCIKICNlbmRpZgogCisj aWYgQ09NUElMRVIoV0lOU0NXKQorI2RlZmluZSBjb21wYXJlRXF1YWwodCwgdSkgICAgICAoKHQp ID09ICh1KSkKKyNlbHNlCiB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVPiBpbmxpbmUg Ym9vbCBjb21wYXJlRXF1YWwoY29uc3QgVCYgdCwgY29uc3QgVSYgdSkgeyByZXR1cm4gdCA9PSBz dGF0aWNfY2FzdDxUPih1KTsgfQorI2VuZGlmCiAKICNkZWZpbmUgU0VUX1ZBUihncm91cCwgdmFy aWFibGUsIHZhbHVlKSBcCiAgICAgaWYgKCFjb21wYXJlRXF1YWwoZ3JvdXAtPnZhcmlhYmxlLCB2 YWx1ZSkpIFwK