29044 2009-09-08 12:20:11 -0700 [GTK] Should update suggested-filename when the response is received 2009-09-08 14:02:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk, Soup P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 145488 0 gustavo 2009-09-08 12:20:11 -0700 When the WebKitDownload object is created with a live Handle, it also has a ResourceResponse object containing the suggested filename. For cases where download is started from scratch, even after the response is received the WebKitDownload's object notion of the suggested filename is not updated. 145492 1 39203 gustavo 2009-09-08 12:23:13 -0700 Created attachment 39203 proposed solution 145507 2 gustavo 2009-09-08 13:03:18 -0700 Will also add this, actually: diff --git a/WebKit/gtk/webkit/webkitwebview.cpp b/WebKit/gtk/webkit/webkitwebview.cpp index 3d24598..617ce0b 100644 --- a/WebKit/gtk/webkit/webkitwebview.cpp +++ b/WebKit/gtk/webkit/webkitwebview.cpp @@ -2587,9 +2587,6 @@ void webkit_web_view_request_download(WebKitWebView* webView, WebKitNetworkReque else download = webkit_download_new(request); - if (!response.isNull() && !response.suggestedFilename().isEmpty()) - webkit_download_set_suggested_filename(download, response.suggestedFilename().utf8().data()); - gboolean handled; g_signal_emit(webView, webkit_web_view_signals[DOWNLOAD_REQUESTED], 0, download, &handled); 145510 3 39203 xan.lopez 2009-09-08 13:04:44 -0700 Comment on attachment 39203 proposed solution r=me with the change in the comment. 145524 4 gustavo 2009-09-08 14:02:40 -0700 Landed as r48183. 39203 2009-09-08 12:23:13 -0700 2009-09-08 13:04:44 -0700 proposed solution 0001-2009-09-08-Gustavo-Noronha-Silva-gustavo.noronha-col.patch text/plain 2553 gustavo RnJvbSA4NjQ4NGJjYmNkYTE5OTlmZGFiZDI3N2FkZjgwZmFkNTE1ZjNiM2YzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFR1ZSwgOCBTZXAgMjAwOSAxNjoyMjowNSAtMDMwMApT dWJqZWN0OiBbUEFUQ0hdIDIwMDktMDktMDggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rh dm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjkwNDQKICAgICAgICBbR1RLXSBTaG91bGQgdXBkYXRlIHN1Z2dlc3RlZC1maWxlbmFtZSB3aGVu IHRoZSByZXNwb25zZSBpcyByZWNlaXZlZAoKICAgICAgICBTZXQgc3VnZ2VzdGVkIGZpbGVuYW1l IGFsc28gd2hlbiB0aGUgcmVzcG9uc2Ugb25seSBjb21lcyBhZnRlciB0aGUKICAgICAgICBkb3du bG9hZCBoYXMgc3RhcnRlZC4KCiAgICAgICAgKiB3ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwOgog ICAgICAgICh3ZWJraXRfZG93bmxvYWRfc2V0X3Jlc3BvbnNlKToKICAgICAgICAod2Via2l0X2Rv d25sb2FkX3NldF9zdWdnZXN0ZWRfZmlsZW5hbWUpOgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYktpdC9ndGsvd2Via2l0 L3dlYmtpdGRvd25sb2FkLmNwcCB8ICAgIDUgKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTkgaW5z ZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDUzNWI5ZWMuLmI3ZDc2ZDUgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMDggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rh dm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI5MDQ0CisgICAgICAgIFtHVEtdIFNob3VsZCB1cGRhdGUgc3VnZ2VzdGVkLWZpbGVuYW1l IHdoZW4gdGhlIHJlc3BvbnNlIGlzIHJlY2VpdmVkCisKKyAgICAgICAgU2V0IHN1Z2dlc3RlZCBm aWxlbmFtZSBhbHNvIHdoZW4gdGhlIHJlc3BvbnNlIG9ubHkgY29tZXMgYWZ0ZXIgdGhlCisgICAg ICAgIGRvd25sb2FkIGhhcyBzdGFydGVkLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdGRvd25s b2FkLmNwcDoKKyAgICAgICAgKHdlYmtpdF9kb3dubG9hZF9zZXRfcmVzcG9uc2UpOgorICAgICAg ICAod2Via2l0X2Rvd25sb2FkX3NldF9zdWdnZXN0ZWRfZmlsZW5hbWUpOgorCiAyMDA5LTA5LTA4 ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1 c3Rhdm8gTm9yb25oYS4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25s b2FkLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcAppbmRleCBkYTU4 OThlLi41NjgzNzhjIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9h ZC5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwCkBAIC01MzUs NiArNTM1LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X2Rvd25sb2FkX3NldF9yZXNwb25zZShXZWJL aXREb3dubG9hZCogZG93bmxvYWQsIGNvbnN0IFJlc291cmMKICAgICAvLyBGSVhNRSBVc2UgV2Vi S2l0TmV0d29ya1Jlc3BvbnNlIHdoZW4gaXQncyBtZXJnZWQuCiAgICAgV2ViS2l0RG93bmxvYWRQ cml2YXRlKiBwcml2ID0gZG93bmxvYWQtPnByaXY7CiAgICAgcHJpdi0+bmV0d29ya1Jlc3BvbnNl ID0gbmV3IFJlc291cmNlUmVzcG9uc2UocmVzcG9uc2UpOworCisgICAgaWYgKCFyZXNwb25zZS5p c051bGwoKSAmJiAhcmVzcG9uc2Uuc3VnZ2VzdGVkRmlsZW5hbWUoKS5pc0VtcHR5KCkpCisgICAg ICAgIHdlYmtpdF9kb3dubG9hZF9zZXRfc3VnZ2VzdGVkX2ZpbGVuYW1lKGRvd25sb2FkLCByZXNw b25zZS5zdWdnZXN0ZWRGaWxlbmFtZSgpLnV0ZjgoKS5kYXRhKCkpOwogfQogCiAvKioKQEAgLTU2 OSw2ICs1NzIsOCBAQCB2b2lkIHdlYmtpdF9kb3dubG9hZF9zZXRfc3VnZ2VzdGVkX2ZpbGVuYW1l KFdlYktpdERvd25sb2FkKiBkb3dubG9hZCwgY29uc3QgZ2NoYQogICAgIFdlYktpdERvd25sb2Fk UHJpdmF0ZSogcHJpdiA9IGRvd25sb2FkLT5wcml2OwogICAgIGdfZnJlZShwcml2LT5zdWdnZXN0 ZWRGaWxlbmFtZSk7CiAgICAgcHJpdi0+c3VnZ2VzdGVkRmlsZW5hbWUgPSBnX3N0cmR1cChzdWdn ZXN0ZWRGaWxlbmFtZSk7CisKKyAgICBnX29iamVjdF9ub3RpZnkoR19PQkpFQ1QoZG93bmxvYWQp LCAic3VnZ2VzdGVkLWZpbGVuYW1lIik7CiB9CiAKIAotLSAKMS42LjMuMwoK