29038 2009-09-08 10:17:39 -0700 Wrong preference name in layout tests 2009-09-09 09:44:55 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 arv arv eric oldest_to_newest 145420 0 arv 2009-09-08 10:17:39 -0700 The following layout tests LayoutTests/fast/events/click-focus-anchor.html LayoutTests/fast/events/tab-focus-anchor.html Both contain a reference to a non-existing preference. The correct preference string is: WebKitTabToLinksPreferenceKey 145540 1 39216 arv 2009-09-08 14:30:37 -0700 Created attachment 39216 Patch v1 145603 2 39216 eric 2009-09-08 17:38:55 -0700 Comment on attachment 39216 Patch v1 Rejecting patch 39216 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 145790 3 eric 2009-09-09 09:33:35 -0700 media/video-source-error.html -> timed out Yet another flakey media test. I think I might add that one to the skipped list as yet another straw in the dam. bug 28624. 145804 4 39216 eric 2009-09-09 09:44:52 -0700 Comment on attachment 39216 Patch v1 Clearing flags on attachment: 39216 Committed r48211: <http://trac.webkit.org/changeset/48211> 145805 5 eric 2009-09-09 09:44:55 -0700 All reviewed patches have been landed. Closing bug. 39216 2009-09-08 14:30:37 -0700 2009-09-09 09:44:52 -0700 Patch v1 bug-29038-20090908143035.patch text/plain 1626 arv ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZDYwNDM1Li4xNTZhMDlhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDkt MDggIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcHJlZmVyZW5jZSBuYW1lIGluIGxh eW91dCB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjkwMzgKKworICAgICAgICAqIGZhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci5odG1s OgorICAgICAgICAqIGZhc3QvZXZlbnRzL3RhYi1mb2N1cy1hbmNob3IuaHRtbDoKKwogMjAwOS0w OS0wOCAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jbGlj ay1mb2N1cy1hbmNob3IuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3Vz LWFuY2hvci5odG1sCmluZGV4IDlhYTI3MGQuLmY0MWNkZTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci5odG1sCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci5odG1sCkBAIC0yMyw3ICsyMyw3IEBAIGZ1 bmN0aW9uIHBhc3MoKQogCiBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwotICAgIGxheW91dFRlc3RDb250cm9s bGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0VGFiVG9MaW5rcyIsIGZhbHNlKTsKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoJ1dlYktpdFRhYlRvTGlua3NQ cmVmZXJlbmNlS2V5JywgZmFsc2UpOwogfQogCiB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdGFiLWZvY3VzLWFuY2hvci5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdGFiLWZvY3VzLWFuY2hvci5odG1sCmluZGV4IDI5 M2I3ZTYuLjVkZjcyOGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RhYi1m b2N1cy1hbmNob3IuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90YWItZm9jdXMt YW5jaG9yLmh0bWwKQEAgLTE3LDcgKzE3LDcgQEAgZnVuY3Rpb24gZmFpbCgpCiAKIGlmICh3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1w QXNUZXh0KCk7Ci0gICAgbGF5b3V0VGVzdENvbnRyb2xsZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCdX ZWJLaXRUYWJUb0xpbmtzJywgZmFsc2UpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJy aWRlUHJlZmVyZW5jZSgnV2ViS2l0VGFiVG9MaW5rc1ByZWZlcmVuY2VLZXknLCBmYWxzZSk7CiB9 CiAKIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigp