29018 2009-09-07 13:02:54 -0700 [Qt] Fix unused variable warnings 2009-09-08 10:37:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Minor --- 0 laszlo.gombos webkit-unassigned eric oldest_to_newest 145228 0 laszlo.gombos 2009-09-07 13:02:54 -0700 The significance of this work is to make a step towards enforcing the same code quality measures as other WebKit ports (most notably the mac port) so that contributors focusing on a specific WebKit ports are less likely break other ports because of the difference in quality requirements. List of gcc warnings (with elevated warning level) - these warnings are not present in the port independent WebKit code: WebCore/history/qt/HistoryItemQt.cpp:48: warning: unused variable 'loadFormdata' WebCore/platform/graphics/qt/ImageBufferQt.cpp:241: warning: unused variable 'basex' WebCore/platform/qt/RenderThemeQt.cpp:575: warning: unused variable 'appearance' WebKit/qt/Api/qwebpage.cpp:829: warning: unused variable 'fontHeight' WebKit/qt/Api/qwebpage.cpp:817: warning: unused variable 'editor' WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:959: warning: unused variable 'page' WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:989: warning: unused variable 'loadType' WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:990: warning: unused variable 'childLoadType' 145232 1 39161 laszlo.gombos 2009-09-07 13:15:48 -0700 Created attachment 39161 proposed patch. Removed dead code except in WebCore/history/qt/HistoryItemQt.cpp, where it made more sense to comment it out. 145309 2 39161 hausmann 2009-09-08 03:28:24 -0700 Comment on attachment 39161 proposed patch. r=me 145434 3 39161 eric 2009-09-08 10:37:18 -0700 Comment on attachment 39161 proposed patch. Clearing flags on attachment: 39161 Committed r48165: <http://trac.webkit.org/changeset/48165> 145435 4 eric 2009-09-08 10:37:21 -0700 All reviewed patches have been landed. Closing bug. 39161 2009-09-07 13:15:48 -0700 2009-09-08 10:37:17 -0700 proposed patch. patch_29018.txt text/plain 5201 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODEzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDktMDcgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRml4IHVudXNlZCB2YXJpYWJsZSB3YXJuaW5ncworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkwMTgKKworICAgICAgICBObyBmdW5j dGlvbmFsIGNoYW5nZSwgbm8gdGVzdHMuCisKKyAgICAgICAgKiBoaXN0b3J5L3F0L0hpc3RvcnlJ dGVtUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUl0ZW06OnJlc3RvcmVTdGF0ZSk6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpwdXRJbWFnZURhdGEpOgorICAgICAgICAqIHBsYXRmb3JtL3F0L1JlbmRl clRoZW1lUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVRdDo6cGFpbnRNZW51 TGlzdCk6CisKIDIwMDktMDktMDcgIERyZXcgV2lsc29uICA8YXR3aWxzb25AZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvaGlzdG9y eS9xdC9IaXN0b3J5SXRlbVF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2hpc3RvcnkvcXQv SGlzdG9yeUl0ZW1RdC5jcHAJKHJldmlzaW9uIDQ4MTE1KQorKysgV2ViQ29yZS9oaXN0b3J5L3F0 L0hpc3RvcnlJdGVtUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw3ICs0NSw3IEBAIGJvb2wg V2ViQ29yZTo6SGlzdG9yeUl0ZW06OnJlc3RvcmVTdGF0ZSgKICAgICBXZWJDb3JlOjpJbnRQb2lu dCBzY3JvbGxQb2ludDsKICAgICBXVEY6OlZlY3RvcjxpbnQ+IHdlZWtseVZpc2l0Q291bnRzOwog ICAgIFdURjo6VmVjdG9yPGludD4gZGFpbHlWaXNpdENvdW50czsKLSAgICBib29sIGxvYWRGb3Jt ZGF0YTsKKyAgICAvLyBib29sIGxvYWRGb3JtZGF0YTsKICAgICAvLyBXZWJDb3JlOjpTdHJpbmcg Zm9ybUNvbnRlbnRUeXBlOwogICAgIC8vIFdURjo6VmVjdG9yPGNoYXI+IGZvcm1EYXRhOwogCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAJ KHJldmlzaW9uIDQ4MTE1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1 ZmZlclF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM4LDcgKzIzOCw2IEBAIHZvaWQgcHV0SW1h Z2VEYXRhKEltYWdlRGF0YSomIHNvdXJjZSwgY28KICAgICAgICAgcXVpbnQzMiogc2NhbkxpbmUg PSByZWludGVycHJldF9jYXN0PHF1aW50MzIqPihpbWFnZS5zY2FuTGluZSh5ICsgZGVzdHkpKTsK ICAgICAgICAgZm9yIChpbnQgeCA9IDA7IHggPCBudW1Db2x1bW5zOyB4KyspIHsKICAgICAgICAg ICAgIC8vIEltYWdlRGF0YSBzdG9yZXMgdGhlIHBpeGVscyBpbiBSR0JBIHdoaWxlIFFJbWFnZSBp cyBBUkdCCi0gICAgICAgICAgICBpbnQgYmFzZXggPSB4ICogNDsKICAgICAgICAgICAgIHF1aW50 MzIgcGl4ZWwgPSByZWludGVycHJldF9jYXN0PHF1aW50MzIqPihzcmNSb3dzICsgNCAqIHgpWzBd OwogICAgICAgICAgICAgcGl4ZWwgPSAoKHBpeGVsIDw8IDE2KSAmIDB4ZmYwMDAwKSB8ICgocGl4 ZWwgPj4gMTYpICYgMHhmZikgfCAocGl4ZWwgJiAweGZmMDBmZjAwKTsKICAgICAgICAgICAgIHNj YW5MaW5lW3ggKyBkZXN0eF0gPSBwaXhlbDsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvUmVu ZGVyVGhlbWVRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJU aGVtZVF0LmNwcAkocmV2aXNpb24gNDgxMTUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRl clRoZW1lUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzIsNyArNTcyLDcgQEAgYm9vbCBSZW5k ZXJUaGVtZVF0OjpwYWludE1lbnVMaXN0KFJlbmRlcgogICAgIFFTdHlsZU9wdGlvbkNvbWJvQm94 IG9wdDsKICAgICBpZiAocC53aWRnZXQpCiAgICAgICAgIG9wdC5pbml0RnJvbShwLndpZGdldCk7 Ci0gICAgQ29udHJvbFBhcnQgYXBwZWFyYW5jZSA9IGFwcGx5VGhlbWUob3B0LCBvKTsKKyAgICBh cHBseVRoZW1lKG9wdCwgbyk7CiAKICAgICBjb25zdCBRUG9pbnQgdG9wTGVmdCA9IHIudG9wTGVm dCgpOwogICAgIHAucGFpbnRlci0+dHJhbnNsYXRlKHRvcExlZnQpOwpJbmRleDogV2ViS2l0L3F0 L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA0 ODEzMikKKysrIFdlYktpdC9xdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NiBAQAorMjAwOS0wOS0wNyAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBGaXggdW51c2VkIHZhcmlhYmxlIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTAxOAorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNw cDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6a2V5UHJlc3NFdmVudCk6CisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGcmFtZUxvYWRlckNsaWVudFF0OjpzdGFydERvd25sb2FkKToKKyAgICAgICAgKFdlYkNvcmU6 OkZyYW1lTG9hZGVyQ2xpZW50UXQ6OmNyZWF0ZUZyYW1lKToKKwogMjAwOS0wOS0wNyAgSmFrdWIg V2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1v biBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCShyZXZpc2lvbiA0ODExNSkKKysrIFdlYktp dC9xdC9BcGkvcXdlYnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MTQsNyArODE0LDYgQEAg dm9pZCBRV2ViUGFnZVByaXZhdGU6OmtleVByZXNzRXZlbnQoUUtleQogewogICAgIGJvb2wgaGFu ZGxlZCA9IGZhbHNlOwogICAgIFdlYkNvcmU6OkZyYW1lKiBmcmFtZSA9IHBhZ2UtPmZvY3VzQ29u dHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsKLSAgICBXZWJDb3JlOjpFZGl0b3IqIGVk aXRvciA9IGZyYW1lLT5lZGl0b3IoKTsKICAgICAvLyB3ZSBmb3J3YXJkIHRoZSBrZXkgZXZlbnQg dG8gV2ViQ29yZSBmaXJzdCB0byBoYW5kbGUgcG90ZW50aWFsIERPTQogICAgIC8vIGRlZmluZWQg ZXZlbnQgaGFuZGxlcnMgYW5kIGxhdGVyIG9uIGVuZCB1cCBpbiBFZGl0b3JDbGllbnRRdDo6aGFu ZGxlS2V5Ym9hcmRFdmVudAogICAgIC8vIHRvIHRyaWdnZXIgZWRpdG9yIGNvbW1hbmRzIHZpYSB0 cmlnZ2VyQWN0aW9uKCkuCkBAIC04MjYsNyArODI1LDYgQEAgdm9pZCBRV2ViUGFnZVByaXZhdGU6 OmtleVByZXNzRXZlbnQoUUtleQogICAgICAgICBpZiAodmlldykKICAgICAgICAgICAgIGRlZmF1 bHRGb250ID0gdmlldy0+Zm9udCgpOwogICAgICAgICBRRm9udE1ldHJpY3MgZm0oZGVmYXVsdEZv bnQpOwotICAgICAgICBpbnQgZm9udEhlaWdodCA9IGZtLmhlaWdodCgpOwogICAgICAgICBpZiAo IWhhbmRsZVNjcm9sbGluZyhldiwgZnJhbWUpKSB7CiAgICAgICAgICAgICBzd2l0Y2ggKGV2LT5r ZXkoKSkgewogICAgICAgICAgICAgY2FzZSBRdDo6S2V5X0JhY2s6CkluZGV4OiBXZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCShyZXZpc2lvbiA0 ODExNSkKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtOTU2LDcgKzk1Niw2IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGll bnRRdDo6c3RhcnREb3dubG9hZCgKICAgICBpZiAoIW1fd2ViRnJhbWUpCiAgICAgICAgIHJldHVy bjsKIAotICAgIFFXZWJQYWdlICpwYWdlID0gbV93ZWJGcmFtZS0+cGFnZSgpOwogICAgIGVtaXQg bV93ZWJGcmFtZS0+cGFnZSgpLT5kb3dubG9hZFJlcXVlc3RlZChyZXF1ZXN0LnRvTmV0d29ya1Jl cXVlc3QoKSk7CiAjZW5kaWYKIH0KQEAgLTk4Niw5ICs5ODUsNiBAQCBQYXNzUmVmUHRyPEZyYW1l PiBGcmFtZUxvYWRlckNsaWVudFF0OjpjCiAKICAgICAvLyAjIyMgc2V0IG92ZXJyaWRlIGVuY29k aW5nIGlmIHdlIGhhdmUgb25lCiAKLSAgICBGcmFtZUxvYWRUeXBlIGxvYWRUeXBlID0gbV9mcmFt ZS0+bG9hZGVyKCktPmxvYWRUeXBlKCk7Ci0gICAgRnJhbWVMb2FkVHlwZSBjaGlsZExvYWRUeXBl ID0gRnJhbWVMb2FkVHlwZVJlZGlyZWN0V2l0aExvY2tlZEJhY2tGb3J3YXJkTGlzdDsKLQogICAg IGZyYW1lRGF0YS5mcmFtZS0+bG9hZGVyKCktPmxvYWRVUkxJbnRvQ2hpbGRGcmFtZShmcmFtZURh dGEudXJsLCBmcmFtZURhdGEucmVmZXJyZXIsIGZyYW1lRGF0YS5mcmFtZS5nZXQoKSk7CiAKICAg ICAvLyBUaGUgZnJhbWUncyBvbmxvYWQgaGFuZGxlciBtYXkgaGF2ZSByZW1vdmVkIGl0IGZyb20g dGhlIGRvY3VtZW50Lgo=