29008 2009-09-07 04:33:44 -0700 Add a test in Qt for https://bugs.webkit.org/show_bug.cgi?id=29005 2009-12-13 14:35:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Enhancement --- 29005 1 benjamin benjamin abarth commit-queue hausmann webkit.review.bot oldest_to_newest 145129 0 benjamin 2009-09-07 04:33:44 -0700 The patch of https://bugs.webkit.org/show_bug.cgi?id=29005 changes the behavior of the runtime arrays generated by Qt. It would be nice to have a test for it. This is related to the task 214611 of Qt: http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=214611 145130 1 39142 benjamin 2009-09-07 04:36:16 -0700 Created attachment 39142 patch suggestion 165839 2 hausmann 2009-11-23 05:58:30 -0800 (In reply to comment #1) > Created an attachment (id=39142) [details] > patch suggestion Did you forget to mark the attachment up for review? :) 165840 3 benjamin 2009-11-23 06:05:50 -0800 (In reply to comment #2) > Did you forget to mark the attachment up for review? :) No, I want to fix 29005 first. :) 170760 4 webkit.review.bot 2009-12-11 07:50:41 -0800 Attachment 39142 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2075: This { should be at the end of the previous line [whitespace/braces] [4] WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2084: tst_QWebFrame::arrayObjectEnumerable is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2091: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2096: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2096: More than one command on the same line [whitespace/newline] [4] Total errors found: 5 170782 5 abarth 2009-12-11 09:17:57 -0800 > WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2084: > tst_QWebFrame::arrayObjectEnumerable is incorrectly named. Don't use > underscores in your identifier names. [readability/naming] [4] False positive filed: https://bugs.webkit.org/show_bug.cgi?id=32436 171136 6 39142 hausmann 2009-12-12 16:09:33 -0800 Comment on attachment 39142 patch suggestion > +class StringListTestObject : public QObject > +{ The coding style says that this brace should be placed on the preceeding line. Otherwise the patch looks good! (sorry about the style nitpick ;( 171208 7 44756 benjamin 2009-12-13 07:28:02 -0800 Created attachment 44756 Patch > The coding style says that this brace should be placed on the preceeding line. > > Otherwise the patch looks good! (sorry about the style nitpick ;( Thanks for the review...on Saturday! :) This is the same patch with the curly bracket on the same line as the class name. Only 8 class definitions of the autotests follow this style, out of 34 classes. I'll have a look at that as part of 32216. 171209 8 webkit.review.bot 2009-12-13 07:30:34 -0800 style-queue ran check-webkit-style on attachment 44756 without any errors. 171240 9 44756 hausmann 2009-12-13 14:21:47 -0800 Comment on attachment 44756 Patch r=me, thanks! 171245 10 44756 commit-queue 2009-12-13 14:35:02 -0800 Comment on attachment 44756 Patch Clearing flags on attachment: 44756 Committed r52069: <http://trac.webkit.org/changeset/52069> 171246 11 commit-queue 2009-12-13 14:35:10 -0800 All reviewed patches have been landed. Closing bug. 39142 2009-09-07 04:36:16 -0700 2009-12-13 07:28:02 -0800 patch suggestion test_array_enumrable.patch text/plain 1951 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGMxZGE2MzIuLjg3ZmIwMzMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTA5LTA3ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI5MDA4CisgICAgICAgIEFkZCBhIHRlc3QgdG8gbWFrZSBzdXJl IHRoZSBsaXN0IHJldHVybmVkIGJ5IFF0IGFyZSBlbnVtZXJhYmxlLgorCisgICAgICAgICogdGVz dHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwOgorCiAyMDA5LTA5LTA1ICBKYWt1YiBXaWVj em9yZWsgIDxmYXcyMTdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1l LmNwcCBiL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKaW5kZXgg MTUwODBlZi4uZjJlMzYwNyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90 c3RfcXdlYmZyYW1lLmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2Vi ZnJhbWUuY3BwCkBAIC01NzMsNiArNTczLDcgQEAgcHJpdmF0ZSBzbG90czoKICAgICB2b2lkIGVu dW1lcmF0ZSgpOwogICAgIHZvaWQgb2JqZWN0RGVsZXRlZCgpOwogICAgIHZvaWQgdHlwZUNvbnZl cnNpb24oKTsKKyAgICB2b2lkIGFycmF5T2JqZWN0RW51bWVyYWJsZSgpOwogICAgIHZvaWQgc3lt bWV0cmljVXJsKCk7CiAgICAgdm9pZCBwcm9ncmVzc1NpZ25hbCgpOwogICAgIHZvaWQgdXJsQ2hh bmdlKCk7CkBAIC0yMDg3LDYgKzIwODgsMzIgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjp0eXBlQ29u dmVyc2lvbigpCiAgICAgLy8gIyMjIFJlZ0V4cHMKIH0KIAorY2xhc3MgU3RyaW5nTGlzdFRlc3RP YmplY3QgOiBwdWJsaWMgUU9iamVjdAoreworICAgIFFfT0JKRUNUCitwdWJsaWMgUV9TTE9UUzoK KyAgICBRVmFyaWFudCBzdHJpbmdMaXN0KCkKKyAgICB7CisgICAgICAgIHJldHVybiBRU3RyaW5n TGlzdCgpIDw8ICJRIiA8PCAidCI7CisgICAgfTsKK307CisKK3ZvaWQgdHN0X1FXZWJGcmFtZTo6 YXJyYXlPYmplY3RFbnVtZXJhYmxlKCkKK3sKKyAgICBRV2ViUGFnZSBwYWdlOworICAgIFFXZWJG cmFtZSogZnJhbWUgPSBwYWdlLm1haW5GcmFtZSgpOworICAgIFFPYmplY3QqIHFvYmplY3QgPSBu ZXcgU3RyaW5nTGlzdFRlc3RPYmplY3QoKTsKKyAgICBmcmFtZS0+YWRkVG9KYXZhU2NyaXB0V2lu ZG93T2JqZWN0KCJ0ZXN0IiwgcW9iamVjdCwgUVNjcmlwdEVuZ2luZTo6U2NyaXB0T3duZXJzaGlw KTsKKworICAgIGNvbnN0IFFTdHJpbmcgc2NyaXB0KCJ2YXIgc3RyaW5nQXJyYXkgPSB0ZXN0LnN0 cmluZ0xpc3QoKTtcCisgICAgICAgICAgICAgICAgICAgICAgICAgIHZhciByZXN1bHQgPSAnJztc CisgICAgICAgICAgICAgICAgICAgICAgICAgIGZvciAodmFyIGkgaW4gc3RyaW5nQXJyYXkpIHtc CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXN1bHQgKz0gc3RyaW5nQXJyYXlbaV07 XAorICAgICAgICAgICAgICAgICAgICAgICAgICB9XAorICAgICAgICAgICAgICAgICAgICAgICAg ICByZXN1bHQ7Iik7CisgICAgUUNPTVBBUkUoZnJhbWUtPmV2YWx1YXRlSmF2YVNjcmlwdChzY3Jp cHQpLnRvU3RyaW5nKCksIFFTdHJpbmc6OmZyb21MYXRpbjEoIlF0IikpOworfQorCiB2b2lkIHRz dF9RV2ViRnJhbWU6OnN5bW1ldHJpY1VybCgpCiB7CiAgICAgUVZFUklGWShtX3ZpZXctPnVybCgp LmlzRW1wdHkoKSk7Cg== 44756 2009-12-13 07:28:02 -0800 2009-12-13 14:35:01 -0800 Patch test_array_enumrable.patch text/plain 1959 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGE1YTEyZWUuLjZmMmRkNTUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTEyLTEzICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBpbiBRdCBmb3Ig aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5MDA1CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTAwOAorCisgICAgICAgICog dGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwOgorCiAyMDA5LTEyLTEzICBTaW1vbiBI YXVzbWFubiAgPGhhdXNtYW5uQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9s Z2VyIEZyZXl0aGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3Rf cXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5j cHAKaW5kZXggZTE0ZmFhMy4uNmUzYTU2YyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3 ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1l L3RzdF9xd2ViZnJhbWUuY3BwCkBAIC01NTAsNiArNTUwLDcgQEAgcHJpdmF0ZSBzbG90czoKICAg ICB2b2lkIGVudW1lcmF0ZSgpOwogICAgIHZvaWQgb2JqZWN0RGVsZXRlZCgpOwogICAgIHZvaWQg dHlwZUNvbnZlcnNpb24oKTsKKyAgICB2b2lkIGFycmF5T2JqZWN0RW51bWVyYWJsZSgpOwogICAg IHZvaWQgc3ltbWV0cmljVXJsKCk7CiAgICAgdm9pZCBwcm9ncmVzc1NpZ25hbCgpOwogICAgIHZv aWQgdXJsQ2hhbmdlKCk7CkBAIC0yMDcwLDYgKzIwNzEsMzEgQEAgdm9pZCB0c3RfUVdlYkZyYW1l Ojp0eXBlQ29udmVyc2lvbigpCiAgICAgLy8gIyMjIFJlZ0V4cHMKIH0KIAorY2xhc3MgU3RyaW5n TGlzdFRlc3RPYmplY3QgOiBwdWJsaWMgUU9iamVjdCB7CisgICAgUV9PQkpFQ1QKK3B1YmxpYyBR X1NMT1RTOgorICAgIFFWYXJpYW50IHN0cmluZ0xpc3QoKQorICAgIHsKKyAgICAgICAgcmV0dXJu IFFTdHJpbmdMaXN0KCkgPDwgIlEiIDw8ICJ0IjsKKyAgICB9OworfTsKKwordm9pZCB0c3RfUVdl YkZyYW1lOjphcnJheU9iamVjdEVudW1lcmFibGUoKQoreworICAgIFFXZWJQYWdlIHBhZ2U7Cisg ICAgUVdlYkZyYW1lKiBmcmFtZSA9IHBhZ2UubWFpbkZyYW1lKCk7CisgICAgUU9iamVjdCogcW9i amVjdCA9IG5ldyBTdHJpbmdMaXN0VGVzdE9iamVjdCgpOworICAgIGZyYW1lLT5hZGRUb0phdmFT Y3JpcHRXaW5kb3dPYmplY3QoInRlc3QiLCBxb2JqZWN0LCBRU2NyaXB0RW5naW5lOjpTY3JpcHRP d25lcnNoaXApOworCisgICAgY29uc3QgUVN0cmluZyBzY3JpcHQoInZhciBzdHJpbmdBcnJheSA9 IHRlc3Quc3RyaW5nTGlzdCgpOyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAidmFyIHJlc3Vs dCA9ICcnOyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAiZm9yICh2YXIgaSBpbiBzdHJpbmdB cnJheSkgeyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAiICAgIHJlc3VsdCArPSBzdHJpbmdB cnJheVtpXTsiCisgICAgICAgICAgICAgICAgICAgICAgICAgIn0iCisgICAgICAgICAgICAgICAg ICAgICAgICAgInJlc3VsdDsiKTsKKyAgICBRQ09NUEFSRShmcmFtZS0+ZXZhbHVhdGVKYXZhU2Ny aXB0KHNjcmlwdCkudG9TdHJpbmcoKSwgUVN0cmluZzo6ZnJvbUxhdGluMSgiUXQiKSk7Cit9CisK IHZvaWQgdHN0X1FXZWJGcmFtZTo6c3ltbWV0cmljVXJsKCkKIHsKICAgICBRVkVSSUZZKG1fdmll dy0+dXJsKCkuaXNFbXB0eSgpKTsK