29007 2009-09-07 04:25:19 -0700 There is no test for the signal javaScriptWindowObjectCleared() 2009-09-08 10:44:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Enhancement --- 0 benjamin webkit-unassigned eric oldest_to_newest 145127 0 benjamin 2009-09-07 04:25:19 -0700 There is no test case for the signal javaScriptWindowObjectCleared() of QWebFrame, it would be nice to have one. 145128 1 39141 benjamin 2009-09-07 04:27:11 -0700 Created attachment 39141 New test for the signal 145133 2 39141 hausmann 2009-09-07 05:52:51 -0700 Comment on attachment 39141 New test for the signal r=me, thanks Benjamin! 145141 3 39141 eric 2009-09-07 07:08:19 -0700 Comment on attachment 39141 New test for the signal Rejecting patch 39141 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 145414 4 39141 eric 2009-09-08 10:13:49 -0700 Comment on attachment 39141 New test for the signal media/video-seeking.html -> failed Another flakey media test. :( 145438 5 39141 eric 2009-09-08 10:44:25 -0700 Comment on attachment 39141 New test for the signal Clearing flags on attachment: 39141 Committed r48166: <http://trac.webkit.org/changeset/48166> 145439 6 eric 2009-09-08 10:44:28 -0700 All reviewed patches have been landed. Closing bug. 39141 2009-09-07 04:27:11 -0700 2009-09-08 10:44:25 -0700 New test for the signal test_javaScriptWindowObjectCleared.patch text/plain 2471 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGMxZGE2MzIuLjk1MWQwOTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTA5LTA3ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI5MDA3CisgICAgICAgIEFkZCBhIHRlc3QgZm9yIHRoZSBzaWdu YWwgUVdlYkZyYW1lOjpqYXZhU2NyaXB0V2luZG93T2JqZWN0Q2xlYXJlZCgpCisKKyAgICAgICAg KiB0ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHA6CisKIDIwMDktMDktMDUgIEpha3Vi IFdpZWN6b3JlayAgPGZhdzIxN0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2Vi ZnJhbWUuY3BwIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcApp bmRleCAxNTA4MGVmLi41NjEwODdmIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZy YW1lL3RzdF9xd2ViZnJhbWUuY3BwCisrKyBiL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0 X3F3ZWJmcmFtZS5jcHAKQEAgLTU3OCw2ICs1NzgsOSBAQCBwcml2YXRlIHNsb3RzOgogICAgIHZv aWQgdXJsQ2hhbmdlKCk7CiAgICAgdm9pZCBkb21DeWNsZXMoKTsKICAgICB2b2lkIHJlcXVlc3Rl ZFVybCgpOworICAgIHZvaWQgamF2YVNjcmlwdFdpbmRvd09iamVjdENsZWFyZWRfZGF0YSgpOwor ICAgIHZvaWQgamF2YVNjcmlwdFdpbmRvd09iamVjdENsZWFyZWQoKTsKKyAgICB2b2lkIGphdmFT Y3JpcHRXaW5kb3dPYmplY3RDbGVhcmVkT25FdmFsdWF0ZSgpOwogICAgIHZvaWQgc2V0SHRtbCgp OwogICAgIHZvaWQgc2V0SHRtbFdpdGhSZXNvdXJjZSgpOwogICAgIHZvaWQgaXB2Nkhvc3RFbmNv ZGluZygpOwpAQCAtMjI3OCw2ICsyMjgxLDQwIEBAIHZvaWQgdHN0X1FXZWJGcmFtZTo6cmVxdWVz dGVkVXJsKCkKICAgICBRQ09NUEFSRShmcmFtZS0+dXJsKCksIFFVcmwoInFyYzovZmFrZS1zc2wt ZXJyb3IuaHRtbCIpKTsKIH0KIAordm9pZCB0c3RfUVdlYkZyYW1lOjpqYXZhU2NyaXB0V2luZG93 T2JqZWN0Q2xlYXJlZF9kYXRhKCkKK3sKKyAgICBRVGVzdDo6YWRkQ29sdW1uPFFTdHJpbmc+KCJo dG1sIik7CisgICAgUVRlc3Q6OmFkZENvbHVtbjxpbnQ+KCJzaWduYWxDb3VudCIpOworICAgIFFU ZXN0OjpuZXdSb3coIndpdGggPHNjcmlwdD4iKSA8PCAiPGh0bWw+PGJvZHk+PHNjcmlwdD48L3Nj cmlwdD48cD5oZWxsbyB3b3JsZDwvcD48L2JvZHk+PC9odG1sPiIgPDwgMTsKKyAgICBRVGVzdDo6 bmV3Um93KCJ3aXRob3V0IDxzY3JpcHQ+IikgPDwgIjxodG1sPjxib2R5PjxwPmhlbGxvIHdvcmxk PC9wPjwvYm9keT48L2h0bWw+IiA8PCAwOworfQorCit2b2lkIHRzdF9RV2ViRnJhbWU6OmphdmFT Y3JpcHRXaW5kb3dPYmplY3RDbGVhcmVkKCkKK3sKKyAgICBRV2ViUGFnZSBwYWdlOworICAgIFFX ZWJGcmFtZSogZnJhbWUgPSBwYWdlLm1haW5GcmFtZSgpOworICAgIFFTaWduYWxTcHkgc3B5KGZy YW1lLCBTSUdOQUwoamF2YVNjcmlwdFdpbmRvd09iamVjdENsZWFyZWQoKSkpOworICAgIFFGRVRD SChRU3RyaW5nLCBodG1sKTsKKyAgICBmcmFtZS0+c2V0SHRtbChodG1sKTsKKworICAgIFFGRVRD SChpbnQsIHNpZ25hbENvdW50KTsKKyAgICBRQ09NUEFSRShzcHkuY291bnQoKSwgc2lnbmFsQ291 bnQpOworfQorCit2b2lkIHRzdF9RV2ViRnJhbWU6OmphdmFTY3JpcHRXaW5kb3dPYmplY3RDbGVh cmVkT25FdmFsdWF0ZSgpCit7CisgICAgUVdlYlBhZ2UgcGFnZTsKKyAgICBRV2ViRnJhbWUqIGZy YW1lID0gcGFnZS5tYWluRnJhbWUoKTsKKyAgICBRU2lnbmFsU3B5IHNweShmcmFtZSwgU0lHTkFM KGphdmFTY3JpcHRXaW5kb3dPYmplY3RDbGVhcmVkKCkpKTsKKyAgICBmcmFtZS0+c2V0SHRtbCgi PGh0bWw+PC9odG1sPiIpOworICAgIFFDT01QQVJFKHNweS5jb3VudCgpLCAwKTsKKyAgICBmcmFt ZS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJ2YXIgYSA9ICdhJzsiKTsKKyAgICBRQ09NUEFSRShzcHku Y291bnQoKSwgMSk7CisgICAgLy8gbm8gbmV3IGNsZWFyIGZvciBhIG5ldyBzY3JpcHQ6CisgICAg ZnJhbWUtPmV2YWx1YXRlSmF2YVNjcmlwdCgidmFyIGEgPSAxOyIpOworICAgIFFDT01QQVJFKHNw eS5jb3VudCgpLCAxKTsKK30KKwogdm9pZCB0c3RfUVdlYkZyYW1lOjpzZXRIdG1sKCkKIHsKICAg ICBRU3RyaW5nIGh0bWwoIjxodG1sPjxoZWFkPjwvaGVhZD48Ym9keT48cD5oZWxsbyB3b3JsZDwv cD48L2JvZHk+PC9odG1sPiIpOwo=