29000 2009-09-06 17:02:29 -0700 Implement HTML5's fakepath 2010-08-30 12:15:49 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned abarth ap barraclough commit-queue dglazkov eric ian mike mjs sam webkit.review.bot oldest_to_newest 145069 0 abarth 2009-09-06 17:02:29 -0700 When you get the value property of an <input type="file">, you're supposed to get C:\fakepath\<filename> instead of just <filename>. 145070 1 39128 abarth 2009-09-06 17:12:56 -0700 Created attachment 39128 work-in-progress 145071 2 abarth 2009-09-06 17:14:21 -0700 The code change looks pretty trivial. Any hints about how to write a test? 145078 3 39130 abarth 2009-09-06 21:09:01 -0700 Created attachment 39130 patch --- 5 files changed, 42 insertions(+), 14 deletions(-) 145391 4 eric 2009-09-08 09:37:13 -0700 This is about the lamest thing ever. Why oh why would HTML5 spec this? 145392 5 eric 2009-09-08 09:38:17 -0700 I would like to know what websites our current behavior breaks. Our behavior is much less-lame than HTML5's speced behavior/IE's behavior (assuming HTML5 is matching IE). 145548 6 39130 eric 2009-09-08 14:46:33 -0700 Comment on attachment 39130 patch I guess I'll r- this based on my above comments. I think the spec should change instead of our implementation, unless there are a list of websites which break due to our (superior) behavior. :) 145561 7 sam 2009-09-08 15:05:13 -0700 I agree with Eric, this is pretty lame. Does anyone know the rationale behind the decision? 145562 8 dglazkov 2009-09-08 15:08:58 -0700 I think it should be c:\awesomepath. /me ducks. 145567 9 barraclough 2009-09-08 15:21:35 -0700 This is just too painfully idiotic a decision in the spec for words. Please, please, no. eseidel++ for the r-. 145616 10 abarth 2009-09-08 18:27:35 -0700 The rationale is as follows: 1) Some number of consumer routers won't let you upload new firmware with our current behavior because they try to trim off the non-existent path. Sadly, these sites can't fix the bug without new firmware. 2) IE8 ships with this behavior and ie-team shows little inclination to match our behavior because of (1). See http://blogs.msdn.com/ie/archive/2009/03/20/rtm-platform-changes.aspx Maciej has stated on the HTML WG mailing list that he supports fakepath. There is some amount of debate on this topic in the HTML WG at present. It might make sense to wait and see how the dust settles, or it might sense to help resolve the situation. 146998 11 mjs 2009-09-13 14:46:15 -0700 Yes, this behavior is lame. But it seems to be the best available choice given the compatibility, platform-independence and privacy constraints. In particular: 1) Exposing the real path is a privacy/security risk. 2) Exposing Unix-style paths breaks some content, including router Web interfaces and apparently Orkut 3) Exposing bare filenames has some of the same issues as #1. Web developers still have the ability to get the real filename without regexp mangling by using control.fileList[0].fileName. More importantly, from a compatibility perspective, since other browsers are doing this, Web content authors *already* have to be prepared to strip the fakepath prefix. So we're not doing Web developers any favors by omitting it. And finally, while the lameness of this compatibility hack is very visible, it's hardly the lamest compatibility hack in the Web platform. Take a look at WebKit's "quirky em" unites or how parsing works when a <form> is misnested inside table structure. This hack just seems gross because it is easy to understand its wrongness without being an expert in the relevant part of the code. 146999 12 mjs 2009-09-13 14:47:55 -0700 The upshot of my comments is, I think we should just bite the pillow and get this change over with. 264801 13 39130 abarth 2010-08-14 23:27:08 -0700 Comment on attachment 39130 patch Here we are a year later and the spec hasn't changed. I think we should reconsider this path. 264829 14 eric 2010-08-15 07:52:41 -0700 I foresee in the future we'll add a new property just to get the real name. This seems to run against Darin Adler's "The future is bigger than the past" argument in other bugs. I have a lot of faith in Hixie, but how many pages are we talking about? The sad thing is that it seems other browsers have done this too, which means we need to. We were just all stupid as a community to cave in the first place. 264833 15 ian 2010-08-15 09:16:03 -0700 Believe me, I wouldn't have specced this if it wasn't a de facto standard backed with compatibility arguments. We already have an API for getting the name accurately: HTMLInputElement.files[0].name 271169 16 39130 darin 2010-08-29 11:39:05 -0700 Comment on attachment 39130 patch > + if (!m_fileList->isEmpty()) { > + String value = "C:\\fakepath\\"; > + value.append(m_fileList->item(0)->fileName()); > + return value; > + } This can be written just with the plus operator: if (!m_fileList->isEmpty()) return C:\\fakepath\\" + m_fileList->item(0)->fileName(); I think that's more pleasant. But also, I think that the fakepath will be mysterious without a comment. 271244 17 65867 abarth 2010-08-29 17:56:45 -0700 Created attachment 65867 Patch for landing 271247 18 65867 commit-queue 2010-08-29 18:16:42 -0700 Comment on attachment 65867 Patch for landing Clearing flags on attachment: 65867 Committed r66343: <http://trac.webkit.org/changeset/66343> 271248 19 commit-queue 2010-08-29 18:16:48 -0700 All reviewed patches have been landed. Closing bug. 271254 20 webkit.review.bot 2010-08-29 18:45:58 -0700 http://trac.webkit.org/changeset/66343 might have broken Qt Linux Release 271473 21 ap 2010-08-30 09:50:24 -0700 -PASS fileInput.value is "DRTFakeFile" +FAIL fileInput.value should be DRTFakeFile. Was C:\fakepath\DRTFakeFile. These should be PASS, not FAIL. 271504 22 abarth 2010-08-30 10:36:58 -0700 > These should be PASS, not FAIL. Ok. 271555 23 abarth 2010-08-30 12:15:49 -0700 > These should be PASS, not FAIL. See Bug 44882. 39128 2009-09-06 17:12:56 -0700 2009-09-06 21:08:58 -0700 work-in-progress bug-29000-20090906191251.patch text/plain 924 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1dlYkNvcmUv aHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCBhMjE1MjBmLi43MTE5MjVjIDEwMDY0NAot LS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC0xMDQyLDExICsxMDQyLDEyIEBAIHZvaWQgSFRNTElu cHV0RWxlbWVudDo6Y29weU5vbkF0dHJpYnV0ZVByb3BlcnRpZXMoY29uc3QgRWxlbWVudCogc291 cmNlKQogCiBTdHJpbmcgSFRNTElucHV0RWxlbWVudDo6dmFsdWUoKSBjb25zdAogewotICAgIC8v IFRoZSBIVE1MNSBzcGVjIChhcyBvZiB0aGUgMTAvMjQvMDggd29ya2luZyBkcmFmdCkgc2F5cyB0 aGF0IHRoZSB2YWx1ZSBhdHRyaWJ1dGUgaXNuJ3QgYXBwbGljYWJsZSB0byB0aGUgZmlsZSB1cGxv YWQgY29udHJvbAotICAgIC8vIGJ1dCB3ZSBkb24ndCB3YW50IHRvIGJyZWFrIGV4aXN0aW5nIHdl YnNpdGVzLCB3aG8gbWF5IGJlIHJlbHlpbmcgb24gYmVpbmcgYWJsZSB0byBnZXQgdGhlIGZpbGUg bmFtZSBhcyBhIHZhbHVlLgogICAgIGlmIChpbnB1dFR5cGUoKSA9PSBGSUxFKSB7Ci0gICAgICAg IGlmICghbV9maWxlTGlzdC0+aXNFbXB0eSgpKQotICAgICAgICAgICAgcmV0dXJuIG1fZmlsZUxp c3QtPml0ZW0oMCktPmZpbGVOYW1lKCk7CisgICAgICAgIGlmICghbV9maWxlTGlzdC0+aXNFbXB0 eSgpKSB7CisgICAgICAgICAgICBTdHJpbmcgdmFsdWUgPSAiQzpcXGZha2VwYXRoXFwiOworICAg ICAgICAgICAgdmFsdWUuYXBwZW5kKG1fZmlsZUxpc3QtPml0ZW0oMCktPmZpbGVOYW1lKCkpOwor ICAgICAgICAgICAgcmV0dXJuIHZhbHVlOworICAgICAgICB9CiAgICAgICAgIHJldHVybiBTdHJp bmcoKTsKICAgICB9 39130 2009-09-06 21:09:01 -0700 2010-08-29 17:44:33 -0700 patch bug-29000-20090906230900.patch text/plain 6344 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZjA2ZGIyLi44Y2NmNTY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDkt MDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgSFRNTDUncyBmYWtlcGF0aAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkwMDAKKwor ICAgICAgICBVcGRhdGUgZXhwZWN0YXRpb25zIGZvciB0aGlzIHBhc3RlYm9hcmQgdGVzdCB0byBp bmNsdWRlIG91ciBuZXcgZnJpZW5kCisgICAgICAgIGZha2VwYXRoLgorCisgICAgICAgICogZWRp dGluZy9wYXN0ZWJvYXJkL2ZpbGUtaW5wdXQtZmlsZXMtYWNjZXNzLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBlZGl0aW5nL3Bhc3RlYm9hcmQvcmVzb3VyY2VzL2ZpbGUtaW5wdXQtZmlsZXMtYWNj ZXNzLmpzOgorICAgICAgICAoZHJhZ2dpbmdQYXRoc1Nob3VsZFJlc3VsdEluRmlsZXMpOgorCiAy MDA5LTA5LTA0ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRp bmcvcGFzdGVib2FyZC9maWxlLWlucHV0LWZpbGVzLWFjY2Vzcy1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvZmlsZS1pbnB1dC1maWxlcy1hY2Nlc3MtZXhwZWN0 ZWQudHh0CmluZGV4IDcwNGFiNjIuLmU1M2YwNDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Vk aXRpbmcvcGFzdGVib2FyZC9maWxlLWlucHV0LWZpbGVzLWFjY2Vzcy1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2ZpbGUtaW5wdXQtZmlsZXMtYWNjZXNz LWV4cGVjdGVkLnR4dApAQCAtNyw0MiArNyw0MiBAQCBEcmFnZ2luZyB0byBhIGRpc2FibGVkIGZp bGUgaW5wdXQgY29udHJvbDoKIFBBU1MgZmlsZUlucHV0LnZhbHVlIGlzICIiCiBQQVNTIGZpbGVJ bnB1dC5maWxlcy5sZW5ndGggaXMgMAogRHJhZ2dpbmcgYSBzaW5nbGUgKG5vbi1leGlzdGFudCkg ZmlsZSB0byBhIGZpbGUgaW5wdXQgY29udHJvbDoKLVBBU1MgZmlsZUlucHV0LnZhbHVlIGlzICJE UlRGYWtlRmlsZSIKK1BBU1MgZmlsZUlucHV0LnZhbHVlIGlzICJDOlxcZmFrZXBhdGhcXERSVEZh a2VGaWxlIgogUEFTUyBmaWxlSW5wdXQuZmlsZXMubGVuZ3RoIGlzIDEKIFBBU1MgZmlsZUlucHV0 LmZpbGVzWzBdLmZpbGVOYW1lIGlzICJEUlRGYWtlRmlsZSIKIFBBU1MgZmlsZUlucHV0LmZpbGVz WzBdLmZpbGVTaXplIGlzIDAKIERyYWdnaW5nIGEgcmVhbCBmaWxlIHRvIGEgZmlsZSBpbnB1dCBj b250cm9sOgotUEFTUyBmaWxlSW5wdXQudmFsdWUgaXMgImFwcGxlLmdpZiIKK1BBU1MgZmlsZUlu cHV0LnZhbHVlIGlzICJDOlxcZmFrZXBhdGhcXGFwcGxlLmdpZiIKIFBBU1MgZmlsZUlucHV0LmZp bGVzLmxlbmd0aCBpcyAxCiBQQVNTIGZpbGVJbnB1dC5maWxlc1swXS5maWxlTmFtZSBpcyAiYXBw bGUuZ2lmIgogUEFTUyBmaWxlSW5wdXQuZmlsZXNbMF0uZmlsZVNpemUgaXMgMTQ3NgogRHJhZ2dp bmcgYSBkaXJlY3Rvcnkgb250byBhbiBmaWxlIGlucHV0IGNvbnRyb2w6Ci1GQUlMIGZpbGVJbnB1 dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgZGlyZWN0b3J5LWZvci1kcmFnZ2luZy4KK0ZBSUwgZmls ZUlucHV0LnZhbHVlIHNob3VsZCBiZSAuIFdhcyBDOlxmYWtlcGF0aFxkaXJlY3RvcnktZm9yLWRy YWdnaW5nLgogRkFJTCBmaWxlSW5wdXQuZmlsZXMubGVuZ3RoIHNob3VsZCBiZSAwLiBXYXMgMS4K IEZJWE1FOiBTaW5nbGUtZmlsZSBpbnB1dCBlbGVtZW50cyBzaG91bGQgcmVmdXNlIG11bHRpLWZp bGUgZHJhZ3MuICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1 OTEzCiBEcmFnZ2luZyB0d28gZmlsZXMgdG8gYSBzaW5nbGUtZmlsZSBpbnB1dCBjb250cm9sOgot RkFJTCBmaWxlSW5wdXQudmFsdWUgc2hvdWxkIGJlIC4gV2FzIGFwcGxlLmdpZi4KK0ZBSUwgZmls ZUlucHV0LnZhbHVlIHNob3VsZCBiZSAuIFdhcyBDOlxmYWtlcGF0aFxhcHBsZS5naWYuCiBGQUlM IGZpbGVJbnB1dC5maWxlcy5sZW5ndGggc2hvdWxkIGJlIDAuIFdhcyAxLgogRHJhZ2dpbmcgYSBm aWxlIGFuZCBhIGRpcmVjdG9yeSBvbnRvIGEgc2luZ2xlLWZpbGUgaW5wdXQgY29udHJvbDoKLUZB SUwgZmlsZUlucHV0LnZhbHVlIHNob3VsZCBiZSAuIFdhcyBhcHBsZS5naWYuCitGQUlMIGZpbGVJ bnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgQzpcZmFrZXBhdGhcYXBwbGUuZ2lmLgogRkFJTCBm aWxlSW5wdXQuZmlsZXMubGVuZ3RoIHNob3VsZCBiZSAwLiBXYXMgMS4KIEZJWE1FOiAgZWxlbWVu dHMgc2hvdWxkIHJlZnVzZSBkcmFncyBpbmNsdWRpbmcgZGlyZWN0b3JpZXM6IGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTg3OS4gIFRoZSBwYWdlIGlzIGdpdmVuIEZp bGUgb2JqZWN0cyBjb3JyZXNwb25kaW5nIHRvIGRpcmVjdG9yaWVzLCBidXQgZm9ybSBzdWJtaXNz aW9uIHdpbGwgZmFpbC4KIERyYWdnaW5nIGEgZGlyZWN0b3J5IGFuZCBhIGZpbGUgb250byBhIHNp bmdsZS1maWxlIGlucHV0IGNvbnRyb2w6Ci1GQUlMIGZpbGVJbnB1dC52YWx1ZSBzaG91bGQgYmUg LiBXYXMgZGlyZWN0b3J5LWZvci1kcmFnZ2luZy4KK0ZBSUwgZmlsZUlucHV0LnZhbHVlIHNob3Vs ZCBiZSAuIFdhcyBDOlxmYWtlcGF0aFxkaXJlY3RvcnktZm9yLWRyYWdnaW5nLgogRkFJTCBmaWxl SW5wdXQuZmlsZXMubGVuZ3RoIHNob3VsZCBiZSAwLiBXYXMgMS4KIERyYWdnaW5nIHR3byBmaWxl cyB0byBhIG11bHRpLWZpbGUgaW5wdXQgY29udHJvbDoKLVBBU1MgZmlsZUlucHV0LnZhbHVlIGlz ICJhcHBsZS5naWYiCitQQVNTIGZpbGVJbnB1dC52YWx1ZSBpcyAiQzpcXGZha2VwYXRoXFxhcHBs ZS5naWYiCiBQQVNTIGZpbGVJbnB1dC5maWxlcy5sZW5ndGggaXMgMgogUEFTUyBmaWxlSW5wdXQu ZmlsZXNbMF0uZmlsZU5hbWUgaXMgImFwcGxlLmdpZiIKIFBBU1MgZmlsZUlucHV0LmZpbGVzWzBd LmZpbGVTaXplIGlzIDE0NzYKIFBBU1MgZmlsZUlucHV0LmZpbGVzWzFdLmZpbGVOYW1lIGlzICJt b3ppbGxhLmdpZiIKIFBBU1MgZmlsZUlucHV0LmZpbGVzWzFdLmZpbGVTaXplIGlzIDI1OTMKIERy YWdnaW5nIGEgZmlsZSBhbmQgYSBkaXJlY3Rvcnkgb250byBhIG11dGxpLWZpbGUgaW5wdXQgY29u dHJvbDoKLUZBSUwgZmlsZUlucHV0LnZhbHVlIHNob3VsZCBiZSAuIFdhcyBhcHBsZS5naWYuCitG QUlMIGZpbGVJbnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgQzpcZmFrZXBhdGhcYXBwbGUuZ2lm LgogRkFJTCBmaWxlSW5wdXQuZmlsZXMubGVuZ3RoIHNob3VsZCBiZSAwLiBXYXMgMi4KIEZJWE1F OiAgZWxlbWVudHMgc2hvdWxkIHJlZnVzZSBkcmFncyBpbmNsdWRpbmcgZGlyZWN0b3JpZXM6IGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTg3OS4gIFRoZSBwYWdlIGlz IGdpdmVuIEZpbGUgb2JqZWN0cyBjb3JyZXNwb25kaW5nIHRvIGRpcmVjdG9yaWVzLCBidXQgZm9y bSBzdWJtaXNzaW9uIHdpbGwgZmFpbC4KIERyYWdnaW5nIGEgZGlyZWN0b3J5IGFuZCBhIGZpbGUg b250byBhIG11dGxpLWZpbGUgaW5wdXQgY29udHJvbDoKLUZBSUwgZmlsZUlucHV0LnZhbHVlIHNo b3VsZCBiZSAuIFdhcyBkaXJlY3RvcnktZm9yLWRyYWdnaW5nLgorRkFJTCBmaWxlSW5wdXQudmFs dWUgc2hvdWxkIGJlIC4gV2FzIEM6XGZha2VwYXRoXGRpcmVjdG9yeS1mb3ItZHJhZ2dpbmcuCiBG QUlMIGZpbGVJbnB1dC5maWxlcy5sZW5ndGggc2hvdWxkIGJlIDAuIFdhcyAyLgogUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5n L3Bhc3RlYm9hcmQvcmVzb3VyY2VzL2ZpbGUtaW5wdXQtZmlsZXMtYWNjZXNzLmpzIGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3Jlc291cmNlcy9maWxlLWlucHV0LWZpbGVzLWFjY2Vz cy5qcwppbmRleCA5MzczZmExLi5kODM0ZWU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL3Bhc3RlYm9hcmQvcmVzb3VyY2VzL2ZpbGUtaW5wdXQtZmlsZXMtYWNjZXNzLmpzCisrKyBi L0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9yZXNvdXJjZXMvZmlsZS1pbnB1dC1maWxl cy1hY2Nlc3MuanMKQEAgLTQwLDcgKzQwLDcgQEAgZnVuY3Rpb24gZHJhZ2dpbmdQYXRoc1Nob3Vs ZFJlc3VsdEluRmlsZXMocGF0aHNBcnJheSwgZmlsZXNBcnJheSkKIHsKICAgICBkcmFnRmlsZXNP bnRvSW5wdXQocGF0aHNBcnJheSk7CiAgICAgLy8gV2ViS2l0IHNlZW1zIHRvIGFsd2F5cyB0YWtl IHRoZSBmaXJzdCBmaWxlIGluIHRoZSBkcmFnZ2VkIGxpc3QgYXMgLnZhbHVlOgotICAgIHNob3Vs ZEJlRXF1YWxUb1N0cmluZygiZmlsZUlucHV0LnZhbHVlIiwgZmlsZXNBcnJheVswXSA/IGZpbGVz QXJyYXlbMF1bJ25hbWUnXSA6ICcnKTsKKyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImZpbGVJ bnB1dC52YWx1ZSIsIGZpbGVzQXJyYXlbMF0gPyAiQzpcXFxcZmFrZXBhdGhcXFxcIiArIGZpbGVz QXJyYXlbMF1bJ25hbWUnXSA6ICcnKTsKICAgICBmaWxlc1Nob3VsZEJlKGZpbGVzQXJyYXkpOwog fQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDA4NThhYjEuLjE3OGJhZTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDktMDYgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgSFRNTDUncyBmYWtlcGF0aAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkwMDAKKworICAgICAgICBUaGUg SFRNTCA1IHNwZWMgc2F5cyB0byBwcmVwZW5kIEM6XGZha2VwYXRoXCB0byB0aGUgdmFsdWUgb2Yg YW4KKyAgICAgICAgPGlucHV0IHR5cGU9ImZpbGUiPiBjb250cm9sLCBzbyB0aGF0J3Mgd2hhdCB3 ZSBkbyBub3cuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6dmFsdWUpOgorCiAyMDA5LTA5LTA0ICBKaWFu IExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJh cnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGEyMTUyMGYuLjcxMTkyNWMgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTEwNDIsMTEgKzEwNDIsMTIgQEAgdm9pZCBI VE1MSW5wdXRFbGVtZW50Ojpjb3B5Tm9uQXR0cmlidXRlUHJvcGVydGllcyhjb25zdCBFbGVtZW50 KiBzb3VyY2UpCiAKIFN0cmluZyBIVE1MSW5wdXRFbGVtZW50Ojp2YWx1ZSgpIGNvbnN0CiB7Ci0g ICAgLy8gVGhlIEhUTUw1IHNwZWMgKGFzIG9mIHRoZSAxMC8yNC8wOCB3b3JraW5nIGRyYWZ0KSBz YXlzIHRoYXQgdGhlIHZhbHVlIGF0dHJpYnV0ZSBpc24ndCBhcHBsaWNhYmxlIHRvIHRoZSBmaWxl IHVwbG9hZCBjb250cm9sCi0gICAgLy8gYnV0IHdlIGRvbid0IHdhbnQgdG8gYnJlYWsgZXhpc3Rp bmcgd2Vic2l0ZXMsIHdobyBtYXkgYmUgcmVseWluZyBvbiBiZWluZyBhYmxlIHRvIGdldCB0aGUg ZmlsZSBuYW1lIGFzIGEgdmFsdWUuCiAgICAgaWYgKGlucHV0VHlwZSgpID09IEZJTEUpIHsKLSAg ICAgICAgaWYgKCFtX2ZpbGVMaXN0LT5pc0VtcHR5KCkpCi0gICAgICAgICAgICByZXR1cm4gbV9m aWxlTGlzdC0+aXRlbSgwKS0+ZmlsZU5hbWUoKTsKKyAgICAgICAgaWYgKCFtX2ZpbGVMaXN0LT5p c0VtcHR5KCkpIHsKKyAgICAgICAgICAgIFN0cmluZyB2YWx1ZSA9ICJDOlxcZmFrZXBhdGhcXCI7 CisgICAgICAgICAgICB2YWx1ZS5hcHBlbmQobV9maWxlTGlzdC0+aXRlbSgwKS0+ZmlsZU5hbWUo KSk7CisgICAgICAgICAgICByZXR1cm4gdmFsdWU7CisgICAgICAgIH0KICAgICAgICAgcmV0dXJu IFN0cmluZygpOwogICAgIH0= 65867 2010-08-29 17:56:45 -0700 2010-08-29 18:16:42 -0700 Patch for landing bug-29000-20100829175643.patch text/plain 6600 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjMzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBJbXBsZW1l bnQgSFRNTDUncyBmYWtlcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjkwMDAKKworICAgICAgICBUaGUgSFRNTCA1IHNwZWMgc2F5cyB0byBwcmVw ZW5kIEM6XGZha2VwYXRoXCB0byB0aGUgdmFsdWUgb2YgYW4KKyAgICAgICAgPGlucHV0IHR5cGU9 ImZpbGUiPiBjb250cm9sLCBzbyB0aGF0J3Mgd2hhdCB3ZSBkbyBub3cuCisKKyAgICAgICAgKiBo dG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxl bWVudDo6dmFsdWUpOgorCiAyMDEwLTA4LTI5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCShyZXZpc2lvbiA2NjMzOCkKKysrIFdlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ5OCwxMSArMTQ5OCwxNiBA QCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OmNvcHlOb25BdHRyaWJ1dGVQCiAKIFN0cmluZyBIVE1M SW5wdXRFbGVtZW50Ojp2YWx1ZSgpIGNvbnN0CiB7Ci0gICAgLy8gVGhlIEhUTUw1IHNwZWMgKGFz IG9mIHRoZSAxMC8yNC8wOCB3b3JraW5nIGRyYWZ0KSBzYXlzIHRoYXQgdGhlIHZhbHVlIGF0dHJp YnV0ZSBpc24ndCBhcHBsaWNhYmxlIHRvIHRoZSBmaWxlIHVwbG9hZCBjb250cm9sCi0gICAgLy8g YnV0IHdlIGRvbid0IHdhbnQgdG8gYnJlYWsgZXhpc3Rpbmcgd2Vic2l0ZXMsIHdobyBtYXkgYmUg cmVseWluZyBvbiBiZWluZyBhYmxlIHRvIGdldCB0aGUgZmlsZSBuYW1lIGFzIGEgdmFsdWUuCiAg ICAgaWYgKGlucHV0VHlwZSgpID09IEZJTEUpIHsKLSAgICAgICAgaWYgKCFtX2ZpbGVMaXN0LT5p c0VtcHR5KCkpCi0gICAgICAgICAgICByZXR1cm4gbV9maWxlTGlzdC0+aXRlbSgwKS0+ZmlsZU5h bWUoKTsKKyAgICAgICAgaWYgKCFtX2ZpbGVMaXN0LT5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAg IC8vIEhUTUw1IHRlbGxzIHVzIHRoYXQgd2UncmUgc3VwcG9zZWQgdG8gdXNlIHRoaXMgZ29vZnkg dmFsdWUgZm9yCisgICAgICAgICAgICAvLyBmaWxlIGlucHV0IGNvbnRyb2xzLiAgSGlzdG9yaWNh bGx5LCBicm93c2VycyByZXZlYWxzIHRoZSByZWFsCisgICAgICAgICAgICAvLyBmaWxlIHBhdGgs IGJ1dCB0aGF0J3MgYSBwcml2YWN5IHByb2JsZW0uICBDb2RlIG9uIHRoZSB3ZWIKKyAgICAgICAg ICAgIC8vIGRlY2lkZWQgdG8gdHJ5IHRvIHBhcnNlIHRoZSB2YWx1ZSBieSBsb29raW5nIGZvciBi YWNrc2xhc2hlcworICAgICAgICAgICAgLy8gKGJlY2F1c2UgdGhhdCdzIHdoYXQgV2luZG93cyBm aWxlIHBhdGhzIHVzZSkuICBUbyBiZSBjb21wYXRpYmxlCisgICAgICAgICAgICAvLyB3aXRoIHRo YXQgY29kZSwgd2UgbWFrZSB1cCBhIGZha2UgcGF0aCBmb3IgdGhlIGZpbGUuCisgICAgICAgICAg ICByZXR1cm4gIkM6XFxmYWtlcGF0aFxcIiArIG1fZmlsZUxpc3QtPml0ZW0oMCktPmZpbGVOYW1l KCk7CisgICAgICAgIH0KICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogICAgIH0KIApJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gNjYzMzgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOC0yOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIElt cGxlbWVudCBIVE1MNSdzIGZha2VwYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yOTAwMAorCisgICAgICAgIFVwZGF0ZSBleHBlY3RhdGlvbnMgZm9y IHRoaXMgcGFzdGVib2FyZCB0ZXN0IHRvIGluY2x1ZGUgb3VyIG5ldyBmcmllbmQKKyAgICAgICAg ZmFrZXBhdGguCisKKyAgICAgICAgKiBlZGl0aW5nL3Bhc3RlYm9hcmQvZmlsZS1pbnB1dC1maWxl cy1hY2Nlc3MtZXhwZWN0ZWQudHh0OgorCiAyMDEwLTA4LTI4ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpAQCAtNDc3ODEs NCArNDc3OTMsNCBAQAogICAgICAgICAqIHBsYXRmb3JtL21hYy9lZGl0aW5nL3Bhc3RlYm9hcmQv c3R5bGVkLWVsZW1lbnQtbWFya3VwLWV4cGVjdGVkLmNoZWNrc3VtOiBSZXBsYWNlZC4KICAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9wYXN0ZWJvYXJkL3N0eWxlZC1lbGVtZW50LW1hcmt1 cC1leHBlY3RlZC5wbmc6IFJlcGxhY2VkLgogICAgICAgICAqIHBsYXRmb3JtL21hYy9lZGl0aW5n L3Bhc3RlYm9hcmQvc3ViZnJhbWUtZHJhZ25kcm9wLTEtZXhwZWN0ZWQuY2hlCi1zdm4KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCitzdm4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvcGFz dGVib2FyZC9maWxlLWlucHV0LWZpbGVzLWFjY2Vzcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2ZpbGUtaW5wdXQtZmlsZXMtYWNjZXNz LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNjYzMzgpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bh c3RlYm9hcmQvZmlsZS1pbnB1dC1maWxlcy1hY2Nlc3MtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC00LDcgKzQsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBCiAKIAogRHJhZ2dpbmcgYSBzaW5nbGUgKG5vbi1leGlzdGFudCkgZmlsZSB0byBhIGZpbGUg aW5wdXQgY29udHJvbDoKLVBBU1MgZmlsZUlucHV0LnZhbHVlIGlzICJEUlRGYWtlRmlsZSIKK0ZB SUwgZmlsZUlucHV0LnZhbHVlIHNob3VsZCBiZSBEUlRGYWtlRmlsZS4gV2FzIEM6XGZha2VwYXRo XERSVEZha2VGaWxlLgogUEFTUyBmaWxlSW5wdXQuZmlsZXMubGVuZ3RoIGlzIDEKIFBBU1MgZmls ZUlucHV0LmZpbGVzWzBdLm5hbWUgaXMgIkRSVEZha2VGaWxlIgogUEFTUyBmaWxlSW5wdXQuZmls ZXNbMF0udHlwZSBpcyAiIgpAQCAtMTIsNyArMTIsNyBAQCBQQVNTIGZpbGVJbnB1dC5maWxlc1sw XS5zaXplIGlzIDAKIFBBU1MgZmlsZUlucHV0LmZpbGVzWzBdLmZpbGVOYW1lIGlzICJEUlRGYWtl RmlsZSIKIFBBU1MgZmlsZUlucHV0LmZpbGVzWzBdLmZpbGVTaXplIGlzIDAKIERyYWdnaW5nIGEg cmVhbCBmaWxlIHRvIGEgZmlsZSBpbnB1dCBjb250cm9sOgotUEFTUyBmaWxlSW5wdXQudmFsdWUg aXMgImFwcGxlLmdpZiIKK0ZBSUwgZmlsZUlucHV0LnZhbHVlIHNob3VsZCBiZSBhcHBsZS5naWYu IFdhcyBDOlxmYWtlcGF0aFxhcHBsZS5naWYuCiBQQVNTIGZpbGVJbnB1dC5maWxlcy5sZW5ndGgg aXMgMQogUEFTUyBmaWxlSW5wdXQuZmlsZXNbMF0ubmFtZSBpcyAiYXBwbGUuZ2lmIgogUEFTUyBm aWxlSW5wdXQuZmlsZXNbMF0udHlwZSBpcyAiaW1hZ2UvZ2lmIgpAQCAtMjAsMjEgKzIwLDIxIEBA IFBBU1MgZmlsZUlucHV0LmZpbGVzWzBdLnNpemUgaXMgMTQ3NgogUEFTUyBmaWxlSW5wdXQuZmls ZXNbMF0uZmlsZU5hbWUgaXMgImFwcGxlLmdpZiIKIFBBU1MgZmlsZUlucHV0LmZpbGVzWzBdLmZp bGVTaXplIGlzIDE0NzYKIERyYWdnaW5nIGEgZGlyZWN0b3J5IG9udG8gYW4gZmlsZSBpbnB1dCBj b250cm9sOgotRkFJTCBmaWxlSW5wdXQudmFsdWUgc2hvdWxkIGJlIC4gV2FzIGRpcmVjdG9yeS1m b3ItZHJhZ2dpbmcuCitGQUlMIGZpbGVJbnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgQzpcZmFr ZXBhdGhcZGlyZWN0b3J5LWZvci1kcmFnZ2luZy4KIEZBSUwgZmlsZUlucHV0LmZpbGVzLmxlbmd0 aCBzaG91bGQgYmUgMC4gV2FzIDEuCiBGSVhNRTogU2luZ2xlLWZpbGUgaW5wdXQgZWxlbWVudHMg c2hvdWxkIHJlZnVzZSBtdWx0aS1maWxlIGRyYWdzLiAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNTkxMwogRHJhZ2dpbmcgdHdvIGZpbGVzIHRvIGEgc2luZ2xl LWZpbGUgaW5wdXQgY29udHJvbDoKLUZBSUwgZmlsZUlucHV0LnZhbHVlIHNob3VsZCBiZSAuIFdh cyBhcHBsZS5naWYuCitGQUlMIGZpbGVJbnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgQzpcZmFr ZXBhdGhcYXBwbGUuZ2lmLgogRkFJTCBmaWxlSW5wdXQuZmlsZXMubGVuZ3RoIHNob3VsZCBiZSAw LiBXYXMgMS4KIERyYWdnaW5nIGEgZmlsZSBhbmQgYSBkaXJlY3Rvcnkgb250byBhIHNpbmdsZS1m aWxlIGlucHV0IGNvbnRyb2w6Ci1GQUlMIGZpbGVJbnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMg YXBwbGUuZ2lmLgorRkFJTCBmaWxlSW5wdXQudmFsdWUgc2hvdWxkIGJlIC4gV2FzIEM6XGZha2Vw YXRoXGFwcGxlLmdpZi4KIEZBSUwgZmlsZUlucHV0LmZpbGVzLmxlbmd0aCBzaG91bGQgYmUgMC4g V2FzIDEuCiBGSVhNRTogIGVsZW1lbnRzIHNob3VsZCByZWZ1c2UgZHJhZ3MgaW5jbHVkaW5nIGRp cmVjdG9yaWVzOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU4Nzku ICBUaGUgcGFnZSBpcyBnaXZlbiBGaWxlIG9iamVjdHMgY29ycmVzcG9uZGluZyB0byBkaXJlY3Rv cmllcywgYnV0IGZvcm0gc3VibWlzc2lvbiB3aWxsIGZhaWwuCiBEcmFnZ2luZyBhIGRpcmVjdG9y eSBhbmQgYSBmaWxlIG9udG8gYSBzaW5nbGUtZmlsZSBpbnB1dCBjb250cm9sOgotRkFJTCBmaWxl SW5wdXQudmFsdWUgc2hvdWxkIGJlIC4gV2FzIGRpcmVjdG9yeS1mb3ItZHJhZ2dpbmcuCitGQUlM IGZpbGVJbnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgQzpcZmFrZXBhdGhcZGlyZWN0b3J5LWZv ci1kcmFnZ2luZy4KIEZBSUwgZmlsZUlucHV0LmZpbGVzLmxlbmd0aCBzaG91bGQgYmUgMC4gV2Fz IDEuCiBEcmFnZ2luZyB0d28gZmlsZXMgdG8gYSBtdWx0aS1maWxlIGlucHV0IGNvbnRyb2w6Ci1Q QVNTIGZpbGVJbnB1dC52YWx1ZSBpcyAiYXBwbGUuZ2lmIgorRkFJTCBmaWxlSW5wdXQudmFsdWUg c2hvdWxkIGJlIGFwcGxlLmdpZi4gV2FzIEM6XGZha2VwYXRoXGFwcGxlLmdpZi4KIFBBU1MgZmls ZUlucHV0LmZpbGVzLmxlbmd0aCBpcyAyCiBQQVNTIGZpbGVJbnB1dC5maWxlc1swXS5uYW1lIGlz ICJhcHBsZS5naWYiCiBQQVNTIGZpbGVJbnB1dC5maWxlc1swXS50eXBlIGlzICJpbWFnZS9naWYi CkBAIC00NywxMSArNDcsMTEgQEAgUEFTUyBmaWxlSW5wdXQuZmlsZXNbMV0uc2l6ZSBpcyAyNTkz CiBQQVNTIGZpbGVJbnB1dC5maWxlc1sxXS5maWxlTmFtZSBpcyAibW96aWxsYS5naWYiCiBQQVNT IGZpbGVJbnB1dC5maWxlc1sxXS5maWxlU2l6ZSBpcyAyNTkzCiBEcmFnZ2luZyBhIGZpbGUgYW5k IGEgZGlyZWN0b3J5IG9udG8gYSBtdXRsaS1maWxlIGlucHV0IGNvbnRyb2w6Ci1GQUlMIGZpbGVJ bnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgYXBwbGUuZ2lmLgorRkFJTCBmaWxlSW5wdXQudmFs dWUgc2hvdWxkIGJlIC4gV2FzIEM6XGZha2VwYXRoXGFwcGxlLmdpZi4KIEZBSUwgZmlsZUlucHV0 LmZpbGVzLmxlbmd0aCBzaG91bGQgYmUgMC4gV2FzIDIuCiBGSVhNRTogIGVsZW1lbnRzIHNob3Vs ZCByZWZ1c2UgZHJhZ3MgaW5jbHVkaW5nIGRpcmVjdG9yaWVzOiBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU4NzkuICBUaGUgcGFnZSBpcyBnaXZlbiBGaWxlIG9iamVj dHMgY29ycmVzcG9uZGluZyB0byBkaXJlY3RvcmllcywgYnV0IGZvcm0gc3VibWlzc2lvbiB3aWxs IGZhaWwuCiBEcmFnZ2luZyBhIGRpcmVjdG9yeSBhbmQgYSBmaWxlIG9udG8gYSBtdXRsaS1maWxl IGlucHV0IGNvbnRyb2w6Ci1GQUlMIGZpbGVJbnB1dC52YWx1ZSBzaG91bGQgYmUgLiBXYXMgZGly ZWN0b3J5LWZvci1kcmFnZ2luZy4KK0ZBSUwgZmlsZUlucHV0LnZhbHVlIHNob3VsZCBiZSAuIFdh cyBDOlxmYWtlcGF0aFxkaXJlY3RvcnktZm9yLWRyYWdnaW5nLgogRkFJTCBmaWxlSW5wdXQuZmls ZXMubGVuZ3RoIHNob3VsZCBiZSAwLiBXYXMgMi4KIERyYWdnaW5nIHRvIGEgZGlzYWJsZWQgZmls ZSBpbnB1dCBjb250cm9sOgogUEFTUyBmaWxlSW5wdXQudmFsdWUgaXMgIiIK