28993 2009-09-04 17:08:11 -0700 [Qt] Remove Qt v4.6 check from the prefetchDNS implementation 2009-09-07 00:10:17 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned eric oldest_to_newest 144961 0 laszlo.gombos 2009-09-04 17:08:11 -0700 Functionality behind r47425 (http://trac.webkit.org/changeset/47425) is guarded with Qt v4.6 build check. Typically we do not use a build time Qt version check for newly introduced QtWebKit functionality. The usage of Qt version check is should be restricted to guard QtWebKit functionality that depends on a Qt functionality that is not available in all Qt versions. In this particular case the functionality introduced by r47425 builds and functions just fine using Qt v4.5. In addition removing the build flag also gets rid of a build warning (from moc). 144964 1 39104 laszlo.gombos 2009-09-04 17:12:32 -0700 Created attachment 39104 proposed patch. 145021 2 39104 eric 2009-09-05 16:29:07 -0700 Comment on attachment 39104 proposed patch. OK. rs=me. I can't remember if you're a committer. Assuming not. cq+ 145023 3 39104 eric 2009-09-05 16:40:29 -0700 Comment on attachment 39104 proposed patch. Rejecting patch 39104 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 145026 4 laszlo.gombos 2009-09-05 17:13:35 -0700 (In reply to comment #3) > (From update of attachment 39104 [details]) > Rejecting patch 39104 from commit-queue. This patch will require manual > commit. > > ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', > '--exit-after-n-failures=1'] failed with exit code 1 Eric, I can/will commit, thanks for the review. 145041 5 39104 eric 2009-09-06 02:02:27 -0700 Comment on attachment 39104 proposed patch. Another victim of bug 28845. media/video-source-error.html -> timed out 145043 6 39104 eric 2009-09-06 02:09:33 -0700 Comment on attachment 39104 proposed patch. Rejecting patch 39104 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 145046 7 laszlo.gombos 2009-09-06 05:39:37 -0700 (In reply to comment #6) > (From update of attachment 39104 [details]) > Rejecting patch 39104 from commit-queue. This patch will require manual > commit. > > ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', > '--exit-after-n-failures=1'] failed with exit code 1 Committed - http://trac.webkit.org/changeset/48100 145103 8 eric 2009-09-07 00:08:48 -0700 Thank you. The commit-queue is kinda paralyzed by bug 28845 at the moment. This hit it *again* when trying to land. 145104 9 eric 2009-09-07 00:10:17 -0700 Actually it hit a different test the final time, same bug though: compositing/geometry/abs-position-inside-opacity.html -> timed out 39104 2009-09-04 17:12:32 -0700 2009-09-06 05:39:58 -0700 proposed patch. patch_28993.txt text/plain 1805 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODA3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMDQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gUmVtb3ZlIFF0IHY0LjYgY2hlY2sgZnJvbSB0aGUgcHJlZmV0Y2hETlMgaW1w bGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI4OTkzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L0Ruc1ByZWZldGNoSGVs cGVyLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L0Ruc1ByZWZldGNoSGVscGVy Lmg6CisKIDIwMDktMDktMDQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL3F0L0Ruc1ByZWZldGNoSGVscGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvcXQvRG5zUHJlZmV0Y2hIZWxwZXIuY3BwCShyZXZpc2lvbiA0ODA0MSkKKysr IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9EbnNQcmVmZXRjaEhlbHBlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIxLDggKzIxLDYgQEAKIAogI2luY2x1ZGUgIkNTdHJpbmcuaCIKIAotI2lm IFFUX1ZFUlNJT04gPj0gMHgwNDA2MDAKLQogbmFtZXNwYWNlIFdlYkNvcmUgewogLy8gdGhpcyBp cyBjYWxsZWQgb24gbW91c2Ugb3ZlciBhIGhyZWYgYW5kIG9uIHBhZ2UgbG9hZGluZwogdm9pZCBw cmVmZXRjaEROUyhjb25zdCBTdHJpbmcmIGhvc3RuYW1lKQpAQCAtMzQsMTcgKzMyLDMgQEAgdm9p ZCBwcmVmZXRjaEROUyhjb25zdCBTdHJpbmcmIGhvc3RuYW1lKQogfQogCiB9Ci0KLSNlbGlmIFFU X1ZFUlNJT04gPj0gMHgwNDA0MDAKLSNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgotbmFtZXNw YWNlIFdlYkNvcmUgewotCi12b2lkIHByZWZldGNoRE5TKGNvbnN0IFN0cmluZyYgaG9zdG5hbWUp Ci17Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLX0KLQotfQotCi0KLSNlbmRpZgpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L0Ruc1ByZWZldGNoSGVscGVyLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L0Ruc1ByZWZldGNoSGVscGVyLmgJKHJldmlz aW9uIDQ4MDQxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L0Ruc1ByZWZldGNoSGVs cGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTIwLDkgKzIwLDYgQEAKICNkZWZpbmUgRE5TUFJFRkVU Q0hIRUxQRVJfSAogCiAjaW5jbHVkZSA8UU9iamVjdD4KLQotI2lmIFFUX1ZFUlNJT04gPj0gMHgw NDA2MDAKLQogI2luY2x1ZGUgPFFDYWNoZT4KICNpbmNsdWRlIDxRSG9zdEluZm8+CiAjaW5jbHVk ZSA8UVNldD4KQEAgLTc1LDYgKzcyLDQgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB9CiAKLSNl bmRpZgotCiAjZW5kaWYgLy8gRE5TUFJFRkVUQ0hIRUxQRVJfSAo=