28992 2009-09-04 16:53:10 -0700 Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting 2009-10-02 14:34:25 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 1 ap webkit-unassigned adele eric jparent ojan rniwa oldest_to_newest 144956 0 ap 2009-09-04 16:53:10 -0700 Opening the attached test case results in a crash in release builds, or an assertion failure in debug: #0 0x03b3d6df in WebCore::CompositeEditCommand::moveParagraphs at CompositeEditCommand.cpp:815 #1 0x03b3e21b in WebCore::CompositeEditCommand::moveParagraph at CompositeEditCommand.cpp:747 #2 0x042db177 in WebCore::ReplaceSelectionCommand::mergeEndIfNeeded at ReplaceSelectionCommand.cpp:699 #3 0x042df692 in WebCore::ReplaceSelectionCommand::doApply at ReplaceSelectionCommand.cpp:960 #4 0x03d37ae3 in WebCore::EditCommand::apply at EditCommand.cpp:91 #5 0x03d37b77 in WebCore::applyCommand at EditCommand.cpp:217 #6 0x03d47097 in WebCore::executeInsertFragment at EditorCommand.cpp:196 #7 0x03d47122 in WebCore::executeInsertHTML at EditorCommand.cpp:479 #8 0x03d43d1f in WebCore::Editor::Command::execute at EditorCommand.cpp:1504 #9 0x03c45edd in WebCore::Document::execCommand at Document.cpp:3241 #10 0x03f509a2 in WebCore::jsDocumentPrototypeFunctionExecCommand at JSDocument.cpp:1867 In real life, this happens when pasting into a contenteditable div. <rdar://7148712> 144962 1 39102 ap 2009-09-04 17:08:20 -0700 Created attachment 39102 reduced test case (will crash) 151970 2 40545 enrica 2009-10-02 14:18:54 -0700 Created attachment 40545 Patch 151972 3 40545 adele 2009-10-02 14:29:27 -0700 Comment on attachment 40545 Patch r=me! I'll commit this. 151973 4 adele 2009-10-02 14:34:25 -0700 Committed revision 49041. 39102 2009-09-04 17:08:20 -0700 2009-09-04 17:08:20 -0700 reduced test case (will crash) paste-crash.html text/html 415 ap PG1ldGEgY2hhcnNldD11dGYtOD4KPGRpdiBjb250ZW50ZWRpdGFibGU+CjxwPjxzcGFuIGNsYXNz PSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNlOnByZSI+ICAgIDwvc3Bhbj5zZWxl Y3QmbmJzcDs8L3A+CjwvZGl2Pgo8c2NyaXB0Pgpkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFt ZSgiZGl2IilbMF0uZm9jdXMoKTsKCnZhciBzZWwgPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CnZh ciBwYXJhZ3JhcGggPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgicCIpWzBdOwpzZWwu c2V0QmFzZUFuZEV4dGVudChwYXJhZ3JhcGgsIDEsIHBhcmFncmFwaC5sYXN0Q2hpbGQsIDYpOwoK ZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydEhUTUwiLCBmYWxzZSwgJzxwPmE8L3A+Jyk7Cjwv c2NyaXB0Pgo8L2JvZHk+Cg== 40545 2009-10-02 14:18:54 -0700 2009-10-02 14:29:27 -0700 Patch bug7148712.txt text/plain 5077 enrica SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTAzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMDIgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB c3NlcnRpb24gZmFpbHVyZSBpbiBDb21wb3NpdGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMo KSBhbmQgY3Jhc2ggaW4gTm9kZTo6bm9kZUluZGV4KCkgd2hlbiBwYXN0aW5nLgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNzE0ODcxMj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI4OTkyCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9zZWxlY3Rpb24v cmVwbGFjZS1zZWxlY3Rpb24tY3Jhc2guaHRtbAorCisgICAgICAgICogZWRpdGluZy9SZXBsYWNl U2VsZWN0aW9uQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXBsYWNlU2VsZWN0aW9u Q29tbWFuZDo6bWVyZ2VFbmRJZk5lZWRlZCk6IEhhbmRsZSBwcm9wZXJseSB0aGUgY2FzZSBvZgor ICAgICAgICB0aGUgZGVzdGluYXRpb24gcG9zaXRpb24gbWF0Y2hpbmcgdGhlIGVuZCBvZiB0aGUg cGFyYWdyYXBoIHRvIG1vdmUuCisKIDIwMDktMTAtMDIgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBl Y2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCklu ZGV4OiBXZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAJKHJldmlz aW9uIDQ5MDI2KQorKysgV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNjk1LDggKzY5NSwxNyBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rp b25Db21tYW5kOjptZXJnZUVuZElmCiAgICAgCiAgICAgVmlzaWJsZVBvc2l0aW9uIGRlc3RpbmF0 aW9uID0gbWVyZ2VGb3J3YXJkID8gZW5kT2ZJbnNlcnRlZENvbnRlbnQubmV4dCgpIDogZW5kT2ZJ bnNlcnRlZENvbnRlbnQ7CiAgICAgVmlzaWJsZVBvc2l0aW9uIHN0YXJ0T2ZQYXJhZ3JhcGhUb01v dmUgPSBtZXJnZUZvcndhcmQgPyBzdGFydE9mUGFyYWdyYXBoKGVuZE9mSW5zZXJ0ZWRDb250ZW50 KSA6IGVuZE9mSW5zZXJ0ZWRDb250ZW50Lm5leHQoKTsKKyAgIAorICAgIC8vIE1lcmdpbmcgZm9y d2FyZCBjb3VsZCByZXN1bHQgaW4gZGVsZXRpbmcgdGhlIGRlc3RpbmF0aW9uIGFuY2hvciBub2Rl LgorICAgIC8vIFRvIGF2b2lkIHRoaXMsIHdlIGFkZCBhIHBsYWNlaG9sZGVyIG5vZGUgYmVmb3Jl IHRoZSBzdGFydCBvZiB0aGUgcGFyYWdyYXBoLgorICAgIGlmIChlbmRPZlBhcmFncmFwaChzdGFy dE9mUGFyYWdyYXBoVG9Nb3ZlKSA9PSBkZXN0aW5hdGlvbikgeworICAgICAgICBSZWZQdHI8Tm9k ZT4gcGxhY2Vob2xkZXIgPSBjcmVhdGVCcmVha0VsZW1lbnQoZG9jdW1lbnQoKSk7CisgICAgICAg IGluc2VydE5vZGVCZWZvcmUocGxhY2Vob2xkZXIsIHN0YXJ0T2ZQYXJhZ3JhcGhUb01vdmUuZGVl cEVxdWl2YWxlbnQoKS5ub2RlKCkpOworICAgICAgICBkZXN0aW5hdGlvbiA9IFZpc2libGVQb3Np dGlvbihQb3NpdGlvbihwbGFjZWhvbGRlci5nZXQoKSwgMCkpOworICAgIH0KIAogICAgIG1vdmVQ YXJhZ3JhcGgoc3RhcnRPZlBhcmFncmFwaFRvTW92ZSwgZW5kT2ZQYXJhZ3JhcGgoc3RhcnRPZlBh cmFncmFwaFRvTW92ZSksIGRlc3RpbmF0aW9uKTsKKyAgICAKICAgICAvLyBNZXJnaW5nIGZvcndh cmQgd2lsbCByZW1vdmUgbV9sYXN0TGVhZkluc2VydGVkIGZyb20gdGhlIGRvY3VtZW50LgogICAg IC8vIEZJWE1FOiBNYWludGFpbiBwb3NpdGlvbnMgZm9yIHRoZSBzdGFydCBhbmQgZW5kIG9mIGlu c2VydGVkIGNvbnRlbnQgaW5zdGVhZCBvZiBrZWVwaW5nIG5vZGVzLiAgVGhlIG5vZGVzIGFyZQog ICAgIC8vIG9ubHkgZXZlciB1c2VkIHRvIGNyZWF0ZSBwb3NpdGlvbnMgd2hlcmUgaW5zZXJ0ZWQg Y29udGVudCBzdGFydHMvZW5kcy4gIEFsc28sIHdlIHNvbWV0aW1lcyBpbnNlcnQgY29udGVudApA QCAtNzA1LDYgKzcxNCwxMCBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjptZXJnZUVu ZElmCiAgICAgICAgIG1fbGFzdExlYWZJbnNlcnRlZCA9IGRlc3RpbmF0aW9uLnByZXZpb3VzKCku ZGVlcEVxdWl2YWxlbnQoKS5ub2RlKCk7CiAgICAgICAgIGlmICghbV9maXJzdE5vZGVJbnNlcnRl ZC0+aW5Eb2N1bWVudCgpKQogICAgICAgICAgICAgbV9maXJzdE5vZGVJbnNlcnRlZCA9IGVuZGlu Z1NlbGVjdGlvbigpLnZpc2libGVTdGFydCgpLmRlZXBFcXVpdmFsZW50KCkubm9kZSgpOworICAg ICAgICAvLyBJZiB3ZSBtZXJnZWQgdGV4dCBub2RlcywgbV9sYXN0TGVhZkluc2VydGVkIGNvdWxk IGJlIG51bGwuIElmIHRoaXMgaXMgdGhlIGNhc2UsCisgICAgICAgIC8vIHdlIHVzZSBtX2ZpcnN0 Tm9kZUluc2VydGVkLgorICAgICAgICBpZiAoIW1fbGFzdExlYWZJbnNlcnRlZCkKKyAgICAgICAg ICAgIG1fbGFzdExlYWZJbnNlcnRlZCA9IG1fZmlyc3ROb2RlSW5zZXJ0ZWQ7CiAgICAgfQogfQog CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiA0OTAzOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDA5LTEwLTAyICBFbnJpY2EgQ2FzdWNjaSAg PGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgdGVzdCBjYXNlLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzE0 ODcxMj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4 OTkyCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9yZXBsYWNlLXNlbGVjdGlvbi1jcmFz aC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3JlcGxh Y2Utc2VsZWN0aW9uLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDA5LTEwLTAyICBLZW5uZXRoIFJ1 c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVu dC4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3JlcGxhY2Utc2VsZWN0aW9u LWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3Nl bGVjdGlvbi9yZXBsYWNlLXNlbGVjdGlvbi1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9yZXBsYWNlLXNlbGVjdGlvbi1jcmFz aC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNyBAQAorCisgICAgICAgIDxk aXYgY29udGVudGVkaXRhYmxlPSIiPgorICAgICAgICAgICAgPHA+PHNwYW4gY2xhc3M9IkFwcGxl LXRhYi1zcGFuIiBzdHlsZT0id2hpdGUtc3BhY2U6cHJlIj4gICAgPGJyPjwvc3Bhbj5ObyBjcmFz aCEmbmJzcDs8L3A+CisgICAgICAgIDwvZGl2PgorICAgIAorCisKSW5kZXg6IExheW91dFRlc3Rz L2VkaXRpbmcvc2VsZWN0aW9uL3JlcGxhY2Utc2VsZWN0aW9uLWNyYXNoLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vcmVwbGFjZS1zZWxlY3Rpb24tY3Jh c2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3Jl cGxhY2Utc2VsZWN0aW9uLWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjUgQEAK KzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgZnVuY3Rp b24gdGVzdCgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudHNC eVRhZ05hbWUoImRpdiIpWzBdLmZvY3VzKCk7CisKKyAgICAgICAgICAgICAgICB2YXIgc2VsID0g d2luZG93LmdldFNlbGVjdGlvbigpOworICAgICAgICAgICAgICAgIHZhciBwYXJhZ3JhcGggPSBk b2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgicCIpWzBdOworICAgICAgICAgICAgICAgIHNl bC5zZXRCYXNlQW5kRXh0ZW50KHBhcmFncmFwaCwgMSwgcGFyYWdyYXBoLmxhc3RDaGlsZCwgNik7 CisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydEhUTUwiLCBmYWxz ZSwgJzxwPk5vIGNyYXNoITwvcD4nKTsKKworICAgICAgICAgICAgICAgIGRvY3VtZW50LndyaXRl KCI8eG1wPiIgKyBkb2N1bWVudC5ib2R5LmlubmVySFRNTCArICI8L3htcD4iKTsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9oZWFkPgorICAgIDxib2R5IG9ubG9hZD0i dGVzdCgpIj4KKyAgICAgICAgPGRpdiBjb250ZW50ZWRpdGFibGU+CisgICAgICAgICAgICA8cD48 c3BhbiBjbGFzcz0iQXBwbGUtdGFiLXNwYW4iIHN0eWxlPSJ3aGl0ZS1zcGFjZTpwcmUiPiAgICA8 L3NwYW4+c2VsZWN0Jm5ic3A7PC9wPgorICAgICAgICA8L2Rpdj4KKyAgICA8L2JvZHk+Cis8L2h0 bWw+Cg==