28979 2009-09-04 11:55:17 -0700 [GTK] Misc improvements to NetworkRequest 2009-09-07 08:32:34 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 144882 0 gustavo 2009-09-04 11:55:17 -0700 While working on NetworkResponse we noticed that some improvements are required in NetworkRequest's documentation, and internals. This bug is to track them. 144883 1 39078 gustavo 2009-09-04 11:57:13 -0700 Created attachment 39078 fix documentation simple doc fix =) 144885 2 39080 gustavo 2009-09-04 12:00:33 -0700 Created attachment 39080 fix place where message is unreffed 144931 3 39080 jmalonzo 2009-09-04 15:17:40 -0700 Comment on attachment 39080 fix place where message is unreffed r=me. 144932 4 39078 jmalonzo 2009-09-04 15:18:03 -0700 Comment on attachment 39078 fix documentation r=me. 145162 5 gustavo 2009-09-07 08:32:34 -0700 Landed as r48116 and r48117. 39078 2009-09-04 11:57:13 -0700 2009-09-04 15:18:03 -0700 fix documentation 0001-Improve-NetworkRequest-docs.patch text/plain 2087 gustavo RnJvbSA4YTRkMGE5MGM3NmQ0Y2U2YWU3ZjJmYzcyNDEzZDk1OGUwMWUwOThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgNCBTZXAgMjAwOSAxNTo1NjoyOCAtMDMwMApT dWJqZWN0OiBbUEFUQ0hdIEltcHJvdmUgTmV0d29ya1JlcXVlc3QgZG9jcwoKLS0tCiBXZWJLaXQv Z3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiBX ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRuZXR3b3JrcmVxdWVzdC5jcHAgfCAgIDExICsrKysrKy0t LS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpp bmRleCAxZDVjOWEwLi42MTZmMjg4IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwor KysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTA5LTA0ICBH dXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODk3OQorICAgICAgICBbR1RLXSBNaXNj IGltcHJvdm1lbnRzIHRvIE5ldHdvcmtSZXF1ZXN0CisKKyAgICAgICAgQnJpbmcgZG9jdW1lbnRh dGlvbiB1cC10by1kYXRlIHdpdGggcmVhbGl0eSByZWdhcmRpbmcgTmV0d29ya1JlcXVlc3QuCisK KyAgICAgICAgKiB3ZWJraXQvd2Via2l0bmV0d29ya3JlcXVlc3QuY3BwOgorCiAyMDA5LTA5LTAy ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVr PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0bmV0d29ya3JlcXVlc3QuY3BwIGIvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0bmV0d29ya3JlcXVlc3QuY3BwCmluZGV4IDVkZTU3YmIuLjRlMWUxMDMgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdG5ldHdvcmtyZXF1ZXN0LmNwcAorKysgYi9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRuZXR3b3JrcmVxdWVzdC5jcHAKQEAgLTMxLDEzICszMSwx NCBAQAogLyoqCiAgKiBTRUNUSU9OOndlYmtpdG5ldHdvcmtyZXF1ZXN0CiAgKiBAc2hvcnRfZGVz Y3JpcHRpb246IFRoZSB0YXJnZXQgb2YgYSBuYXZpZ2F0aW9uIHJlcXVlc3QKLSAqIEBzZWVfYWxz bzogI1dlYktpdFdlYlZpZXc6Om5hdmlnYXRpb24tcmVxdWVzdGVkCisgKiBAc2VlX2Fsc286ICNX ZWJLaXRXZWJWaWV3OjpuYXZpZ2F0aW9uLXBvbGljeS1kZWNpc2lvbi1yZXF1ZXN0ZWQKICAqCiAg KiBUaGlzIGNsYXNzIHJlcHJlc2VudHMgdGhlIG5ldHdvcmsgcmVsYXRlZCBhc3BlY3RzIG9mIGEg bmF2aWdhdGlvbgotICogcmVxdWVzdC4gQ3VycmVudGx5IHRoaXMgaXMgb25seSB0aGUgdXJpIG9m IHRoZSB0YXJnZXQuIEluIHRoZSBmdXR1cmUKLSAqIHRoZSBzdGF0ZSBvZiB0aGUgd2ViIGZvcm0g bWlnaHQgYmUgYWRkZWQuCi0gKiBDdXJyZW50bHkgdGhpcyBvYmplY3QgaXMgb25seSB1c2VkIGFs b25nIHdpdGggdGhlCi0gKiAjV2ViS2l0V2ViVmlldzo6bmF2aWdhdGlvbi1yZXF1ZXN0ZWQgc2ln bmFsLgorICogcmVxdWVzdC4gSXQgaXMgdXNlZCB3aGVuZXZlciBXZWJLaXQgd2FudHMgdG8gcHJv dmlkZSBpbmZvcm1hdGlvbgorICogYWJvdXQgYSByZXF1ZXN0IHRoYXQgd2lsbCBiZSBzZW50LCBv ciBoYXMgYmVlbiBzZW50LiBJbnNpZGUgaXQgeW91CisgKiBjYW4gZmluZCB0aGUgVVJJIG9mIHRo ZSByZXF1ZXN0LCBhbmQsIGZvciB2YWxpZCBVUklzLCBhCisgKiAjU291cE1lc3NhZ2Ugb2JqZWN0 LCB3aGljaCBwcm92aWRlcyBhY2Nlc3MgdG8gZnVydGhlciBpbmZvcm1hdGlvbgorICogc3VjaCBh cyBoZWFkZXJzLgogICoKICAqLwogCi0tIAoxLjYuMy4zCgo= 39080 2009-09-04 12:00:33 -0700 2009-09-04 15:17:39 -0700 fix place where message is unreffed 0001-Unref-message-in-dispose.patch text/plain 2749 gustavo RnJvbSA0Y2EyZDBkMzRiMDg0MjNhNWUxMDBiYThhOTI2NGNmZWVhY2FlMTNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgNCBTZXAgMjAwOSAxNTo1OTo1MyAtMDMwMApT dWJqZWN0OiBbUEFUQ0hdIFVucmVmIG1lc3NhZ2UgaW4gZGlzcG9zZQoKLS0tCiBXZWJLaXQvZ3Rr L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBX ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRuZXR3b3JrcmVxdWVzdC5jcHAgfCAgIDE1ICsrKysrKysr KysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VM b2cKaW5kZXggNjE2ZjI4OC4uOTg3YmM0NiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTUsNiArNSwyMCBAQAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg5NzkKICAgICAgICAgW0dU S10gTWlzYyBpbXByb3ZtZW50cyB0byBOZXR3b3JrUmVxdWVzdAogCisgICAgICAgIFVucmVmIG1l c3NhZ2UgaW4gZGlzcG9zZSwgYXMgaXQgc2hvdWxkIGJlLCBub3QgaW4gZmluYWxpemUuCisKKyAg ICAgICAgKiB3ZWJraXQvd2Via2l0bmV0d29ya3JlcXVlc3QuY3BwOgorICAgICAgICAod2Via2l0 X25ldHdvcmtfcmVxdWVzdF9kaXNwb3NlKToKKyAgICAgICAgKHdlYmtpdF9uZXR3b3JrX3JlcXVl c3RfZmluYWxpemUpOgorICAgICAgICAod2Via2l0X25ldHdvcmtfcmVxdWVzdF9jbGFzc19pbml0 KToKKworMjAwOS0wOS0wNCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3Jvbmhh QGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg5NzkK KyAgICAgICAgW0dUS10gTWlzYyBpbXByb3ZtZW50cyB0byBOZXR3b3JrUmVxdWVzdAorCiAgICAg ICAgIEJyaW5nIGRvY3VtZW50YXRpb24gdXAtdG8tZGF0ZSB3aXRoIHJlYWxpdHkgcmVnYXJkaW5n IE5ldHdvcmtSZXF1ZXN0LgogCiAgICAgICAgICogd2Via2l0L3dlYmtpdG5ldHdvcmtyZXF1ZXN0 LmNwcDoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdG5ldHdvcmtyZXF1ZXN0 LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdG5ldHdvcmtyZXF1ZXN0LmNwcAppbmRleCA0 ZTFlMTAzLi4yOTFmNGZjIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRuZXR3 b3JrcmVxdWVzdC5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0bmV0d29ya3JlcXVl c3QuY3BwCkBAIC01OCwxOCArNTgsMjYgQEAgZW51bSB7CiAgICAgUFJPUF9NRVNTQUdFLAogfTsK IAotc3RhdGljIHZvaWQgd2Via2l0X25ldHdvcmtfcmVxdWVzdF9maW5hbGl6ZShHT2JqZWN0KiBv YmplY3QpCitzdGF0aWMgdm9pZCB3ZWJraXRfbmV0d29ya19yZXF1ZXN0X2Rpc3Bvc2UoR09iamVj dCogb2JqZWN0KQogewogICAgIFdlYktpdE5ldHdvcmtSZXF1ZXN0KiByZXF1ZXN0ID0gV0VCS0lU X05FVFdPUktfUkVRVUVTVChvYmplY3QpOwogICAgIFdlYktpdE5ldHdvcmtSZXF1ZXN0UHJpdmF0 ZSogcHJpdiA9IHJlcXVlc3QtPnByaXY7CiAKLSAgICBnX2ZyZWUocHJpdi0+dXJpKTsKLQogICAg IGlmIChwcml2LT5tZXNzYWdlKSB7CiAgICAgICAgIGdfb2JqZWN0X3VucmVmKHByaXYtPm1lc3Nh Z2UpOwogICAgICAgICBwcml2LT5tZXNzYWdlID0gTlVMTDsKICAgICB9CiAKKyAgICBHX09CSkVD VF9DTEFTUyh3ZWJraXRfbmV0d29ya19yZXF1ZXN0X3BhcmVudF9jbGFzcyktPmRpc3Bvc2Uob2Jq ZWN0KTsKK30KKworc3RhdGljIHZvaWQgd2Via2l0X25ldHdvcmtfcmVxdWVzdF9maW5hbGl6ZShH T2JqZWN0KiBvYmplY3QpCit7CisgICAgV2ViS2l0TmV0d29ya1JlcXVlc3QqIHJlcXVlc3QgPSBX RUJLSVRfTkVUV09SS19SRVFVRVNUKG9iamVjdCk7CisgICAgV2ViS2l0TmV0d29ya1JlcXVlc3RQ cml2YXRlKiBwcml2ID0gcmVxdWVzdC0+cHJpdjsKKworICAgIGdfZnJlZShwcml2LT51cmkpOwor CiAgICAgR19PQkpFQ1RfQ0xBU1Mod2Via2l0X25ldHdvcmtfcmVxdWVzdF9wYXJlbnRfY2xhc3Mp LT5maW5hbGl6ZShvYmplY3QpOwogfQogCkBAIC0xMTAsNiArMTE4LDcgQEAgc3RhdGljIHZvaWQg d2Via2l0X25ldHdvcmtfcmVxdWVzdF9jbGFzc19pbml0KFdlYktpdE5ldHdvcmtSZXF1ZXN0Q2xh c3MqIHJlcXVlc3QKIHsKICAgICBHT2JqZWN0Q2xhc3MqIG9iamVjdENsYXNzID0gR19PQkpFQ1Rf Q0xBU1MocmVxdWVzdENsYXNzKTsKIAorICAgIG9iamVjdENsYXNzLT5kaXNwb3NlID0gd2Via2l0 X25ldHdvcmtfcmVxdWVzdF9kaXNwb3NlOwogICAgIG9iamVjdENsYXNzLT5maW5hbGl6ZSA9IHdl YmtpdF9uZXR3b3JrX3JlcXVlc3RfZmluYWxpemU7CiAgICAgb2JqZWN0Q2xhc3MtPmdldF9wcm9w ZXJ0eSA9IHdlYmtpdF9uZXR3b3JrX3JlcXVlc3RfZ2V0X3Byb3BlcnR5OwogICAgIG9iamVjdENs YXNzLT5zZXRfcHJvcGVydHkgPSB3ZWJraXRfbmV0d29ya19yZXF1ZXN0X3NldF9wcm9wZXJ0eTsK LS0gCjEuNi4zLjMKCg==