28974 2009-09-04 09:46:28 -0700 chromium windows compile broken 2009-09-04 10:08:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 tony tony levin oldest_to_newest 144837 0 tony 2009-09-04 09:46:28 -0700 I forgot to return a value in a RenderThemeChromiumSkia::paintSliderThumb and gcc didn't complain to me on linux. Patch coming. 144838 1 39071 tony 2009-09-04 09:48:11 -0700 Created attachment 39071 v1 144852 2 levin 2009-09-04 10:08:56 -0700 Committed as http://trac.webkit.org/changeset/48061 39071 2009-09-04 09:48:11 -0700 2009-09-04 09:50:22 -0700 v1 buildfix.diff text/plain 1256 tony SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODA1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDktMDQgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg Q2hyb21pdW0gV2luIGNvbXBpbGUuICBNaXNzaW5nIHJldHVybiBzdGF0ZW1lbnQgaW4KKyAgICAg ICAgV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OnBhaW50U2xpZGVyVGh1bWIuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODk3NAorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4LgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l Q2hyb21pdW1Ta2lhOjpwYWludFNsaWRlclRodW1iKToKKwogMjAwOS0wOS0wNCAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNl aWRlbC4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tp YS5jcHAJKHJldmlzaW9uIDQ4MDU2KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVD aHJvbWl1bVNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MjIsNiArODIyLDggQEAgYm9vbCBS ZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6cGFpbnRTbGlkZQogICAgICAgICBkcmF3SG9yaXpMaW5l KGNhbnZhcywgbWlkeCAtIDIsIG1pZHggKyAyLCBtaWR5IC0gMywgcGFpbnQpOwogICAgICAgICBk cmF3SG9yaXpMaW5lKGNhbnZhcywgbWlkeCAtIDIsIG1pZHggKyAyLCBtaWR5ICsgMywgcGFpbnQp OwogICAgIH0KKworICAgIHJldHVybiBmYWxzZTsKIH0KIAogaW50IFJlbmRlclRoZW1lQ2hyb21p dW1Ta2lhOjpwb3B1cEludGVybmFsUGFkZGluZ0xlZnQoUmVuZGVyU3R5bGUqIHN0eWxlKSBjb25z dAo=