28962 2009-09-03 19:31:22 -0700 Remove unnecessary dependency on unistd.h in Completion.cpp 2009-09-04 07:02:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yong.li.webkit webkit-unassigned manyoso staikos oldest_to_newest 144672 0 39032 yong.li.webkit 2009-09-03 19:31:22 -0700 Created attachment 39032 the patch Why does Completion.cpp include "unistd.h"? It's not used at all. 144686 1 39032 levin 2009-09-03 22:00:29 -0700 Comment on attachment 39032 the patch r=me with one small fix below. > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > + https://bugs.webkit.org/show_bug.cgi?id=(OOPS!) Please fill in the bug number when landing. It appears that this include was added for http://bugs.webkit.org/show_bug.cgi?id=17339 due to the use of getpid() in this file but that function call is no longer present. 144802 2 yong.li.webkit 2009-09-04 07:02:19 -0700 landed @48048 39032 2009-09-03 19:31:22 -0700 2009-09-03 22:00:29 -0700 the patch completion_cpp.patch text/plain 908 yong.li.webkit ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAzMjE2M2Q5Li40NGFhZGFjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMDktMDktMDMgIFlvbmcgTGkgIDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW5uZWNl c3NhcnkgZGVwZW5kZW5jeSBvbiB1bmlzdGQuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9KE9PUFMhKQorCisgICAgICAgICogcnVudGltZS9Db21wbGV0 aW9uLmNwcDoKKwogMjAwOS0wOS0wMyAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQ29tcGxldGlvbi5jcHAgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NvbXBsZXRpb24uY3BwCmluZGV4IGViNjZhOTcuLmYzNmRlNTQgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQ29tcGxldGlvbi5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9Db21wbGV0aW9uLmNwcApAQCAtMzEsMTAgKzMxLDYgQEAKICNpbmNsdWRlICJEZWJ1Z2dl ci5oIgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAKLSNpZiAhUExBVEZPUk0oV0lOX09TKQotI2luY2x1 ZGUgPHVuaXN0ZC5oPgotI2VuZGlmCi0KIG5hbWVzcGFjZSBKU0MgewogCiBDb21wbGV0aW9uIGNo ZWNrU3ludGF4KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgU291cmNlQ29kZSYgc291cmNlKQo=