28961 2009-09-03 19:31:04 -0700 [Qt] Fix tst_QWebPage::database autotest failure 2009-09-04 00:50:48 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned eric oldest_to_newest 144671 0 laszlo.gombos 2009-09-03 19:31:04 -0700 FAIL! : tst_QWebPage::database() Compared values are not the same Actual (s1.toString()): Expected (QString("This is a test for local storage")): This is a test for local storage Loc: [WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(426)] 144676 1 39034 laszlo.gombos 2009-09-03 19:54:23 -0700 Created attachment 39034 proposed patch. Test case broke after http://trac.webkit.org/changeset/47283 which disabled localStorage by default. Enable all the features that are tested explicitly to avoid this problem in the future. 144712 2 39034 eric 2009-09-04 00:15:24 -0700 Comment on attachment 39034 proposed patch. LGTM. 144718 3 39034 eric 2009-09-04 00:24:26 -0700 Comment on attachment 39034 proposed patch. Rejecting patch 39034 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 144730 4 39034 eric 2009-09-04 00:42:12 -0700 Comment on attachment 39034 proposed patch. Yet another victim of bug 28845! media/video-source-error.html -> crashed 144735 5 39034 eric 2009-09-04 00:50:43 -0700 Comment on attachment 39034 proposed patch. Clearing flags on attachment: 39034 Committed r48041: <http://trac.webkit.org/changeset/48041> 144736 6 eric 2009-09-04 00:50:48 -0700 All reviewed patches have been landed. Closing bug. 39034 2009-09-03 19:54:23 -0700 2009-09-04 00:50:43 -0700 proposed patch. patch_28961.txt text/plain 1442 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDgwMzcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDktMDMgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gRml4IHRzdF9RV2ViUGFnZTo6ZGF0YWJhc2UgYXV0b3Rlc3QgZmFp bHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg5 NjEKKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgdGVzdCBjYXNlIGVuYWJsZXMgdGhlIGZl YXR1cmUgYmVmb3JlIAorICAgICAgICB0aGUgZmVhdHVyZSBnZXRzIHRlc3RlZAorCisgICAgICAg ICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKHRzdF9RV2ViUGFn ZTo6ZGF0YWJhc2UpOgorCiAyMDA5LTA5LTAzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgZXJpY0B3ZWJraXQub3JnLgpJbmRleDogV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAJKHJldmlzaW9uIDQ4MDI0KQorKysg V2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQwNyw2ICs0MDcsMTAgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmRhdGFiYXNlKCkKICAgICBR V2ViU2V0dGluZ3M6OnNldE9mZmxpbmVTdG9yYWdlRGVmYXVsdFF1b3RhKDEwMjQgKiAxMDI0KTsK ICAgICBRVkVSSUZZKFFXZWJTZXR0aW5nczo6b2ZmbGluZVN0b3JhZ2VEZWZhdWx0UXVvdGEoKSA9 PSAxMDI0ICogMTAyNCk7CiAKKyAgICBtX3BhZ2UtPnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShR V2ViU2V0dGluZ3M6OkxvY2FsU3RvcmFnZUVuYWJsZWQsIHRydWUpOworICAgIG1fcGFnZS0+c2V0 dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6U2Vzc2lvblN0b3JhZ2VFbmFibGVk LCB0cnVlKTsKKyAgICBtX3BhZ2UtPnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2ViU2V0dGlu Z3M6Ok9mZmxpbmVTdG9yYWdlRGF0YWJhc2VFbmFibGVkLCB0cnVlKTsKKwogICAgIFFTdHJpbmcg ZGJGaWxlTmFtZSA9IHBhdGggKyAiRGF0YWJhc2VzLmRiIjsKIAogICAgIGlmIChRRmlsZTo6ZXhp c3RzKGRiRmlsZU5hbWUpKQo=