28953 2009-09-03 13:19:20 -0700 WinLauncher MSVC project does not write buildfailed file on build failure 2009-09-09 11:42:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 dbates dbates abarth aroben mrowe oldest_to_newest 144579 0 dbates 2009-09-03 13:19:20 -0700 The Microsoft Visual C++ (VC) project file for WinLauncher does write the file buildfailed on a build failure because the project file does not specify any pre- and post- build events. Other VC project files have such build events. We should set these build events so that the WinLauncher project build process is consistent with the other project files. 144580 1 mrowe 2009-09-03 13:21:31 -0700 Is WinLauncher built as part of the WebKit solution? 144582 2 39005 dbates 2009-09-03 13:22:09 -0700 Created attachment 39005 Patch 144584 3 dbates 2009-09-03 13:23:14 -0700 Yes. (In reply to comment #1) > Is WinLauncher built as part of the WebKit solution? 144589 4 39005 aroben 2009-09-03 13:49:05 -0700 Comment on attachment 39005 Patch r=me 145091 5 abarth 2009-09-06 22:03:08 -0700 Assigned to dbates for landing. 145873 6 39005 dbates 2009-09-09 11:42:01 -0700 Comment on attachment 39005 Patch Clearing flags on attachment: 39005 Committed r48218: <http://trac.webkit.org/changeset/48218> 145874 7 dbates 2009-09-09 11:42:06 -0700 All reviewed patches have been landed. Closing bug. 39005 2009-09-03 13:22:09 -0700 2009-09-09 11:42:01 -0700 Patch WinLaunchBuild_1.patch text/plain 3944 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ4MDI5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDktMDMgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor ICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI4OTUzCisKKyAgICAgICAgQWRkZWQgcHJlLSBhbmQgcG9zdC0gYnVpbGQgZXZlbnRzIHNvIHRo YXQgb24gYnVpbGQgZmFpbHVyZSwgdGhlIGZpbGUgCisgICAgICAgIGJ1aWxkZmFpbGVkIGlzIHdy aXR0ZW4gdG8gdGhlIGRpcmVjdG9yeSAkKFdlYktpdE91dHB1dERpcikuCisKKyAgICAgICAgKiBX aW5MYXVuY2hlci9XaW5MYXVuY2hlci52Y3Byb2o6CisKIDIwMDktMDktMDMgIEtldmluIFdhdHRl cnMgIDxrZXZpbndhdHRlcnNAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtldmlu IE9sbGl2aWVyLgpJbmRleDogV2ViS2l0VG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIudmNw cm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZj cHJvagkocmV2aXNpb24gNDgwMjQpCisrKyBXZWJLaXRUb29scy9XaW5MYXVuY2hlci9XaW5MYXVu Y2hlci52Y3Byb2oJKHdvcmtpbmcgY29weSkKQEAgLTIzLDYgKzIzLDcgQEAKIAkJCT4NCiAJCQk8 VG9vbA0KIAkJCQlOYW1lPSJWQ1ByZUJ1aWxkRXZlbnRUb29sIg0KKwkJCQlDb21tYW5kTGluZT0i JVN5c3RlbURyaXZlJVxjeWd3aW5cYmluXHdoaWNoLmV4ZSBiYXNoJiN4MEQ7JiN4MEE7aWYgZXJy b3JsZXZlbCAxIHNldCBQQVRIPSVTeXN0ZW1Ecml2ZSVcY3lnd2luXGJpbjslUEFUSCUmI3gwRDsm I3gwQTtjbWQgL2MmI3gwRDsmI3gwQTtpZiBleGlzdCAmcXVvdDskKFdlYktpdE91dHB1dERpcilc YnVpbGRmYWlsZWQmcXVvdDsgZ3JlcCBYWCQoUHJvamVjdE5hbWUpWFggJnF1b3Q7JChXZWJLaXRP dXRwdXREaXIpXGJ1aWxkZmFpbGVkJnF1b3Q7JiN4MEQ7JiN4MEE7aWYgZXJyb3JsZXZlbCAxIGV4 aXQgMSYjeDBEOyYjeDBBO2VjaG8gWFgkKFByb2plY3ROYW1lKVhYICZndDsgJnF1b3Q7JChXZWJL aXRPdXRwdXREaXIpXGJ1aWxkZmFpbGVkJnF1b3Q7JiN4MEQ7JiN4MEE7Ig0KIAkJCS8+DQogCQkJ PFRvb2wNCiAJCQkJTmFtZT0iVkNDdXN0b21CdWlsZFRvb2wiDQpAQCAtOTQsNiArOTUsNyBAQAog CQkJLz4NCiAJCQk8VG9vbA0KIAkJCQlOYW1lPSJWQ1Bvc3RCdWlsZEV2ZW50VG9vbCINCisJCQkJ Q29tbWFuZExpbmU9ImlmIGV4aXN0ICZxdW90OyQoV2ViS2l0T3V0cHV0RGlyKVxidWlsZGZhaWxl ZCZxdW90OyBkZWwgJnF1b3Q7JChXZWJLaXRPdXRwdXREaXIpXGJ1aWxkZmFpbGVkJnF1b3Q7Ig0K IAkJCS8+DQogCQk8L0NvbmZpZ3VyYXRpb24+DQogCQk8Q29uZmlndXJhdGlvbg0KQEAgLTEwNSw2 ICsxMDcsNyBAQAogCQkJPg0KIAkJCTxUb29sDQogCQkJCU5hbWU9IlZDUHJlQnVpbGRFdmVudFRv b2wiDQorCQkJCUNvbW1hbmRMaW5lPSIlU3lzdGVtRHJpdmUlXGN5Z3dpblxiaW5cd2hpY2guZXhl IGJhc2gmI3gwRDsmI3gwQTtpZiBlcnJvcmxldmVsIDEgc2V0IFBBVEg9JVN5c3RlbURyaXZlJVxj eWd3aW5cYmluOyVQQVRIJSYjeDBEOyYjeDBBO2NtZCAvYyYjeDBEOyYjeDBBO2lmIGV4aXN0ICZx dW90OyQoV2ViS2l0T3V0cHV0RGlyKVxidWlsZGZhaWxlZCZxdW90OyBncmVwIFhYJChQcm9qZWN0 TmFtZSlYWCAmcXVvdDskKFdlYktpdE91dHB1dERpcilcYnVpbGRmYWlsZWQmcXVvdDsmI3gwRDsm I3gwQTtpZiBlcnJvcmxldmVsIDEgZXhpdCAxJiN4MEQ7JiN4MEE7ZWNobyBYWCQoUHJvamVjdE5h bWUpWFggJmd0OyAmcXVvdDskKFdlYktpdE91dHB1dERpcilcYnVpbGRmYWlsZWQmcXVvdDsmI3gw RDsmI3gwQTsiDQogCQkJLz4NCiAJCQk8VG9vbA0KIAkJCQlOYW1lPSJWQ0N1c3RvbUJ1aWxkVG9v bCINCkBAIC0xNzYsNiArMTc5LDcgQEAKIAkJCS8+DQogCQkJPFRvb2wNCiAJCQkJTmFtZT0iVkNQ b3N0QnVpbGRFdmVudFRvb2wiDQorCQkJCUNvbW1hbmRMaW5lPSJpZiBleGlzdCAmcXVvdDskKFdl YktpdE91dHB1dERpcilcYnVpbGRmYWlsZWQmcXVvdDsgZGVsICZxdW90OyQoV2ViS2l0T3V0cHV0 RGlyKVxidWlsZGZhaWxlZCZxdW90OyINCiAJCQkvPg0KIAkJPC9Db25maWd1cmF0aW9uPg0KIAkJ PENvbmZpZ3VyYXRpb24NCkBAIC0xODYsNiArMTkwLDcgQEAKIAkJCT4NCiAJCQk8VG9vbA0KIAkJ CQlOYW1lPSJWQ1ByZUJ1aWxkRXZlbnRUb29sIg0KKwkJCQlDb21tYW5kTGluZT0iJVN5c3RlbURy aXZlJVxjeWd3aW5cYmluXHdoaWNoLmV4ZSBiYXNoJiN4MEQ7JiN4MEE7aWYgZXJyb3JsZXZlbCAx IHNldCBQQVRIPSVTeXN0ZW1Ecml2ZSVcY3lnd2luXGJpbjslUEFUSCUmI3gwRDsmI3gwQTtjbWQg L2MmI3gwRDsmI3gwQTtpZiBleGlzdCAmcXVvdDskKFdlYktpdE91dHB1dERpcilcYnVpbGRmYWls ZWQmcXVvdDsgZ3JlcCBYWCQoUHJvamVjdE5hbWUpWFggJnF1b3Q7JChXZWJLaXRPdXRwdXREaXIp XGJ1aWxkZmFpbGVkJnF1b3Q7JiN4MEQ7JiN4MEE7aWYgZXJyb3JsZXZlbCAxIGV4aXQgMSYjeDBE OyYjeDBBO2VjaG8gWFgkKFByb2plY3ROYW1lKVhYICZndDsgJnF1b3Q7JChXZWJLaXRPdXRwdXRE aXIpXGJ1aWxkZmFpbGVkJnF1b3Q7JiN4MEQ7JiN4MEE7Ig0KIAkJCS8+DQogCQkJPFRvb2wNCiAJ CQkJTmFtZT0iVkNDdXN0b21CdWlsZFRvb2wiDQpAQCAtMjU3LDYgKzI2Miw3IEBACiAJCQkvPg0K IAkJCTxUb29sDQogCQkJCU5hbWU9IlZDUG9zdEJ1aWxkRXZlbnRUb29sIg0KKwkJCQlDb21tYW5k TGluZT0iaWYgZXhpc3QgJnF1b3Q7JChXZWJLaXRPdXRwdXREaXIpXGJ1aWxkZmFpbGVkJnF1b3Q7 IGRlbCAmcXVvdDskKFdlYktpdE91dHB1dERpcilcYnVpbGRmYWlsZWQmcXVvdDsiDQogCQkJLz4N CiAJCTwvQ29uZmlndXJhdGlvbj4NCiAJCTxDb25maWd1cmF0aW9uDQpAQCAtMjY3LDYgKzI3Myw3 IEBACiAJCQk+DQogCQkJPFRvb2wNCiAJCQkJTmFtZT0iVkNQcmVCdWlsZEV2ZW50VG9vbCINCisJ CQkJQ29tbWFuZExpbmU9IiVTeXN0ZW1Ecml2ZSVcY3lnd2luXGJpblx3aGljaC5leGUgYmFzaCYj eDBEOyYjeDBBO2lmIGVycm9ybGV2ZWwgMSBzZXQgUEFUSD0lU3lzdGVtRHJpdmUlXGN5Z3dpblxi aW47JVBBVEglJiN4MEQ7JiN4MEE7Y21kIC9jJiN4MEQ7JiN4MEE7aWYgZXhpc3QgJnF1b3Q7JChX ZWJLaXRPdXRwdXREaXIpXGJ1aWxkZmFpbGVkJnF1b3Q7IGdyZXAgWFgkKFByb2plY3ROYW1lKVhY ICZxdW90OyQoV2ViS2l0T3V0cHV0RGlyKVxidWlsZGZhaWxlZCZxdW90OyYjeDBEOyYjeDBBO2lm IGVycm9ybGV2ZWwgMSBleGl0IDEmI3gwRDsmI3gwQTtlY2hvIFhYJChQcm9qZWN0TmFtZSlYWCAm Z3Q7ICZxdW90OyQoV2ViS2l0T3V0cHV0RGlyKVxidWlsZGZhaWxlZCZxdW90OyYjeDBEOyYjeDBB OyINCiAJCQkvPg0KIAkJCTxUb29sDQogCQkJCU5hbWU9IlZDQ3VzdG9tQnVpbGRUb29sIg0KQEAg LTMzOCw2ICszNDUsNyBAQAogCQkJLz4NCiAJCQk8VG9vbA0KIAkJCQlOYW1lPSJWQ1Bvc3RCdWls ZEV2ZW50VG9vbCINCisJCQkJQ29tbWFuZExpbmU9ImlmIGV4aXN0ICZxdW90OyQoV2ViS2l0T3V0 cHV0RGlyKVxidWlsZGZhaWxlZCZxdW90OyBkZWwgJnF1b3Q7JChXZWJLaXRPdXRwdXREaXIpXGJ1 aWxkZmFpbGVkJnF1b3Q7Ig0KIAkJCS8+DQogCQk8L0NvbmZpZ3VyYXRpb24+DQogCTwvQ29uZmln dXJhdGlvbnM+DQo=